From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90641C761A6 for ; Thu, 30 Mar 2023 14:39:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 191B56B0071; Thu, 30 Mar 2023 10:39:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11DD06B0072; Thu, 30 Mar 2023 10:39:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F23DC6B0074; Thu, 30 Mar 2023 10:39:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E11BA6B0071 for ; Thu, 30 Mar 2023 10:39:57 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 47CCE80672 for ; Thu, 30 Mar 2023 14:39:57 +0000 (UTC) X-FDA: 80625824034.21.427E4A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 7034340004 for ; Thu, 30 Mar 2023 14:39:55 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Keu0yHkz; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680187195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O3V/Opjj7Xto80R0YuRGPZTCgbXp6rtl0lkxbOZukAg=; b=AqmU82wgR1NkjhZbnMkX4cDpWSZj3sZc1cKU43PtWbleu8usKEmKlEMM+7crR3OSOyJPAY xSA9nvW6EUVBeXUoA2IKlEbz4tlTNBmUTt7dqgEb2oEHMYH1omBStgsALFgn1Y2e2opQR/ Nwg9jgRxjSM7SupKobqVKq4Gb/fTUsE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Keu0yHkz; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680187195; a=rsa-sha256; cv=none; b=UW/ow0WWuql1Ur1cPKufc9uS1Zo1TjKIhKbcYNv4BPxf9n0FGkSpyBqs8yScMSC5ktMeO4 SOdEPumtEe3zaXcvv06UVPxJr6HDIXpoqDER++/+D0fjmmOdXLhfpxnlqnlRdoI34LKKw3 d0X9irTEC6rkxarzyCy53DU0RAAb7Vg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680187194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O3V/Opjj7Xto80R0YuRGPZTCgbXp6rtl0lkxbOZukAg=; b=Keu0yHkzMuWqNdNHkdXu9tBU/TlGs6svRLeq5uPUfKZGJPSYhFNjdnmnzYsNrpONrdEbd0 FWcdWmuJffeG6GrvlS1c88swZ3/wLnEMplnFSM4GHWNUDtsFYI0C9K5EzEufXMwQexmiA5 dEyLd6RZTPxMA6c6Slz1SZx9qFAk+JE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-515-E0MKE2P4Mqa-h5CUMt8wSA-1; Thu, 30 Mar 2023 10:39:51 -0400 X-MC-Unique: E0MKE2P4Mqa-h5CUMt8wSA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 510DD884340; Thu, 30 Mar 2023 14:39:50 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 699CEC15BA0; Thu, 30 Mar 2023 14:39:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <64259aca22046_21883920890@willemb.c.googlers.com.notmuch> References: <64259aca22046_21883920890@willemb.c.googlers.com.notmuch> <20230329141354.516864-1-dhowells@redhat.com> <20230329141354.516864-17-dhowells@redhat.com> To: Willem de Bruijn Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 16/48] ip, udp: Support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <838853.1680187186.1@warthog.procyon.org.uk> Date: Thu, 30 Mar 2023 15:39:46 +0100 Message-ID: <838854.1680187186@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Stat-Signature: cppswh8pgraujwpxpt9acc4drgxdyys7 X-Rspam-User: X-Rspamd-Queue-Id: 7034340004 X-Rspamd-Server: rspam06 X-HE-Tag: 1680187195-312108 X-HE-Meta: U2FsdGVkX1/RasFDOpf/Sk23vfNm3FAU/ZllHbUciFXxNCZcnN7c6DmByZRk+C7nEXQeMHJQC0vI/rqfGAYgp1RIKz2HtKQD5AJJ/FxGnpySIhdSxdThiJcBZumZPMOgIhF1G+ooeivE9tb/+l8P8VlZiiF+YRmnmz3quFEs9jDOSBU1/wlbbVrZ0SRz8Dg1TqJvr3ALFhXVXkeC/oIw51g6EeawaAzW19SsL6rm3FNvSeqZowVIlUx+XcNYKcwIj/BEt5poQsq7n5DIp1Gq6bSxXNqPWiAoRbuybKFMiyAxkirhTD7UbauZPsOdVua8B4gyoS/X8keimCLUyVIC8QR49VOC1TVZJ+rpBFHqZrUFoCnCiM1aZYCxLWESHsLrQ+6auuyOr8rUCQ/jMrv3+pl5YWrXijKpOO4gV7KGCDPj8LQC0xOrrVXYAHkeoV401jqNU7zxeV+iDubIbt6i1vdQV8urtZIJZML/dlsGf/itTJvdpfVVuFWpxiSs+wxEXjzoauM2A++phUTOVACq8iRiNAH5UYCvezgu7hkJXxtFLKxUKJ7+1lMq/0LjvEBcxIIRpiY8VnNGwYCrbOpiGlXX+9w2qK4z8L1bJfGrxUJ7Kno+2mxv4isxKH5/ayINhnycsL6R2d9UtCQ6FATlAbQM3c+3mh9rqXTtYvd879IY5Svlmnr4kVGMkHgQm40O5178tcAgacwepfddeEr4gCs1gvVg1mQSekPZBhSpxL+qUEIWOQQnOtCC46jVF8MdSylq6MS4lFwcpNCScQUwbTEve4eKCJSsfZ9n86rvOGAPQFqtmA4nsd4zi2KkYxOMLmOKcuPL37UE4M9k6YRMYvqJtdV2muH+kVfjvGssUpySTp9EdzJPQN3ppl8f0NjKwtHkR9AdaYqwTirD9+dwK67VrQ227Nom2mheXO/Du6tdezDB6U+sXfcLqipKMduAiZaeoTOOFqwfniE5h8h v0xgxpwi 19A5lyDnsQ5Asu7OBXKB/k1DRX/r+3DvLt+dTUsuYQfLV/xjhb9J92CgUl9ZSsQfSdjoj/XpctF2YnHxfxi7v/vSgZ7jD2SfO0LLFw3YKqQudCnoj+dag9Q1Qu5NIzeuuOQve/nj9cmhOtXdFj5CiXrlEiEQ2DR3Xm2DSUzk23QNMiTZR2jnQB/b64KWF7EDzfehOwGdahpgD4WF9KTF64lCVPeKgeXhnd31VAQaZBOvhGJaRuwXGMpsPOyo8yTYprktpphat4goJFsKW6p8fLeBxZxAW8xsSzG8aVNaq2UbnOstBhPl+n857ol0FUwBGG3KA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Willem de Bruijn wrote: > > diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c > > A non-RFC version would require the same for ipv6, of course. I missed the fact that ipv6 had it's own version of __ip_append_data() despite sharing tcp_sendmsg(). Could __ip_append_data() and __ip6_append_data() be shared? I guess that the v6_cork, the flowi6 and the ipcm6_cookie might prevent that. David