linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] perf: map pages in advance
Date: Fri, 29 Nov 2024 14:11:16 +0100	[thread overview]
Message-ID: <8376a446-1e8d-4359-ac69-626790ebcd97@redhat.com> (raw)
In-Reply-To: <03f654d5-424a-4d23-828e-323aff46fa61@lucifer.local>

On 29.11.24 13:48, Lorenzo Stoakes wrote:
> Will reply inline also but to be clear - we should differentiate between
> ongoing discussion about how best to tackle these things going forward
> vs. whether _this patch_ is OK :)
> 
> I don't think you're objecting to the patch as such, just disappointed
> about VM_PFNMAP and wanting to discuss this more generally?

Well, a bit of both :)

> 
> As I say below, we can't use VM_MIXEDMAP as it's broken for our case (we
> have to use page->mapping if there's a struct page), so I think _right now_
> this is the only sane solution.

I'm not so sure ...

I've also been wondering whether this particular user really wants to 
allocate and work on folios for the time being :/


Putting aside the remainder of what we discuss further below for now, 
I've just been wondering if we could somehow have two mappings with two 
separate ops. The one for the single R/W page, the other for the R/O 
pages ...

... but I'm not sure yet if that would completely help.

... still trying to grasp all the details here, and how to keep GUP working.

-- 
Cheers,

David / dhildenb



  reply	other threads:[~2024-11-29 13:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28 11:37 Lorenzo Stoakes
2024-11-28 13:08 ` David Hildenbrand
2024-11-28 13:20   ` Lorenzo Stoakes
2024-11-28 13:37     ` David Hildenbrand
2024-11-28 14:23       ` Lorenzo Stoakes
2024-11-29 12:12         ` David Hildenbrand
2024-11-29 12:26           ` Peter Zijlstra
2024-11-29 12:45             ` David Hildenbrand
2024-11-29 12:55               ` Lorenzo Stoakes
2024-11-29 12:59                 ` David Hildenbrand
2024-11-29 13:02                   ` Lorenzo Stoakes
2024-11-29 13:12                     ` David Hildenbrand
2024-11-29 13:19                       ` Lorenzo Stoakes
2024-11-29 13:24                         ` David Hildenbrand
2024-11-29 13:38                           ` Lorenzo Stoakes
2024-11-29 13:47                             ` David Hildenbrand
2024-11-29 13:59                               ` Lorenzo Stoakes
2024-11-29 14:09                                 ` David Hildenbrand
2024-11-29 14:35                                   ` Lorenzo Stoakes
2024-11-29 14:48                                     ` David Hildenbrand
2024-11-29 20:42                                       ` Matthew Wilcox
2024-11-29 12:48           ` Lorenzo Stoakes
2024-11-29 13:11             ` David Hildenbrand [this message]
2024-11-28 20:47 ` Lorenzo Stoakes
2024-11-29  8:52   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8376a446-1e8d-4359-ac69-626790ebcd97@redhat.com \
    --to=david@redhat.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox