From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C160C3ABCD for ; Mon, 12 May 2025 12:05:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16E886B00F7; Mon, 12 May 2025 08:05:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11EB86B00F8; Mon, 12 May 2025 08:05:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F00966B00F9; Mon, 12 May 2025 08:05:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CDE616B00F7 for ; Mon, 12 May 2025 08:05:54 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 05A08120FB6 for ; Mon, 12 May 2025 12:05:55 +0000 (UTC) X-FDA: 83434127112.14.943D3D6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 7D2F1A0009 for ; Mon, 12 May 2025 12:05:53 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MxzFoqbv; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747051553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wdJlzktGGrJqFesVqic51nFN+xlPwzqlSYZMp8S0TxI=; b=Sn5dfO36ewet+mnqATIiaQei4qGik84lLaGtVOR3nHf51WoCqTTYSVU32SuyuxjWoprHhq j4dnwp8X4oNJsyhjzts5wwF5oOI5fb1cgs2eEN4AIL+e0ey3p3r/IjBAlG/W/dgivvhk+m P/DMgH8zbv3vy8LRtTYFdhSk8ZaUhHE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747051553; a=rsa-sha256; cv=none; b=CnmAt1jshZePCnKN9GgOQ4QauNlIyM4ABY0/PxYTGkZCsiTUchH4zxXDnva6SzNGY6cXvb NLu1jIP8EH32Mj9ykzi+4EfOOs5Ng3aZVcFstIgD7KmZAKXTow6HEJhalqqNblsNif0sVt 23djE2YNQlVcEPAqbJMyizKa/t1PGW8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MxzFoqbv; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747051552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wdJlzktGGrJqFesVqic51nFN+xlPwzqlSYZMp8S0TxI=; b=MxzFoqbvTbaBNKNAxro7+dJ8rKtRMUkB1XcEcuVl0aU8J3mfjKIY5KO6AcH+8bAqcwKU/S rb1oml/MsIFwpqQb27cvXwmnV8wATN01qluLHKnBLdgDH3+GwM+ke9xjra5xSdHiY3SDPd hdmfbD4sON8r7g1t8/NVRDsjGJCBRHU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-REF9HXNzPO-Dgjr0jz4niQ-1; Mon, 12 May 2025 08:05:48 -0400 X-MC-Unique: REF9HXNzPO-Dgjr0jz4niQ-1 X-Mimecast-MFC-AGG-ID: REF9HXNzPO-Dgjr0jz4niQ_1747051547 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a0b1798d69so1446812f8f.3 for ; Mon, 12 May 2025 05:05:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747051547; x=1747656347; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wdJlzktGGrJqFesVqic51nFN+xlPwzqlSYZMp8S0TxI=; b=J0YnSSN3lYvUJjclu247jgipQGiU6xlp4uKbGCWZMCaIRow+LpZnw4dyxyNLOSDAWm nbzkvwdznk5Z3bGhUKlRoQUTNTJrSKIO4L+UNQdMeUnQzGhxGIgDXZHmyGziL55HYXMa l4pJSV3hbpg+ZE+hNgzG370BkzcSwmYi7mWWLPFWhUdd6ttwOqfsZXQ/0EPBhUBw/lNf MSdACKEeGLYac8CNW1YKxdSxLSFRMa4okDNg9+rRM2DAM+uyfl1IaLNGKn3lgj5UJB43 wNquYlXxDaLVtVTXWQB6R0ibA8Jwf2BBySraG/q3yjqjjdh3gq79ilN+DL7FLCaKZWNX gO/A== X-Forwarded-Encrypted: i=1; AJvYcCXCS9OkR+G7Z+jM02OK54RpSGo+7uvAY9NMelZMXHlTBrd0cJ6adhmBoVyFWMUNyKwYcDuKdgIbQQ==@kvack.org X-Gm-Message-State: AOJu0YxEd1N5FXUPd6dvTT4D2JV7u6p5vNE528svYD0kfSeDNUKMPsVE A29KdTgFMOP+gQtJBDTXTQk7LUQrE+E8SJQ0KatrE3S408ExDqNc3iwYbm1iV+zk4p0l7KOMW86 yC8EcaZDOOJ9JBG8GFZIV3v1Oa8lzw5FOQiof2IK6foyplPZO X-Gm-Gg: ASbGncviJApp8s0dHQwSHlZ3+2UDM9ld4tDgp3jz/oN894Ik67Xaz1ZDyyx8sM97G5i UJIDOLjTTPrcAD8Sch52g/EtpUTw0tTVTEC9sHUQhXthuzfJYgOSSUQb29Xd4vRCwElkYgGRnQs cScs7w6saUqllQIUtowwSvQgiiQ3BBqWLWwmEjn0mUytE2MtC/N4LFRP2dDpFX0kSqrHIBKXgR3 AtHzbw4Mn/251ZfipFidlnmR3qK7PpWFon8F+KZ2P/1+rFCZI4+oLlvN6OlhnplSq8ixoiGHcwn YRdj6DR5P9QsZbe2wRK63J4S+jrUDFzTH9dSOMCumcbt3y2fP4T5HwgUoYjgF+pdpc4pSu5OvJG Aio+QofuY6l8HNWLXi1Q8kwbcbG2v1OAbH3PKxu4= X-Received: by 2002:a05:6000:2a1:b0:3a0:b733:f262 with SMTP id ffacd0b85a97d-3a1f64ab58bmr10472086f8f.51.1747051547081; Mon, 12 May 2025 05:05:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFASPPotExaPDA1hbZyCJdrcf7Y8GXHdAS7ODG1uszxEfWE0IHpAxbF5G0Tk+V/yx8Uk0/lbA== X-Received: by 2002:a05:6000:2a1:b0:3a0:b733:f262 with SMTP id ffacd0b85a97d-3a1f64ab58bmr10472042f8f.51.1747051546618; Mon, 12 May 2025 05:05:46 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4a:5800:f1ae:8e20:d7f4:51b0? (p200300d82f4a5800f1ae8e20d7f451b0.dip0.t-ipconnect.de. [2003:d8:2f4a:5800:f1ae:8e20:d7f4:51b0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f57de100sm12085800f8f.2.2025.05.12.05.05.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 05:05:46 -0700 (PDT) Message-ID: <836f2574-cb60-44c5-865c-7f13a90779ec@redhat.com> Date: Mon, 12 May 2025 14:05:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64/mm: Disable barrier batching in interrupt contexts To: Ryan Roberts , Catalin Marinas , Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzbot+5c0d9392e042f41d45c5@syzkaller.appspotmail.com References: <20250512102242.4156463-1-ryan.roberts@arm.com> <001dfd4f-27f2-407f-bd1c-21928a754342@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9mrFTYK27YsY9Uu7X_efXYEJo23Icb-iRaBmEByveQU_1747051547 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 9jnc41w7zrsspkooehs9c6o9j6x4o4hj X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7D2F1A0009 X-HE-Tag: 1747051553-421475 X-HE-Meta: U2FsdGVkX18PK3zu1Q5jkvwcGDJ6kb1Sl7aglyUgfcBDts5NUYqOUhY7Z8+QVD9m9yO5x9p/n5jacrQzRKulE5fUPpcZ5O7FUmo53lKoJG/Fp+vWSXUuE9/Z46bvizbu9mZNOmEk7aNJ/QCrtpd3wjNOgoXJg68cFXpMDSuCaj4hT2I0JJKHglHVLWG+nuoIsvejmSxLwQr+j3uV8/hN7XtgfnJFhdCi8MuharRCjY6v9pZsp7gqBR8JEurHOaNIdBJZEj/r0D6WxSTFI2bkALOE+JrRydAHL03ZCe/UC+0PCEJahM5ICucCJyQd7frhCd90UHYszAE5Fs0fYxcVzIQ4EtL0GpgxbYVFnq8H0gZT3f7kx0icdHQjosQDCJf0dMEkn61P3wMLm+E7mcpn9mtrIRvycWiN1wOE0Zx4jbQcXi2rYTl5yVKz4pY8dVJV/OqigUsr3UUIDfxuEpU/ODe7BT4tACt0HXstIOSSiBm29T4NQ4t9N4xE2jzUmSXWuM5Qpb6iCmZZXZuYO7SFDbwqJyEjMcBYspjcI0vRRUQrIXlEOWhyl3tzYOuEYY5NSL4sVwg8Gc5FBanSm4AdVdmAJiwffABz9uKWcGUtMcWLDhNgrUpY01Bplkmif4wsz3bIyzi6RyBAd9pmXcRDQdf4bHEWs2mHvBKLS0STXuIeK2K5F8iCzSyGkThNG6ev4f/AxQ6bLhcpQXK6W51TV9ARtvfVSVNpi/8b/A9kUe76e+UBLCoHR3s194bCSz/JWmmWMttfB5kyXcFneVhlWmGl9PgcNRAJ2q/HaGqHmbRdOGtR25Ra65gKbMNNsJXWVrl0J+EYCGd3vVyN8xvP2oXqsnZsD+psVoASN8JtqQIFUyz93M8aJsE8u9wgPTPfWRthOL8VaZ4yGtrwMt/le/eiUol4B9jnbvWKZg3CfTY5gE8xlxlkb+cBo80FTbpmSoYK9J9t0B5n8kKhF69 2qu2tyYj 9vI7y4Mg2IdafkS8ucsJNd50utOo1N+hV+AgeBWDQqBS0jj9sJBJmeYBWPDm9zriYtJICwHofmV4yqmQUg36WfZm1CNWuQtQi/3AOZqwaVGX9AUyGa6XyExJhsLdzfXMoLRPaJnV4AiFr3t0o5Js3ZLVmIVdImGHdqfKXwgnCe6ctgXQTqlHGpXudndTnMujsfP8AWdFH3a1GPDTsYsMOG9OTEpskcosAPGMI2xw7meWrgymxYBs1hKPh2lynssB1pfFZOuBwf5ENTfY4zBziYoqYKIS4GQG7qAWCmOfh79/Ew3HspFE4bo6vPf1kS7Z1xcqUGQsXoCjJQugqqYAh6zvOBk1uZ8mNdhqNxrB0lPSxpZUuXO5oYqWNCIv77Q6Ho6GefPcM/jLX9fRlwAn5lnlrBLSg0oAHjpgmLElA4dNAxZi93KceJSI8qY8iHR4Y/f31EhTvNnUr/LDbSF2DVl1GApatVNELg++/T/3Pn2wJJ3Xuob3aY1NzbNZFqnXo21Y7Nut9TL6IrGFdgU4FLMNLVa4nkS7b7wmmPpvyGapDAUWneKf3M4IISIDea98gj0h4bjNwLl0AF345VF6avGkB7whOmXNH4pLlJjC5RzT9lg0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>>   static inline void arch_leave_lazy_mmu_mode(void) >>>   { >>> +    if (in_interrupt()) >>> +        return; >>> + >>>       arch_flush_lazy_mmu_mode(); >>>       clear_thread_flag(TIF_LAZY_MMU); >>>   } >> >> I guess in all cases we could optimize out the in_interrupt() check on !debug >> configs. > > I think that assumes we can easily and accurately identify all configs that > cause this? We've identified 2 but I'm not confident that it's a full list. Agreed. I was wondering if we could convert the ones to use different pte helpers, whereby these helpers would not be available without CONFIG_WHATEVER. Then, make these features select CONFIG_WHATEVER. VM_WARN_ON_* would be used to catch any violations / wrong use of pte helpers. > Also, KFENCE isn't really a debug config (despite me calling it that in the > commit log) - it's supposed to be something that can be enabled in production > builds. Agreed. Even Fedora has it. > >> >> Hm, maybe there is an elegant way to catch all of these "problematic" users? > > I'm all ears if you have any suggestions? :) > > > It actaully looks like x86/XEN tries to solves this problem in a similar way: Heh, yes. Good old xen ... > > enum xen_lazy_mode xen_get_lazy_mode(void) > { > if (in_interrupt()) > return XEN_LAZY_NONE; > > return this_cpu_read(xen_lazy_mode); > } > > Although I'm not convinced it's fully robust. It also has: > > static inline void enter_lazy(enum xen_lazy_mode mode) > { > BUG_ON(this_cpu_read(xen_lazy_mode) != XEN_LAZY_NONE); > > this_cpu_write(xen_lazy_mode, mode); > } > > which is called as part of its arch_enter_lazy_mmu_mode() implementation. If a > task was already in lazy mmu mode when an interrupt comes in and causes the > nested arch_enter_lazy_mmu_mode() that we saw in this bug report, surely that > BUG_ON() should trigger? Hm, good point. But that code is old, so probably something seems to be preventing that? In any case, just a thought on the in_interrupt() check, I think this commit is good enough as is. -- Cheers, David / dhildenb