From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54AC3E68940 for ; Thu, 31 Oct 2024 01:08:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBCB06B009D; Wed, 30 Oct 2024 21:08:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B455B6B00A0; Wed, 30 Oct 2024 21:08:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E65D6B00A1; Wed, 30 Oct 2024 21:08:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7EDA06B009D for ; Wed, 30 Oct 2024 21:08:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3B5531A0160 for ; Thu, 31 Oct 2024 01:08:49 +0000 (UTC) X-FDA: 82732111350.09.F7E8165 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by imf11.hostedemail.com (Postfix) with ESMTP id E4B5B40002 for ; Thu, 31 Oct 2024 01:08:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730336872; a=rsa-sha256; cv=none; b=Ztfnrjj29C2kaWg7o079bKH85iP74bm0TxtFkfAFrv7DkhfQBIMTWNnXV01ezaIHv0zeyY GRSvppkv4zFLCRWqJV52yBndVP2zDPTq7cSZhlPIhWvF3RRASd75D8A/fzdi1GCy4TWHA2 F6WKpuGBa49rI8Dw9jB72tQhPfg4coA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730336872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U2satVl/EjUt6b8eaeOcoyCBMnxPkPLjVdch8TDZcEA=; b=1ME2uYd92WGP3x5uEE7mPoG6t1KkBHj+kfJ0G4WSfAYqC1GlWFvBCBOS/2w1NLuEGVx7KY MXqDR+flbE+erlZOwTvqZncVQSQ7OXvz53SDthX11bdqzjmshslVqIGKV7fPlfYhFVgKWq 2u9/ZEeACiX4CFPyxJK2JhWLsUDEkIM= Received: from loongson.cn (unknown [10.20.42.62]) by gateway (Coremail) with SMTP id _____8AxaeGZ2CJn3N4fAA--.444S3; Thu, 31 Oct 2024 09:08:41 +0800 (CST) Received: from [10.20.42.62] (unknown [10.20.42.62]) by front1 (Coremail) with SMTP id qMiowMAxreCX2CJn3b8rAA--.6898S3; Thu, 31 Oct 2024 09:08:41 +0800 (CST) Subject: Re: [PATCH v2] mm: define general function pXd_init() To: Andrew Morton Cc: Huacai Chen , Thomas Bogendoerfer , Andrey Ryabinin , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , WANG Xuerui References: <20241030063905.2434824-1-maobibo@loongson.cn> <20241030164123.ff63a1c0e7666ad1a4f8944e@linux-foundation.org> From: maobibo Message-ID: <836c4d86-3b93-06fc-8ac1-6f636a244753@loongson.cn> Date: Thu, 31 Oct 2024 09:08:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20241030164123.ff63a1c0e7666ad1a4f8944e@linux-foundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID:qMiowMAxreCX2CJn3b8rAA--.6898S3 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj9xXoWrKry7ZrykuF13CF18Cry5KFX_yoWfXFg_W3 Z7Zws5u3ykGay2gFWqkry5Cr4UGayrJF4vyw1UWr92k3s3tr45Jws0gFyfXrs09Fs2vr9x uayvvan8Zrn8WosvyTuYvTs0mTUanT9S1TB71UUUUjUqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbDkYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_Jrv_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV W8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4j6F4UM28EF7xvwVC2z280aVCY1x0267AKxVW8 JVW8Jr1ln4kS14v26r1Y6r17M2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2 x26I8E6xACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r126r1D McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7 I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AKxVWUAVWUtwCF04k20xvY0x0EwIxGrwCF x2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C267AKxVWUXVWUAwC20s026c02F40E14v26r 1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij 64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr 0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8HKZJUUUUU== X-Rspam-User: X-Rspamd-Queue-Id: E4B5B40002 X-Rspamd-Server: rspam01 X-Stat-Signature: yod8a5w14ecfg3nxqztkueras3ka6931 X-HE-Tag: 1730336892-289529 X-HE-Meta: U2FsdGVkX1/l7X5GsM8fpliHE4BoJfNmj4s/pml8jDjQPtvcCR2SfacFilgZv4sI42NhALlI1MatXm0aQ7dE9rKneFWNaBMyVxedV5uKnwfIBwQulNH0EOvvCuuH7F9qTLvY54IW8Xno8pcrT3CIvMbVyQ4RDDr84a0g1VGMgdp392ScLoohDOpEfUE9jIJLD+aYi0FJWmR4yrAnh48KMzxW/IVV0l7gZ1MB1XvVjdOs5olBvTgzquS5d9st6DAh5LVrSS8ri2SEhzj/gfUizJY3MuzgkSg9uHbhG5Cw2FrLpUDE+fFLWcJbeZIFuAhdvOQfxGfiv8vYo6IV1qLQlC3T61570XaUTrTBLEP2Jga782eogzleBgl8PvJwpi+MEL+uwObYr/YUBjsKgW31ShSs7ixhfNhX3JlVKWsC+MBBh4XyxEsANyoDbZldJxCQATRfyCkc7dvaIrMAroHVVEJiyiwQh9RRvYP7cAqJz1/UplAP0qLet/n3cdDZcfVh+3nGgX1fOqhcOAU6S/EruAzboQnQM4h+GaxJGCQUZmUPh8gRtMf+Fkg3b5PWDr4E7JSto/IZe97LOQRn6elKiYuY3lJCT0I88nMlqq2z+4pZP86J5uCvXyC89fSuOECTiOzlIHEIgh4Yidya4joRO5HUQyfJNiqwzJyyXU5HQZNZU6sz557RG5I4NM8gKRPSST67gQXo+EFRUXm1d6oTu72/+K7n/sAZTkgxTnNzSvLsWPfpKmz0k3k0/znaiq6yeQfpK12hq5iISVinPM13X3bp/c3OxK1rF+dXnB2gJbvSZJJOkxtr9iKAbUYKtzvH7ca5ICX0FL9EffT1oiygGjRR6flzcdsyU/MN3yVLtJybn7G8cOJpqyqZyTR/vlvY3gmHuqtWNDpUrn4ZaDL3nB5+GE1D6eFuJokpvtfR++xh2eA09+xcy1NFRzxt/0sl2QMIbx9QkepERMBRoro 6y5EGotR gFFBB1eIfTaL13YIor+7Io4ALU+S6F50F/e/FKv2DqKzzCA6QoY489xDpqlnAuSxgKb9vPudXxSuIKl4KsA84yHggRYdw4N015q6QY6iQTnTHceLa1xqpfHwGQQ4tj3qEz/0oonJXWtYrnGM8SltWcV4ElfEQ5MWdJhEkmioTmZmjpgCdLvLiviTQbIyHqGOirZPD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/31 上午7:41, Andrew Morton wrote: > On Wed, 30 Oct 2024 14:39:05 +0800 Bibo Mao wrote: > >> --- a/arch/loongarch/include/asm/pgtable.h >> +++ b/arch/loongarch/include/asm/pgtable.h >> @@ -267,8 +267,11 @@ extern void set_pmd_at(struct mm_struct *mm, unsigned long addr, pmd_t *pmdp, pm >> * Initialize a new pgd / pud / pmd table with invalid pointers. >> */ >> extern void pgd_init(void *addr); >> +#define pud_init pud_init >> extern void pud_init(void *addr); >> +#define pmd_init pmd_init >> extern void pmd_init(void *addr); >> +#define kernel_pte_init kernel_pte_init >> extern void kernel_pte_init(void *addr); > > Nitlet: don't we usually put the #define *after* the definition? > > void foo(void); > #define foo() foo() yes, it should be so. Will modify it in next version. Regards Bibo Mao > > ? > >