From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Nicholas Piggin <npiggin@gmail.com>,
"linux-mm @ kvack . org" <linux-mm@kvack.org>
Cc: "linux-arm-kernel @ lists . infradead . org"
<linux-arm-kernel@lists.infradead.org>,
"linuxppc-dev @ lists . ozlabs . org"
<linuxppc-dev@lists.ozlabs.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 3/3] mm/vmalloc: fix vmalloc_to_page for huge vmap mappings
Date: Mon, 1 Jul 2019 15:28:51 +0530 [thread overview]
Message-ID: <8369ca48-ebab-fe2d-363d-00769827fd0b@arm.com> (raw)
In-Reply-To: <20190701064026.970-4-npiggin@gmail.com>
On 07/01/2019 12:10 PM, Nicholas Piggin wrote:
> vmalloc_to_page returns NULL for addresses mapped by larger pages[*].
> Whether or not a vmap is huge depends on the architecture details,
> alignments, boot options, etc., which the caller can not be expected
> to know. Therefore HUGE_VMAP is a regression for vmalloc_to_page.
>
> This change teaches vmalloc_to_page about larger pages, and returns
> the struct page that corresponds to the offset within the large page.
> This makes the API agnostic to mapping implementation details.
>
> [*] As explained by commit 029c54b095995 ("mm/vmalloc.c: huge-vmap:
> fail gracefully on unexpected huge vmap mappings")
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
prev parent reply other threads:[~2019-07-01 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 6:40 [PATCH v2 0/3] " Nicholas Piggin
2019-07-01 6:40 ` [PATCH v2 1/3] arm64: mm: Add p?d_large() definitions Nicholas Piggin
2019-07-01 9:44 ` Catalin Marinas
2019-07-01 9:57 ` Steven Price
2019-07-02 2:55 ` Nicholas Piggin
2019-07-01 6:40 ` [PATCH v2 2/3] powerpc/64s: Add p?d_large definitions Nicholas Piggin
2019-07-01 6:40 ` [PATCH v2 3/3] mm/vmalloc: fix vmalloc_to_page for huge vmap mappings Nicholas Piggin
2019-07-01 9:58 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8369ca48-ebab-fe2d-363d-00769827fd0b@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox