From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 306B2C02188 for ; Mon, 27 Jan 2025 14:47:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6218280166; Mon, 27 Jan 2025 09:47:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B11B5280165; Mon, 27 Jan 2025 09:47:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93DDB280166; Mon, 27 Jan 2025 09:47:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6E010280165 for ; Mon, 27 Jan 2025 09:47:07 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DEB4A45B21 for ; Mon, 27 Jan 2025 14:47:06 +0000 (UTC) X-FDA: 83053509252.30.4E2132E Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf11.hostedemail.com (Postfix) with ESMTP id 978AF40010 for ; Mon, 27 Jan 2025 14:47:03 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hKimuiSe; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=EV8zaKkn; spf=pass (imf11.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737989223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TH5BtQ0pmC4dbdi6KONKAiJLZgZtvcQX9F2S9knR/Mc=; b=3GAg66QgYb6hXDrqPSGOa7+Vh75aSmpODHS9uQAknuHreXA+HpF6CHTZv5SJH1vUR3ICpL Iv/ogzRRn+tQcECwLIU8F0f3xGCn6CFrVkANhqSrUXHCgD4KiiDBV/0MRGZnIlcmkuDYRM euKOczfGsjTJJorXcZwkKChDv0d/wYA= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=hKimuiSe; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=EV8zaKkn; spf=pass (imf11.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1737989223; a=rsa-sha256; cv=pass; b=wzM5psyWDe4JZkoHTkAQbhe3RZ8EvKKqQvdRXccwa9ITNpYnqaEzc6Uu43GTcVZAg2E+LW Aub3+xIm8tQFO8S8JwIWkU8axl/iqMWU5U5ImmMQzdq6OtLO/wp8D+ENzQlbTWbz1GLay1 5S8/UvrDzGPXLevK1r9aoE+HiH3q6ZE= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50REVluN000835; Mon, 27 Jan 2025 14:46:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=TH5BtQ0pmC4dbdi6KO NKAiJLZgZtvcQX9F2S9knR/Mc=; b=hKimuiSe/xxf7gQ9FBShU/RoKstJmCDeIY rCRP1ChyP72LnWMLP9uZpE9ozJJZp6G3nDq4bQ0ckR3VsjdCeloV8eY42ILgwRkh cseeueslHzcUIGWu5WRLyLWvJTfYHYv/p69Ek4ZCm9iWe1B3P7zf05wsgPLrooWy GAC8kHdFueSghBwggFjIGSGBKAJ+ccT0V0VJkxEF+i2C96zqG4YcpofZag1gZFVl VcnVrxwQeaSqeZFTvXsuShkua0uk1OCzQKMSoPX+I1uziva1T9JcZ2GuDGNYktmy rWuc8zDt7ruFNEDA3rfMZ8ANoCiWQkI75q9QAUaAx6eiadSoTpgw== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44ec00g1ae-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 14:46:50 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50RDiWL2023908; Mon, 27 Jan 2025 14:46:50 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2173.outbound.protection.outlook.com [104.47.58.173]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44cpd71vka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 14:46:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WdbmNthiLpCSuaPUttgMmMSIkDb5oo2xkxeFCetQAsjK2D9LnBDHrQnY8AjiKtEbhzXNwgLf3uGeKik3tCXe/quwo1qdaxw5BdJj8+mF2W3ST16wcFH5ZmScfuV8P8RTjZ9JKn5eDhj50edkSibFFNEAu7CE2B0Vf5q53WZhZTG80JD8fiKl/h3h7IvYEG7NbFkLWMeTSBDI4X/apyawXaye6R5oI85nq8qz9JBvx4gYZHlvC2NAbkeznY97r1RM1F6dj7ucRkQVRS6TxQufBX4/Vvon5MFf9mjKM5cTeHRIBD1A+fXBtNCBsiMtIdK8viYzh+FRDQVDY2529yAfMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TH5BtQ0pmC4dbdi6KONKAiJLZgZtvcQX9F2S9knR/Mc=; b=zJY4Yd+Q3wITEQmSvVHbyiloBzRMdgaXPRYrpH9cKRgdMPeEgC7XzHyV0IComtXhYmY5V4D+yvrHDdFDazYoCT7ZfgFRfaIkmRM0i5HNNP+s/jX5cnDXYSnufjM2Sly7BLfLC7xodrq13Ukdveqoxwm+mGWG881Xx2fK4qYMovC2xmW2bs/hj6oIl8EhXeqschzfNiAVf5so2FiuNDs+zXN60ICC2rid/nwj43QqEaJFXa6OPD0x9UdwOZnk2KOH7WlNaJI56Fsk8+XWYrbBNUh7JEHxwGnOA424aTApBLwVzd358mqiSySSVmLnDJvMis0tHBKSsBVpoqynN+FOGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TH5BtQ0pmC4dbdi6KONKAiJLZgZtvcQX9F2S9knR/Mc=; b=EV8zaKknvE2r5iCvtJ12aEjYqDHxWIRb/bZTQMtB4Qqn3GZu7k0EYYAQJwwIdGggEgDvxSr5ypn/+EXuHToZwqAhiXOY5+zS4SRdtfLoZRFHxRJS+g/Uw09kfOWd2W2kaddHyF5yHWYwRiJ5Tslzptgmsg6qS/foXahLy8zxzks= Received: from MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) by DS0PR10MB8150.namprd10.prod.outlook.com (2603:10b6:8:203::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.22; Mon, 27 Jan 2025 14:46:48 +0000 Received: from MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348]) by MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348%3]) with mapi id 15.20.8377.021; Mon, 27 Jan 2025 14:46:48 +0000 Date: Mon, 27 Jan 2025 14:46:42 +0000 From: Lorenzo Stoakes To: Daniil Dulov Cc: Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org, stable@vger.kernel.com Subject: Re: [PATCH] mm/vma: Fix hugetlb accounting error in copy_vma() Message-ID: <83645f1b-cede-455c-abc0-6f105199eee9@lucifer.local> References: <20250127143201.45453-1-d.dulov@aladdin.ru> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250127143201.45453-1-d.dulov@aladdin.ru> X-ClientProxiedBy: LO4P265CA0292.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:38f::18) To MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3374:EE_|DS0PR10MB8150:EE_ X-MS-Office365-Filtering-Correlation-Id: 51bd80a9-f88f-41dd-c433-08dd3ee16d96 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?fbdVu1mN8Vdu8X+YwkEZXwB64ZXbqOzsXdFK5ckku6+N9fLULEcudXAM1Vrp?= =?us-ascii?Q?ygnBhQ84Jhw7qiGCDslIWYTmCU+J4sveu8t+xKnfubhiACE5TePmwj1cxHGT?= =?us-ascii?Q?BHIhzKCEW/BqVU4nf9F2rJULcff2GCWbnkbSSFCozM1HLhtSIBzmeK4FkEFE?= =?us-ascii?Q?iRIRwAZv86bFsz1HJiFUhptPgmWT8MVFWXTRC80dV2Pttlmqttp4MiyZl7tw?= =?us-ascii?Q?1Ov5+X622ccojhFkid8Dmi/qYnVK5acnpaYVJU3E/22dFfpruVJSydC9I1oU?= =?us-ascii?Q?TPJBqIfokYDsQDs3bKEfR2SHH755U3PoIR/AOEyKCJeDFHuiFPcKm5E5XBUn?= =?us-ascii?Q?C6AyOCH+PIJVb4OOmCwa5BtfK08DjvXOxNnSr6jr/qs2g8E5SAUxYC09gFVK?= =?us-ascii?Q?Sl/om9St+RNIBB7/xIsbitf89coBqFTyq3mLhRW0lxRs0WXVMM548N/PFegk?= =?us-ascii?Q?2uX8QesSNyZJ5OEKYpPXEnN91Dkle2Kv7o1ooPb1o8XfmHenqwyQWZfKrRF/?= =?us-ascii?Q?2+y8jhbipUdl2Synm758VLoWalyaBJuB4vQLlr/7cYDA8j5KwQlwrjoX24Mr?= =?us-ascii?Q?0yR5rtFEk+oyIJ6W2me5bGHx/EmRJHo5L+OZF9BRckLPFVjZXhflmB33S60g?= =?us-ascii?Q?K24F46uupJILVGSTWAnntveFhRRBjlzWgawJmVw1IZTe+A2H6ept5AuFtKry?= =?us-ascii?Q?L/huWVJQ7JTrJAFj+L1HzmSlJd4iNs29s7UUJ17o5d6NLfiLuR46M74qGEfn?= =?us-ascii?Q?Zbh8DQE+Iv21nsZm2vkaofOdTf0PGxjlsuOQyRSL/SN5XEnspX6Vd/kKvtnM?= =?us-ascii?Q?tHHmPtqLE7X0Ko75JlxfCmo61eo1ClwUI6yPj878bgKuwOFTQtoQO6fRRlWQ?= =?us-ascii?Q?NQQRAFwS+9qtZ1aUsYxWsQ16onK0ZSTvdlKBExv6oaOhQp/R7UdOvU3gTRld?= =?us-ascii?Q?RvrOvmrrnotQrNK7dRU4qEpjccGOv3UZ8Nq7G58uBzlAwyzxym6ikG+fTE+M?= =?us-ascii?Q?tU0LwLx5sudhLMbUIUZkGk6RdP+HDq6YgGzF4af5lAF0kBxk9IW3i4s1gAeD?= =?us-ascii?Q?TH+RQ0KaH7mXPcVXKqojjeyiHj9A7lwvJB/oBGl6U9MDkdDzHQBFFaEldcq7?= =?us-ascii?Q?PKPY7mCuQzI3OX2GIQJESPfj7W1K/qCAfwPLiS6sgMd5cmUfYpCHoyTjnb+7?= =?us-ascii?Q?S8HrvQ+GdbMWWVwfzoleXSef/q901sATY3gFY5PGEpgKCJfVzyx2RtcL5vbi?= =?us-ascii?Q?wAYhz4NlPaVv+vy2yf7DarDGCGO8/JIOaKIzT+06YAxXI1xHJDZ7CdUg1uwQ?= =?us-ascii?Q?Jxyo/v1s8rDco3MMOEovJoBm3Z0xgaImaa0DV0n/FFQAiQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3374.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YLTdR1mLBYWfcfcinfKppJ+CUyz3yGWnPdByMwSzjlkvgTNdfspGJgB2pr2N?= =?us-ascii?Q?jsIZFUd96Zz+GVBVcrCKs24phCQF8qR+m1qkxC4tmFJc1lS3yOhfodM4rosI?= =?us-ascii?Q?W0BqkK3zVUCfGDuPHu20PNvlypoHXP5WLSmkNdM2rqBtqNHZvdAnuc143NUH?= =?us-ascii?Q?lHoy5yM8XjqDi6owbUxA2cm6TFxoGEHIZHDVnrmfnSAvLitC7TleSRoj56qC?= =?us-ascii?Q?rsrDNQdEUU/RoKnx4aDU7HDNmShPF1ywsshkXGGrvJeJjz9YbnwU0cVqb+Ak?= =?us-ascii?Q?rhUIQvXVoz1c/kq6S9kQ66htHeViNQDoiPEFY24aj1IZj9gYVl5VpJlHCEbP?= =?us-ascii?Q?e4yFVbCLt61Y3OYvI9i8osUTtaHgEi+eiBRYW7/JENEFoysTr34gAvqHFf/9?= =?us-ascii?Q?y+7zjkzaV3zjhIEymNpbD6IPtKfOPm2fsrVsDq+7rz1Mm4GfSBc64RmOOzTn?= =?us-ascii?Q?OzdsTQZAkrAKblA6teewH1fJtwOQJ7HsfaA62vAEZaXybMddPKKWwKpLCGwb?= =?us-ascii?Q?6EJb8xlDFVaY6bXGFn4QvpmTN0/yEcoGnluIQGYMFkzmJMnqTw+KOPb7M4n8?= =?us-ascii?Q?3iYSpNdHQ1INBTaqezKtMZYPgRud5SAi1lixV8zfaKmB3cyMjHrj+vXoZTdx?= =?us-ascii?Q?VhvqqbKRrmtT3NSQgnXwT2jbdOFnGH456xQw4UOlzVpzrwJKVhedTZKWQIRa?= =?us-ascii?Q?013Z67BX3kbkFe1U6AoQBft4OC7Raceb3xUUTpDZ6hcoVXxxLKlBDDdCi1dv?= =?us-ascii?Q?5YLZ6kjcVvA3tqrALXmYLo/Q4r91oEVaICXmKaZOhxYtgOFm03M/X/AmSv0k?= =?us-ascii?Q?678zIhXQL8FBOvI56D6cCumomniONjqKHn9gJF+OcSaiztMAAT/uzzyrwdh7?= =?us-ascii?Q?zzj2YvudRLIgVXg3FrZhAyllodYrSGwcfiJSjB7adxGw3CHouhLbfQiAvpC+?= =?us-ascii?Q?GQPrfcdEfx5RXPGuEeQcoxc30+DJjjpkNOVhntL2qBiKTG7t9hrJJbnJ4Kta?= =?us-ascii?Q?OQZW5CQJiaCoBYVwWdHK+yYZZdPREJsq3wgNlnQZ2oKsS0yLTdjEyTKR3dVS?= =?us-ascii?Q?dCTgx6CB5y9VvtXzWyNtJPA+JI1xSfqFco0weHG0uYB3u1QSoODQ1+Ng1jBF?= =?us-ascii?Q?mubiIFJw1JaHJpDcbm9x/xWvr4RvqujqZCZaJ3jwD9Ooc4NbylN6vvQ1EVsh?= =?us-ascii?Q?LHvL9hNq3+w4ncRBehIhmqo1vaZqsaV1uLjVd6mUyXkTzfazIsWtcuXVjInD?= =?us-ascii?Q?iijt5lZ01xEnMHcJtGl21sKp467VH9vnZ5lT7nK1p6ou0kEKlMKbvYaF1k45?= =?us-ascii?Q?rrtBQ9b64j2vi/FqVA58FtiJb8YOIvG+RvMjI7xk/mG0COHT4Zn47vhLllbh?= =?us-ascii?Q?q7ERqBG3P9rkXE/Lb14CPqpolUQhohx9kLfX9/35I4zNtPGBOyf7g+gI1drT?= =?us-ascii?Q?I2d9Xdg322mC0ae+u7bdbAhy12ylIu58MUi1L/9szK+H9q1oVajN3QC8p22w?= =?us-ascii?Q?wNkEpHY6DHPgLXWwQZDPdjCAxfo6sL3h9B0P9Qny1wUzsD6x8IbQF4k9KLAD?= =?us-ascii?Q?LO3f14SUzsQX5pl2/upr/S4Wbar75XU3KVNvSIdoEa/mySso2sVO+b5NpY4X?= =?us-ascii?Q?yg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: xsTTJp2sEO/OckTyrtIZKuIbShWBgZNLeHWBrVX+n5Ms3eIuslQ2S/nLG2gFKerkxAD0AHtRdulOFfsEKDWm+BgErjxuW8cobcNOCshEosFF4G/WLA2CcvntirRfVi0JlSb1v77LtHoegYPypRWAy3WQZuMh8Jbwo4xIdWw+EWGRaKq/k/KJYu2l+tq+yW34VYXR4QpiUXEUx1W7EU6/y5DJg0a05n24FeyLVeK5RaACfdnlu4dk5VoYHN4qMOmmkzdIhbHmI+rdkGv0h6EJ9SHOHsZNxqwGEZXoxI0wfGmYL/A7mPDKV/xc7hshpOs0W9mpD96Hn0F25dXzsiNeAUddA+DJDl1iJDd3s+UegKGFeFAR5o75vNdAnULCEJ5Y7CpEJKAzJ6ZrGZPhkZQ7os18L7dxwn3m3Oj2DYm+61/goCivYGwbGIEx2pdj7bV/5JxcrYwv9f9+kb5zeFqRarnVc+8W3kGf85zH7DI+Y+9OMDnc6i4ORzWwvAaUWtNONKg09VaknZOGMbroxVmezBbb6ebDSSAApUrX5SISSXp34SgnT0JkgZ3Uw1UMWol3mW5BC7T0xlV7RExAgVzywAnvzgNcrJFyTzfVHAjOLaA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51bd80a9-f88f-41dd-c433-08dd3ee16d96 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3374.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2025 14:46:48.6415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V6eg5Z9tSCtEidtNZxmhAI7bLb9kizY9giPPbnchzlpkSJP7FG/QD6Hoydu1TzJwbsLI5mh/tVjpAoiWh97aCOn3hJr32zkDK/ZoejrV9FU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB8150 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_07,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxlogscore=983 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501270118 X-Proofpoint-GUID: F9RsK4Dd3cTQgx13Aq4lK96Lx2M5InS2 X-Proofpoint-ORIG-GUID: F9RsK4Dd3cTQgx13Aq4lK96Lx2M5InS2 X-Rspamd-Queue-Id: 978AF40010 X-Stat-Signature: ksama81fnunee4nkbu7sxrakse181hhd X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1737989223-573667 X-HE-Meta: U2FsdGVkX19Eq41bUMobVWeL7Z/I2j0GFFrHZKChGhVOgq+AFH54Qn6sLrAdmgwfpAU2mX6qP+OhGmox+jwLrlTaoQySA0eZEVksIM4rU3S4G2QeKZ/rVdsnHLY2pqePAcX8lG+vyamhENd485l4nGOsCSt5tUuwWFS63MnvnrxUSxGOdCmRf41u5FrPQ6rJi5fz2r730aJxlWPCT6OIAtPEdy3jOWg2VvpiMgQ1Qt7pbeJd41ANjef6ovbQ24N3qX+OiIYeKt1EZX12rFQ1yseWsbM2S8e+8UDTqxePUf6O8Z3CLOvfwHnafPi43ZqbvaPwCiSttkbQ44pwI0497ny55CqYS4/LcNp5GFu/Apes+1GRpuQa6UNqpPvlhGWLXHFEOQ1vz7Df4hgIiqDZWYwX+7VF8zccS8ZHn9VF4KPqOv2fKSj4IoTHLsZhvrqwtuMIQ0rA9nsuDX/tl1MztNUljVRHMTWeSVqjKj6X+7rWXkmAzSA+RaDeSqN2bCjQ02hLsqLQl5rEUeLqwjp/w0JH9A92TOHbhnWJPhEvfqp037Xm1ju74dIgU09SzH4DWllwqZqXFvhATEejDc9fNPc08AeK8p5rWCgOL1Jcbg2JhUnXNwC21Mn19hhSp5Hib7JEon0lbRj1i1ekq65gA+zm0Y/W6jad89SkCl/2Gat5eXGAaMnUprtZWMaBaECUYaG8uU+3uyUY9TjUmITvTk+peJJqUuVLfC2S1zLx73xzCV6IMXlphsBFGMAxZnyUi9LhOVisoXunp6uATv8wqIv33PuDGhPrxW+uUWOHSY2qnG4ghusrSzvqkgE2ZnVePhLuzzbHZgPkCKsQmHviP8f4F+QVvfJSONbASFz4O5BV00Lx3lNQtHfiCBM6b3ufdWxgh2VXCztIeFgVooqGU+kp5Ogb9h+FFCRZKIKs/tIGi7jD6cAfko+OmEEWP8hMjUTOBgzepUdywnYywL8 fRyRr7xF XUHCxWDkmooNotUSFi1JXfU3EUeC55jw2Y9gNA5qfxiGDQVBRHeRvthS4Inzz0hWwBD9CDuU084G7gy82IErTM9cznu4IJatpijIrROhRYUI/J2W8wMyEBhTrt7Q3LxGPh2DfCuWQyDBmvESvA6E2+4i/2waRV+FS4Gnh8tBLwoPTh/L06POJY3vUp+MqSGicEO2tCFyEa5e+1kH7elGT086uZTCGIY0QeYOfkCdpli3FYiUrabtAXhlCqWSH11O9xexwSl6fcw/zikhWIvPawWhhsHC8t0aJvkyVltdY4cy2zeJSvImVtlLWDTbW+27XD4Xd+7dVgFpYnmCjM6cG3P/lmWuzaqLFl9fDBfOwz8w6/1WP4F7SgS1ZsWn1cxPiPlNz2xXvGbgDD9C23ABhYAnKkk6T4FNCdSnIH+lk52OSOxl7VMMlfxUTdAk+gyACEqg3s2j9/FRnyx5Ifdns6Teo15TeQhOgRSLA1FRgvaY1Nx3xy4VanT2u1gITAUnaQjvSwxw6Q50edDlZf3woIZrdmCTpebF4h1Jup6kx3zS7RJOY6jmGXQ0t3ezDlcTtiaxeufHhMtyKHkZkE3awZ3WvQX3Y21jtYNkFt4icqh2WTOI9PllxzUhdImv05D7VS+sAQYDeox1zVmiQjxXV1zJ383qm3M184HPq86DPLNAxmVROrTwScm+V+yJkVLXt5gADbseG3jljimt+Yifg/TwAywt4exRxU9N06SRU7a0rqDuJeO8ZC+IHsXYQR4b6yAS8FV1sJsxdKARGMJcwXC8tGYN89aAc27k58XGhbM3YTSLxaqN9ql7pZFBMmIztFaED X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks for the report. On Mon, Jan 27, 2025 at 05:32:01PM +0300, Daniil Dulov wrote: > In copy_vma() allocation of maple tree nodes may fail. Since page accounting > takes place at the close() operation for hugetlb, it is called at the error > path against the new_vma to account pages of the vma that was not successfully > copied and that shares the page_counter with the original vma. Then, when the > process is being terminated, vm_ops->close() is called once again against the > original vma, which results in a page_counter underflow. This seems like a bug in hugetlb. I really hate the solution here, it's hacky and assumes only these fields are meaningful for 'close twice' scenarios. We now use vma_close(), which assigns vma->vm_ops to vma_dummy_vm_ops, meaning no further close() invocations can occur. If hugetlb is _still_ choosing to internally invoke this, it seems like it should have some if (vma->vm_ops == hugetlb_vm_ops) { ... } check first? That way it'll account for the closing twice issue. Can you easily repro in order to check a solution like that fixes your problem? I don't see why it shouldn't > > page_counter underflow: -1024 nr_pages=1024 > WARNING: CPU: 1 PID: 1086 at mm/page_counter.c:55 page_counter_cancel+0xd6/0x130 mm/page_counter.c:55 > Modules linked in: > CPU: 1 PID: 1086 Comm: syz-executor200 Not tainted 6.1.108-syzkaller-00078-g9ce77c16947b #0 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014 > Call Trace: > > page_counter_uncharge+0x2e/0x70 mm/page_counter.c:158 > hugetlb_cgroup_uncharge_counter+0xd2/0x420 mm/hugetlb_cgroup.c:430 > hugetlb_vm_op_close+0x435/0x700 mm/hugetlb.c:4886 > remove_vma+0x84/0x130 mm/mmap.c:140 > exit_mmap+0x32f/0x7a0 mm/mmap.c:3249 > __mmput+0x11e/0x430 kernel/fork.c:1199 > mmput+0x61/0x70 kernel/fork.c:1221 > exit_mm kernel/exit.c:565 [inline] > do_exit+0xa4a/0x2790 kernel/exit.c:858 > do_group_exit+0xd0/0x2a0 kernel/exit.c:1021 > __do_sys_exit_group kernel/exit.c:1032 [inline] > __se_sys_exit_group kernel/exit.c:1030 [inline] > __x64_sys_exit_group+0x3a/0x50 kernel/exit.c:1030 > do_syscall_x64 arch/x86/entry/common.c:51 [inline] > do_syscall_64+0x35/0x80 arch/x86/entry/common.c:81 > entry_SYSCALL_64_after_hwframe+0x6e/0xd8 > > > Since there is no sense in vm accounting for a bad copy of vma, set vm_start > to be equal vm_end and vm_pgoff to be equal 0. Previously, a similar issue > has been fixed in __split_vma() in the same way [1]. > > [1]: https://lore.kernel.org/all/20220719201523.3561958-1-Liam.Howlett@oracle.com/T/ Understood that we do this elsewhere, I think equally we should not do this there either! :) > > Found by Linux Verification Center (linuxtesting.org) with Syzkaller. > > Fixes: d4af56c5c7c6 ("mm: start tracking VMAs with maple tree") > Cc: stable@vger.kernel.com > Signed-off-by: Daniil Dulov > --- > mm/vma.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/vma.c b/mm/vma.c > index bb2119e5a0d0..dbc68b7cd0ec 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -1772,6 +1772,9 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, > return new_vma; > > out_vma_link: > + /* Avoid vm accounting in close() operation */ > + new_vma->vm_start = new_vma->vm_end; > + new_vma->vm_pgoff = 0; > vma_close(new_vma); > > if (new_vma->vm_file) > -- > 2.34.1 > >