From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8EE8C6FD19 for ; Thu, 16 Mar 2023 14:57:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 360FC900005; Thu, 16 Mar 2023 10:57:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31105900002; Thu, 16 Mar 2023 10:57:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D8B9900005; Thu, 16 Mar 2023 10:57:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0F2AE900002 for ; Thu, 16 Mar 2023 10:57:21 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5EBBBA0946 for ; Thu, 16 Mar 2023 14:57:20 +0000 (UTC) X-FDA: 80575064640.02.0A34E25 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 4FC7640016 for ; Thu, 16 Mar 2023 14:57:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MF8VRFD+; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678978638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dzgtYRuv2N6ox79mROVezmyy+dEWrd7NrYkm4MuwFdo=; b=FGgxdjeKinv2x9OPzqnWDzY1ViK1FSBNoNlOcQ/Z5mfpHnXysjjOYnD7wIlNHfkUvGsMFD NWl/+tB0kdMDnmWKDCGoB2Jqt4pmYXUIVNqXj8tkSKf5ZAQ2MrafBrOgX3opjI6NGvYHqp 6MqqQlJjaSBwhwcregnqyvT8gsnwoiE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MF8VRFD+; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678978638; a=rsa-sha256; cv=none; b=zkUrUoPvOATv83QKnDVCpu7SQo/HsDUK6cIIljE8asJARgILh1vLTltlnqSJJo9sE/Q1eC 5VBDhCXs0r4+JU579H+5TjEz889yJSyd1MCV0qHftT52khdv6B/M7NWgSlX+cBc1EqGDnf jXzvm6Ha9h+XuJXTXkSf8UGkaialG5A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678978636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dzgtYRuv2N6ox79mROVezmyy+dEWrd7NrYkm4MuwFdo=; b=MF8VRFD+335ms5hze0Z54L3dmRJnz7CpBJ1gBxsNFT7TdCJoDmu87E6+9Lax3wq/seyGZc oQD+n9/cAZsm062vxkM1YX/XDtireBrljxBCf1x3dG5gwSwvll4WCqtqOdoH9JEWBZ+J7/ y/zOHaqzeCUjuqSJQFNa+sXBgo0lejg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-BTd4ke2qOiChgO-yS0RhBw-1; Thu, 16 Mar 2023 10:57:15 -0400 X-MC-Unique: BTd4ke2qOiChgO-yS0RhBw-1 Received: by mail-wm1-f72.google.com with SMTP id o31-20020a05600c511f00b003ed2ed2acb5so2764259wms.0 for ; Thu, 16 Mar 2023 07:57:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678978634; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dzgtYRuv2N6ox79mROVezmyy+dEWrd7NrYkm4MuwFdo=; b=X3vBnxqHyGVLNnFi9RSxUFvFHXnHNLVeYMk5pRIokjNAaMM4DYOi5VEINKkzaVBhuT 9mjaDbD/jS5hYuSDIIT4oUtcJ62qWrRYm6kJdrqB+T9ECtlNW5xQxKulM/dumy0m8XoW PcTRKGsTZVVmUrcl0aX8D2U+Rl1mWdf4TF56cSDmFy+9DqY6LFpdv6eobUg7VuSvka5C LWuTeIiTLq47HO1Vc2xd9/OOEa4+LuzUf3+6awpH+xTqlTuDHV9gOJZv7/3y++rhB/5e ZQMJdG07mHNn1nlRbP5n3/q7MmklFnkaPbfrmN3bLSx2UnUnvt77kgLvJOXs3cqNdh+b kCFg== X-Gm-Message-State: AO0yUKUvZ1nlOyDKKBHTFd24MqQ4EDOoigyLxOClPCdILE5AU4A9RbR7 6fl12Q388FL01uySdm+BzeqYoBbrZHkHjTpRWbhiIstTvtxSTx/SbjB/DEkfrqCDU94r/qirfwE Ey7+mE5+FqqQ= X-Received: by 2002:a05:600c:27cd:b0:3ed:5a12:5641 with SMTP id l13-20020a05600c27cd00b003ed5a125641mr2118063wmb.36.1678978633923; Thu, 16 Mar 2023 07:57:13 -0700 (PDT) X-Google-Smtp-Source: AK7set9Lgxs8uH0JXoZf16zE7x4qcYswa8cWdymlyPBoS/qG+4kXT/DlM+LrT8xXJG6ATIxR0lqOpQ== X-Received: by 2002:a05:600c:27cd:b0:3ed:5a12:5641 with SMTP id l13-20020a05600c27cd00b003ed5a125641mr2118044wmb.36.1678978633558; Thu, 16 Mar 2023 07:57:13 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id bg5-20020a05600c3c8500b003e7f1086660sm5529697wmb.15.2023.03.16.07.57.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 07:57:13 -0700 (PDT) Message-ID: <83625129-26c9-8885-7367-bb56bc5367f3@redhat.com> Date: Thu, 16 Mar 2023 15:57:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm/thp: Rename TRANSPARENT_HUGEPAGE_NEVER_DAX to _UNSUPPORTED To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrew Morton , "Aneesh Kumar K . V" , Yang Shi References: <20230315171642.1244625-1-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230315171642.1244625-1-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4FC7640016 X-Stat-Signature: gww91jn8atkiasgzetwkrn7wettte8yq X-HE-Tag: 1678978637-287164 X-HE-Meta: U2FsdGVkX1/tWbBZOKBvnvpao3ILWAYOP9p2NUN0GK4nkcX4kBpGt5mlov3Bwd1MYy59m159Xs6c/5FxtnsyswUlMr8196ULI1wQWWBaTWokjYkXFJnWmi8QAIgqHS/2Nltnry7laz/x0i0c1MebSsD0U/aOZJz8oMnNteb1aAZODS+onoC0yoRsKjaGuOb5nAN6/By4UOXW5+mTyE0qfvNEokQUo/ZKN72eg4lfkmXRDHLH19r1mJlE1rZH4d/IZVNhhOM5wN8CdJT/B4mXLvmA4t7SLEGqn/EEW97SfLQhGmjWymaxNpKq7IxQs1qhw0YNVlkTjbhOESEduv3wvErMyBBX83fGXCAqt7Vctkubwx4rrMe2SILLZL/6hlCYx9TrQ4QjjqksnlIFyxrBdVSW2jfm4d6mtn+SlLZ2o2UsvJ/m4WI9g4CBBLJ5I+UVGrLb4sSSfukvG4oGCnHPId6Ya+Wt8Fzv/cIMcrB+3ZTKw/iQQNJQDlYyAwgcxrdHzmJwiD7her6CbSY3f3p4Qx3EDfVSkZKL+l260CfOttkWqgp05j/0F3OplOfPXyBsC8ZirloeT5RoUorEwPxhrpf/uZl6ESMMgC/SYM3S5ZYH/ZDts63d9dkSBnRMg2hIZZqLph2vZ9N0LnC4g1IZgmTKUctQ3dikOPxR6jqIsjJsTJN8WapXra4T2iQqX0k757pmHPtcYInK0bIBaog57iGzjv/CC8XkeNwGw6NPqekW+QPT2hvUUCS50GTOXJ3KPl3H0RhEg7/8nKEaBbjDX1CP2RWgsah2ciPVYnr9uppA631dLEptrvIklIj3J9ziMuZmCrVU2D+tp1k7viiylq63AfAd15rGXeiy49sUUCztSOCqAHleyPZbfUsv4Ki9u7PIvrRQJYOd40QOYfS5mHCfw2X9XE45vpxzmoaqqJjUidpN4epB7NEzlenP4pJ7+DYSd5N8sGAVt8MXyNs XME8/HmR KItEvhwfM58uj/TBTFg6BRdGhwWPbNdtMhWQh7ZuGU8CXlxmux5UyOBzQgFr4NqzatWViZlkSCiYMmUDmqA6LQhAgkdGZDOklANaR7kHJ7qoXmjyt7gptSFU6lHC/u3T6sGLOAz1jT4YYXnZv47zimB5ZqCy+irPaaGrPeNiBKDfnDB3hvoUWWFhhRL9Z6Gis+/4pH4aVTywSFWIFLcE4KJgQ61LQAleH69ncJwIrRR7zC5nQN7L+aRSMRf/pmKczYTltviQhbUpj96PA/k6RdaZ+Z1SKg7BrcNFOejI19JTBzKga/xjYYtjZzoXF3JuYDYO2a8jmDtvac7ovEsCjuxgqWCqHLeg2oQ9QGXWF1K5txVum0p1JAKOF5kdUhqqDiLJzBJ7laA6Lwz9Ohrx1ubidlr8NBRmSJAvxpDhfMbyS6N9XzddidsheOLonnt3tXPjj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.03.23 18:16, Peter Xu wrote: > TRANSPARENT_HUGEPAGE_NEVER_DAX has nothing to do with DAX. It's set when > has_transparent_hugepage() returns false, checked in hugepage_vma_check() > and will disable THP completely if false. Rename it to reflect its real > purpose. > > Cc: Aneesh Kumar K.V > Cc: Yang Shi > Signed-off-by: Peter Xu > --- > include/linux/huge_mm.h | 2 +- > mm/huge_memory.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 70bd867eba94..9a3a3af2dd80 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -79,7 +79,7 @@ static inline vm_fault_t vmf_insert_pfn_pud(struct vm_fault *vmf, pfn_t pfn, > } > > enum transparent_hugepage_flag { > - TRANSPARENT_HUGEPAGE_NEVER_DAX, > + TRANSPARENT_HUGEPAGE_UNSUPPORTED, > TRANSPARENT_HUGEPAGE_FLAG, > TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, > TRANSPARENT_HUGEPAGE_DEFRAG_DIRECT_FLAG, > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index b0ab247939e0..913e7dc32869 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -88,7 +88,7 @@ bool hugepage_vma_check(struct vm_area_struct *vma, unsigned long vm_flags, > /* > * If the hardware/firmware marked hugepage support disabled. > */ > - if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_NEVER_DAX)) > + if (transparent_hugepage_flags & (1 << TRANSPARENT_HUGEPAGE_UNSUPPORTED)) > return false; > > /* khugepaged doesn't collapse DAX vma, but page fault is fine. */ > @@ -464,7 +464,7 @@ static int __init hugepage_init(void) > * Hardware doesn't support hugepages, hence disable > * DAX PMD support. We should also fixup that comment then, no? Acked-by: David Hildenbrand -- Thanks, David / dhildenb