From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 084CCCD1284 for ; Thu, 4 Apr 2024 18:40:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 617A56B0089; Thu, 4 Apr 2024 14:40:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C7A06B008C; Thu, 4 Apr 2024 14:40:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 468066B0092; Thu, 4 Apr 2024 14:40:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 29FD46B0089 for ; Thu, 4 Apr 2024 14:40:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E00BD160AC2 for ; Thu, 4 Apr 2024 18:40:19 +0000 (UTC) X-FDA: 81972714558.23.F01ABBD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id CC02AC0017 for ; Thu, 4 Apr 2024 18:40:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a5Ot7DxR; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712256017; a=rsa-sha256; cv=none; b=GUBjiEXMl/4m8SC/2ccnBPrCSpvSaBo/r6xrAEI7eRTkH0A21lf0yLNPq+Za0o4JCS3BNk bgjYK/hW/pvKk50iPdSCNetngdifydLEXTDBTQdmkPv7zN4rFoIGkawu4Gbv8PYpmOmYOi 8blI9L9UvEqRJEfnWrHFt79M8lHmoug= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a5Ot7DxR; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712256017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3rdFduKNsgYkMXlnNZ7V7vkBY+/0KWfUGBmXjdWrYMU=; b=XTyOabPNzM9ZzWBB82NEqP1Zpksbi9UieJBk8RD7GkCHW3bGheXuZ0ji396LMe8u6vwxh6 9HXl880Xi8ZmdEuNNxx148HQzR8KYrqdrzJjW+Ft330KKLzZtxidQzdDejuCBn9RXCArTa 2FEjUXxr56FopnyuYoSjHnJzd2ucOzQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712256017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3rdFduKNsgYkMXlnNZ7V7vkBY+/0KWfUGBmXjdWrYMU=; b=a5Ot7DxRPb/leM3Iuh2n94OgKc/eqUAPcJktVYTuSCBvwGp74RHaILjMJ5mAoyGRfh45ze s6qvzD7Jt0DuvU6DwWa5Py9e5Y63PQARFUgDuUvIjHcizbHeC6XoVS4U/zAQ6up2RVoZI9 wGTGOVdkP4DsqHl7/VvQ5fOBztAGR6g= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-wc_GV-oFMsGEm00CBo-quQ-1; Thu, 04 Apr 2024 14:40:15 -0400 X-MC-Unique: wc_GV-oFMsGEm00CBo-quQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-343da0a889dso97842f8f.0 for ; Thu, 04 Apr 2024 11:40:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712256014; x=1712860814; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3rdFduKNsgYkMXlnNZ7V7vkBY+/0KWfUGBmXjdWrYMU=; b=Az3B4CyKAe4tWJPhcbXJ/8jWjo2VanuPI0cvFQCggHZPwGSo6Oog/BXRSgQWIbDjp6 nKJXhkSsUYpWUstd45WXwCA4gANwsiwiVSvPA0/Q3i727sD1Q5wkPlHePuYDmNIXaghB 6TJxUeBKz73kHiY0qIZ6Y1mEom4nERPjNewJ/icEE/R2BNSelyyby0evqVZblqN2dcNw GX+5yugiqqC7t4t2wagcUtKgLjtjKsuppExarFCLZ/YJCtyw4DhVW+vLQvvpCOxRPHQd G8P7a86deS7DGD9x9M4gSOOjQ2E4KeYmkXcN0TwC8rV3HKnCIUxLXOHor0VyWTMmr5PM poEw== X-Gm-Message-State: AOJu0Yzfa3dy++rUsK1JkfMCO14Jb7iN1i9lWLi/Umsk5BFT7hlLsj81 fW5ZM/2Eprjh8849V2JZVBG0J61IT00OtpV21diKuIAFidZ9YfHYazpcZ9REdeUyP9APVd3qb6a peDnjRTKi8mrWpX6RtsEftgjPJGlp3i1NJH1pp1raTRhW0TxMjnQTgIYE X-Received: by 2002:a05:6000:cc:b0:343:b5f1:2da with SMTP id q12-20020a05600000cc00b00343b5f102damr312132wrx.11.1712256014695; Thu, 04 Apr 2024 11:40:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGs0tYv1QYnvUcfygrtUL4/iFZ8sufxJpt+u3aDJM/IXnBucv0jB2GNPtoYahzpIGjCtwre8g== X-Received: by 2002:a05:6000:cc:b0:343:b5f1:2da with SMTP id q12-20020a05600000cc00b00343b5f102damr312118wrx.11.1712256014200; Thu, 04 Apr 2024 11:40:14 -0700 (PDT) Received: from ?IPV6:2003:cb:c743:de00:7030:120f:d1c9:4c3c? (p200300cbc743de007030120fd1c94c3c.dip0.t-ipconnect.de. [2003:cb:c743:de00:7030:120f:d1c9:4c3c]) by smtp.gmail.com with ESMTPSA id z13-20020a056000110d00b0034174875850sm32589wrw.70.2024.04.04.11.40.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 11:40:13 -0700 (PDT) Message-ID: <834da4aa-3b49-4603-bda7-a19154570615@redhat.com> Date: Thu, 4 Apr 2024 20:40:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Remove struct page from get_shadow_from_swap_cache To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240402201659.918308-1-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240402201659.918308-1-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CC02AC0017 X-Stat-Signature: kxruz5oec3mgtxyd58uwj5u9fknn7mug X-Rspam-User: X-HE-Tag: 1712256017-332084 X-HE-Meta: U2FsdGVkX1/LlJ38ZlW+/kVP/8RJRnp10uSoM51652JYTXXY98NHSHyr0NjiHUy9ScRdXqyKN6Ix9+TMTlwl2yvdXFVCl/N2jou31iGewtv6Lr6yLn+r78mtzww+/HvR61hkGv7X+YrZ5/iIzGNqNRaQmjvi+fmAmUdne7yXRT/zcBEj5iH8HsDdbPaNMKSm1pib/RT9o5hS5dqMSlUs28uO4mTTzNsCJ5eQwbBeDR8QjAcr6GzAlb1xzSEfpj/zEfpQNzPjO6KrNGULxKi85jGNcN6EznTLad3Cis6UUk0+WsBRa73n28OgOc7pncFXYFITF2E8y1gnLR12fXcwdlFyrBTYIe1qD4jVXsdioiRnQrI3OaMrLHeBhWcRXR5AoakwyJ/wFzxMEB4rNnLycFEBa8Xpnk4i8IC/XgCBzxs4JKqm8/Fx/N4xse2KMsIBjwt71K6XsKOYrn4g3KENI+6tacvfHkvk4oUF0YHE31BtwpRx0vjqUlGImdrtayAPOxZQRA1k53W/uPbXitBTplCBn/C1519iiXaOIjkZums6Pj5CozM8HZR6s2NBAf5bnUuR8fDGcM8OVwkcXhHHliB3FoXRQMCICRjEoY8DhfpWehS1nF0/3HJCPbM6iobXgzJOE1mClN68D7foSzNNW8JJRBmZ04qCiTQz7nPINlEagUcZctD/dTYOj1wIAqIreOloraso6FSZDkxh3m49c0+xodkSBWTwZD+V1M4UjVX9LooSDkh5tDn1VWT4Bi3G+h2xKktbM9HzD95d6B6g3RqzvFE1CqrUyy/B6bO4aMlXX5z7/sgba2mAHCjV1aY0w+0CRbIbBXt+jHEgwyf12swqry6BgqjPu9zstYBoiXHw9wjoEBRRvAtPcJt4xw+Vw6bXyf+JTRH/1aTEhUYPYyAjadvWXE8R61cDXM568++CFSRjbYvg+yR2nhBm5Kwc/bZrl8uUd46SEHjzksB wtI6Cd6+ ahYjxCKNlLdeouxsOJnun9ZcwdwzB8swDCfbid6ROp/K1tYWKOO1kfDyrqCxFmYr4+7DFBTdkJfpP6ov/i/zIjNps/+52+voEgPUA/dizF5eq/5SsCO2lw71UX1O5agI5lq1zPttTApakv49l/++makyGdJ7aDpjsAZUuvubJY/R3QvQvx1ugLEM6dpKWqx2VMIZvC925v2T/OOYkqSEaNLD8FBTj+hasVsHpE2YZWwpy9Tg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.24 22:16, Matthew Wilcox (Oracle) wrote: > We don't actually use any parts of struct page; all we do is check the > value of the pointer. So give the pointer the appropriate name & type. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/swap_state.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/swap_state.c b/mm/swap_state.c > index f3c379e93bc6..c00ef2f18f2b 100644 > --- a/mm/swap_state.c > +++ b/mm/swap_state.c > @@ -73,11 +73,11 @@ void *get_shadow_from_swap_cache(swp_entry_t entry) > { > struct address_space *address_space = swap_address_space(entry); > pgoff_t idx = swp_offset(entry); > - struct page *page; > + void *shadow; > > - page = xa_load(&address_space->i_pages, idx); > - if (xa_is_value(page)) > - return page; > + shadow = xa_load(&address_space->i_pages, idx); > + if (xa_is_value(shadow)) > + return shadow; > return NULL; > } > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb