From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1276EC636CD for ; Sun, 5 Feb 2023 09:56:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29B8B6B0072; Sun, 5 Feb 2023 04:56:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24B6D6B0073; Sun, 5 Feb 2023 04:56:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 112B16B0074; Sun, 5 Feb 2023 04:56:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 01D506B0072 for ; Sun, 5 Feb 2023 04:56:03 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BB95240ABD for ; Sun, 5 Feb 2023 09:56:03 +0000 (UTC) X-FDA: 80432782206.24.3DB0CA8 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by imf13.hostedemail.com (Postfix) with ESMTP id 7254520014 for ; Sun, 5 Feb 2023 09:56:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=tlOrqmII; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=MAMoCKge; dmarc=none; spf=pass (imf13.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.25 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675590961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IfnK616YIRqy87UD2TtxtShT/uMOi2eIt6iskw/90R4=; b=C5dpzGHDesK7qaG7PZ6or52G7dtFnDGp80Ve1q20/ugHPD5fdR65QOLBkI+AyCkQrtG33r B8hprTjsF1lJT4SqByc4VX0GRS/2Q7Cv91CpAdi5LZubGFM1esOlJHjZEH58s3xvwD5+KZ kVOX3trZlkcHzYkCBuLvrF3pU9W0qTw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=tlOrqmII; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=MAMoCKge; dmarc=none; spf=pass (imf13.hostedemail.com: domain of arnd@arndb.de designates 64.147.123.25 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675590961; a=rsa-sha256; cv=none; b=W7c4XWWSOEh02aC9fDB9ryw3vTr2ZzyweG6nm9BJXlSaDW4HMqDSLiTJHr4PpPXlP+xam3 W3yqygxBMiE32frWdUqVjAPRm8jwT2e/wiw+y7XszPxN1YjYcteVN+QAfaNWEnxiQTXLtF PbnEA/5wE+P8BAObPMSF6gw5IgqLGBQ= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 019DA32000CC; Sun, 5 Feb 2023 04:55:58 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Sun, 05 Feb 2023 04:55:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1675590958; x=1675677358; bh=IfnK616YIR qy87UD2TtxtShT/uMOi2eIt6iskw/90R4=; b=tlOrqmIIpcN0PiYS60DC7MHHeT J+uINRCytwTA8maMW6d0O4aha9DxnZ7f+f+wE45CPLJMb2gV1+Bn38IRH1c5GJB7 vhssxsznyEe0FmuAbhSEP9xdpdPoLJIqtWmCgDUC5XPZliG0Tbk4E0dLtxpAj4RG wrwwyZwW07ZO5hZQOAMbgA7g05hiSic1og5Yrer5TByi7f76EnDtaWnD2pVHcn9g guaCNpk/jTJO5M7LNmOXIXzMTmKdYck5hkfPYCCkhlcB/vEMmGwHJxuapmOVD9y+ SINI8MywCVcjE8gUyoWACPu+u0H5keB/XAUXdrKpsAoxzOcLH2hklGNdwdAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675590958; x=1675677358; bh=IfnK616YIRqy87UD2TtxtShT/uMO i2eIt6iskw/90R4=; b=MAMoCKgeBnHRLYyWdji9sY2G96cuh3YfoMVyfM00fv7D +QRQyGKp5ku7Mt6PRjRHSNSUAG1EMU2LTbrVzdc59+FyFb4yQcFqS0xGv1zc2wf3 VxABmtk/ubMlDPeD4xYw7DzR+S6gGQSzya53SsZZFezNZbpXnVgv6EaKJn8R+eOV d945gz98yqHD3bH0IhXKOLjfKo/FyKZZosZyFaJCZ+CILh0Xb/nS5YhsZYCb02Kf /ms3J3UDd6PLP+4QfmU9NLHCTWErs+nYLx5B7yERaHX8VpOBzjvfn3EPvUH+t12E lAjZUI4E7ihsDOt31tio+mLa3D3r0Lq4dWNpbfPBKw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvvefutgesth dtredtreertdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnuges rghrnhgusgdruggvqeenucggtffrrghtthgvrhhnpeffheeugeetiefhgeethfejgfdtue fggeejleehjeeutefhfeeggefhkedtkeetffenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 06039B60089; Sun, 5 Feb 2023 04:55:58 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-107-g82c3c54364-fm-20230131.002-g82c3c543 Mime-Version: 1.0 Message-Id: <834254e6-a9c2-440c-9c67-fc5fa5ca43bc@app.fastmail.com> In-Reply-To: <20230203190413.2559707-3-nphamcs@gmail.com> References: <20230203190413.2559707-1-nphamcs@gmail.com> <20230203190413.2559707-3-nphamcs@gmail.com> Date: Sun, 05 Feb 2023 10:55:38 +0100 From: "Arnd Bergmann" To: "Nhat Pham" , "Andrew Morton" Cc: "Johannes Weiner" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, "Matthew Wilcox" , linux-api@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v9 2/3] cachestat: implement cachestat syscall Content-Type: text/plain X-Rspamd-Queue-Id: 7254520014 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 4g3xq6f8h7ofxyr37mbd15c868bxm8iw X-HE-Tag: 1675590961-418112 X-HE-Meta: U2FsdGVkX19YXfuIa1dQrmVExKKdeQlwjVmHsuLQ+M7jUP+HF/tLixE3wQohH1h8kckw7Y1QK94invmepfBdQP51JYzXWiJdr/VXMSBMfVs3ddq+IFIwQ77AkVnbPiqD+YJmNbnNYjO9RMcZAuo3/F4ZsrEF25PK9dpTsyZR/6uf4PGEzWYo5xkqwkj1skBOMNPlYlt/uM1Sygsd9NgGeMt8QQHa1Wy/6JdwF9jQ1fhOKJdZsY9N//ojMa4sp/FiFL/Mu/lYa8H3Tm5UgzEevW9FRZnVLkXgu5uM7ZWTTzH6kWCvOVSyCh01sfmbhYKAILMPp0Jgvk5vbxx9oB9eRvIGwodKEHr4yEHpto8iUpZEmd4gmFNyX3R/PmNPWmVmWdM6Z9+h8qdGu5LzhzDsq6EQMbdqCGHVgtUmjsVwu3hBebWbO/L9iGCimAbe7IQcgL7xfHbMyNjCVlctXSVSLKnC4oXgfN1rx9rSiP8S5dzR/CJ59a257iPNSSU2U0lwnac/KOQxJrPuiNXC54bz1qQ6nbdLwY3vuZcNGqGtFl1MwTOtf8XVR8iyUEMjaLiMEnIsoV+6YaGHO4lygZ97W3V8HK6ObH3fRxJ1sFqgQhRNPs/yObPHCtyn9BVyarThalDJNUUss5rCoeEXkQ4d/LBGKLD/7ejJG+q77SxG7Nw3W++Tt+OKH4d7tuOT/vXKOCqb3Xy50C5/Fs3+HvEQXVE0XqnkRIwvO4KAWbwkZ5OIa2SvDIb2RnnSSdZKaoPrx403JTIeEhfudjEGhj/mQ7y92DFrzfkcyeXNCQKCNHYWMhlc0fSJ8WAIohv7Mdp5zlZuN35u5eniIWEXsiA4pgP+u0LAWLaWDgzIB1JYdkulwIdA03UWRR4c7efijkSIpCXsVAQUPdLz/qR/Ar/iNy1NZZ5+eDB5DkmVeswajQUfv3f3A4u94vT7R6HauoGqQ7qnSqOFEl0IuUivOp/ pRBFZuRI C/i+Cp5T+tvD4TKPpkxACF8ebT+WE8QSJ/n7MIanIaSik1mxxJ67hFUJABd0euLfLKWTtAHX8sO0X+r+aPuk7mvQRU5DWFX9qmFCLncb/2eC13Hp2p9PLupoWLZtcpJCTLyFmEOfWdlwudpBqiNL6tGn9Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 3, 2023, at 20:04, Nhat Pham wrote: > +SYSCALL_DEFINE5(cachestat, unsigned int, fd, loff_t, off, size_t, len, > + struct cachestat __user *, cstat, unsigned int, flags) > +{ > + return ksys_cachestat(fd, off, len, cstat, flags); > +} > + > +#ifdef CONFIG_COMPAT > +COMPAT_SYSCALL_DEFINE6(cachestat, unsigned int, fd, > compat_arg_u64_dual(off), > + size_t, len, struct cachestat __user *, cstat, unsigned int, flags) > +{ > + return ksys_cachestat(fd, compat_arg_u64_glue(off), len, cstat, > flags); > +} This still looks wrong to me, as this compat definition does not match the native variant on architectures that require 64-bit arguments to be passed in aligned register pairs, such as arm, mips or ppc, but not x86, s390 or riscv. Arnd