From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB952C47074 for ; Thu, 4 Jan 2024 15:49:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 381206B0085; Thu, 4 Jan 2024 10:49:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3320F6B0095; Thu, 4 Jan 2024 10:49:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D1866B0098; Thu, 4 Jan 2024 10:49:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0EC716B0085 for ; Thu, 4 Jan 2024 10:49:21 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DC0124099E for ; Thu, 4 Jan 2024 15:49:20 +0000 (UTC) X-FDA: 81642062880.24.0005FE6 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf27.hostedemail.com (Postfix) with ESMTP id E3C1F40004 for ; Thu, 4 Jan 2024 15:49:18 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=aRA3Nok9; dmarc=pass (policy=reject) header.from=sifive.com; spf=pass (imf27.hostedemail.com: domain of samuel.holland@sifive.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=samuel.holland@sifive.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704383359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7TIDLSdpMStFIDjtZ3v/tdAZRRwjQGD+NRWYb5ITqWs=; b=p+P4RpJnH5jjCt+JO0wFvpqaNwXrkLZzK+vdykGKSKIEwCodt0BcWXv/n6CQSG0wrTv/mh QgteX5deW8lqHAsbGaToZRxHYc4DyhO670zdNNyU4mfr8BWQcpT+Hb1MdOEB8SYXosNAjA uqBJfuo3XGGeW+gq0XgsUdSoOoST29M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=sifive.com header.s=google header.b=aRA3Nok9; dmarc=pass (policy=reject) header.from=sifive.com; spf=pass (imf27.hostedemail.com: domain of samuel.holland@sifive.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=samuel.holland@sifive.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704383359; a=rsa-sha256; cv=none; b=v+eOE3KwVBkD65aSYizBnl+WFy0Af7TyG8TwCNMrRm3/+6pPiwfTN4QbqL1bPOgr2hQiIU Wsy/+wl3eBgZUfX9bIPo5egcMYush47tGdZBVobylRp1mjkXsfnO/BfwQk6dIaiU0w1c7E Qb2NaRdPZIHOdQ0HqCKVLIjNsh2PFCk= Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-7bb5fda069bso25168839f.0 for ; Thu, 04 Jan 2024 07:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1704383358; x=1704988158; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7TIDLSdpMStFIDjtZ3v/tdAZRRwjQGD+NRWYb5ITqWs=; b=aRA3Nok9JsbeccNn7IQKpGZDigxsI6bR1fEjAXT3EBF2qnwCMhxvUpYfdi8Ix0y4tv 1EXPb3S1AtL/eibxO2IazXlQIvCl3kJVkLFEdta0b8hNzmaVWgT7p1tBMK5mzwGphuHm IJGf31ea7hMPw2pRsCmwiQtWcZmi/3+NLKXNBgFbQVQz8unHdXF0KJkR7IRfNCYOz1o5 X4g7eUUPploAC5UqI9xEo8Ro8AYBIwq2CJb6VGOSAmzuxm3zTNP4nmduLJ9rAx3c4sBp /Hb613fEpW2VmtGFjiS7DJ1maYS9TC5xayeBf/wwjPARI0uL9c1RGCybQ6lQAXUw2auZ gQpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704383358; x=1704988158; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7TIDLSdpMStFIDjtZ3v/tdAZRRwjQGD+NRWYb5ITqWs=; b=h9sfZVUAnm5/B3yJWOKM+Tp8TLFjhWIk2aTH8sXGKlTrI97KXg9jIlbJKh0Ttopwiq tBXR0lUj5vrjR2GLr0sme/OOwzIKpPvp+Jd+2dVv4VLNWaeG0myn6CHNBle91TEmp2RD rssQUDj51kw6JCjUOXj0T69TDz0WY7BZZS2uSGMzOOu6qV3W/pzIix7w6d4+D/FwO2UC k7FVUNKPdTVB3ETyrcp9ThPkZzUoK5H3Q2TLHMOXDFUGvyIW26eP/x1pUMs6wuDpYTUT c1iczVDgbpS5my2xbPz9K1Hsnsm7t8GFg9cTT6PpPDyWKS9Y4/SxZ33WK3p5USaprTN/ cm+g== X-Gm-Message-State: AOJu0Yygo5B6k/voPgtrqrHjURYKVU+gys5Kmdn6uFib0oFiTDrjLhPT kCntsHVLpuhID4dDFncwu9qUkr0xeGdm7A== X-Google-Smtp-Source: AGHT+IGl23oaNLXkpTgQvFzjqjcPmDls8qUwG0Ek6OVfKuEbJznQZTa3hgKoIBfrgeoXH1vqf0zj0A== X-Received: by 2002:a6b:e915:0:b0:7ba:85e4:f8de with SMTP id u21-20020a6be915000000b007ba85e4f8demr732625iof.42.1704383358130; Thu, 04 Jan 2024 07:49:18 -0800 (PST) Received: from ?IPV6:2605:a601:adae:4500:b86c:e734:b34:45c6? ([2605:a601:adae:4500:b86c:e734:b34:45c6]) by smtp.gmail.com with ESMTPSA id ep24-20020a0566384e1800b0046696ea033dsm7981361jab.146.2024.01.04.07.49.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 07:49:17 -0800 (PST) Message-ID: <8341e264-53be-4821-ad9a-145e154aeec3@sifive.com> Date: Thu, 4 Jan 2024 09:49:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 10/12] riscv: mm: Make asid_bits a local variable Content-Language: en-US To: Jisheng Zhang Cc: Palmer Dabbelt , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexandre Ghiti References: <20240102220134.3229156-1-samuel.holland@sifive.com> <20240102220134.3229156-11-samuel.holland@sifive.com> From: Samuel Holland In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E3C1F40004 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: nw794s65o3qioeg9stbgottbpc1fjy94 X-HE-Tag: 1704383358-249143 X-HE-Meta: U2FsdGVkX1/wvKLUTuk0f4DVhbzoi+EfPfnEAXPSNCstq/BJXZouH8J4/159JrKF9WaIgK9GlaZvOlkVrDWzxVAm/7JAs5TOmOuzxun4picc+pD9s0F2le/rhSryz/Da6rUbaEEdWpAOa0cx71OMPbErmDT1drAhcadWyAwEm9yPM1i0UB5ipDm30rMhOmn0OwahTya379X2VnQQdgyoPaz5gBD90hz9aqPQv0ayCzEGFwEXzUyvvk7rRhQSYAfrlIbM+F+Shm+rodAtfvws8oPjgazFPeOtmM1JUWI5BFG7HGHnIcsSzDomsZ+BX67OfLrTasjYltR36HslDvAR2e3+9adzW3gb43BrmzzHXkVOBkJGeAGWBCmiOO7mae5rk8MzCRnEQs+5ZsWiEqGeVZN/6JQLcpMBSbIvKLhwsPkCstbQHj9SmVLqq1yoMAiY3T0ZMwqocturkPCY5SNLbHWvkgo6dYAWNQ6LsGNE9mCcF8VpiMvMrgOgYnjT8qY5o86CeG0bbqwbiSQL2c6ZEmdtm7OsuZLiGBvubKNmkSHgCdGMyGNGRRb2X4Htzh/HZP1jx/2MczfDUwSJQxTVkLNjc4CxIqwOOVA1dLTtbEFADwL2jJkKxGm+QSZQLWDGadvqXaH7iAXt/v/n0nxC7V5szD9IaP87aEPO7dFX5/N/tHZdbkX2n4A4VsR9ZbkG69LwbfAYOs3KXdfQCXRyZa7Ng3ZxUpP0hjnxf/mNqTi1DnmSdd4D3clENK8qkCcQXuHjqYylPvnQt5+oYtp7xZBIa623jpbpOa8xMbNoXFFqeIfZC0fSjejst8BYQmEa8LBxRR9u+5lRueh+j9xUiLazPFBenBr5iswR9alG/eKAfHcqny42DU0J6xTNe6zSr7FxDzDlDYdB53U/2GKf/ajgUrGUrsMt0ZXv9BBA9YhEIBoHWRITO+vUcAiMREXFnEuzWwCFS51c1sariFv /XOPESR9 /13KHWQZWlkqnPGQhvLUHU02pGlgzKdURw7bSc3zQe45YgebUZ2zywagTk/oicvKrSb5YEDFWYKlhL1rAsB7I/xsIBbRZbvgSKGUXl/orRyRwE2ur/0tZa/91oeQEmkawmjlQYvQh9b8D9ysEnxHJGjoGi6kCe1kn5ksfyKBo7YceQixm+asduiGQc3B06C6ybo5eJ6badgQ+Aqq7Ch506XZ4VjDHFMTT0A7fiazRyIlTCiGEzSM3cPjFK89HC6X//v3hE491B0vS2Vky8Ct5xXVf2iK9r6v+XJab/9F9zvtCF3E8JuUJ/CVZSfzC59WH5Wl9kJVqIZRRmLl2C7VEqYRugnEhd9QVN/RurasYc04qInjo2+gEKJyANhPXnkK0EOV7+EzOtNhSkMzQT+j6X/dpNjzHFLvBh5vxqwE7w55zI0rcuVtnfI/b5komKqEwriWbxb97UHDpjj/8zdnXC7TVHtG/J37ZVvDROnj6xIHdyNb2OsmSnMhZQhKQzRKr+ZXslhKKkRDOVRaKAp/2BSElgjV0MeycPIsZe4hnoNO7Ame+/EsX9pzSAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-01-03 9:00 AM, Jisheng Zhang wrote: > On Tue, Jan 02, 2024 at 02:00:47PM -0800, Samuel Holland wrote: >> This variable is only used inside asids_init(). > > This is due to patch9, so can be folded into patch9. I'm not sure what you mean here. Patch 9 does not touch any references to the asid_bits variable, though it does touch adjacent lines. >> >> Signed-off-by: Samuel Holland >> --- >> >> (no changes since v1) >> >> arch/riscv/mm/context.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/riscv/mm/context.c b/arch/riscv/mm/context.c >> index b5170ac1b742..43a8bc2d5af4 100644 >> --- a/arch/riscv/mm/context.c >> +++ b/arch/riscv/mm/context.c >> @@ -20,7 +20,6 @@ >> >> DEFINE_STATIC_KEY_FALSE(use_asid_allocator); >> >> -static unsigned long asid_bits; >> static unsigned long num_asids; >> >> static atomic_long_t current_version; >> @@ -226,7 +225,7 @@ static inline void set_mm(struct mm_struct *prev, >> >> static int __init asids_init(void) >> { >> - unsigned long old; >> + unsigned long asid_bits, old; >> >> /* Figure-out number of ASID bits in HW */ >> old = csr_read(CSR_SATP); >> -- >> 2.42.0 >> >> >> _______________________________________________ >> linux-riscv mailing list >> linux-riscv@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-riscv