From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C427CC433F5 for ; Mon, 27 Sep 2021 15:51:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 598C360FC0 for ; Mon, 27 Sep 2021 15:51:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 598C360FC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C3F726B006C; Mon, 27 Sep 2021 11:51:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEDF9900003; Mon, 27 Sep 2021 11:51:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB5E0900002; Mon, 27 Sep 2021 11:51:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id 9C5746B006C for ; Mon, 27 Sep 2021 11:51:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A57782FE0E for ; Mon, 27 Sep 2021 15:51:46 +0000 (UTC) X-FDA: 78633793812.28.8F538F2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 435AA801A8B2 for ; Mon, 27 Sep 2021 15:51:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632757905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/vgpSXmiTJjoeFVzvxVktr7agfW9UwhR9y61Ap04cEk=; b=dg1M2tErlrZL2UZ5+qxSyU5xjL8aS4sHgpfmVyOJkzXV1pI0ndsuPWoivZDw3tPzH8BXZl 4S0xqe6bP55zgTmhwosxquGEXko+B4gSzRRatp1PJdFXFlgVYQc8fU5BfRFX4vDelcIvs+ tsWM13zYfxvKZN97Otj07X9rqusWaXU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-496-mKoBnbWBMv2kTMcGzQ5dGQ-1; Mon, 27 Sep 2021 11:51:44 -0400 X-MC-Unique: mKoBnbWBMv2kTMcGzQ5dGQ-1 Received: by mail-wr1-f71.google.com with SMTP id r7-20020a5d6947000000b0015e0f68a63bso14257424wrw.22 for ; Mon, 27 Sep 2021 08:51:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=/vgpSXmiTJjoeFVzvxVktr7agfW9UwhR9y61Ap04cEk=; b=esP54eML/58cPoEGTqPtk+wzKBP32hBnkMujkdtQ2VZaZ/anwvEb6wZJjchyFBZ2Yx zFx/UXlJ0vZB6tqal1CZTP9N0A4jbWWGg+930yOs3Af5adv03rRDdO43LMZEoRQgARCl KEwSp8Knqo/UrQiKojg3QSX5QdL3up5mUZ29izMH7yFj2dJDS502lP7j/rm/3RpnXslP G9lhXoml2Yw+yCVcE1AIV90I0NcImEvJFrh2Sn8lWSNigLKJwlYotBDdF9u6LPhQip6C of4S9aw53l6iECCl+nMtkg39CzC850FPFyJjvccM1m1H3QTLHFmf9y+x/y++AGkYtJVG whHg== X-Gm-Message-State: AOAM53081GySvRUW+MPRs4HGS96dCj3JxMpqJggzbYF4H3hmoLNInYhX zEmRHwxQes+8VBBZyjyu652RpjW5VSHX9IlwhmTS+Gi86yUjM85IO4CRt02xQ2hcs2zuFJ/s/R7 Jg98KyOSgtnE= X-Received: by 2002:a1c:a78d:: with SMTP id q135mr685567wme.36.1632757903077; Mon, 27 Sep 2021 08:51:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWTyyR4BQrL35V7YoVFE/8tnjzyceGwJuLvzKyMN+8BuumNqGsYOneMg0dw3n5qeSkT146PA== X-Received: by 2002:a1c:a78d:: with SMTP id q135mr685553wme.36.1632757902915; Mon, 27 Sep 2021 08:51:42 -0700 (PDT) Received: from [192.168.3.132] (p5b0c654d.dip0.t-ipconnect.de. [91.12.101.77]) by smtp.gmail.com with ESMTPSA id c18sm9623733wmb.27.2021.09.27.08.51.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 08:51:42 -0700 (PDT) Subject: Re: [RFC] arm64: mm: update max_pfn after memory hotplug To: Chris Goldsworthy , Catalin Marinas , Will Deacon , Andrew Morton Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sudarshan Rajagopalan References: <595d09279824faf1f54961cef52b745609b05d97.1632437225.git.quic_cgoldswo@quicinc.com> From: David Hildenbrand Organization: Red Hat Message-ID: <833493d2-d585-47ee-c258-79eae5deff36@redhat.com> Date: Mon, 27 Sep 2021 17:51:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <595d09279824faf1f54961cef52b745609b05d97.1632437225.git.quic_cgoldswo@quicinc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 435AA801A8B2 X-Stat-Signature: 8w38pzm7edzwiwaa43bi67quw6nx5mt4 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dg1M2tEr; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf06.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1632757906-97589 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.09.21 00:54, Chris Goldsworthy wrote: > From: Sudarshan Rajagopalan > > After new memory blocks have been hotplugged, max_pfn and max_low_pfn > needs updating to reflect on new PFNs being hot added to system. > > Signed-off-by: Sudarshan Rajagopalan > Signed-off-by: Chris Goldsworthy > --- > arch/arm64/mm/mmu.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index cfd9deb..fd85b51 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -1499,6 +1499,11 @@ int arch_add_memory(int nid, u64 start, u64 size, > if (ret) > __remove_pgd_mapping(swapper_pg_dir, > __phys_to_virt(start), size); > + else { > + max_pfn = PFN_UP(start + size); > + max_low_pfn = max_pfn; > + } > + > return ret; Note: didn't verify if updating max_low_pfn is correct here. Acked-by: David Hildenbrand -- Thanks, David / dhildenb