From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1977DC742A7 for ; Wed, 8 Mar 2023 10:21:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 323916B0072; Wed, 8 Mar 2023 05:21:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D2E3280002; Wed, 8 Mar 2023 05:21:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14C37280001; Wed, 8 Mar 2023 05:21:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 008236B0072 for ; Wed, 8 Mar 2023 05:21:20 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BE21440578 for ; Wed, 8 Mar 2023 10:21:20 +0000 (UTC) X-FDA: 80545338720.19.3529FD0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id B823D40016 for ; Wed, 8 Mar 2023 10:21:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=P089fFIe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iFNnLRik; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678270879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JZa0zpAJCeh9dzklwAiQIDL273b6n4qNFXa7CBwrKNI=; b=2Q6603z4x0ZbF1vWxn7fLk8GSaDdbMfCdLA/GpUsNA+2KNZs5kZedfUYgA9FbhrimBLICF jsCM/G2z1mQSxEqYMwoI+pVWdVlPXEu2PqI+GsxcpC6Idxnck/YhH/rhPQcAaI6cNyMGZL DafP7tF5PVgnGCWp1IwXepa7V/cX4Ug= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=P089fFIe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iFNnLRik; dmarc=none; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678270879; a=rsa-sha256; cv=none; b=5ef/KXlWcJclCbazKkM96NF0sIj6Kvx/Wlxb38WR4KblJpIQed8BISbGRwTqBOy73Po4o+ PSQq+ZMkXcskP9l1UG4fQ0ACVIWwrfXNi8LWNGv2DRBvtAV5GHaWiCqvqrM/LBh/J/ERXs u9u0bc8kELUGLn2Rub5QjAescJQdn3U= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 291861FE35; Wed, 8 Mar 2023 10:21:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678270877; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JZa0zpAJCeh9dzklwAiQIDL273b6n4qNFXa7CBwrKNI=; b=P089fFIeokxOaKc2AugIP592HPZ9E/nYJdJaAkitiG8p5Ny8rI79+EnhcDQCGz3R80NA4u 4p8N9UiD2Nh70cxcV9TGbYAbKGjOaZWjw5frB5ihLE6ZSznFoOb9m8XqiXebpCeXd2Q7Vv LiNy0WDoavyfWfCdREY9NwlnuS0csCc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678270877; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JZa0zpAJCeh9dzklwAiQIDL273b6n4qNFXa7CBwrKNI=; b=iFNnLRikDeqTC1JTbHAm9Z0Vf4a2PwibCfkX9pPQ49UiGyZR/4OD43yKaCgRxz2JlglRCI DNjm22/74WXOySDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E834F1391B; Wed, 8 Mar 2023 10:21:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1LqXN5xhCGSFWQAAMHmgww (envelope-from ); Wed, 08 Mar 2023 10:21:16 +0000 Message-ID: <83344b3d-1de1-f3c2-913c-a8c54ce7a99f@suse.cz> Date: Wed, 8 Mar 2023 11:21:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH V2 1/2] sysctl: Limit the value of interface compact_memory Content-Language: en-US To: ye.xingchen@zte.com.cn, mcgrof@kernel.org Cc: keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linmiaohe@huawei.com, chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <202303061407332798543@zte.com.cn> From: Vlastimil Babka In-Reply-To: <202303061407332798543@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B823D40016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 1444u5ws7mikt8ktiw4izhrq3w5qqqjk X-HE-Tag: 1678270878-468419 X-HE-Meta: U2FsdGVkX1+kEhdaSw1GKI0mrxctEzTVDNn85NlUSWgAKku1j7Mg1kf3hx+eXgfTd0aDngGFmoczkVEIwJ9TeGONYttqa9b6DlaewvYuvLzoqcpjEdT0p79sKRvChtDNT9bRtM2LBSvRtl5Bz+q6u56eQbHqPVKJ/X52yVPkKjAFZFt2LbM8MXalywwa/jKbfJ2FFXVV2j4atviPpxHwafvYQ4ncT0SEhF35ijn9X5u+mxQlHQiv1Mel00J3g9hchl4q+rCFcD/+FnoYIh6wHgihwmPd4Pig48E2P6EfaUry2eoeVJDZ1SjL5XlaCYB7mwT16zK66Yj69LkHbXBqUVA0Eh73G6zWbkRvVfIJ1po/LB33k/zphywGORZhV2E/GTdlgPQ5q7nHJEIyvk3/8PqB+i39C19D8Ee361RdZS4C8ibSjUj0+krtMTvq4M1E1qh+R05ROGyz5Bb99WU3iLB+/maOJQS7LZeeyv2GdueCQX9iDlXWl9aQ91QKM+FNsuFQP72FmdqRQlyigR7zsynWp0PAfA444I+PYwTJ5gwDRMbL+HQc6Vy2Tqf5iK4ciDON4Q81sNxxEt1SUdJno/t2LJ1/6QNxCC7sHySLszqJ107PXpXwZ00DNUB/QbhEgUIw8sFyXEIWdzEkZeFhM488j+x1ukQT2dCmMS2cQmPvf/pADdtrg7zGCHnCp0XEBPMkTSyqpxJ802Mj9ZfwLkAV4ITfDGlxoVf6UiIvIEY0I8fqIH/XYLgyQ1S5P0skPvggpvBrGWrqZ1DhCkGk2zmocu5nUxIfuq+fvazQFlWjcGOz6JRQC4234wu/TCH9PZmnQbG7wVqj19DwI5Sf2b/4SeiOlH98J30AMwj0Y/6pwWi7XJoWSR0DG/Cl/ChxuDPju9QItz9nW8mPQjyxc1nT2vy5uKY/Mjm4ueOLoOYjSwpBJx1wgUlfm51ilJl88pUmdvAl0bMFWWT3w3v aJvG7GZx Ubgff6jRlKkpgJAgw8CYVb6FYDrp3LSM80A800OK+KjvFgGJELWQkOSB24bVqjHghaBNTI8tEGXmFsaVJX6gRtHkBjokH33VTv7q3RXNFwawfVKINsv1F5xwOrsOnhaZamQMmpOZiQDfLYB4EnnJNowDWyLqXwj5Evhd3QjLbSLnA1wGdR81ZeDIQH13Sjlc+qWxLREP/JHh05xq/bziXJHC523GiYcxaIzeMmYNyu7oy7Ky0uvYWJS2mVFA32hRmNe4yUzzFUVGeJjqj8KcB27b5U+pYuFUIcy0ZVaYFoJbbGDveFdBhNLIKilai5v6FbfMojNP7Qqtncsj3RiVpsLK/E7mC3dP2h1052IkqnUdsrbRn565z45UDjcsHYsjLSIUZPI0COgY18jIvGKv5IH1mWCr/9PLNKImkzb1M1WBK6xcxYnzRkSvYcXuikzrofoaI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/6/23 07:07, ye.xingchen@zte.com.cn wrote: > From: Minghao Chi > > In Documentation/admin-guide/sysctl/vm.rst:109 say: when 1 is written > to the file, all zones are compacted such that free memory is available > in contiguous blocks where possible. > So limit the value of interface compact_memory to 1. > > Link: https://lore.kernel.org/all/ZAJwoXJCzfk1WIBx@bombadil.infradead.org/ I don't think the split to two patches you did, achieves Luis' request. > Signed-off-by: Minghao Chi > Signed-off-by: Ye Xingchen > > --- > include/linux/compaction.h | 1 + > kernel/sysctl.c | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/linux/compaction.h b/include/linux/compaction.h > index 52a9ff65faee..caa24e33eeb1 100644 > --- a/include/linux/compaction.h > +++ b/include/linux/compaction.h > @@ -81,6 +81,7 @@ static inline unsigned long compact_gap(unsigned int order) > } > > #ifdef CONFIG_COMPACTION > +extern int sysctl_compact_memory; > extern unsigned int sysctl_compaction_proactiveness; > extern int sysctl_compaction_handler(struct ctl_table *table, int write, > void *buffer, size_t *length, loff_t *ppos); > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index c14552a662ae..67f70952f71a 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -2192,10 +2192,12 @@ static struct ctl_table vm_table[] = { > #ifdef CONFIG_COMPACTION > { > .procname = "compact_memory", > - .data = NULL, > + .data = &sysctl_compact_memory, I doubt this compiles/links without patch 2, as there's no definition until patch 2. > .maxlen = sizeof(int), > .mode = 0200, > .proc_handler = sysctl_compaction_handler, > + .extra1 = SYSCTL_ONE, > + .extra2 = SYSCTL_ONE, > }, > { > .procname = "compaction_proactiveness", IIUC his request was to move the compaction entries out of sysctl.c?