From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF00C7EE25 for ; Fri, 9 Jun 2023 07:09:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A97648E0002; Fri, 9 Jun 2023 03:09:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F8E08E0001; Fri, 9 Jun 2023 03:09:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 899998E0002; Fri, 9 Jun 2023 03:09:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 75FDA8E0001 for ; Fri, 9 Jun 2023 03:09:51 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 40CEFAE8B5 for ; Fri, 9 Jun 2023 07:09:51 +0000 (UTC) X-FDA: 80882334582.29.657551B Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf23.hostedemail.com (Postfix) with ESMTP id 659AE14000A for ; Fri, 9 Jun 2023 07:09:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VIBeOPX7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686294589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dsUQxZYRm+804TG3N1NYOiAFj4oUnWWH+PPkf8kpyCs=; b=lTm5kS52skFr87HQK+0asQjj6yocS1P0AF+GK8BVmBarkZ4SumoCKSV4cxRVrtEX7OiVEj q7WzTbjCA9VMmrfktdI9H15+tG7I/jxHeuxcnF9NYLHVaEEAjZulYjschpnh8Lu1pyCSSX ji0TQxXJ2+fZYUWoK0RitLHzTk3euD0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VIBeOPX7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686294589; a=rsa-sha256; cv=none; b=qgFLdvKGxvypWrcFDdXYm8oBr95CXA5dvu0UNUJEDe8QHItCm5kwmcrzjsK7d9/iELGSHB Wf1J6FKDfILWWI+zKBBd6ykmKSAM3Fxqr7Z1Cyzpim71fLUUuQhMMeI/zABNiBfJTpMFdh uytQHYJiacNVvdXWPQ2MHMUGKfqhiFU= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-30ae141785bso1404145f8f.3 for ; Fri, 09 Jun 2023 00:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686294588; x=1688886588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dsUQxZYRm+804TG3N1NYOiAFj4oUnWWH+PPkf8kpyCs=; b=VIBeOPX778pkEi8zOAzk6+hv5PLrC1ZtogIuZjhoXxFpnbjU/hp0aFNWSXmeX4nClC 6YR2GP9F/VLX+TgF5MF7f9Y6WS5hOsc7zJV6hM00rBm/qc05Bcd5svzc735aEF1S4nVw iVg4oTBUDBHuUUHHFUu1iKRQUBBsVzNSiHwh/Wh+jUJT38hojkoII0YWq1Qo2qeRQMUz PZ9hwiD8McSoGcj+yg6ctHsCEfKvI5HfUGsPx9OSF1ZC2au9qod2u3gXOCE6cXgPOxxL t4Ye29lkx/eOQBSQvCM+FHSlLDsA+A8OfFiq8UODA2D1VsSCkaJKAji+YMLtQD+crUNR B+1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686294588; x=1688886588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dsUQxZYRm+804TG3N1NYOiAFj4oUnWWH+PPkf8kpyCs=; b=aDTBbL1IMulyxm/q83ZKEDKEOYqk8VVJB0QJSfFn6wAp8JQkAV7J1jcbf+A5IARVos kNk5E7prrpEp85KyNF5F0DVH21m1vnoOx1rtA4fmLJW28t8j9msO2LS/k/Hfa9u4Z2hQ tVdDG0ke0QCQwSMBU2S/W7b11YHMBj5Eq2GeEi9ocQA6FtqP0xbqWesLIlS7fIgc9ASn Nl2rVTEdvAlMh25t9jM0ygdtX9TaP9fq+ZFuJMMCiYzH6gVnSqhJjiKFHYPlQQLmJe5n lv3OKMg9Khtkvl0J1k+cF/oCrOEeOGlrUMlKvcdll5dlp8ehOTX9mw9x1RVMyu6Nsfpm zsyA== X-Gm-Message-State: AC+VfDxtUlXoSO+9N7LFxI7pZeLEzc+u88qNew4u7VU5Ys6cUyxN1TYM tC26EgRryHI6VLe03nQxmlo= X-Google-Smtp-Source: ACHHUZ4KDnBu20Tppnxd5dpmGGJ8FvdL0jIqd/GV6xV8fA48gDuCgqM1fS5Dbc+TFZxhgm7cQTL+Qw== X-Received: by 2002:adf:f48f:0:b0:30a:9014:838d with SMTP id l15-20020adff48f000000b0030a9014838dmr462883wro.11.1686294587518; Fri, 09 Jun 2023 00:09:47 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id q2-20020adffec2000000b0030632833e74sm3600386wrs.11.2023.06.09.00.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 00:09:46 -0700 (PDT) Date: Fri, 9 Jun 2023 08:09:45 +0100 From: Lorenzo Stoakes To: Lu Hongfei Cc: Andrew Morton , Uladzislau Rezki , Christoph Hellwig , "open list:VMALLOC" , open list , opensource.kernel@vivo.com Subject: Re: [PATCH] mm/vmalloc: Replace the ternary conditional operator with min() Message-ID: <832d7c69-ffd5-4764-8ffe-3a02bef0efb0@lucifer.local> References: <20230609061309.42453-1-luhongfei@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230609061309.42453-1-luhongfei@vivo.com> X-Rspam-User: X-Stat-Signature: 3f7skx8hfq947brqqz79ubanebjjreer X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 659AE14000A X-HE-Tag: 1686294589-770565 X-HE-Meta: U2FsdGVkX1+GoS3rZ6tibXdZNK0Hw8FFj2xS4GXW4zSczff/zZvE+RqwHWLmrjriVNAjvX1cev3STiiP/EJfy6NKcqNcq3GEM8ucv3KTcGftQyIOZNH+SpgDCofRoCwfa943/RFuwl4FhMzMNaxfDlYATIDQjgwDWLrC/CSWOIqyJbgPsPFJZ6tyVHyuFRCETRk0VRz0d0L4quUHgXacajPWqiByrJRnWs+D/MDJCMw15fDFstqduyYu3btN6UHF9fGJPG5Q4yiV0rTqHVgYUqMZ/13LElN2gl+DzfPLzbhSUy300nia2zUF/4wxoD06ObIXBQ1PoPitDQTfU213SVJMLEWlHf9K9bMm1VEs0SPNUfXjsesVzX+lrqJjYTc8HYPEzVDTybWEVdlluL0uliDAsUDHuS7/KPclSqaAmmO4UPLtZMDkf/4bVY3rNkjbEWC9sPgStGByE1d3M7GewFI36shEQCP5+NpllX81P29i9VWFOS9WTtx2BShOjS4ZEfkIvwbHi0h2zrYq7dn85bW0LioXbHaxxPNXNvz52NeQ7AxeiYlSdVH8ZFQ21zAw6xZD7ElQuk9zGjlYO2qz/k7uQAfXHyXbGDqIK+n897s+Z5w403KaLQhbcY8wUucfgn8ebw+pQwV9luCng2sehGFlU/4wW0qXI7BH2o2KMuO4exMVZO+gcSdiaXtehQU1pHCKjLPeNCoi5xb5ZdUCdTVPTXDElhTu3y/fW7bTuxW/vWtw4shDqF7gv8Kq8WYr6c7VIA4VT+F6VFR6XUNzPparpzLTVda/nL+Wo5ylkXa5muM0z9pqmMX4ERHwWnKfqsejBiS0BnL09L39sDQntGFiCleFsMWIpWQv+oySLBN6s1Nnh1JszWOuPyg7gd94VQf/FEQeaynTPy7i+vqkL863M5fbtgRKgSzlJ83aDWDU0EQeRB8wfkOEm7G30F2PBt99uncVf/L5NXyQoLq k/RWDK9o jOk35Cs08KzQlGRlwnHBiLcwIhuVcvO63IyTFLVOnJj0CD5vHAEg1cZxVA0Hmff7Sl32A87mHEh4VkGVtF5b5junAFfaGrqQoIEDC1/eXBu7j+u57vMTMICTi/o9c3zXo0wYH4196Wjz3+u72LTGQRE55kLfBqYvcpY1369YhbSRvAbe9dycbR8iuL4mOWJyIhucaesKuRUCcfB2MmpPC0GPWUgBF8ZkTPuqIm+gqBSwjgRwuqW9nsSoi9uEMWOJUoXnnQmd9GZSvoFJlAph5o/5OPYapcMvrBKkKS+CReyGSb7B3KJWS5lNtu7Ys5Sz7TPCt7WfZcnzAJRsocPD1MCvP70WH0jY6qu1CYtG4l3PZFVP9WVIHlhOO3r69LJsWMkNZCCkswhV5FeQmmmzuhpooPIwtW6kh6V2mH6bBPenlVM6vAwgn2H2rBjmU1e2od2/4b0G6KZIni0UQHFXs1HKBPRLT5ubtYuG+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 09, 2023 at 02:13:09PM +0800, Lu Hongfei wrote: > It would be better to replace the traditional ternary conditional > operator with min() in zero_iter > > Signed-off-by: Lu Hongfei > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 29077d61ff81..42df032e6c27 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3571,7 +3571,7 @@ static size_t zero_iter(struct iov_iter *iter, size_t count) > while (remains > 0) { > size_t num, copied; > > - num = remains < PAGE_SIZE ? remains : PAGE_SIZE; > + num = min(remains, PAGE_SIZE); > copied = copy_page_to_iter_nofault(ZERO_PAGE(0), 0, num, iter); > remains -= copied; > > -- > 2.39.0 > Looks good to me, thanks, Reviewed-by: Lorenzo Stoakes