* [PATCH] mm/page-flags: remove folio_start_writeback_keepwrite()
@ 2025-07-22 18:22 Joanne Koong
2025-07-22 18:29 ` Matthew Wilcox
2025-07-22 19:53 ` David Hildenbrand
0 siblings, 2 replies; 3+ messages in thread
From: Joanne Koong @ 2025-07-22 18:22 UTC (permalink / raw)
To: linux-mm; +Cc: akpm, willy
Commit cd57b77197a4 ("ext4: Convert ext4_bio_write_page() to use a
folio) removed set_page_writeback_keepwrite() which was the last/only
caller of folio_start_writeback_keepwrite().
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
include/linux/page-flags.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 8e4d6eda8a8d..8d3fa3a91ce4 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -837,8 +837,6 @@ void set_page_writeback(struct page *page);
#define folio_start_writeback(folio) \
__folio_start_writeback(folio, false)
-#define folio_start_writeback_keepwrite(folio) \
- __folio_start_writeback(folio, true)
static __always_inline bool folio_test_head(const struct folio *folio)
{
--
2.47.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/page-flags: remove folio_start_writeback_keepwrite()
2025-07-22 18:22 [PATCH] mm/page-flags: remove folio_start_writeback_keepwrite() Joanne Koong
@ 2025-07-22 18:29 ` Matthew Wilcox
2025-07-22 19:53 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2025-07-22 18:29 UTC (permalink / raw)
To: Joanne Koong; +Cc: linux-mm, akpm
On Tue, Jul 22, 2025 at 11:22:30AM -0700, Joanne Koong wrote:
> Commit cd57b77197a4 ("ext4: Convert ext4_bio_write_page() to use a
> folio) removed set_page_writeback_keepwrite() which was the last/only
> caller of folio_start_writeback_keepwrite().
>
> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
Yes, it did. Unfortunately, it doesn't remove the 'keep_towrite'
boolean argument, but I guess we can remove this now-unused wrapper.
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/page-flags: remove folio_start_writeback_keepwrite()
2025-07-22 18:22 [PATCH] mm/page-flags: remove folio_start_writeback_keepwrite() Joanne Koong
2025-07-22 18:29 ` Matthew Wilcox
@ 2025-07-22 19:53 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2025-07-22 19:53 UTC (permalink / raw)
To: Joanne Koong, linux-mm; +Cc: akpm, willy
On 22.07.25 20:22, Joanne Koong wrote:
> Commit cd57b77197a4 ("ext4: Convert ext4_bio_write_page() to use a
> folio) removed set_page_writeback_keepwrite() which was the last/only
> caller of folio_start_writeback_keepwrite().
>
> Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-22 19:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-22 18:22 [PATCH] mm/page-flags: remove folio_start_writeback_keepwrite() Joanne Koong
2025-07-22 18:29 ` Matthew Wilcox
2025-07-22 19:53 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox