From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E25C54E94 for ; Tue, 24 Jan 2023 13:40:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51F266B0071; Tue, 24 Jan 2023 08:40:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A84E6B0072; Tue, 24 Jan 2023 08:40:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 320DA6B0074; Tue, 24 Jan 2023 08:40:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1F8866B0071 for ; Tue, 24 Jan 2023 08:40:31 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E7B0AC0AF3 for ; Tue, 24 Jan 2023 13:40:30 +0000 (UTC) X-FDA: 80389802220.09.95BBB71 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 19D4518001D for ; Tue, 24 Jan 2023 13:40:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DbTe9JLK; spf=pass (imf24.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674567628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dc2lpk1IhYXovbMeoOSgyQn9kH0NS6oWJutu8QaUfdE=; b=EJTULZv+XbQrvj8Qq5vTzj4jX3YLpUXD0njpjqol8oswm51V9X4zzPMoDdf6n8ftMKsyOi Wwi+6i2WtF2tM+odr//AHN3JifztBE7Q3tGdmGuTm3E28GRIFC1tuwMpUYQe8PwDFX4ihr jqDP2BTn7y+DD4ST+QVmWY5YUCua4bw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DbTe9JLK; spf=pass (imf24.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674567628; a=rsa-sha256; cv=none; b=2+fmPOvwtpuwNx/6yvE+a9HBxXLioiHXUDwXa1zC296htsK2qxGvxQ/gp+1gdRV/+PLFhC KmQdC0qv+whxUs4uC8YfJAsR3EyjehkxIogFBEuNKCl1DVXu4Mon927iOra42GLkej5xWC okfczsooZwQQj1+Y6p6Ifg4i4oChSJY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674567627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Dc2lpk1IhYXovbMeoOSgyQn9kH0NS6oWJutu8QaUfdE=; b=DbTe9JLK2jM8FbN3ouw4pU8ZApgv97dB01ZaS2z2cz9rxNUxXWoW9SFM5xaf5vPpwIlZ70 UShK8WVhN8jMCYbEq3XEqpjPX09arH7hVMA8+TvEeUlp6I/ZmWWW5hXeKoDuWsONWXsJWo UwcolvLfNtL5j21UNUvhA9UpIjSYSnA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-252-G2D2RqR8MR2toSQPLiUuOA-1; Tue, 24 Jan 2023 08:40:25 -0500 X-MC-Unique: G2D2RqR8MR2toSQPLiUuOA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 527461C06913; Tue, 24 Jan 2023 13:40:24 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 73784140EBF5; Tue, 24 Jan 2023 13:40:22 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20230123173007.325544-1-dhowells@redhat.com> <20230123173007.325544-11-dhowells@redhat.com> <31f7d71d-0eb9-2250-78c0-2e8f31023c66@nvidia.com> <84721e8d-d40e-617c-b75e-ead51c3e1edf@nvidia.com> To: Jason Gunthorpe Cc: dhowells@redhat.com, John Hubbard , Al Viro , Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mm@kvack.org Subject: Re: [PATCH v8 10/10] mm: Renumber FOLL_PIN and FOLL_GET down MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <831745.1674567621.1@warthog.procyon.org.uk> Date: Tue, 24 Jan 2023 13:40:21 +0000 Message-ID: <831747.1674567621@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Stat-Signature: w8k3e618jxmjynn9so545ahmhq5k4e1y X-Rspam-User: X-Rspamd-Queue-Id: 19D4518001D X-Rspamd-Server: rspam06 X-HE-Tag: 1674567627-225029 X-HE-Meta: U2FsdGVkX1+meDbEvkmDbhIpCIaAv7vM/gEmi9R1v/5OSoHax/CmdrGrkIvAJC7FUPFatU+Y4EuE6sko3SsDtFR2kfp7wvZppBDDRYNHaJr8zbccprKoTSb24HQTy8x7wfBKKopLr7GK/tCBaR/yDKILP7zB7FfHqL8D1jHXNvHIs+/9uS+/1iidCSKFTdP52ZC91OPQY+UP18AbgNZYS7GSvSuFr4o2zpFYt6U9oWgxIr4x/iFNE/xFCLjlnqKMZbsgqsSTWYilKFhqxZzqr+FbDtgX8V/sY5Zb0KshGcg35P9dyAWy07eoQ0r0XRFC0yDPaSyXU9Q4CLQHeaBBussnYVCz4tbZVSVJOE4dDcrFt1CxKyT12E1A+LUKxg1hguXlXZwF2JlGiAjfTNN+6bTFT2g0N5bJxJd0JBk1IPrhGZZRqD77t7OHes+CH0086d0zLNVNQ3PN1uw712cYAW/40EPWv+ycc6tfVvU3CKKumJUAIkgo0oM95YwqOZh7ODB378E2iIc4K3aICcjdskeFoWOYE7+reoMInNAKbJp3EMgbYhVO+o9rD2JlvE/4zgcRJmknVgMwIbOjIlCR0+L+/O2q3HRtRI9SBVR1OnBurdysAVKf9LQcgpmYWEIKUmw4p46Av1inhULEjqXLJ5dsY3/PoF0djieG/cJb/34dQv8POppyCN+cJSn/ZIwVSw2oIKDHLpjDPNgMWTPG4eivWWsy3hvlAyeeYDgx1TU25QxZNeGLK9MQHvt4I6FGN20k0Qf+pH55+JFamThlgbWTeGDCaLDcIftV/Vi1htaeRK6XSmWsSDybFrBJeWX/dN2rKTtg5Ydiqm1/OJVHJP3wP0YU7bz63Tpyju2Ix2n29W3N0OqGiUv2y2i8ncfybGAxT6AyNFLicDPNuTehSbzv1Q5J4tKpBcy5ybgQiAIKDd/+Ys0SNW9Bi0II2ZkEpT/C8Yn1i7oVKs1zYdh vbL3d+D/ Ex3wTjPPvzjhPBR1MMtWbCaXvdZ+paNG6qTjarXP+X5KsFGmjfaap/hgy2h5d+EmnVeI1Zx0baXojnHIpDpTWaOSYuNQ6VdYmcWIcu0EynrsPSMwREyze9foSyK82lCQSIZDwJaT6BvE32AXkcqdYDGg7awON5bWmlclCm4/cx4YjUJOVNt46EX3M5bnhtIU0+Vl+amIz8ISZM0yEqCr4ZqpFO+6SpCKpNHO4SwBycFqPDtcvpPNlkC6IzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jason Gunthorpe wrote: > Though, I'm not so keen on using FOLL_ internal flags inside the block > layer.. Can you stick with the BIO versions of these? It's used in a new iov_iter function and will be used in a bunch of filesystems including network filesystems. I'm also looking at using it in the sk_buff handling also. David