From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25AC9C77B61 for ; Mon, 24 Apr 2023 14:21:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DF2A6B0071; Mon, 24 Apr 2023 10:21:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88F6E6B0074; Mon, 24 Apr 2023 10:21:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 730DD6B0075; Mon, 24 Apr 2023 10:21:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6172A6B0071 for ; Mon, 24 Apr 2023 10:21:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3BEF580122 for ; Mon, 24 Apr 2023 14:21:47 +0000 (UTC) X-FDA: 80716498254.01.84A4AA6 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf27.hostedemail.com (Postfix) with ESMTP id 22CF540035 for ; Mon, 24 Apr 2023 14:21:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Vil/LZpK"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=i1h6J7pB; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682346104; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oS59SRMyvblbYQ/G1blmGCgsVR/u0O42HYVoCKNaGwc=; b=V6OSQLgZczXWB9sM9zEUFKIp4c4foUc4ogGAPNtCRkifqcm55aE4zfOEEwdRUTnZOBWdr/ qR9jEyOIkrmmKvQ4CqKBKX0FwevF1Rz9k0haB+rnhZ+7QvOv94nWPG12TGK0doroMH9OHV ykBAWG3xH3h/qmJ0Istswqvvb6YeNlY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Vil/LZpK"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=i1h6J7pB; spf=pass (imf27.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682346104; a=rsa-sha256; cv=none; b=1BaWEJwWFPpm9l/Fx7Jkmh9x4EB80HkfeGJ98FM9TmjWPu5baX2dzfDtGvX36OnXKKe2PG Iglqrf8GrhIaSsLMmz15E8oh8ttmVk20HKyDc4aneSMuJ/WYgGYrcxQRnZdTZMN0TUarb4 LQWTkERAHorQXIlmT8PeuFGAb2bOyEA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3F8FA1FD87; Mon, 24 Apr 2023 14:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1682346102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oS59SRMyvblbYQ/G1blmGCgsVR/u0O42HYVoCKNaGwc=; b=Vil/LZpKUEtewmntDHG7Yrp7JFnWc5IuxrclIFUDBS1KwY7XjqmGVqbH67axq3RIiSLLFe Ak/ScVmBdalNEUSVeSpa73lqzNe88hAstKIeIK45RZa7WhmTPffSUqwtEPj7nj44mpe/3d GMKAhSgJlnysgDC00vxd+mSmnK4JxyA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1682346102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oS59SRMyvblbYQ/G1blmGCgsVR/u0O42HYVoCKNaGwc=; b=i1h6J7pBqXJZarnZ05WykCJwXV+6MX8LtYRm3kGbFNgu6wOg+ue9c+BbaTdok743txiH/q wzN3B0axDhgKifDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 129F81390E; Mon, 24 Apr 2023 14:21:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7pRcA3aQRmQ2PAAAMHmgww (envelope-from ); Mon, 24 Apr 2023 14:21:42 +0000 Message-ID: <8315a507-3f27-5b08-7d0c-c6056b64c3d6@suse.cz> Date: Mon, 24 Apr 2023 16:21:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH linux-next v2] mm: workingset: update description of the source file Content-Language: en-US To: Yang Yang , akpm@linux-foundation.org Cc: hannes@cmpxchg.org, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rppt@kernel.org References: <0ddb50f0-2e2d-e750-3867-3842a3ea12cc@suse.cz> <20230421113130.240586-1-yang.yang29@zte.com.cn> From: Vlastimil Babka In-Reply-To: <20230421113130.240586-1-yang.yang29@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 22CF540035 X-Rspam-User: X-Stat-Signature: iqh54p1c3y7drcmmace7jzpfbecpsp5q X-HE-Tag: 1682346103-629654 X-HE-Meta: U2FsdGVkX18ir35LLXW+2mzEpyQvxuwLzW3H1wvpFTlqWkm7WUBpn7cRKCAhl6fCSwnmukNVFSQA2HXhE62ZeMvbI3ekmZE78jhneYB6JZT0voavnBgCWneCwbWMB81flikV+rak730SFVvzEiR1vcXEbP+xiT01zElUZ8dTi3R5qVemtIyMjsS1qcWo5QOVa0LBucj9Z7hNNErQpfiULGnhohfVict0LL1Upg5VhrK8zb/kdI6yTw/0fL7FHU31Y0QH4927C9uTs+f/th8+33QtWiXmEeT0esifqhct/Bqpw9d7sJbhR8orQlpSN7DZx+0dWznjAgKH6+/S0sAPXRE9UgWdIafuV7tBXxpHDlwtDTNk0P+TL6SjcSZCdN5WrUQ+EREWZhxVEZ8wfEuCWn6/6vWp30wmtKqD8LEr0ISyKS0uGQmgoN5P8s5QS7/A152NPrSHP4cxlj8XpYL4ywA31O74VYvr1KxZ+EbhzMLJcG6ZcDc7JfzPnNRj1u4zpeHM0LEO+VPRywxAOQx9hlBlxZKozC7ecH6QwutbrvDoVQkxl64VIHNpF/H13bxR/RMVjiGhSSOw52oGFYGX3CSAJJHiZXOYPWzhamxz2YdRRRWX5wis7ZHSJvRJz7JGZH7tpbSeFRBEnCNs+Bx1uylxnlygDdolHtckYsiemkG3uIYJPFrQQ5gUJ5H60RWtzaeZq1WmUknpmz9voIPT2zn8HvVy4qZ15Kb9gyea4jA2hlBrZB2+CALLpZqxMXCr5f8FO4IORHC0iznhVK4PaPFLX5OGb9b7CF9O6HK4WUCExjBzhxyut8FcdoFGBijAL+CxSDLHBfzVNNH11Y9RVko42E/SxLq+gBC+7hfGhBTvsLJTRjyjewQWnqNjT++vSfzr9Fm8d0o3RkYRbSOEB4vKl8gETFZHkhxuAt1v3666SiJkKRgS3kbyMhdwlAYNQGln2GW/2UhXE+zP4ph wxEzclF8 k9r0pWo++lhkzFEXwmimpiO6S6aOWEKYq3udNyfeRVDlScsATuUdxa+GSw65OhCyOZy+2JWQMi7hkAl7Ljx19UZV1BeR+5ZYzTnFUUFWmkFOM+ZWJXOxIP6NTp6oMxeXjJjnm/AWB1z9um1bc64+BxDIHNllzf2Jrg2igfzWj6cT1E5cP7hi1TeFmQWCVKbRiIfE4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/21/23 13:31, Yang Yang wrote: >> I'm late but FWIW, not supper happy that while the updated calculations are >> now accurate wrt the actual code, the explanation (which was written at the >> time of page cache-only workinset) was more easier to follow in the simpler >> form. Now it's still mostly talking about page cache and explaining the >>balance between its active and inactive list only, and then suddenly the >> anon lists appear out of nowhere in the final equations. > > Thanks for your reviewing! I should update the whole parts. Sorry for > hadn't do it better, please drop the patch, I will try to submit patchv3 > to fix this. I think it's too late to drop, and not worth rebasing the git tree in early merge window for that. >> In other words, I think it would have been better to leave that explanation >> as it was, and then add a new part describing the extension to anon pages. > > I read the description of the source file again carefully, and think that > there is no need to creat a new part, if we explain at the begining that > the word 'pages' include page cache and anonymous page, and do some minor > adjustments. For example: > Per node, two kinds of clock lists are maintained for pages.. I think it would make following the explanation more complicated, and it's already difficult enough. Reasoning just about active vs inactive file list is much simpler to follow the equations and observations behind them. Wonder what Johannes as the original author thinks, anyway.