From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A04C4345F for ; Mon, 29 Apr 2024 15:35:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32B316B008C; Mon, 29 Apr 2024 11:35:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DBD36B0096; Mon, 29 Apr 2024 11:35:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F1E26B009A; Mon, 29 Apr 2024 11:35:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0082C6B008C for ; Mon, 29 Apr 2024 11:35:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A67FC1A0A26 for ; Mon, 29 Apr 2024 15:35:49 +0000 (UTC) X-FDA: 82062969618.11.EA86A62 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id ED32040009 for ; Mon, 29 Apr 2024 15:35:47 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714404948; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k/KCqr6mtixyP2ceoIOXoD/HgpBRNAdh9hJVimPdxB4=; b=T0EWi7bDuLcFQQqlPS0/UB9dhZmzXSamxoj6Hzl8+DlkOWWYVwRPwasFIAq+/4yilk/6td Dpv5HlDBAwltUHYkWrh9QGKI5tGUrvGDvSX8qskF8ypifU/h3vRQal9LDNmR3Jta7wKpbd 4hBcNnMBOLVS09fa08qrvmU7nJ0ab7M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714404948; a=rsa-sha256; cv=none; b=0cxc3XINo3j/BxWHib7gpEBo38GIoWaxf+9kLuGBZDOz865jJ1RRWy+13ik00D0u91r22k 002CslebZdi6pnih9i17IGj0TlKKFLBixmn1U1RwceY3VJ6EOAOkE+B2Y5xICJqpz4/HRG uG0ss15bcW+ynhNKNFFu+B2wy70/oCU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B962F2F4; Mon, 29 Apr 2024 08:36:13 -0700 (PDT) Received: from [10.57.65.53] (unknown [10.57.65.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EEA353F793; Mon, 29 Apr 2024 08:35:45 -0700 (PDT) Message-ID: <830f83d3-6f88-42e3-929e-c87597441a1c@arm.com> Date: Mon, 29 Apr 2024 16:35:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: Fix race between __split_huge_pmd_locked() and GUP-fast Content-Language: en-GB To: Zi Yan Cc: John Hubbard , Andrew Morton , Zi Yan , "Aneesh Kumar K.V" , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240425170704.3379492-1-ryan.roberts@arm.com> <17956e0f-1101-42d7-9cba-87e196312484@nvidia.com> <2C9D897B-0E96-42F0-B3C4-9926E6DF5F4B@nvidia.com> <328b2b69-e4ab-4a00-9137-1f7c3dc2d195@nvidia.com> <23fbca83-a175-4d5a-8cf7-ed54c1830d37@arm.com> <64037B35-3E80-4367-BA0B-334356373A78@nvidia.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: ED32040009 X-Stat-Signature: q9nrhfrmwo8yc3rqtwwj15qy8oacty7b X-HE-Tag: 1714404947-524733 X-HE-Meta: U2FsdGVkX19uqaBcbPhwAq+gQ3TxsM0ggnrb4k2kjrG6slSYGxxGTeQsWOgM9XKJO3WpdDM1jf2LuoRgHvCKn71xIqvJLvWjAU+Kh4i3ELquxCyIvCg7UwW7gxgBY7hazSvgctzFPkG4WUSwx3ZF3Xf0cRi/9frFdw1pquOeNWfrxTalu3SFVMHVTF9g38pUgfCCSqDtwh3PZ6DY5sV0l39IwtR+ykFBgdSUJrH/FbkrbK8f4T7pRXXd0buTlFeWcr72N2I2rMnkiUKXdflQHJsROYC0N52IaJ0hrsFJOOV4sPHam/Br081G8iPiuvqLk3QHKdD9xe+zJluKIbhkOy8oT1kMLgxnoaOakpvsxUAhiwOI6vlbVWgQd2LkvR5u7u3WL2OeGUPZbT+RNSsnjjj44PK+5p+BOaYWTioYZUDtjWuXQglYRPxoIr+J2d0BHukQJpEFtzPXhp/3O6kDD3q2MRrHrhHnSAY48GhoL+OLouEs+nkjpTrVT3LLJX4hVBZF/L0J3veHk3WC38CZdWYn8FpWtQVPn5AXXim+LDq74JLfqUtn1gnVT1mqs+P36D3avW+xseeqRXuP37k2oS8czzkaLKvtn9BhRaoZRQbFrUj4S1oe058M0/ft/XR+IpKHf9DFnWQPsUkDAqlrIE95SRiDmOlD5xNMqqQ1oeC7flbCQ6tJ9SVB9teq0Lrg1mvWcyZtzi4HwdPdUrFlSxKourVjYJrknL2x4mQ/hnN4Bfd+yT7GZO4P7y5EIrm9DaJeSdsH2UIHyPTcB3m5pTs1hNAb3ZDZldvRX3vWLJ+55AWwf1SFkzL1hdZiA4Li2oLiiwUfBoTM3vu93cNFArteJPzYultMfDPOt+aOA2LjscT21JRrerdj8ToCqNsKV3pdDq8I+co9kSG9EJSt39v69mIkiDd04cZi1durFbi2zbFCp4lIBHK4bUeyVYzxU5LnllH71Wi0/6ZysuL 1EqnVtVa EECWg5KI2JzP8AYZRbQlc0ikL37JSMSFgeMn0BhFT+0CGlZWdKqpZGYMSenkSxzP8pFfQivFbPKSefh8xYRQ5q1yCJkZm0NIdZO5QWaBgc8hIrkRyIp3EAPpDA8ECri4DTSqUWOiRMwJvvy2lKECjj72Gdr879OJ4q/lq6LBpg3SzbyVjXPoMWIF2zIEurm9SmZTbiyeQHCQiiDQBKKHWpfu7VgcGxXB0uejUZvOjnWLfv0WdWwCIg2X5xRlW0yhMu72juPiIysJfvdB55dsXV6m2cw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29/04/2024 16:29, Zi Yan wrote: > On 29 Apr 2024, at 10:45, Zi Yan wrote: > >> On 29 Apr 2024, at 5:29, Ryan Roberts wrote: >> >>> On 27/04/2024 20:11, John Hubbard wrote: >>>> On 4/27/24 8:14 AM, Zi Yan wrote: >>>>> On 27 Apr 2024, at 0:41, John Hubbard wrote: >>>>>> On 4/25/24 10:07 AM, Ryan Roberts wrote: >>>>>>> __split_huge_pmd_locked() can be called for a present THP, devmap or >>>>>>> (non-present) migration entry. It calls pmdp_invalidate() >>>>>>> unconditionally on the pmdp and only determines if it is present or not >>>>>>> based on the returned old pmd. This is a problem for the migration entry >>>>>>> case because pmd_mkinvalid(), called by pmdp_invalidate() must only be >>>>>>> called for a present pmd. >>>>>>> >>>>>>> On arm64 at least, pmd_mkinvalid() will mark the pmd such that any >>>>>>> future call to pmd_present() will return true. And therefore any >>>>>>> lockless pgtable walker could see the migration entry pmd in this state >>>>>>> and start interpretting the fields as if it were present, leading to >>>>>>> BadThings (TM). GUP-fast appears to be one such lockless pgtable walker. >>>>>>> I suspect the same is possible on other architectures. >>>>>>> >>>>>>> Fix this by only calling pmdp_invalidate() for a present pmd. And for >>>>>> >>>>>> Yes, this seems like a good design decision (after reading through the >>>>>> discussion that you all had in the other threads). >>>>> >>>>> This will only be good for arm64 and does not prevent other arch developers >>>>> to write code breaking arm64, since only arm64's pmd_mkinvalid() can turn >>>>> a swap entry to a pmd_present() entry. >>>> >>>> Well, let's characterize it in a bit more detail, then: >>> >>> Hi All, >>> >>> Thanks for all the feedback! I had thought that this patch would be entirely >>> uncontraversial - obviously I was wrong :) >>> >>> I've read all the emails, and trying to summarize a way forward here... >>> >>>> >>>> 1) This patch will make things better for arm64. That's important! >>>> >>>> 2) Equally important, this patch does not make anything worse for >>>>    other CPU arches. >>>> >>>> 3) This patch represents a new design constraint on the CPU arch >>>>    layer, and thus requires documentation and whatever enforcement >>>>    we can provide, in order to keep future code out of trouble. >>> >>> I know its only semantics, but I don't view this as a new design constraint. I >>> see it as an existing constraint that was previously being violated, and this >>> patch aims to fix that. The generic version of pmdp_invalidate() unconditionally >>> does a tlb invalidation on the address range covered by the pmd. That makes no >>> sense unless the pmd was previously present. So my conclusion is that the >>> function only expects to be called for present pmds. >>> >>> Additionally Documentation/mm/arch_pgtable_helpers.rst already says this: >>> >>> " >>> | pmd_mkinvalid | Invalidates a mapped PMD [1] | >>> " >>> >>> I read "mapped" to be a synonym for "present". So I think its already >>> documented. Happy to explcitly change "mapped" to "present" though, if it helps? >>> >>> Finally, [1] which is linked from Documentation/mm/arch_pgtable_helpers.rst, >>> also implies this constraint, although it doesn't explicitly say it. >>> >>> [1] https://lore.kernel.org/linux-mm/20181017020930.GN30832@redhat.com/ >>> >>>> >>>> 3.a) See the VM_WARN_ON() hunks below. >>> >>> It sounds like everybody would be happy if I sprinkle these into the arches that >>> override pmdp_invalidate[_ad]()? There are 3 arches that have their own version >>> of pmdp_invalidate(); powerpc, s390 and sparc. And 1 that has its own version of >>> pmdp_invalidate_ad(); x86. I'll add them in all of those. >>> >>> I'll use VM_WARN_ON_ONCE() as suggested by John. >>> >>> I'd rather not put it directly into pmd_mkinvalid() since that would set a >>> precedent for adding them absolutely everywhere. (e.g. pte_mkdirty(), ...). >> >> I understand your concern here. I assume you also understand the potential issue >> with this, namely it does not prevent one from using pmd_mkinvalid() improperly >> and causing a bug and the bug might only appear on arm64. >> >>> >>>> >>>> 3.b) I like the new design constraint, because it is reasonable and >>>>      clearly understandable: don't invalidate a non-present page >>>>      table entry. >>>> >>>> I do wonder if there is somewhere else that this should be documented? >>> >>> If I change: >>> >>> " >>> | pmd_mkinvalid | Invalidates a mapped PMD [1] | >>> " >>> >>> To: >>> >>> " >>> | pmd_mkinvalid | Invalidates a present PMD; do not call for | >>> | non-present pmd [1] | >>> " >>> >>> Is that sufficient? (I'll do the same for pud_mkinvalid() too. >> >> Sounds good to me. >> >> Also, if you move pmdp_invalidate(), please move the big comment with it to >> avoid confusion. Thanks. > > And the Fixes tag does not need to go back that far, since this only affects arm64, > which enables thp migration at commit 53fa117bb33c ("arm64/mm: Enable THP migration"). Yes, will do - good point. > > -- > Best Regards, > Yan, Zi