From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C7DC41535 for ; Sun, 17 Dec 2023 00:04:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30BF96B0071; Sat, 16 Dec 2023 19:04:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BB816B0078; Sat, 16 Dec 2023 19:04:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1ABE06B007B; Sat, 16 Dec 2023 19:04:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0B06F6B0071 for ; Sat, 16 Dec 2023 19:04:58 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CE1B7160750 for ; Sun, 17 Dec 2023 00:04:57 +0000 (UTC) X-FDA: 81574364634.21.915558E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP id E44271A001B for ; Sun, 17 Dec 2023 00:04:54 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=kC2ct2d4; spf=none (imf19.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702771495; a=rsa-sha256; cv=none; b=bHqoDd6Ry89Ugg22+s0/kuxdtoaqJXcUMndPWdPIHvBcbwDzVmIf6CjBsNB4HG68P/3wv0 F+WsDuOv9TsPj5uGDvMBkMiC+myNO57buw4xMQb6Q5j2tM5Ni0RR8v4rvwdRKn5JaqmaI7 eQnVMsbrkTn5uiOXL2hqFt1fF6tmrFk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=kC2ct2d4; spf=none (imf19.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702771495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=49WEMktJZzZnrc7NcYvQXYQTLTaAK6hXzQVTPjEh4lg=; b=EmaDZP8fxqoFqcI0tUh0ia+P5fe7m38xCY0QSc13c7kJ349OhqhKLvlYouJ/ENK2+4Us/X ZUnJIuQK+Mz4eBDdOsPrHpjzYpBoY0h6TYNgaRsAemmVEbtlPGuuubLmhWzKCQ0wHd1Oq0 XexaNRCtKb2S0mXVMaHdqDCu4JSuz2M= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=49WEMktJZzZnrc7NcYvQXYQTLTaAK6hXzQVTPjEh4lg=; b=kC2ct2d4n5wKDgv0zPRyvS8fwX s7n6UCugZnNFJv/ial9cqwbNXJt2VphiRvsfIqyLmWkXWgYBmOwKiWdtBNkvYm4s1+bBXohChAmKF 8OXaj2/wz+1ffYi8uDw9C0EoF15htXC9/fa+yr3GxclMxc+9F6rXWvup6OVK2I/y9uUD26aNXcUag sanI9e86tv6pWL0AOzOekCKDkjr6wStwBZCdUgYL3Qjc/s8uXfhnJADf3cTFDakVFQxtgpmeh6kvG kCAhsfWSLc7XkzICjNROiUsK+W5MJYCdMoCaul9WbdlzYMJdY1POzA3OX2KjQLPZo9CMbQIzWiXLz mywFEqyA==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rEeeE-006sbG-1w; Sun, 17 Dec 2023 00:04:46 +0000 Message-ID: <82ed43c2-2a9d-4c5e-8ccd-8078397b7953@infradead.org> Date: Sat, 16 Dec 2023 16:04:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Content-Language: en-US To: Kent Overstreet , Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> <20231216223522.s4skrclervsskx32@moria.home.lan> From: Randy Dunlap In-Reply-To: <20231216223522.s4skrclervsskx32@moria.home.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E44271A001B X-Stat-Signature: cjmupaywfuant8jqndgr6yeejip8yqx8 X-Rspam-User: X-HE-Tag: 1702771494-480598 X-HE-Meta: U2FsdGVkX18tR5skxSzGJcqkeLXVK4gu60QvREmlGmrZ0G0xqh5Wk63dlXbJhnSEtWzMwsn1KimVZzyf6K9WdycumyTz0qQqh/lyElewkE3L81uHQSvJL+HWwuINf37zJiLRs80rOJusgEWY/mTRCK8cBI7SHD0x0M5IgMVTxQcVVAtpUj999/sGVqPKQqovTKH/+NkgLBtH8MA3A+YbtLd6X+rg5sEiZZhCZicbfuOFn5Ky3uWtm+ErwpZYFLtlBRu+CrEVLZqwdbJjGS7URaBkapNgguksKYG8MU3i67fy4JjYy82pUmWL6uCg/Hnj6FM4z5H7AIdQmZ+LLbdB/1K+hI0oegmwJz9XCcLW2KE2JluUpSvcyiPsBiJF9+LKbI+z7qafC6EE4rWHw5MvLM/iUoGqB/uqdlSTMl2ZLbHWUFrc3bDDyLjkCAYid5N0rJqZMPnIDn85cq423Wo84tFVoOkpUZKd8aywrEqLXE0YWhq3NkZLXp/gjaT9OwHj/TjiQmSnTxLLhJX6kbeeGlsgRZ1KL1eVfMfXyEwiOYdOqsG1I4tyvTzTNrUtx41dEFCabznWA4eqGcce7J9q8YAjbUE8DjAnX7Oi0fdxYzLE8unPbqX4dvhbWlhiVT2iSH7vnd2+hQKV151U+/QZSHXbKVCovZ9YmLdR7n8ID0MeMhvEYFBmBTjhMnPfcyqFiZCoKS/118C24pXfLwynXl7W3PTrrjSZQJK+mkCBLQmhcG6wNw4Iic/njqgd+zpdbTekrHIuPmCVvcz3JaasYjJGEXBHyLfhNDkYXvRAyGYRmjLy6hcCNTvCnpRWsZby4FokYpCO/klleRkmmtK48L+SKbZ+2tFXRh1H5quhsofINJGyq25hzxcnd69wZwQisgGlVhHfNQxotw7+Hp+beJ96jnPlb3UExWsVmobHC1YLIPehXxizFZvyGInbduy8/QDCIrJaUEkLPraYrzn v0NL6LkJ xvCwprF2sPf8bGog= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/16/23 14:35, Kent Overstreet wrote: > On Sat, Dec 16, 2023 at 06:13:41AM +0000, Matthew Wilcox wrote: >> On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: >>> - INIT_HLIST_NODE(¬ifier->link); >>> + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ >>> + notifier->link.next = NULL; >>> + notifier->link.pprev = NULL; >> >> Arguably INIT_HLIST_NODE() belongs in types.h -- we already have >> RCUREF_INIT() and ATOMIC_INIT() in there. > > I think I'd prefer to keep types.h as minimal as possible - as soon as > we start putting non type stuff in there people won't know what the > distinction is and it'll grow. > > preempt.h is a bit unusual too, normally we'd just split out a _types.h > header there but it's not so easy to split up usefully. > I don't feel like I have NAK power, but if I did, I would NAK open coding of INIT_HLIST_HEAD() or anything like it. I would expect some $maintainer to do likewise, but I could be surprised. -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html