From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08F66C4338F for ; Tue, 10 Aug 2021 21:57:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 88129601FD for ; Tue, 10 Aug 2021 21:57:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 88129601FD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1A5D76B0073; Tue, 10 Aug 2021 17:57:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 157906B0074; Tue, 10 Aug 2021 17:57:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 044D36B0075; Tue, 10 Aug 2021 17:57:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id DFD5A6B0073 for ; Tue, 10 Aug 2021 17:57:14 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7241D22877 for ; Tue, 10 Aug 2021 21:57:14 +0000 (UTC) X-FDA: 78460532388.07.83FF299 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by imf20.hostedemail.com (Postfix) with ESMTP id 162FDD006491 for ; Tue, 10 Aug 2021 21:57:13 +0000 (UTC) Received: by mail-ot1-f54.google.com with SMTP id c23-20020a0568301af7b029050cd611fb72so904206otd.3 for ; Tue, 10 Aug 2021 14:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=3CKiUkciyqrhRNXWdxOMWFYpCxgAYsTB56M3DgbEbSE=; b=SNy/E/cWnLYbgGZnakp3SuCzfhohYLGhDVt70Hy8g6rR8xgblVfXSKFo6iDkjc1JJF h+Qikx6HkULyPm+zLK7+DFKCsHucfzVCk9U+uGXcWwmx5fBVd3h9btw5jv9GYdt7Je+g 5HalV0IwtjRs7u15WidNmDX6IYv/Afp8uDm/ymD0L7qXVIOPHoiE86auJ9ZNKXTQlrUY Zx7GWvEQLkEmF2AZfpn0e3t6svZXfLajmK8WeCOws4shdyZRxql+qsfYmoaYr3yd85Ms Ouk2DYUthxYN5UbgqQDGNJIuGJowoEtFB4Nv9BuzQwxSOJlaWOHxpa6hVXGk4qkgf3vS woiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=3CKiUkciyqrhRNXWdxOMWFYpCxgAYsTB56M3DgbEbSE=; b=LmXKHZNqJGMIX6mjAzUmVftzCxIkxRx+Qhr7zrlX9ShswCHHCjVogwYIkx0wk/pKvw SPRbPGunZPJmngawGrlko3PPrRXrj+jW9y7yWzEcfjbXO/oy0K3T8Jjo5XxZ6VnZHsLZ VMf76nDX4Z1RPxRQZRRwduEJF1X7BrxoVob0gtBYTxj26YtreW3fVJjPORnXoKO9tbyR 5dF+EH97nvn9mRk+hwTq8Bg1VVeS8AxjPhH7g00+Q1cD/ymMKrke9esUrdNtB3XTFx09 C9lk+8qLbrR7UuvEg41u17M174NnR5arCH4XwoeZCTnylD9DtH95JvvAyZMObPl0Dumk P3KQ== X-Gm-Message-State: AOAM533QhU3q1Kqd2BeR2L+5zoZjmF6JIuOkVIgLySnsObBDF7ImXxHb UAdPzAO3vVfDZG7yVrFqc1GRsA== X-Google-Smtp-Source: ABdhPJxND1r3/Q/piPZkf2esSXXZ890/lZNgwNteO7rZbCT3vPjvRJEiQ+HfNA2tpcc4/vytKz4Bqg== X-Received: by 2002:a9d:24e8:: with SMTP id z95mr14359964ota.181.1628632633289; Tue, 10 Aug 2021 14:57:13 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id h60sm2678725oth.76.2021.08.10.14.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 14:57:12 -0700 (PDT) Date: Tue, 10 Aug 2021 14:57:02 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Yang Shi cc: Hugh Dickins , Huang Ying , Miaohe Lin , Andrew Morton , Linux MM , Linux Kernel Mailing List Subject: Re: [PATCH 3/3] Revert "mm: swap: check if swap backing device is congested or not" In-Reply-To: Message-ID: <82e1c65e-f942-1421-5053-7b77679dfbb@google.com> References: <20210810202936.2672-1-shy828301@gmail.com> <20210810202936.2672-3-shy828301@gmail.com> <3983c910-a02b-e67b-8c2b-7a379c3d22e1@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 162FDD006491 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b="SNy/E/cW"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of hughd@google.com designates 209.85.210.54 as permitted sender) smtp.mailfrom=hughd@google.com X-Stat-Signature: osbaz7ye1t8zztamdmg5tepxe5hnbjgi X-HE-Tag: 1628632633-33885 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 10 Aug 2021, Yang Shi wrote: > On Tue, Aug 10, 2021 at 2:08 PM Hugh Dickins wrote: > > > > I guess 1/3 will vanish now, since what it's reverting has not yet gone > > forward to Linus: it would have been nice for 2/3 to have mentioned that > > what it's reverting is kindof buggy: but then you'd have to explain the > > "kindof", and that takes more words than it's worth - maybe a lore Link > > to the discussion? > > It is fine, I think this one is the best elaborated the problem: > https://lore.kernel.org/linux-mm/24187e5e-069-9f3f-cefe-39ac70783753@google.com/ Yes, that best elaborated the problem when I thought it was a problem, then https://lore.kernel.org/linux-mm/e82380b9-3ad4-4a52-be50-6d45c7f2b5da@google.com/ explained why I later came to think that it wasn't a problem after all. Hence "kindof" buggy: but good to be reverted anyway. Whatever! Thanks, Hugh