From: Hugh Dickins <hughd@google.com>
To: Yang Shi <shy828301@gmail.com>
Cc: Hugh Dickins <hughd@google.com>,
Huang Ying <ying.huang@intel.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] Revert "mm: swap: check if swap backing device is congested or not"
Date: Tue, 10 Aug 2021 14:57:02 -0700 (PDT) [thread overview]
Message-ID: <82e1c65e-f942-1421-5053-7b77679dfbb@google.com> (raw)
In-Reply-To: <CAHbLzkqifgqAgytL_XGa=fE3tH-oU9x=uv-yNCYGzeO3QEGvFQ@mail.gmail.com>
On Tue, 10 Aug 2021, Yang Shi wrote:
> On Tue, Aug 10, 2021 at 2:08 PM Hugh Dickins <hughd@google.com> wrote:
> >
> > I guess 1/3 will vanish now, since what it's reverting has not yet gone
> > forward to Linus: it would have been nice for 2/3 to have mentioned that
> > what it's reverting is kindof buggy: but then you'd have to explain the
> > "kindof", and that takes more words than it's worth - maybe a lore Link
> > to the discussion?
>
> It is fine, I think this one is the best elaborated the problem:
> https://lore.kernel.org/linux-mm/24187e5e-069-9f3f-cefe-39ac70783753@google.com/
Yes, that best elaborated the problem when I thought it was a problem, then
https://lore.kernel.org/linux-mm/e82380b9-3ad4-4a52-be50-6d45c7f2b5da@google.com/
explained why I later came to think that it wasn't a problem after all.
Hence "kindof" buggy: but good to be reverted anyway.
Whatever!
Thanks,
Hugh
prev parent reply other threads:[~2021-08-10 21:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 20:29 [PATCH 1/3 linux-next] Revert "mm,shmem: fix a typo in shmem_swapin_page()" Yang Shi
2021-08-10 20:29 ` [PATCH 2/3] Revert "mm/shmem: fix shmem_swapin() race with swapoff" Yang Shi
2021-08-10 23:14 ` Yang Shi
2021-08-10 20:29 ` [PATCH 3/3] Revert "mm: swap: check if swap backing device is congested or not" Yang Shi
2021-08-10 21:08 ` Hugh Dickins
2021-08-10 21:30 ` Yang Shi
2021-08-10 21:57 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82e1c65e-f942-1421-5053-7b77679dfbb@google.com \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox