From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE07C04A6A for ; Thu, 27 Jul 2023 11:49:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E9E16B0075; Thu, 27 Jul 2023 07:49:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09A7C6B0078; Thu, 27 Jul 2023 07:49:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECD0A6B007B; Thu, 27 Jul 2023 07:49:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DDD336B0075 for ; Thu, 27 Jul 2023 07:49:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id ABF2F1A0514 for ; Thu, 27 Jul 2023 11:49:50 +0000 (UTC) X-FDA: 81057222540.30.929EC50 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf14.hostedemail.com (Postfix) with ESMTP id A7E22100011 for ; Thu, 27 Jul 2023 11:49:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=g5Gw9jVr; spf=pass (imf14.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690458588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XMGzMo0D9w2lh2SUTyPSHMy4PaBaVyHmeoSWJwj5o98=; b=A+iHUua5U1r+o4D6dFopLgZ63F+Y+4ft+CI36DI+tJPywB7icsTv7f4kA1Am+vkibcv+Q1 OOUVlJz/8hFAdvo8ZXD2JSrYb+IcMZ7a/BlDlYKlqqhV/s3j1plvoAncpeqlfK1zKHbp+S AuTTt2spq1rULnpPNk59wu794onxGA0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690458588; a=rsa-sha256; cv=none; b=LOxA/PZMWwA7vLAiXcsKiYJsMmEhusEjOre8M5B8XEDmF3ymlade1x7YXI7n4MgfIOu391 Cwyo5k5s6+5mkUkkIrxN2s9m1eySraf/qRPZYN5gP5whNd3XLCB6CA7YygoC57S1zW/nuI +XRsznfBEIPas7kCufvxrA6CU/G7esw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=g5Gw9jVr; spf=pass (imf14.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com Received: from [192.168.100.7] (unknown [59.103.218.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 8C5206607057; Thu, 27 Jul 2023 12:49:40 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690458587; bh=NC/0VSOPtAjML62vw26aYCCXLVTxIUCUUJS7zYvPPmc=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=g5Gw9jVrYVSkBWRsfZ85xC9Pv7jkspf3yqXuJtKBaFobfMRIpTo5ZqoUhbu8S/A/r KiRk5MZNS3mhjapKKtlHZC4pnXcxUCGVOv65GG+DMRFdp+oV8tCZZIXzIIEDFXmIWv mFczKH20FJBTCjgqeo0glCPBkHqZ21380lsTwdi2jxEihxtgS+kAGxfJzcqIsOEJui Pu8DJACPMXee76vw9s8ZB8oxlGZcA8Eu9490oMKx6BEmSG5Mu82JOWWv67EfzSlLCC Z3hwEQXPjDVKWqrtsmnQHurlKRdV1d9eZA8LV5n/VW89lQ2b4iG4sDAeLH4/7ocJd5 GmEh8qxav/0Rw== Message-ID: <82de29db-85fc-0d44-ef41-3ccfe0d3d2c1@collabora.com> Date: Thu, 27 Jul 2023 16:49:36 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Muhammad Usama Anjum , Peter Xu , David Hildenbrand , Andrew Morton , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com, =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Subject: Re: [PATCH v26 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs Content-Language: en-US To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= References: <20230727093637.1262110-1-usama.anjum@collabora.com> <20230727093637.1262110-3-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A7E22100011 X-Rspam-User: X-Stat-Signature: mrba1epd5quw66hrtrds3qy4psm6kzuy X-Rspamd-Server: rspam03 X-HE-Tag: 1690458588-734455 X-HE-Meta: U2FsdGVkX18Vh5l7jShoRO9E4LHROa+cAbokbG2qRnwbUIiDTDO+kWv+WmTHeKAHpUkXOl+mVZd5Vy0Mpk+WsiNa5l+45hDPLmAd6yeKwK6kH7Cr6IYNXfjP9iLo4CsgbbSJM+XdL1M8K4UCM9OfYoTFzWkcC0j4nGSouqXpDOpqKkhLw7CMMl8fVVEVAf7QQrisJzxfvUpI310o+7jBLphpfdB93ZuXhI3M0Y2n/slMDrRNszMzfOKA4balcSrsINeaH0cG0j/Org1BohLR1Cdjsv3pOuA20nxH/ewvBFjck2NHVbz2eEs5K1Io8wlYQEIAqqPxWOYR2zwK8/AgKP/+AAVDYoGw35PN6Zs/IX2660Vt4Fk5x4VWnxX6deCCbcttnLwM7ylnXnNR90Eu58a4hWP0kgUIDqigEdI4F0IF+p46IiZjwf4DtzmNtRMo06lw7KV6iUIfNO8vdSmbj40MnOzPJVFZdvqh9VOqEzzgQ0ckWeyw3gLJcrBQF/Bd94DVff5+WdxLtJk3ISX27yObDKORXhJ5TZVvcWmDWBsyK5WnpQrJKCA4I+/2Zh1F5yqjvSAHyXBGWRg2SK2PXjil5FTnoXkLZlHnIXwuOShmeHfLpQPvmcC2tk8nO0qJLp2vr7c/ia6Y2zSHdMCyPYlTuK8hflwp+BL1mPxYO8Y1pCoRnEzZtdCzhxfq3JD4k4jZrgpRLfCjMplYt35I1WnJ1GP+3v9j2JohrAJ2kh4b863L/dr/f5uLgUwF7wg4LuxfDdqVtkCVrvaAHXpumfMDM9gSH7iGVjF0Ei8dVZiLhGzePpI2SyJr977qzZ7s9XmgopzMcOaYq0+bjzMuiwO90tXulFqHEtsjX3h+2/sKLZX1M7/t6dsRnX2ymM10GvyuoLCi29Fr1n2q121nAQtiqJirCD3Vw6O0hyXqV3p3qxefS3OJsp982BkiFYV6G3QovsSYP8ohBPkQpdH p2W28tQ9 LRSTgCfVhnqjUkdgLzrK4viz9qtXScJLbfHrkkzF1GMb2b1LL+6TFYkua3xNWJXPF8jsrmfVSPG2U2KJbCAhL0sXTKaCno6DqI5d4ExTRybZ3VbPguC47Ci4OzhZhH+IVZAz3DyvK+bXTc7EWnr5Vkvifqm3HgRQ58AH3NgU/R/KyidbJNj/eKzfsI6czVm9+ZcAQFJLmT83ppiUyhNoK9RKXxI5vTPMht9UePX9lEnz3NtOLCe66gg0plGcW/yckKozdRJfYhbjSPU7e8tI3Tdkwg85OrE175BEUoKOJt/LMQwPWp5UZ6wneWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/27/23 4:46 PM, Michał Mirosław wrote: > On Thu, 27 Jul 2023 at 11:37, Muhammad Usama Anjum > wrote: > [...] >> --- a/include/uapi/linux/fs.h >> +++ b/include/uapi/linux/fs.h > [...] >> +/* >> + * struct pm_scan_arg - Pagemap ioctl argument >> + * @size: Size of the structure >> + * @flags: Flags for the IOCTL >> + * @start: Starting address of the region >> + * @end: Ending address of the region >> + * @walk_end: Ending address of the visited memory is returned >> + * (This helps if entire range hasn't been visited) > > "Address where the scan stopped (written by kernel). walk_end == end > informs that the scan completed." I'll update comment. > > (To make the userspace life easier, we can copy `end` (only) in case > of full scan completion, so that the tag is retained.) Lets be consist and not copy tag from end to walk_end as we'll now know about tag every time. It should be the responsibility of the user to deal with it. > >> + * @vec: Address of page_region struct array for output >> + * @vec_len: Length of the page_region struct array >> + * @max_pages: Optional limit for number of returned pages (0 = disabled) >> + * @category_inverted: PAGE_IS_* categories which values match if 0 instead of 1 >> + * @category_mask: Skip pages for which any category doesn't match >> + * @category_anyof_mask: Skip pages for which no category matches >> + * @return_mask: PAGE_IS_* categories that are to be reported in `page_region`s returned >> + */ -- BR, Muhammad Usama Anjum