From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9354CC0218B for ; Thu, 23 Jan 2025 11:39:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8EC46B007B; Thu, 23 Jan 2025 06:39:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C17E56B0082; Thu, 23 Jan 2025 06:39:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A43466B0083; Thu, 23 Jan 2025 06:39:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 80FD56B007B for ; Thu, 23 Jan 2025 06:39:56 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 892891A0CBA for ; Thu, 23 Jan 2025 11:39:55 +0000 (UTC) X-FDA: 83038522350.06.A253993 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 0082A160007 for ; Thu, 23 Jan 2025 11:39:52 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AOPOKqd+; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737632393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=26sJp6LLr853+l42FCxrIN7KhwPqa68kRd/qGpcZQT8=; b=kUHkWAwWB97754jtY1R38WOyvVZwmyDdLWiJpP+vdzEndP6Ygsb+TL7R2CZfKCpCt/++F7 BX+9S6yu83GJztyvd30tT8MeEwrYBDB27mgJUhCA28aaChRV5g5gviQjN97drnz54FGTj/ Byldb3sO6lRQBxugtYtCCv3ukyfoXsg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AOPOKqd+; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737632393; a=rsa-sha256; cv=none; b=b80LDRnIaB6jZwSZZPxdc8+8+xoaQoncXVYX03eQY5Uex02UTxqcAEgh6YNpmS9Lwywrn3 pdwjC7dkdVh85A0cPXRDmxivaJPnZ0m3+5fdTlk3Xm6nYIqpWpa3Xvf5xr7m51x8FBl8OU cE8bzdEbX0+TQaGchO58/BLp5dq+Yxw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737632392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=26sJp6LLr853+l42FCxrIN7KhwPqa68kRd/qGpcZQT8=; b=AOPOKqd+1vPXDGVZtPXrJTlvZONgC42m0+Epv5lZIqTtfp/chlzJcIsQfOUw/pziGuqRfC HCFgVuSqLzGUbJdehBUMC54T3feF+/l8YQhRK8+lDp+SoszTdlbhfICorVyZVRczmHhNAM pks3qSdVfAmUo6c8LcVeP0VkRpl8mP8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-I0AAt5LeMJmVx83XDjiXZA-1; Thu, 23 Jan 2025 06:39:49 -0500 X-MC-Unique: I0AAt5LeMJmVx83XDjiXZA-1 X-Mimecast-MFC-AGG-ID: I0AAt5LeMJmVx83XDjiXZA Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38a684a0971so417737f8f.2 for ; Thu, 23 Jan 2025 03:39:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737632388; x=1738237188; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=26sJp6LLr853+l42FCxrIN7KhwPqa68kRd/qGpcZQT8=; b=wNQ+f6BqeWV7mrqaWDejC4dhZ6uZJUc82i+0d1lhfOw4qNfDGXSAD6SoCTI8enmK4S Yx0YwRVPKj4D5WCi1oCNDQARePqE3hJizvCR0coCp+/4clA9fQPgTSFKwWdBLUvuwReH CybzJ7Q12AXgjzW/p6SKgkyvvmrQhdiYiQ2NdVYLQ2yWh7cKdA25ddHCzr6/2MfrpENp nxk14mBy42EmeZBNsM6ta0E6363moEt19R61QmJqxxCpmPxRuJOIt4H6BBlYRry1d6Zf Qtqr/9g1aj5tqm5Z/IDEN2PIWnEcbJO5RZz74G7Q115wIS67L+mmrKPw70+GxmvEdKS1 ctHg== X-Forwarded-Encrypted: i=1; AJvYcCWLsgYlM5l7GEpnx5yusCQnaAB8flLcXsAyVhWIuGY9k1iuHS7EmtznrS6N7lXah6PSB6clUCP3Dw==@kvack.org X-Gm-Message-State: AOJu0Yye6bhNbfpvD38H3MU09gIqd172hYax+YW3HsZArh2GSz7VZRJW 0gnQ55MP8x2KPTZm7mvU1EPf0Kycagd9M3PAc2qte92Mv9UWAJsqfdGO0PIGvizIM0fORmVd89r 4gnqkIFNimZuogw4qmXMJY8zYrcp3FWHMcMry0Lhjuw3Hxu1C X-Gm-Gg: ASbGncvQgcN2zsf3zknFYQlKjyb10Bz1i/nxbaNFy+p3XM9yCazSO68Qs+hb7/VFz1Z UU3798/pnTW91xwG7g19exI9Y+FQM9r1kLsBxOue7THfdEowV7G+iV8OVlMj78CB0hfsXuFvhnx BoBN5IkdHwiIJ66OcBIXfVt7pAQK+cQB1Who3190Vxj5enmnk5b0GXfzeImoVqOnDT6xFKcLt4F S60F4/ROgNX6TX374LC3Ub9ySXWrq0wsDjZTsyGVT4ZC4jmw5f3d/PzqKwaFvwhWb3q7GMJS5nX wtlEfPipXHpbIXxol7l4mZv84QB7DWnFwSRV32yN9WZAR9CrCqg5uUSxmYGIDPtXo/5Lo5t9jmz ovBikWBsxajzRidCg0xk11w== X-Received: by 2002:a05:6000:186f:b0:38a:8647:3dac with SMTP id ffacd0b85a97d-38bf57a68aemr21941736f8f.34.1737632387880; Thu, 23 Jan 2025 03:39:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOdqnws9Ojo4ed6tHwT2TPMkSJHd3gT/xgbU599QXRB2REcnN3KIZ7uuGKPDeYqeZC5/UPlw== X-Received: by 2002:a05:6000:186f:b0:38a:8647:3dac with SMTP id ffacd0b85a97d-38bf57a68aemr21941653f8f.34.1737632387364; Thu, 23 Jan 2025 03:39:47 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:b400:e20a:6d03:7ac8:f97d? (p200300cbc70bb400e20a6d037ac8f97d.dip0.t-ipconnect.de. [2003:cb:c70b:b400:e20a:6d03:7ac8:f97d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438b31d9a39sm58733405e9.31.2025.01.23.03.39.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 03:39:46 -0800 (PST) Message-ID: <82d8d3a3-6f06-4904-9d94-6f92bba89dbc@redhat.com> Date: Thu, 23 Jan 2025 12:39:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 2/9] KVM: guest_memfd: Add guest_memfd support to kvm_(read|/write)_guest_page() To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com References: <20250122152738.1173160-1-tabba@google.com> <20250122152738.1173160-3-tabba@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rXmwJXDRi14sGO1fgaP-g6NOxdkcfFP2OjWVVR9bVeI_1737632388 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0082A160007 X-Stat-Signature: guq93pjqtw66gmpujbuok5jcgy1gwuob X-Rspam-User: X-HE-Tag: 1737632392-484260 X-HE-Meta: U2FsdGVkX1/TJpu3PpGSur9VPBeyXOiR7OtT+7xFgXyC/mWhPZIlMJBNOaHf3vWxGCdv1/z+qM7H0BZ0gm+w24lZ2B1qYJss9C5erm52hwEC9vY9TrOvHVH+oNG8pUANbc2AUgp+paNBzrwmxj1VhEgDS2Ob9H/RHcT1sCricQosku7AgNkeMq/accl/1AiuYatCpY4aNptPqPifFwlVzPXmsPYb60fMWfm53bVGx6nAjXs2W1XulllTCCCM4LJMweYcv/qW+ZoICHQd3GIEMFrGFRzJMLfgWk3rAnzzgVoE3mHMSUz4XP+MAMszhzzgaoNJrvpGHhIIP5ZEXqO7su6EW/24X9bteMZtb7ivTqO2nKV+Ykx87YwIAuuoH9nGcoJOc4GryIoEzhvPFMXeiU+TwUq0/jnRKq8rYqzKaTmgRsOHO7W8zxmqllFi+I0wmzRzdZvWb2/ZCnZBXMPvHsi/WvL+XsLg335nXcZa2YsFvpvemHIv/4/2A2bVFW1qeyhIBYHTegVIqrfx1v4JZ230ryl9+EC1Vw7ihggOM8hXgjGlHOdYg2TU38tp24GiqHfA8ItvK/PS8MEQHjzbHHXfwhWjvDv5YfKCXuSW+qqzPFRhjUlHwLW7H2lLHDEIq1CJ80yqdTSjILBQVkpvqd6krpJjhIDFMitMkVWZnkclSF73rddUBGH1kL1q2oUutBY24ZIyBALjTXlWKoOsUoe0kCvRIx5utixt3ks8VyPJKb+7rm/zTSuBpDppQTCtY2UJmDJHotU5iFWkh2zQq9ng1W2/FE2CSQRitEkpEJz+50LFj4N2CeFfDLmbdyg2vBthksWZ+9qIUwZDSg0+7ULP5K4FOpW8Jc0FdGK4n2GpWKwId210fTiRJuVIgISukXunQ7VgPWVhiffHMKh5pZTQiSXbxlgnMWJ1kqAmfX5bv20u/oAWZWHP+I2llx0hvg7FjvkFsicRnzbk2SD xsq/j5Io saMNfFyDY413O/PD0TSUQ4NOyypDplXUrOzitEhKmrzYYLylbs7drBbirjmWuCGs7F73atHVh/0tcRMEM2IR9N7U4L5b+7pI76e6d2K9ADEG8hg2ZkTAN695vT2riBLI/0GO3sJS57HnzSQHrYKHafHZpMropqPHb/YuhfATrX43fxSQKUBBwrTUGDaMZJyTWW+/+sdgP5MH/7n/k4Y/aSnI/UUr1Htg9bLeL3NrQoeGG9ZbMQ4mvQsFcI+fVBjf5oln0X7OyADokXi3M5zSddFVkLv5OirPr6kVmS/4hcR7IAf12rQXdM/Fvo3WslYz9ju6MbXXK11DqqAeU0zKV8enBBHUWD2+qr8M5CX7c+5SxcAMBokxgqbTHlGYr7zGIr7YqVbGLhm86feut3zhBeCJubzAiLTluV7JlrX6mbEEeyn1xnx3KLkFiLwi05zDX6YQdUhpvBeWKDWy+mikxsa+jdnF0+PnBqVazykC1k5k3bY9EwBM1hPlXVMaJHUogF4G/S8zfpPdvLu98eU8R6CdMOxlAWWwdpUrqGDtegVjWwGAmFexm6XpNM3bXC/GbBWUm8sk0CFNRCK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.01.25 10:48, Fuad Tabba wrote: > On Wed, 22 Jan 2025 at 22:10, David Hildenbrand wrote: >> >> On 22.01.25 16:27, Fuad Tabba wrote: >>> Make kvm_(read|/write)_guest_page() capable of accessing guest >>> memory for slots that don't have a userspace address, but only if >>> the memory is mappable, which also indicates that it is >>> accessible by the host. >> >> Interesting. So far my assumption was that, for shared memory, user >> space would simply mmap() guest_memdd and pass it as userspace address >> to the same memslot that has this guest_memfd for private memory. >> >> Wouldn't that be easier in the first shot? (IOW, not require this patch >> with the cost of faulting the shared page into the page table on access) > In light of: https://lkml.kernel.org/r/20250117190938.93793-4-imbrenda@linux.ibm.com there can, in theory, be memslots that start at address 0 and have a "valid" mapping. This case is done from the kernel (and on special s390x hardware), though, so it does not apply here at all so far. In practice, getting address 0 as a valid address is unlikely, because the default: $ sysctl vm.mmap_min_addr vm.mmap_min_addr = 65536 usually prohibits it for good reason. > This has to do more with the ABI I had for pkvm and shared memory > implementations, in which you don't need to specify the userspace > address for memory in a guestmem memslot. The issue is there is no > obvious address to map it to. This would be the case in kvm:arm64 for > tracking paravirtualized time, which the userspace doesn't necessarily > need to interact with, but kvm does. So I understand correctly: userspace wouldn't have to mmap it because it is not interested in accessing it, but there is nothing speaking against mmaping it, at least in the first shot. I assume it would not be a private memslot (so far, my understanding is that internal memslots never have a guest_memfd attached). kvm_gmem_create() is only called via KVM_CREATE_GUEST_MEMFD, to be set on user-created memslots. > > That said, we could always have a userspace address dedicated to > mapping shared locations, and use that address when the necessity > arises. Or we could always require that memslots have a userspace > address, even if not used. I don't really have a strong preference. So, the simpler version where user space would simply mmap guest_memfd to provide the address via userspace_addr would at least work for the use case of paravirtualized time? It would get rid of the immediate need for this patch and patch #4 to get it flying. One interesting question is: when would you want shared memory in guest_memfd and *not* provide it as part of the same memslot. One nice thing about the mmap might be that access go via user-space page tables: E.g., __kvm_read_guest_page can just access the memory without requiring the folio lock and an additional temporary folio reference on every access -- it's handled implicitly via the mapcount. (of course, to map the page we still need that once on the fault path) -- Cheers, David / dhildenb