From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FE2EE7716A for ; Tue, 17 Dec 2024 06:42:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 923596B0095; Tue, 17 Dec 2024 01:41:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D4166B009A; Tue, 17 Dec 2024 01:41:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 771BD6B00A3; Tue, 17 Dec 2024 01:41:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 58B5D6B0095 for ; Tue, 17 Dec 2024 01:41:59 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7C31C1203E8 for ; Tue, 17 Dec 2024 06:41:58 +0000 (UTC) X-FDA: 82903505580.02.AB53FB7 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id D19071C000C for ; Tue, 17 Dec 2024 06:41:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734417703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PtPKGdxfLZ8kNEUDogHNU/rE0hcFFbbdFw1zoD78rY0=; b=LOJXOVEWSKqaj/OroV1DU/o4oFUR+TLZHpaVDz8fPzrhYdxtadt+wILi8VGSa5rnzMq8Ym ZJDDcNnJvNp3EpQ7M2khCVOPDVTB2FuelnhUhA0TuOPUVfru1MHg+VJ0riI2nnKyssbDWI yQq/E+KuktNXFwU4tdC/53q1itMgZ9A= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734417703; a=rsa-sha256; cv=none; b=G/TFD3YC7gdiOFPxUrL6aoPpQT/Yo9ZW7Jv+CF3kyxaDkErdbXDfy61iNJdlJP34fKrfOJ KMwABdCjyIYKvWofuiB301SlDNeOjWhm8c0PQ0MUNTL2GLh/JGK5cwX6L8MNT/tB7pHZ/a Bxzhx3I7WyixDW/qLczzQ4x3eSrKj6I= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 97BD31007; Mon, 16 Dec 2024 22:42:23 -0800 (PST) Received: from [10.162.40.67] (K4MQJ0H1H2.blr.arm.com [10.162.40.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF5B53F528; Mon, 16 Dec 2024 22:41:45 -0800 (PST) Message-ID: <82c8712b-b7c3-4b58-8b29-dbc436d885be@arm.com> Date: Tue, 17 Dec 2024 12:11:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 05/12] khugepaged: Generalize __collapse_huge_page_isolate() To: Matthew Wilcox , g@casper.infradead.org Cc: akpm@linux-foundation.org, david@redhat.com, kirill.shutemov@linux.intel.com, ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241216165105.56185-1-dev.jain@arm.com> <20241216165105.56185-6-dev.jain@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D19071C000C X-Stat-Signature: nzmincpfbc5de7khbsmgck83gw89nkdz X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734417702-899870 X-HE-Meta: U2FsdGVkX18TgZKoasZ4gU/4u/DPZO74OCiTZ0QykUheVP5FCC6YBtcK6boA44INz6v7Wk7RsRACvm5qJdG3pYEEN5z9HhTSMU8eAUxUSyTQexV4PZ1bqV3Ev70/+DY0LxWiOxiy2mTYrH4wllwbjULEhLQEajcEpxcTmKdVE/CibSEfEJ/rdATtR485qwA7CJfrgTejj9x68cMOa6ULmImYC/dyu8ocw7rOGKj/PyPf4YDpW23RCSR6H1jcpGq0zzkdoLLfFZICwmfgqsSXk+vZe2hdnTd6FAw3jrpnY8NCPVfTWut2ocLNMUPGuV5NSUkoQSA934loxhIRGPRBhFVn4aM5JZ+uoEoZjNX7nFMhJNTuS218WbL8rSjvgK/Kn8GRFuMaqUkpuu4EJ3thKD67R6VLwX1/fNb7gz5zUhMBfUZf8fV5s793T7ePfbCURfhvs9d8jzcK69KtD1y8aIYsrkoqdqS1tSMOwxt66mcyEx4X/piBdZaeZDQt4utBAPGwp/vCsgEnvzZnI2c9PfwhZyZQtRu0ae9E06u3fPnnh26Cmw9bREEf6IUGs0rSWYZ2qF/xGz7vMSpgbYzkjSDU81h8LQNgjeHBWB+gbtQ0+QHjGcxz36IXkRH4g4TPyJeJsVNypDdrBN/+mVAVDdjq287DlYWMDWSS0240X3ansU1N22WgSyg7vjiDoKdlMoSokOOhgHW+elQv/+Fuu/c1RvcNhHcaX9qUiUUGkbh17aGwSN1i/x6uN2GfinLqVgl1gcJkeG/vtaw09ELdIqZzryGC5eopmrjW8NZ0qYsGCNPbGGy4Uib2ZGMHBByZ8B2UiPahcowd/wjCuPBF42FSiiF96nPID6e3O9iCejuedng+xKqxkuZg47NcK1OpcO/Xc5UosWiojQvrqGQuUoNBSh41hi5ye/698eJRSdSgFta+H41Mn0Ym3Ea/Lz6YluFgzcm6o5/sms2XCHd TZvKo+hZ cs5CXgOCVLFcT5wrd02sHEnTvXgQLdY9eipp8eL2koCEjjfUOktyAl2cMnmSiqnsMu2v3ZIt27/ubp2b999d3s3gJSeHp8yeOD7Ssw9dfjYonsPcLvW6bJlKIvbyrQy0/nI8XoYzlO2gDEhzDhz2oMJUpjua5YqXgeXt1wL1QWXxKBnKK9Aj2VMwWjUIbRN1uBaHBy2kiQEMuO8Qn11xQcPWRy4eV3aihtB+5Dj5fVIl+ZpNLOyMN3Xb2eu55RDmtAB4dYhbDe4k2K/ns7eOVBpxidHC/RaSAIEsDZ0x9h65T+3T9gvqyENhxXyK40geyE2eam12zghEJdvvTdORvHSxrT1jv6HG/NP+cxem9+/qlx6V9NmYc2O86DnzcryljPDr5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17/12/24 10:02 am, Matthew Wilcox wrote: > On Mon, Dec 16, 2024 at 10:20:58PM +0530, Dev Jain wrote: >> { >> - struct page *page = NULL; >> - struct folio *folio = NULL; >> - pte_t *_pte; >> + unsigned int max_ptes_shared = khugepaged_max_ptes_shared >> (HPAGE_PMD_ORDER - order); >> + unsigned int max_ptes_none = khugepaged_max_ptes_none >> (HPAGE_PMD_ORDER - order); >> int none_or_zero = 0, shared = 0, result = SCAN_FAIL, referenced = 0; >> + struct folio *folio = NULL; >> + struct page *page = NULL; > why are you moving variables around unnecessarily? In a previous work, I moved code around and David noted to arrange the declarations in reverse Xmas tree order. I guess (?) that was not spoiling git history, so if this feels like that, I will revert. > >> bool writable = false; >> + pte_t *_pte; >> >> - for (_pte = pte; _pte < pte + HPAGE_PMD_NR; >> + >> + for (_pte = pte; _pte < pte + (1UL << order); > spurious blank line My bad > > > also you might first want to finish off the page->folio conversion in > this function first; we have a vm_normal_folio() now. I did not add any code before we derive the folio...I'm sorry, I don't get what you mean...