From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31713C6FD1F for ; Tue, 26 Mar 2024 13:17:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B47416B008A; Tue, 26 Mar 2024 09:17:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF71A6B0092; Tue, 26 Mar 2024 09:17:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C0676B0093; Tue, 26 Mar 2024 09:17:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8C4DA6B008A for ; Tue, 26 Mar 2024 09:17:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5C584A0952 for ; Tue, 26 Mar 2024 13:17:46 +0000 (UTC) X-FDA: 81939242532.02.7072E77 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf01.hostedemail.com (Postfix) with ESMTP id 98AFC4001E for ; Tue, 26 Mar 2024 13:17:43 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711459064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J0kF/tvMTxOE4wHckY4TKUxoaAoK5tEOS6kSjFqYUsQ=; b=UQfwck5+OdFAYh9LIK8J1663yaJJ5r9l3RRRA8mHpKwE767PBM/Qi9Jq2VINnxQ+/sXnTX 4/vE1Lxz+Ihmo0HM5Eb1iTzhZFGBEPlU+AszIlkJ+RAA9EWkV2mKmKTRKFACEECuSGSOt0 nSazUyzGP1dbTOdn3CjJg32ZnY98SQ8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711459064; a=rsa-sha256; cv=none; b=O7zqUJCH+zkZMZcZ0Ijqnmmb7ER1qnmyJpxyvRkhqhE7zAfx6MN5+m8aVwh5NeAO6SJPiZ EgYosEa6c4HlQXJF7pJy/UpcpyUD7w4Hly7/8q248YKUnGSayudkTovMvcHsSvTbTp0c7A iSLDZCpKhC+ghwnJK+Hg2o8t9JXTBvo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of shikemeng@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4V3r2432FLz4f3jMP for ; Tue, 26 Mar 2024 21:17:32 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 998351A06E1 for ; Tue, 26 Mar 2024 21:17:38 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP2 (Coremail) with SMTP id Syh0CgBHtwrxygJmG1g9IQ--.29068S2; Tue, 26 Mar 2024 21:17:38 +0800 (CST) Subject: Re: [PATCH 6/6] writeback: remove unneeded GDTC_INIT_NO_WB To: Tejun Heo Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, jack@suse.cz, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, peterz@infradead.org References: <20240320110222.6564-1-shikemeng@huaweicloud.com> <20240320110222.6564-7-shikemeng@huaweicloud.com> From: Kemeng Shi Message-ID: <82ade435-3ad8-7628-4c1d-09399ebdec49@huaweicloud.com> Date: Tue, 26 Mar 2024 21:17:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgBHtwrxygJmG1g9IQ--.29068S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJr4kCw4fGFWxGw4rGr43GFg_yoW8Xw4rpF 4fJ3WUKay5Xa9a9rnFkw4xXr98KrWxK3y3X3s0kw45CFs7G3WfGr1jq3yFgF17Ar1fJrn8 ZrWxtas3Xa1UA3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUv2b4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q 6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVW3JVWrJr1lIxAIcVC2z280aVAF wI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa 7IU189N3UUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-Stat-Signature: jdj65ggcuzbphuz8wqk4iix9w6iiw4w1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 98AFC4001E X-Rspam-User: X-HE-Tag: 1711459063-679823 X-HE-Meta: U2FsdGVkX1/BbbxhA+n3eUo+mNl+OZiGinXacLG2Q8lSrp18kOGi7SjF+L6eCnpwMFteLNSZi4chUyAg5eOp460ddnnvYcNGABAV0dyjkt2hIr2o15rmubj1xhyOKoQlbkynZY2NfTihaA4t9l7c+gRDXp6/Yr5G0WUx9WycR6M5tQjVttPX9YdZ5UmNiRj7+CzmsieBLYE0cVGAPfPefU+mWZXawZ7gfZXm0jfBAoN6/68ypT0hA194olwii8snktdwjqtmsZyLxvG4x+mjni68YZs+OIL/Gz7TL6zUgqny0gTI+IKrro9ktUWafkbBNIYS8Yis/ipvkzVwZPv8Zo8EaSP5gDGHJ3AOFr0Ct8X2ytI8/+njgG5oVdN3Ks6Lj9bnC5tw2Yf3uUR4E2R7wJdsJiZr33lerHvZCYEzbOpX+/GXMqUVeTQCM9hwYi94tajQBJVoki1XJDPKjNNC9KEpECEkdlgIlSnEE7evnnGt3zS6iXi+sU3HJiJPIAv1XS63h7dSsy26FMrJzG4tswhsP8amJT/7mCsl8O9bnh5IhzgkYaWLOb9mdurwWy+oZXaIR4FWIOjSjivd0Xi0fSkShRbsX9f/6fQ2r14qe9kl9VhLY5YhWoZ6krc9s2lBfZNyhOGnVt2PSIXofwSSRjOBVNuYU3AAboDJLCbqoHBBUXRbBmF2O3JpX7gRAoCCrknSNZ35rTlRTNwtAFJ6nPgWghjKOofEoTpL2mw7CWD4O77ZK8xdbe+raQkxvWCLMobdOpaX6bydpTm2dI1OUueEXtRR0Ru+O2UB0c2npmix2KFaNZKzfeXj2TKrVTf5YNacQ6xPSpG18UtIjHRoRfDDFnCZnxl9KbfXkEbeuQSX6HF3c2ZWoPYwENVwsFHyUJDpUlfeZaECrV6JW6NebMKx4SqW1GcvdQf9sL+56KRjleN3sL77KH4xN1EUaSVjdP2AMBgRLQ5Nj2H1OeM pXbaOXdQ taw6od1xQEoNhkF+wFMOAHDJMxWI102JsiNF/IhXDUlmmPK+kvYrfAb/6IkxBJpmFGIYWTYJ8oOsHTa8RWrxcB/Z+hAJBhVhq3rCKzh0cl3BNMc0nvyP1uLYUyTi6FxPceHY6r/OXL1aymwFdLUwTGkmrAdFx0P3TsXpT6bT2KIkoY7LPIP4aVlgMWrAUDJhXkiiAt+9/VwzrH1E+PfLdx8YhTyrq3ZILAEDYVVZ3ufuKfbSx+9YZQ8nZZt9GWzPltv7i0wnghPEQCXkIVFvE7cLXzA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: on 3/26/2024 4:26 AM, Tejun Heo wrote: > On Thu, Mar 21, 2024 at 03:12:21PM +0800, Kemeng Shi wrote: >> >> >> on 3/20/2024 11:15 PM, Tejun Heo wrote: >>> Hello, >>> >>> On Wed, Mar 20, 2024 at 07:02:22PM +0800, Kemeng Shi wrote: >>>> We never use gdtc->dom set with GDTC_INIT_NO_WB, just remove unneeded >>>> GDTC_INIT_NO_WB >>>> >>>> Signed-off-by: Kemeng Shi >>> ... >>>> void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty) >>>> { >>>> - struct dirty_throttle_control gdtc = { GDTC_INIT_NO_WB }; >>>> + struct dirty_throttle_control gdtc = { }; >>> >>> Even if it's currently not referenced, wouldn't it still be better to always >>> guarantee that a dtc's dom is always initialized? I'm not sure what we get >>> by removing this. >> As we explicitly use GDTC_INIT_NO_WB to set global_wb_domain before >> calculating dirty limit with domain_dirty_limits, I intuitively think the dirty >> limit calculation in domain_dirty_limits is related to global_wb_domain when >> CONFIG_WRITEBACK_CGROUP is enabled while the truth is not. So this is a little >> confusing to me. >> Would it be acceptable to you that we keep useing GDTC_INIT_NO_WB but >> define GDTC_INIT_NO_WB to null fow now and redefine GDTC_INIT_NO_WB when some >> member of gdtc is really needed. >> Of couse I'm not insistent on this. Would like to hear you suggestion. Thanks! > > Ah, I see. In that case, the proposed change of removing GDTC_INIT_NO_WB > looks good to me. Sure, will do it in next version. Thanks! > > Thanks. >