From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 321BFC4345F for ; Thu, 25 Apr 2024 06:22:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D77A6B0083; Thu, 25 Apr 2024 02:22:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 984F16B0088; Thu, 25 Apr 2024 02:22:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 873F86B0089; Thu, 25 Apr 2024 02:22:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6A11C6B0083 for ; Thu, 25 Apr 2024 02:22:06 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F03B21C173A for ; Thu, 25 Apr 2024 06:22:05 +0000 (UTC) X-FDA: 82047059010.25.35291D2 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf25.hostedemail.com (Postfix) with ESMTP id 0620AA0003 for ; Thu, 25 Apr 2024 06:22:02 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714026124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sNFk7y6L19U7Au+xI/DRdrWmxngq6MO+Cj2PVnt5KSw=; b=kCXsWheHSM8zhEkgyVAwSRveds1dXTZ/O69jj1KbuSGiNvA54KYWLaiaXMPyu0n0aXd/vy lBYST50qCC81MBGqTGqPTCU3V3OGse/dMaOEyCA4wbFQckfeMPG2Bi2QSg8tfdusdj9dub vBNnlCQYJ+5CNp5hnm0zIDM5ZWH6sFc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf25.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714026124; a=rsa-sha256; cv=none; b=YhVMNO3C1WqG29pZLDnF3T7c0E65OZYpM8ILrSafO9g3UtxmvrkJkhLoiMCVhMFqILkDJY SaJl8E+2RAzs9u5rBy1vLOc+z1Ye9oAFLkLKpTCNlXNpp9CjmvB6W+T/kpZdmkWGLTFda2 dWXzsLf6XlQVU2BfZtoC9L2Ug0XT+Mo= Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4VQ5KD4qPVz1R9NF; Thu, 25 Apr 2024 14:18:56 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 273C01402E0; Thu, 25 Apr 2024 14:21:59 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 25 Apr 2024 14:21:58 +0800 Subject: Re: [PATCH 3/6] memory-failure: Remove calls to page_mapping() To: "Matthew Wilcox (Oracle)" CC: , , , Andrew Morton , References: <20240423225552.4113447-1-willy@infradead.org> <20240423225552.4113447-4-willy@infradead.org> From: Miaohe Lin Message-ID: <82a80acf-7d2e-b207-07bb-2584ef874352@huawei.com> Date: Thu, 25 Apr 2024 14:21:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240423225552.4113447-4-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0620AA0003 X-Stat-Signature: 33othtk83qk8jky1r84xcfdn4uzapypg X-HE-Tag: 1714026122-184046 X-HE-Meta: U2FsdGVkX1+71Gi9u57yGQStCBomxrxPkcO/Ka7NGOZluEcr3jnPXzLb6ePR1ZfrPXtn2q8GDRBbslmNVDT3rLdz5n93k7guoWI2ugfMzXU1hdZVK5fOeaiNLl2vguKTWNaOa3c1I/em3HbTXw6oJRI/S6q9xnl8HJNcsxLiFRdm6fAHwveOGLhk3RxCvDplLjaCqbtwZTSZXle0kY+EqQeAO7c/3CUsPBWVpmUEZU3kAGAtK6X1dJMXXxovgGDSnB5QE5KgbCZRFnaI7Ed1Xwz0XWY0o2/6uOmDEE3JLeBHvtEy31bOZenKpJsuABtUvmt4cGDjDwenmlb7zg20arPZChbF1EyFeNWViyPYsZ+M2PcQmoW3RFrJRSBcs3NGiIpAmW2IuZmIyUNqicQ1Bxx9cxAu9FBWPBBGaVOwERg1CswVFMBrekPJ2MWDK30fwHTUtgICHO/kODPSAKOD6jUjy3O5LWyIofF6gkuofxSojtNw6TqykhXu92xlGp4KGlX1uczWlEfdsKyuHp+96ZVslXyqgGBPMlLIDl5DTq11apFiHH2j+CQYbUoM4td4Z2cztAdHl7YOzyyC1wyti9s2z02TQqghjdxZZoHA8wXwZ2HTr18bImpG0jQN1dvU8FyjbPZEVwjhCUDY7y8jAgmqs3im/UtiQ14fwWZSNesGvjLPDsPwX7af5suqejo8qJSwvDGgjiYnteXvE3UNbT/nJn6a1MPMvUyleE539pVxWePlyRTQVqlwCzakP5AkjKV5SBmUWKC7O6oWVwj+H6AfrY6QiTAZlqjkxqOZr2sZXYqEbGfPUSKrqVMvLr9+zMhwZG7eabkx9VsEI6Uf1gX2rB3TE0W06bRV8ldf6D1o/VcLEzASvWxsJhKUt+bGgyrRmkWG5sDG0K1fl46I/0LJiiB5tYHjFsN3OimiR0WxSZa9Bo7BQmgy/p8ujtv9Z4U4IDbSpfRPqHeSEHN mJjZ0Isi ikoXOzXp8Xoxh2VsR8dZxNm9SENyu7abaN0QYNUwau2VGtHVuGt2HnWT+eGCIbPLwRo6l2rKEMLD1EKDPT+DGaDJS4QVl0m3A3BgtEyOvV64eDLvKoQVpJbps4641tnzAA5OdC/4NrI7lZ0tUUk89xdbMQDg8e5gBf80nEnIXguMl+bqAx9SaU3BT3vQMr/UuWqZNcpOK3UmqN62K1eWQkYKsUP7/XmnOF/pyNuZpVCsR1l/Vt5TWJhyX9hjL1K9IMq84 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/24 6:55, Matthew Wilcox (Oracle) wrote: > This is mostly just inlining page_mapping() into the two callers. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Miaohe Lin Thanks. . > --- > mm/memory-failure.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index e065dd9be21e..62aa3db17854 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -216,6 +216,7 @@ EXPORT_SYMBOL_GPL(hwpoison_filter_flags_value); > > static int hwpoison_filter_dev(struct page *p) > { > + struct folio *folio = page_folio(p); > struct address_space *mapping; > dev_t dev; > > @@ -223,7 +224,7 @@ static int hwpoison_filter_dev(struct page *p) > hwpoison_filter_dev_minor == ~0U) > return 0; > > - mapping = page_mapping(p); > + mapping = folio_mapping(folio); > if (mapping == NULL || mapping->host == NULL) > return -EINVAL; > > @@ -1090,7 +1091,8 @@ static int me_pagecache_clean(struct page_state *ps, struct page *p) > */ > static int me_pagecache_dirty(struct page_state *ps, struct page *p) > { > - struct address_space *mapping = page_mapping(p); > + struct folio *folio = page_folio(p); > + struct address_space *mapping = folio_mapping(folio); > > /* TBD: print more information about the file. */ > if (mapping) { >