From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB067C2BD09 for ; Mon, 15 Jul 2024 08:36:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AA816B008C; Mon, 15 Jul 2024 04:36:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 482086B0092; Mon, 15 Jul 2024 04:36:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 397436B0093; Mon, 15 Jul 2024 04:36:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1BE5E6B008C for ; Mon, 15 Jul 2024 04:36:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7B35081477 for ; Mon, 15 Jul 2024 08:36:38 +0000 (UTC) X-FDA: 82341330876.03.DCBE5D9 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id C51921C0010 for ; Mon, 15 Jul 2024 08:36:36 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721032577; a=rsa-sha256; cv=none; b=eV3sbRlg3r+i3HSQgFK+FwOCPZPVpf/3XcaNRJE8VObWktgG6unVbwYCQ/gR/mPtf+WFVa 3XTcPJP5bS1zBDjmb04iz9a4N7f47Dt2G4hEi4cz22N1bVxucnXWhZ2VyQhtx7QQrTF59v 7PXIJWBxZnvhawNTG42GqobBqWcMHq4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721032577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPMzlsgnL8R/QiQfmyp770SvYe9ecicLzEbOI+zGB84=; b=b3ZDSCzhJh4P5wn5qsyDKdT9AOy+RsdLnoLD1A6r4B6uHf0cguZEIFaB9l7q29S1KmAnLs NxID0O4K6fr6EU7fH2BTMbel5AVDo1VWaMtUtaUZonxf1wW1I5r6MIBiKbGNV2XR1Gl866 nbjaSjoPbG89o77W4qeny8ZwLzDCO08= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 256A8DA7; Mon, 15 Jul 2024 01:37:01 -0700 (PDT) Received: from [10.162.40.16] (a077893.blr.arm.com [10.162.40.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9C89A3F73F; Mon, 15 Jul 2024 01:36:27 -0700 (PDT) Message-ID: <82a5acea-0a06-437e-b246-ae2874c3493e@arm.com> Date: Mon, 15 Jul 2024 14:06:24 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/29] KVM: arm64: make kvm_at() take an OP_AT_* To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-9-joey.gouly@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240503130147.1154804-9-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: si1ofpcgqn6yw9tpf7jsx65s43t6uugh X-Rspamd-Queue-Id: C51921C0010 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721032596-583175 X-HE-Meta: U2FsdGVkX18jLvlpgyjvUSrQ3xzMAqpQi4bH3DlwRwEUcS6pMsA/4x90Vgg4BNHtEgAwD2V3ilUZsV3DwG1LxV//WDYHh8etQGMHnZR3Hd8zf1Wqnn66ybzfyYZE7W80pwHwNm7KjxlbItnyy2p9nD2ob49dSQKtYfLKZSG24jxbBBWwac7XcGAdS19JcT9uzYmRdFF4BNYvHGm+8ttZj9Pz8SbLx0ERci9hWWQ/7rmmt+mPzh7Th2hM74Ff1sHsZ+S/hsoROwY63YolTl0Z6gl51PT1AGgIEptqkMWt9KbHJTQw8gC4cJorYYQf4bOFK3v4uhkUHgDBIs24q9VrQ2P4DAlykSSFTt4nmK0ZEIGVo3fASGum/g/Z5NNHdoAl5Pi/A54JuO3IlO86EasJlJmNXbLloXETMxTeti8DFp4N7fGaJsIauoddPXDOljPNIfZuIWN4HwBNWSkthUGsCwN02lptVNMH8RyohDeHBfc6MDfu/0I2Wo6AZMhppMgeDINFhR2v/dE+rd5DoQd8xxnmf88dVyvNT2lBtpd8kOG8lrU6Ye2ASX1KWOicCdzOclv821KEUELxLIowkIHgFRAvuforCIa+zFSBuRbzYQcWQIcL35kbzaEropwxt2gN0+3v6lQcgIPV4klcWkquYep9NHFVlAkqfGlIJZ5VqGGErrtznQw3r0uzJrQoWGGPELFBU+QtdS4ZO1VbWQYEigMXijaKBBTbJIeSbSelemDyfEYbRPTK9qMgB+u19ERqmBm3KaiibT+H7x5U4g1EICRsK7gb8epJHQ34wMXDPcFxIVHpKMCZN3OqSGRgJPqMdWdCAYWD7l31JHnz8PRWwwrzqJcHK3rm5UbCloKcUs6hs5X4BzN1g1452C4OF2lyt+VU+edwx0ESBaRzG/GCbX/VyNp1yqWrn+WiZgVRWQlsVjgu2GiyakKtie5f/XHIgIinw8e2hC+DUOTiR5A gAYcyUSR h5GQRuYQ5zi95n+2cf5CSla152HQlfcB3dEZ9zH5R2G+GlbIM4b9E0WWCEFZTp9WZpCJKD8/3caZzNh0I0+6U0tE7UjAsruYCLuScA3r7CWxdz0beOrGMto4QjAlZ+u1goC70G62BUYiHLGwpytkcAPfWG2CceImsXGH2aDzdSin65ZniMHAR3fO8up6Uu+zvN3lbrmuTOTB/tuR1UGzfZggJFxJBYYkS18D9oEFQZZDqPj/m3tByfutndg5Ki/FbNQjpNyVky06aDr3mqs8JepinDJ6TYGFUpq8EUrSDMz03Keg2KWoT7hwiDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 18:31, Joey Gouly wrote: > To allow using newer instructions that current assemblers don't know about, > replace the `at` instruction with the underlying SYS instruction. > > Signed-off-by: Joey Gouly > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/include/asm/kvm_asm.h | 3 ++- > arch/arm64/kvm/hyp/include/hyp/fault.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h > index 24b5e6b23417..ce65fd0f01b0 100644 > --- a/arch/arm64/include/asm/kvm_asm.h > +++ b/arch/arm64/include/asm/kvm_asm.h > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > > #define ARM_EXIT_WITH_SERROR_BIT 31 > #define ARM_EXCEPTION_CODE(x) ((x) & ~(1U << ARM_EXIT_WITH_SERROR_BIT)) > @@ -261,7 +262,7 @@ extern u64 __kvm_get_mdcr_el2(void); > asm volatile( \ > " mrs %1, spsr_el2\n" \ > " mrs %2, elr_el2\n" \ > - "1: at "at_op", %3\n" \ > + "1: " __msr_s(at_op, "%3") "\n" \ > " isb\n" \ > " b 9f\n" \ > "2: msr spsr_el2, %1\n" \ > diff --git a/arch/arm64/kvm/hyp/include/hyp/fault.h b/arch/arm64/kvm/hyp/include/hyp/fault.h > index 9e13c1bc2ad5..487c06099d6f 100644 > --- a/arch/arm64/kvm/hyp/include/hyp/fault.h > +++ b/arch/arm64/kvm/hyp/include/hyp/fault.h > @@ -27,7 +27,7 @@ static inline bool __translate_far_to_hpfar(u64 far, u64 *hpfar) > * saved the guest context yet, and we may return early... > */ > par = read_sysreg_par(); > - if (!__kvm_at("s1e1r", far)) > + if (!__kvm_at(OP_AT_S1E1R, far)) > tmp = read_sysreg_par(); > else > tmp = SYS_PAR_EL1_F; /* back to the guest */ I guess this patch has already been included in a different series now. https://lore.kernel.org/all/20240625133508.259829-6-maz@kernel.org/