From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7950C25B75 for ; Mon, 3 Jun 2024 08:55:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAEC26B008C; Mon, 3 Jun 2024 04:55:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5B456B0092; Mon, 3 Jun 2024 04:55:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FE206B0093; Mon, 3 Jun 2024 04:55:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 83C536B008C for ; Mon, 3 Jun 2024 04:55:18 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D0B0B1A0947 for ; Mon, 3 Jun 2024 08:55:17 +0000 (UTC) X-FDA: 82188968274.07.4E62693 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 8C7CEA0003 for ; Mon, 3 Jun 2024 08:55:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gbXSlq64; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717404915; a=rsa-sha256; cv=none; b=WUvQGaO+5ovC+lE1q58ChkB5rPXJPnGk5MTxfpQ+5r6uENgziLvYPo0IWB5w+TLUNk+MIy Vef+MIUvtc4+yp2OWuYoFl90ZZOWv9Id9/Gr+lbhRTBN3Ao1A7aDZORlHiWYinNKgygBuS DGwc1nURHTSRZaMIoz1r/hf882rFHMU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gbXSlq64; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717404915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2s4KDSxoNfrGEnnhMoH6dWFkR4bhdOpB3wDJq7wYYrg=; b=Y5Bb7E5vI8vdxIBQ60zrEBk/siVbwL7M3Bi29PMvKkCKdjGJA4swfg1Ga7IXgPti4au/Ne d8XeLie0ehr6M89J/RHZPquHFT3mVjumX2bQYUjN+CGuVLhMUK6FAe5zvpzf07/c0ppU9O 9goRS+NwT0tiV+Y8WqpvctLOH4ySgcA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717404914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2s4KDSxoNfrGEnnhMoH6dWFkR4bhdOpB3wDJq7wYYrg=; b=gbXSlq6442ib2WPVnnrPvusO70kJ7Y6kR8aoGopQ9y3moPYsrkoDX1d9pChRDj3es7BqgJ hESmw0Ku0ckTgwZyHyMt7jSHuUT2n0ifKPFcXjiDL38/72Uacg1+mjqP6qFWaW/KfSNQrF CkAoZGEu+Uav4M96vQD9XBbeBJBdC10= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-BUlb-dxWOqy7TJ2cN5vyRA-1; Mon, 03 Jun 2024 04:55:13 -0400 X-MC-Unique: BUlb-dxWOqy7TJ2cN5vyRA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42108822a8eso22653915e9.0 for ; Mon, 03 Jun 2024 01:55:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717404912; x=1718009712; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2s4KDSxoNfrGEnnhMoH6dWFkR4bhdOpB3wDJq7wYYrg=; b=fVcW1c0ePbEkXXEw5Ka4bVSIgIa230aQfLykGhn3oVLnndV8L6fXyLiyDHA+2uswE3 WPggJwt0kXblqVMyc3ji+GFy4LHb4KKkxyBJuPPKfQd7BvC9Kp0JD7OtleyDw1oi5H3z Glb86xM2mYpp9Br6TgeStPxSRoiIU29cdJFvt+maj8ckR8G88xyCuBl9MFppJr/Sk6zq mxqF6+uJiLXBW6nL2IxysKvyM3n0h4PwEs/yKoawwFZ4uLswG1wuXAdNrEqL4Edutd3l xdZ2yagb42dWfuvc0FysLETPxulC+eSrpDwHKpQkhCKVJKZO12e4hgWaBQOpB7HL3+tv qMvw== X-Forwarded-Encrypted: i=1; AJvYcCU5tIGV6MaXBJTaZRKcMkH0V2D8X2Ep5edKgJUbwK2OBIuxt39s8iB9L85UcltBvEOi5H/7kqtBiVXw88gmEVKYqN4= X-Gm-Message-State: AOJu0YyTXtwJ/BnXbedqs0VQOZ8BgsIFQNK9RcOQYdnvGukJ5VLhIz4u iomd7Ns5WUxVvIQW6LerqUheYiM1a/sCtcTJZ3Tqti/vtVKzz3t05oZdWKsVKabXFHIPQptdop8 CHfd/0gzOmMbt3nbVJpI+0Ke2JF9Lz00B0RM5Plmz9N8gzROn X-Received: by 2002:a5d:550e:0:b0:354:df32:69da with SMTP id ffacd0b85a97d-35dc7e3e081mr10030732f8f.14.1717404912088; Mon, 03 Jun 2024 01:55:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJI2yOCxoWj4bqoc0cm7olNxtaofZfFRKHUqFZYjLVm8Rqfyh6b/mBu+TEbiy2PXCmYdWVQA== X-Received: by 2002:a5d:550e:0:b0:354:df32:69da with SMTP id ffacd0b85a97d-35dc7e3e081mr10030713f8f.14.1717404911611; Mon, 03 Jun 2024 01:55:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c731:3d00:918f:ce94:4280:80f0? (p200300cbc7313d00918fce94428080f0.dip0.t-ipconnect.de. [2003:cb:c731:3d00:918f:ce94:4280:80f0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd062fe96sm8127125f8f.67.2024.06.03.01.55.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 01:55:11 -0700 (PDT) Message-ID: <8297c4d3-f97b-4923-9b27-19294fa130eb@redhat.com> Date: Mon, 3 Jun 2024 10:55:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: increase totalram_pages on freeing to buddy system To: Wei Yang Cc: rppt@kernel.org, akpm@linux-foundation.org, osalvador@suse.de, linux-mm@kvack.org References: <20240601133402.2675-1-richard.weiyang@gmail.com> <0316a276-a0d8-4fc2-ad67-0d4732b6d89b@redhat.com> <20240602005820.2uk23ot4mskfl5sl@master> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240602005820.2uk23ot4mskfl5sl@master> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8C7CEA0003 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: mi6zw59xoca4un9pdhtn3pbmgtg5ka7b X-HE-Tag: 1717404915-100458 X-HE-Meta: U2FsdGVkX1+UuDOK/GeJsf4PTrpqyOAJo6igJmgEHNWTH9Rb4PyeJ1eIE3RjZK/hsuVQcE0f/GW1CWsOi9pWjAPoheKHZWCi5ESyuU6Ee6wOUnDUqY/9s5p12cMsZiKJUqN4aCCMwqQ9a+K35kGnYx7fZHW+pZ7RsUp8YXbhZJYQSfjkexAPQR/3ur8TEeu741Lugl45gsSVQMcXIkHONYP0VQXNRWBJ1jtCYp5FFYmGiaC3VptlC8SXg3NMq8+mNlQB8zHOjyYQdYuXZH9Pg7qfOnTImegzVBr1Ky5HEIgKHamPL0CpmwsqeWNf78iKpvgHTPRB0pWW3LQZ7J++YSn/ZAJ1B/x8FSSPDR3/NsnLPpirzE40zY9NX16CFCYl7AaZnaP3tLyUWhqr4iFjFJj/l/ofBw2uY8hCReUcwNhnwHXHddlHHwpuuy/QD8HNJw8TzmhtrSFuLeW5hNPpTpu+HLCXIGfxGC4Uq4+foa9d7jVp8eXLTA3Qw83lVv4LDx4HWOZpSX8y3qP8xHgPKTtxnA1hWzbGmVOeHzcQHyGztRdmUap/5Uckbjwli5KQzrhpQqzusufEyjIKV8M47QhyUSbc2ECrZm1UuGOAhCK6SP9wUxmoOcCGa5FOeATnueh4VECQXycX2KKq7FeG9EG8x+FHvdRM2trqXGqnVWq5N3fhChhReLjV1YRbGuOjtf8iIluM+t+xzRGP+JBC8xwubkzAZvCe+F8HihRBihIWUq7hXO0VarZdocO5LsACYQqTJqO82kamJXIQyF6m8ruElLVQO5rZCRmh8W4S+1VOZ97/Yb1AaKZv4o+80f2gn8U0Bw4v9tohkZVb/ruiPSR2EOKdaiNMmaaxIITYri0MRUj8r+XnJ93FTQUcnzNQW5z0Z2EclE3B39n80QU1r21k4tgrhCa5hLNVzu/9J43V8mLQ3ViHQTWhwM3INJJcBOZuU7gJsi4wU0Frpud nM9U4AdE Ql0s6txsnKkIlAdmWLoozH8/RMlF1R9uaxS+18Ln4bxDUkVQhshhEpORFC75NDYcX5R533Rx8dOGTwOX3i7HK17ODvPnDUps8QPI6kXkT7wDMxaj6Rh1OJlDPOfgFVjT1SxJdjKg/t6NHWiV0AjmeJiQzgtd8nMGvlhEBlBKfMUjQSBNs3GzqMr/s08RC9P6fsJzNEAjCnnXFsJ/r0UFFIAg0TElGRYVaFFO01vwdcLwGchCUZYTYmNI4kG1tF9JT7DWT6/yE3WYoTTX5hqlyZYWJzOQcSNhDBlOsiDkS/Q5HfDpfzzCm8EjOOg79vh3GJzLZud/1lALL6qnzE26bLjvsxp5ierCoAPoZVVHQp/YdLwSoHXdrXzmHv78Hs5R3oCj8ILI3/SjYYEwOd+A2aN8sma5pYwpUSC3kadwPmaG2rqLCUZ0YlA3IiBCp1e9W3P9sdEtuYYrEJheNqgBlvItHXp4Eqck24m1XWQP2YPy8Vwk2UbOzo3pZA8taL1A0R6JlJlGGfHKGtGrP2hxym8z2LIpqjN5AbmyI1gaqCw52heuS1K3uAaASW2Qn+VLM+UBNBH/LsAh4v58= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.06.24 02:58, Wei Yang wrote: > On Sat, Jun 01, 2024 at 06:15:33PM +0200, David Hildenbrand wrote: >> On 01.06.24 17:32, David Hildenbrand wrote: >>> On 01.06.24 15:34, Wei Yang wrote: >>>> Total memory represents pages managed by buddy system. >>> >>> No, that's managed pages. >>> >>>> After the >>>> introduction of DEFERRED_STRUCT_PAGE_INIT, it may count the pages before >>>> being managed. >>>> >>> >>> I recall one reason that is done, so other subsystem know the total >>> memory size even before deferred init is done. >>> >>>> free_low_memory_core_early() returns number of pages for all free pages, >>>> even at this moment only early initialized pages are freed to buddy >>>> system. This means the total memory at this moment is not correct. >>>> >>>> Let's increase it when pages are freed to buddy system. >>> >>> I'm missing the "why", and the very first sentence of this patch is wrong. >> >> Correction: your statement was correct :) That's why >> adjust_managed_page_count() adjusts that as well. >> >> __free_pages_core() only adjusts managed page count, because it assumes >> totalram has already been adjusted early during boot. >> >> The reason we have this split for now, I think, is because of subsystems that >> call totalram_pages() during init. >> >> So the "why" question remains, because this change has the potential to break >> other stuff. >> > > Thanks, I didn't notice this. I think having your cleanup would be very nice, as I have patches in the works that would benefit from being able to move the totalram update from memory hotplug code to __free_pages_core(). We'd have to make sure that no code relies on totalram being sane/fixed during boot for the initial memory. I think right now we might have such code. Further, we currently require only a single atomic RMW instruction to adjust totalram during boot, moving it to __free_pages_core() would imply more atomics: but usually only one per MAX_ORDER page, so I doubt this would make a big difference. -- Cheers, David / dhildenb