From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D6BC5B555 for ; Mon, 2 Jun 2025 21:09:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6F866B0343; Mon, 2 Jun 2025 17:09:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E47926B0344; Mon, 2 Jun 2025 17:09:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D36476B0345; Mon, 2 Jun 2025 17:09:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B5B996B0343 for ; Mon, 2 Jun 2025 17:09:24 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 64C455F782 for ; Mon, 2 Jun 2025 21:09:24 +0000 (UTC) X-FDA: 83511701448.11.FD7B4A8 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2060.outbound.protection.outlook.com [40.107.94.60]) by imf12.hostedemail.com (Postfix) with ESMTP id 6870B4000E for ; Mon, 2 Jun 2025 21:09:21 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=RBNJU+eo; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf12.hostedemail.com: domain of ziy@nvidia.com designates 40.107.94.60 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748898561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wu7yHOSr5LQw1ISgD/r1sleXDkRYzbDvhbACmVhfh78=; b=ww6uQZ/BL3B5IfZYjfDq5NaMite6d/5PFnyZpZlBmWaTeGj13H5235Yl9NdHBCyIIjcmQ2 +p0cAsvd6OPwAgpthYhh5k4/5lJq82pShp0vsQs7MeLh15hVCTi1J9CsEoh+F2dlSfllhL 2+f0tsS+a2KT4NkbOrqOMGOl4mzFRzI= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1748898561; a=rsa-sha256; cv=pass; b=JpgA1kYK3nJrayoYXHoSVq2wzufFbhwS+Sa0thX/5aVFF0ICS8qyOgRSPNvOtE4SFymG47 X7IckhyJ+1hVey3ItBSzsRCcciX5QTp14X+0YfSQFSUgIa9yzWMnOcyynSh8lZcB0wgeUe oplps7SyIF1HoxWBFgDF51dVi4O4K2E= ARC-Authentication-Results: i=2; imf12.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=RBNJU+eo; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf12.hostedemail.com: domain of ziy@nvidia.com designates 40.107.94.60 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sBtGvJHonxUXHUUILmB0vS083rsz/yE75r1BCqhewCOVyK5GD6jcAjTC1EGgiOcLkooD8ww91H7GAIwPQJYT2CGhNO9gdgLFM5RTgfz6B/1n7HR1AcyN/100nXo824Q68CfnNMUrTE9GvhqgR6SIsilZ9+rLpDCUMiuRSNnnZTGuewvmeVj9pBZ22xWyuzNKepY27L0LU+JPSrpBvTSKHz0A6dOoRYFsVXMbPwF+/qlk+u3QsNGcX0bkT5CKOWXq3AWkwJtu0ACprPqOg6oJKvlq+CQp8Kp+srtt4ZWL3mMt2DOATEPCiWejRy5IdHqMA3lmt+N62z+HJsXVicCwTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wu7yHOSr5LQw1ISgD/r1sleXDkRYzbDvhbACmVhfh78=; b=Vf2wRzSFoXX047TllfbwbFeD56lVutB2ttzP/nXdjEvHThQfNo/NPnlwu/G37+YjKkaQbxfD6ARrhXfMfhTnPlSwLJNIVp31F7Xn6GeG4PSPgr6ndQhw0A+Zhmz1uTr9GO77dTL/0s7CeUiHPtqtKWoRj5IDoQ1uDo5sHqY5hdHG+d0vgTQB33d52gH9MDOapn9SsxnUFOu0Le37p0v8I2jPBFVpY6Qio+ZfLLhFtFCiM9AGzdFZzHrWfssxW2gBNKvGn8aUsECWfzMoq6NDE1mmA0dxWyzbJE8imxfj37RavVmXiR/jMFzmVQPPFXDMwUWhHxe2oXpaK0R2WvD9BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wu7yHOSr5LQw1ISgD/r1sleXDkRYzbDvhbACmVhfh78=; b=RBNJU+eoXif1EkG3ILDGedfxPqq2V76kJNDOUkK1xqwGTWxYO3tHVo7+g6an2XgoGPZAMq8ZVNLrEqnz0tSriK43oynv/Om9bhgQgja56SOkbh3zkMYOP8lT3KkNNEng9LgE6yM5LTqE11IdW7g4qOl/20LwwSSonbQOhumeLNTUEPPWcQKCJRugXw+dZZMerUrqQ42jLctFniFTgS6tWiKqNQWGWsQAswJgFLSz+VZvJdpo0WJOEgpAuByUsGVaGLv1obuW3ccDMLi+omS2AptnxHP7MBVXUFhtoEgfRjO8UwlU/WvYtb8fSrfDWW2DlY91GJjsxHO4dHw5oHkw8g== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by IA1PR12MB7518.namprd12.prod.outlook.com (2603:10b6:208:419::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.31; Mon, 2 Jun 2025 21:09:17 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8792.034; Mon, 2 Jun 2025 21:09:17 +0000 From: Zi Yan To: David Hildenbrand Cc: Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org, Andrew Morton , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 6/6] mm/page_isolation: remove migratetype parameter from more functions. Date: Mon, 02 Jun 2025 17:09:15 -0400 X-Mailer: MailMate (2.0r6255) Message-ID: <8297D7ED-2220-469A-922D-98C5E5B7671C@nvidia.com> In-Reply-To: <1f1f1d26-5bbf-498a-b6af-0fb51fb3d50f@redhat.com> References: <20250602151807.987731-1-ziy@nvidia.com> <20250602151807.987731-7-ziy@nvidia.com> <7BD9FB05-4125-4EA8-841D-9D08907D01D5@nvidia.com> <1f1f1d26-5bbf-498a-b6af-0fb51fb3d50f@redhat.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0P220CA0027.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:52e::8) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|IA1PR12MB7518:EE_ X-MS-Office365-Filtering-Correlation-Id: 8bb89757-67e7-4cf0-0aa2-08dda219bc5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?H54Nfydn29Ws8B5batz6Ff77uD0DHm70LWb5GnompnM59L3D6tXBcPldKuxq?= =?us-ascii?Q?Nt8w7JTuIajHak1GyKGrNXupAXfWuwxLRWclR3lHHT9ja22/eAc487gg5Pb/?= =?us-ascii?Q?+gpcUeaMwXBqWJuy90Cb2V5RbtM+oR3pVfuVpOg3B7hUXuuZ6CAdkdSb3Zic?= =?us-ascii?Q?coObnjDN5U6Pxf6VAqloAGxEqd9ohlPlVNpQYFppR4bplQgneldqh6CE/eMS?= =?us-ascii?Q?LMGP2EdwerfmNqDKoZSc7n2c0RCwTUsdWLwhV36x23ykQ3AkLdwIORyttH1L?= =?us-ascii?Q?qWJHQc5wtR/hMViiyybwCUM4dq07XGWqBdVb4A8oQEYk6IFopG98OU2t4oAo?= =?us-ascii?Q?/Ags7TLR23Lp0kKiyLuZLpnGA8hzhEpKJ8n1Om3eLfaUNYINCA8aDTnfRweX?= =?us-ascii?Q?fglIawst0mbzlBAx/j6NSdzNfON0wyIpSjjZ4X0ag2ou3jp116BT4jGoWW5A?= =?us-ascii?Q?IFjUS1aWbDPzHmXVIqMcsWLK9iUndXJWEdKzaaBOVRvcO22nWvCKkGYK4kfw?= =?us-ascii?Q?QOTDUiko3LSyfCPeMe4h9dl++IG+klvzVMi2j/7XMQfxGwSRf3gxEqNtds+l?= =?us-ascii?Q?o4p9tuygEa6rjRhSvAajoGnlzpdKhQKyctnKcY7ZWjr0pzzW/YHyNpb5H1O+?= =?us-ascii?Q?ktg/d9jRAQ5nE2cYiEYOJl331EWjY88fTwgJgZ0T7PTyn+PWIpykGlAPM02j?= =?us-ascii?Q?jwbDdHjVfl31nfSBjEhuG40pa0BHVrPVG4okWEolyv+FUfzDWjxVp2hgR9rn?= =?us-ascii?Q?o31EvWSuGAxfXQ8eMfqp+mj06aTIAe77S/XW7IxtVN7qyeoPJy046s/EP7xK?= =?us-ascii?Q?4bHp0lZiQAp44+8G7+fcPtKe/feaZdjpa97rDEI+0qeHxBisf1RqneDl08mR?= =?us-ascii?Q?bcLzMhb16QSCQOiThJRjIfRZrX8cc47V6IPMK9dtkM2OCCknw11lhPhzR7G5?= =?us-ascii?Q?nYGvrtlpGgjFFMCyfLXiBiQEKeiSybPgmY0z5ZPyvJvCf5vGRyGfUy00WAgT?= =?us-ascii?Q?P2Umc5HVe4p8Wq/kb7vWqB1+64WvHccunbhKlK+7larkmf65OX9PFVjciOHo?= =?us-ascii?Q?5ES3C2um1OtL/7qEf30kY6VQPwIuz6aREAmz1iHaswOtxGbzsbV3wYKqQ1r/?= =?us-ascii?Q?zcleSzM3q2MNlwhCmK4kJMLR8BUyI8tP/K0kWS8JL5T+I/G8sSoY7DOLw+Mc?= =?us-ascii?Q?RH3rk+LQY6gc9ZYSxyACgs0qgWKO9rWF3C9Yqwtud7FkTY+tbscnzh1ot+Rc?= =?us-ascii?Q?Ylk076c2pWrR0xlpq+Kc5/Vc9pYyA4kDNQjOnf00PfIpt3WkPKcLk1u02cnu?= =?us-ascii?Q?FQgsIBaF51S27Ck8MJWQny1h1lD21BiYZaz+eqW0IBpqHmuEd9juTQTlh+8j?= =?us-ascii?Q?27lZD9AI7XAFiT2HNH1hiJgMnY1DZmplgr8HwEa9DilyVnK3pcilA+fvyiRc?= =?us-ascii?Q?VNfqtNjqmwo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k2CeIjYYTZaD422un0X7ABOwhIPRsZQpIsI3Aq5xWW/vLUTjap7Z8ehx9qUf?= =?us-ascii?Q?J1fsD5v7VZVdnA8x81FxWB20HIAcjjCy3KXdUb6PNof5jh3YO1yDeuMiqhOC?= =?us-ascii?Q?6YgzY5DMxXdUV+Qy4wDwL9FBj6LSxZeJ+B0AlTrQhB7WzFw4AAhr3qZKreA5?= =?us-ascii?Q?LBQMVCtVVQwaM+ZJaeM9jDKIYbXNEoFD79si6fXWDxgQfFzErKI3WR0K2Qun?= =?us-ascii?Q?HhYSoau4XCo2AxlDOZAkzZFKBKc0D/PnFc1l4lGbjYv4tG29am7MFc9pc3lE?= =?us-ascii?Q?Bus24gmpOCqgJ2lrlVoymlFL0gyQmtMtIyCDu2SMzEbzEe2pvLigGvc9SW/e?= =?us-ascii?Q?5M71jwHyR7cjGH9yOnxW50cXDXK3QAVMu10v/5SePVdOqVmk1S5GP8s67S3M?= =?us-ascii?Q?sqA1MrFUSZsN1M/xGAHrPumZoh60BhJosTvJ3fj7El+1R3PstFG8+rxNlCmN?= =?us-ascii?Q?FV92IS3bRVK6IZIE6LLxv2yUFTk9EAEx1/JXAXjCZUtez1NNg565EEJ5vwRB?= =?us-ascii?Q?po3sSIoBbJY8HzN2MF+JLUElfrIe0JI7trVjM2bVKzzGyTHQJoe4+m9Zi7rD?= =?us-ascii?Q?pFdGdn9HxpvXsJX7k18SBhwI/dUoxAPKwmS8a1ux3ERNgF0iGgorLEjezWx1?= =?us-ascii?Q?I5raLd/xnpf3H7UdjDKMXTkM/J5DbMy3eHdcWn8HXazpmg+OHrhM0iI676RI?= =?us-ascii?Q?EeEWPhU/mA4tg5/Xn/OCpDhMF67NLWigD0v/rj/AOLp+EVH10amv0Dx/+eEX?= =?us-ascii?Q?SZ7GRjVywF6Rz5myxOkM/MtJyhv38+oGj+J2m18BDVNysc97Klyx/EP11ITW?= =?us-ascii?Q?AfjXokTS3hQFJ62ijyOUE9JX2rGD/H3ySFkI4vQDQfR2K5L8wNzmd3kzBKeo?= =?us-ascii?Q?0Mv0NNgF7iqzc+EGFc6REoFuvud59O8UArOgVpjd5uyeX30wLg/bno1z4PTk?= =?us-ascii?Q?kNf+DLZoXLW1ef8Ocg4uY6f+3A9KvD17A06Oaws7fYIGmmfqVqeLj1a56u4j?= =?us-ascii?Q?j8UZ4bvWlrCsgPA88jJQZgVnlP2uhAWLV2XbaL/XTx1juYOpvacg0Kt2sldJ?= =?us-ascii?Q?hqVeEiWhG9BvCqHDAhM54dteBf7TkrYisaTuRM2hqYDXMWOC+9DOMXFwQPH2?= =?us-ascii?Q?IIkHzKt1VojGOGgSrjjD/7y3gAd5w9FEO9WIjpZCElnM4N/d16cdE0zNAZHa?= =?us-ascii?Q?ioGMx+9nwD1V7NEdTkGkkaMvtUAPKLYbVXh3tRnp9n6bqNInuwuWgzIghdF3?= =?us-ascii?Q?7B97M0uKL9o3T1dEgYcpe7xSFlPu0wUUz+/7TBl+ziuwmsz5sgPi8rLhiA1P?= =?us-ascii?Q?7rroZcIkvm1TyoPleiXy4sCVW0IR1PzEp2dLqn7mNyrvfWusV4zhFnyH35lP?= =?us-ascii?Q?E0ooGhflKOU2fEbZoUwbs2qArPQwCFkhKZND/GOxU/A8k+1ZFylNQatdGczY?= =?us-ascii?Q?W0L5CK4+7D9xQsOfruf3tpnaBrhsoLWPxfIaHfEhU6YOrK5/ju62+JODiT+u?= =?us-ascii?Q?Sqs+3nPyk1U8X2nzUqwZXxnKOAJwko4oycy35CqaZdZ+GUNULNG4/V48pC+f?= =?us-ascii?Q?1xfqhhn20noRZmLa/ze6KE3KsDvJXRfPp9MXpibP?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8bb89757-67e7-4cf0-0aa2-08dda219bc5b X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2025 21:09:17.5796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: czENkcwYX6i0ZPE215IHxxwyAI6ajV0XgAeJi5BrDtJvRcQz/a598NiZeMSfbSw6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7518 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6870B4000E X-Stat-Signature: yjch7qr18ky1jjs9ywdjsxa8gwztbtmd X-Rspam-User: X-HE-Tag: 1748898561-951802 X-HE-Meta: U2FsdGVkX19dMgvt4JOf+wDsvELcyWTG8V2T2Uog/REsxahnssavpokS+CrmsNLnVv6WR5Zze5hOtrYtbFNrnwjU9tBUOteTjWSrofbOj4Aye0Y/1+yxUxa0aQud9N19b+xOzEqDUbrZrVI0bxP/abYiYRFXtM/5lpD4zSzf7epdomFmw2IKjoBf18WZ7uqzYW0lLi2zMTvIIUT3waLyZlLPTXWLmPmNlktIsY85zlMKebp7Yh6pihs7o1buXI5zMHeA+KDA278ruz0uHs/JGz5h7XCv6XMGuy6vTRry+A4MxYhw9qhEo/sLcdEV4J5KnkJhxxJ9zmnlf6jen+2NULPMGf/Xtqd1H+ky1IkgfYd/ORUdmlXcW+dX5NpLrjHOR0LyqPuB3sQMKBitAA3IgIMdu89XAZjYVXm098A830gySUdYWYlJGNP+1BF+tGN9TYkwP8dfG5fEpKQEE+I8tC9H+IvSa7XMyu5vTZxG8Kz+I8DwFfzwbn51592Mj7QRmw2OndchVj0+m+p78ph93w2tq6vwrN9SHqOJMA3FUqFLbZzX661oYVomi/FXDQJn5+V1ReS0SI48bWJ5GVeD5hrrMKh19P59tqzG9PJZBKA/xe6VnnUJvrLtH+7uQ+1VW+6U05cwuaXk5KtH580uB3BO9PZoujdfpTgLhQoOM9vB2yyIBsE5fVPxcbgpRpk5uuEboBRwC5U2BRTnH+1xEF3XTtGmRk8gyvQUob6JtCokvaXjS+K2CHW9Tda9ZKt+EvhfXrkrdo5MGbyGWcEKAwaGWQJcJsXqUuFE7/i2S0UAJthjW/zQ7Ai2GJIqlV60a1Mbscs7P042KpE9OWRO2FpEnvaBBjg3hTu/BHOwY1p+ephFNaJkJDNcJFat0lZC7CUcXUcY4NYir9LSGfo5PL4RAxKrEoPFao12U9/AFBpoCTMWJHbDKUqzytQd+1BWTZfI7VVSj/E03+MAcE3 C/sxL0o9 TBO+R6bPjqdE3Pd+zVaojymebdoyW+kxNCSvw6uOFsdVHEWDH2zmhVvS7TgeSUZGmFE767XPFzpxjxUU2wqNooSHmUjY5Q84Fluqv0W0ral/OrWQzjkQR+E1Dp24XpAOyycPLc5K6FVkJTjwHxd6e/zrAzwcG3rLVQSI6iOsnLsvOq4EHFG7P9yBAfMsfz8QHKMxb1TAT7H2tYtccXugYXh384cGI/X7YKuFxzuowOOXj2fISN5DEBVZHiuOae/VH8GhsUTJNVLb2OwDbYr2GkjhWQ28O6yp7cIVWFWxuLu/9QkRxkP/KeVrjkxsJZcFu/HFyEkKW7epCEWqepfflfMMLHhoCoHiVJPaQB6S6q0WkgtwCMrCXVF3L8R+xrZ8idX3LYhAH1/T25rKNXfKfS3SR6N6heTxqAPl7pfDcxCv0iuxUhkQuD/k9dXIXT6r9zwm6gfP/eFbHpZVSEWkDxGZaWsGuyGmQjxUCuukoqay85F4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2 Jun 2025, at 16:59, David Hildenbrand wrote: > On 02.06.25 18:59, Zi Yan wrote: >> On 2 Jun 2025, at 11:18, Zi Yan wrote: >> >>> migratetype is no longer overwritten during pageblock isolation, >>> start_isolate_page_range(), has_unmovable_pages(), and >>> set_migratetype_isolate() no longer need which migratetype to restore= >>> during isolation failure. >>> >>> For has_unmoable_pages(), it needs to know if the isolation is for CM= A >>> allocation, so adding PB_ISOLATE_MODE_CMA_ALLOC provide the informati= on. >>> At the same time change isolation flags to enum pb_isolate_mode >>> (PB_ISOLATE_MODE_MEM_OFFLINE, PB_ISOLATE_MODE_CMA_ALLOC, >>> PB_ISOLATE_MODE_OTHER). Remove REPORT_FAILURE and check >>> PB_ISOLATE_MODE_MEM_OFFLINE, since only PB_ISOLATE_MODE_MEM_OFFLINE >>> reports isolation failures. >>> >>> alloc_contig_range() no longer needs migratetype. Replace it with >>> PB_ISOLATE_MODE_CMA_ALLOC to tell if an allocation is for CMA. So doe= s >>> __alloc_contig_migrate_range(). >> >> This paragraph should be changed to: >> >> alloc_contig_range() no longer needs migratetype. Replace it with >> a newly defined acr_flags_t to tell if an allocation is for CMA. So do= es >> __alloc_contig_migrate_range(). Add ACR_OTHER (set to 0) to indicate >> other cases. >> >> + >> +typedef unsigned int __bitwise acr_flags_t; >> +#define ACR_OTHER ((__force acr_flags_t)0) // other allocations >> +#define ACR_CMA ((__force acr_flags_t)BIT(0)) // allocate for CMA > > For FPI I called that "FPI_NONE" -- no special request -- and similarly= for RMAP "RMAP_NONE". > > So if ACR_CMA is set, it's a CMA allocation, otherwise just an ordinary= one. > > > Apart from that LGTM. Make sense. Thanks. This is the rename fixup. =46rom ba6ff91746640e5baccbf55a48f9290a04ec1363 Mon Sep 17 00:00:00 2001 From: Zi Yan Date: Mon, 2 Jun 2025 17:05:19 -0400 Subject: [PATCH] rename ACR_OTHER to ACR_NONE. Signed-off-by: Zi Yan --- drivers/virtio/virtio_mem.c | 2 +- include/linux/gfp.h | 2 +- mm/page_alloc.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c index 6bce70b139b2..42ebaafb9591 100644 --- a/drivers/virtio/virtio_mem.c +++ b/drivers/virtio/virtio_mem.c @@ -1243,7 +1243,7 @@ static int virtio_mem_fake_offline(struct virtio_me= m *vm, unsigned long pfn, if (atomic_read(&vm->config_changed)) return -EAGAIN; - rc =3D alloc_contig_range(pfn, pfn + nr_pages, ACR_OTHER, + rc =3D alloc_contig_range(pfn, pfn + nr_pages, ACR_NONE, GFP_KERNEL); if (rc =3D=3D -ENOMEM) /* whoops, out of memory */ diff --git a/include/linux/gfp.h b/include/linux/gfp.h index 95065cec85e5..ccf35cc351ff 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -425,7 +425,7 @@ extern gfp_t vma_thp_gfp_mask(struct vm_area_struct *= vma); #ifdef CONFIG_CONTIG_ALLOC typedef unsigned int __bitwise acr_flags_t; -#define ACR_OTHER ((__force acr_flags_t)0) // other allocations +#define ACR_NONE ((__force acr_flags_t)0) // ordinary allocation request= #define ACR_CMA ((__force acr_flags_t)BIT(0)) // allocate for CMA /* The below functions must be run on a range from a single zone. */ diff --git a/mm/page_alloc.c b/mm/page_alloc.c index c12442fdb579..0867e2b2e187 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6997,7 +6997,7 @@ static int __alloc_contig_pages(unsigned long start= _pfn, { unsigned long end_pfn =3D start_pfn + nr_pages; - return alloc_contig_range_noprof(start_pfn, end_pfn, ACR_OTHER, + return alloc_contig_range_noprof(start_pfn, end_pfn, ACR_NONE, gfp_mask); } -- = 2.47.2 Best Regards, Yan, Zi