From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1193C433FE for ; Wed, 30 Nov 2022 16:39:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 247316B0072; Wed, 30 Nov 2022 11:39:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F7006B0073; Wed, 30 Nov 2022 11:39:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0983A6B0074; Wed, 30 Nov 2022 11:39:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EA7346B0072 for ; Wed, 30 Nov 2022 11:39:55 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AF48EAB8F6 for ; Wed, 30 Nov 2022 16:39:55 +0000 (UTC) X-FDA: 80190670350.20.0BAE674 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id DCB37C000C for ; Wed, 30 Nov 2022 16:39:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669826394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FibScgnLZTZQVJwSPq/5rFupjljThtgCjtutjs0/d8U=; b=e/p1mFqUPLhUr7CPYo4W4ZM/I2dMlsCUoiEnVc50azQg+EVy5hWGA+fMBWMAUtpu2djWWv vbny2HxKaM+pkHezGuTWgIiJnlD8Yr9e/CQnLKrqqrhqGv4Hsbz4MEUMRRxyfs3YDwA9JP t79dkWPPCtjLSDsSZ4kx8FKFOAelhXw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-526-x3h9R127PGqmicDtGBDXkg-1; Wed, 30 Nov 2022 11:39:53 -0500 X-MC-Unique: x3h9R127PGqmicDtGBDXkg-1 Received: by mail-wm1-f72.google.com with SMTP id m14-20020a7bcb8e000000b003cfcff0057eso812832wmi.9 for ; Wed, 30 Nov 2022 08:39:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FibScgnLZTZQVJwSPq/5rFupjljThtgCjtutjs0/d8U=; b=JkaIGVeSIpV05Od4gPIwnbxRhXDI1kFPo4pIJX55f3d+ZNdjWw19/QSznLXbnDnCH3 L0Y8v9vm5aVW9JzDXPjiqQEr8jW+SyA8OgG5CeYDizNK3AvGZ28gDUwNS59WuxfYyWhF eZztl1/vfQR7SX5NpoNuAYBElOG8a3A98Ln4esAqy/AjqlWrC2NGOfOz6N6tENWIFPUy Z+xQ6pK59CNzdChDs5lWCagPQYywWY71i+Mv2oL1Ggh9FQrARv8F8J5c49eMF8K9R/Vh Y4lUvQBQ8uXYEwAZfLbwh8A2Y29dr4iJJyDMDK5qZsfTZh/BdwBM05BDovteYVY/g+Xx BGLA== X-Gm-Message-State: ANoB5plTxOhls993GCrraCWfrx3rBkNuJeE7Y6arR7SVKpYWFw1QA6Qu CZXm1p3h2NNiJcIZMDyGM4gpGgvk4Et07pCbOlH0+7PIyWt2VXHIedXb3YfIizdO1Pvxf17L9vB 2Gd8CGz4SidM= X-Received: by 2002:a05:600c:3495:b0:3cf:ae53:918f with SMTP id a21-20020a05600c349500b003cfae53918fmr34347027wmq.131.1669826391940; Wed, 30 Nov 2022 08:39:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf4IzXvotDDH3ARJouInxJxra3FD5+ga8g8sHGirbSriZuhOGHjtFxK+lAN+vFsR8EswaedPnA== X-Received: by 2002:a05:600c:3495:b0:3cf:ae53:918f with SMTP id a21-20020a05600c349500b003cfae53918fmr34347013wmq.131.1669826391634; Wed, 30 Nov 2022 08:39:51 -0800 (PST) Received: from ?IPV6:2003:cb:c703:7600:a8ea:29ce:7ee3:dd41? (p200300cbc7037600a8ea29ce7ee3dd41.dip0.t-ipconnect.de. [2003:cb:c703:7600:a8ea:29ce:7ee3:dd41]) by smtp.gmail.com with ESMTPSA id u11-20020a5d6acb000000b00241c4bd6c09sm2060024wrw.33.2022.11.30.08.39.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 08:39:51 -0800 (PST) Message-ID: <8290e578-9eaa-5859-6309-e62634b66fb5@redhat.com> Date: Wed, 30 Nov 2022 17:39:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 09/10] mm/hugetlb: Make page_vma_mapped_walk() safe to pmd unshare To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , Jann Horn , Andrew Morton , Andrea Arcangeli , Rik van Riel , Nadav Amit , Miaohe Lin , Muchun Song , Mike Kravetz References: <20221129193526.3588187-1-peterx@redhat.com> <20221129193526.3588187-10-peterx@redhat.com> <65a3a912-3534-6718-2c55-e0d4b5246f1e@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669826395; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FibScgnLZTZQVJwSPq/5rFupjljThtgCjtutjs0/d8U=; b=C7g6+RZe2NJ3CYjJYFAmrmBhEQrHk+vk2zRUnjKaTdS3qy4pd/UkWUYohMApg00eYcCCXf Jao3WF7lwoheYxBdfkuBv95u+7riRUbseCKHiCdQHfJMYj6Tjze1jXQ93H0+3Aeg4ANBdc eGJRRQJ/Hc+Hns7G0LAXkBNskZCx4Uk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e/p1mFqU"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669826395; a=rsa-sha256; cv=none; b=AXyu3FHdhsMYcd6Z1CENGi9hIxllt6LgBwXEe6twjiM5r8Yv8PRsO0SoAWltZmfkqcqITi VlusfD/v8grWpQgikXz3n0zNCb6L2lUFpzKQHVdabX5Yds6k9FS7pUkOedtUWm1TuNDO9H /vZJBIEJHyTGEMfrtGOie2r8uk60iT8= X-Stat-Signature: h7t1etd6kpqkfh76wcmbpbs6wfbsxi3s X-Rspamd-Queue-Id: DCB37C000C Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="e/p1mFqU"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1669826394-360646 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 30.11.22 17:32, Peter Xu wrote: > On Wed, Nov 30, 2022 at 05:18:45PM +0100, David Hildenbrand wrote: >> On 29.11.22 20:35, Peter Xu wrote: >>> Since page_vma_mapped_walk() walks the pgtable, it needs the vma lock >>> to make sure the pgtable page will not be freed concurrently. >>> >>> Signed-off-by: Peter Xu >>> --- >>> include/linux/rmap.h | 4 ++++ >>> mm/page_vma_mapped.c | 5 ++++- >>> 2 files changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/linux/rmap.h b/include/linux/rmap.h >>> index bd3504d11b15..a50d18bb86aa 100644 >>> --- a/include/linux/rmap.h >>> +++ b/include/linux/rmap.h >>> @@ -13,6 +13,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> /* >>> * The anon_vma heads a list of private "related" vmas, to scan if >>> @@ -408,6 +409,9 @@ static inline void page_vma_mapped_walk_done(struct page_vma_mapped_walk *pvmw) >>> pte_unmap(pvmw->pte); >>> if (pvmw->ptl) >>> spin_unlock(pvmw->ptl); >>> + /* This needs to be after unlock of the spinlock */ >>> + if (is_vm_hugetlb_page(pvmw->vma)) >>> + hugetlb_vma_unlock_read(pvmw->vma); >>> } >>> bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw); >>> diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c >>> index 93e13fc17d3c..f94ec78b54ff 100644 >>> --- a/mm/page_vma_mapped.c >>> +++ b/mm/page_vma_mapped.c >>> @@ -169,10 +169,13 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) >>> if (pvmw->pte) >>> return not_found(pvmw); >>> + hugetlb_vma_lock_read(vma); >>> /* when pud is not present, pte will be NULL */ >>> pvmw->pte = huge_pte_offset(mm, pvmw->address, size); >>> - if (!pvmw->pte) >>> + if (!pvmw->pte) { >>> + hugetlb_vma_unlock_read(vma); >>> return false; >>> + } >>> pvmw->ptl = huge_pte_lock(hstate, mm, pvmw->pte); >>> if (!check_pte(pvmw)) >> >> Looking at code like mm/damon/paddr.c:__damon_pa_mkold() and reading the >> doc of page_vma_mapped_walk(), this might be broken. >> >> Can't we get page_vma_mapped_walk() called multiple times? > > Yes it normally can, but not for hugetlbfs? Feel free to check: > > if (unlikely(is_vm_hugetlb_page(vma))) { > ... > /* The only possible mapping was handled on last iteration */ > if (pvmw->pte) > return not_found(pvmw); > } Ah, I see, thanks. Acked-by: David Hildenbrand -- Thanks, David / dhildenb