From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D615FC54E76 for ; Thu, 16 Nov 2023 23:10:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EBBC280014; Thu, 16 Nov 2023 18:10:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59CE8280011; Thu, 16 Nov 2023 18:10:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 416DC280014; Thu, 16 Nov 2023 18:10:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 31B19280011 for ; Thu, 16 Nov 2023 18:10:39 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F283AC0D0C for ; Thu, 16 Nov 2023 23:10:38 +0000 (UTC) X-FDA: 81465363756.08.549B4FE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id C1C8D4001D for ; Thu, 16 Nov 2023 23:10:36 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IYEaS4wW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700176236; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vsRuG6AZDvK4gWcMyoVnW7/GiXUT/qiRajyImbex+2A=; b=qrpSZgk6JO7+b3uEv1IOocn8nshiuVL3cvWlk5caq9/+9Qhf39/M0ggBCfXJHFqqCGiB+7 e5VNQIqKz9u8wRmecRlDbZQfc0xCjH0VWzUVutuuiyiKg53mlDDu06r9m9OCxBkDaIIdxa oVTrzvI5tVHkPB4Cjrwm/e0zrMnSFYs= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IYEaS4wW; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700176236; a=rsa-sha256; cv=none; b=N8T1t0FEmPR7Ur/yNpmJeUCWFu98GLOHdTavAJtQAMPEs85CgXBrOfc8SmxeY/KaQCNWlw CMBiXu3HCsYS3DgOtal13AEhCtbfGN8kmYJpxLlQk5E8DlDIuBbjFrwxD+mRSAj7X5PjXp 2OMXcexP/aW6+rQ5XWGPjFNd6tqNa3E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700176236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vsRuG6AZDvK4gWcMyoVnW7/GiXUT/qiRajyImbex+2A=; b=IYEaS4wWCj5h0u+E6Rh4PKRb32mj0/JFiXCPLb//taSMi9fTmDJY1Z0x//J0/W836ad+fL 7Ow/qfNNJkSSdo+oLNkQrZ0aiAcovsr7dpnSG3zxLmC2u76gLYlOIT+zXqD8YVOae+yTIO 4vo/OtVhN2dv+Ees3TpJDIHLHaonOHs= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-NVCufmfzMwaFAKoDkdP_Vw-1; Thu, 16 Nov 2023 18:10:34 -0500 X-MC-Unique: NVCufmfzMwaFAKoDkdP_Vw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-32d9602824dso698018f8f.2 for ; Thu, 16 Nov 2023 15:10:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700176233; x=1700781033; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vsRuG6AZDvK4gWcMyoVnW7/GiXUT/qiRajyImbex+2A=; b=KAlfBe8TT7PPPTUqSg/6uZFuavFPW3e6fxLyNM13XydjY2rjx7cQdHvmyXkKBtjKLM 1EQ6ZZ9uSdaPb71tfvvwMApqOc3q9W/kVfrAumHK0FY02d02H0lnPeaIs/8D+bWr7f9F YYH3rOIfZW7zOUzus0VSEINV6o6bKz45H6O8YWrr/6ZiX6eriDIiTUkoPS8m2LH/rwj1 nrZ21YiuJjES1S78zp3Al6M15NoiNY+PxmiPaXYyKgbdvKAdzkKkJ1LeoETwIZjZNL0e 0yDrTD9QTShUcCbeYuQymdYuT7Z0cMBli281tv+c11QYouBqHDnbNUuI80INHnbzW/ye Bjhg== X-Gm-Message-State: AOJu0YzMXaV8eEOi3BVvr5u6fvSg9a5a6SCmDxGbf+xSv5vsWoNcoAlS 8dYFVXw+GDSSbX4pf30BA2JX9r23auOZls/fmNM2ycauFEqT5BSVKSyzkLOhdM/77xzZs47WiIT CJa7T6rc8FGg= X-Received: by 2002:a05:6000:1884:b0:32d:9755:44f1 with SMTP id a4-20020a056000188400b0032d975544f1mr14474784wri.32.1700176233647; Thu, 16 Nov 2023 15:10:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IELl3t8eiBv9s3Q7oGal+cSI9uZA3D9LbBDlaqJ+zo8ZHJCN8ByWB28vEeghB6VnL6KlDdYNA== X-Received: by 2002:a05:6000:1884:b0:32d:9755:44f1 with SMTP id a4-20020a056000188400b0032d975544f1mr14474770wri.32.1700176233281; Thu, 16 Nov 2023 15:10:33 -0800 (PST) Received: from ?IPV6:2003:cb:c714:e000:d929:2324:97c7:112c? (p200300cbc714e000d929232497c7112c.dip0.t-ipconnect.de. [2003:cb:c714:e000:d929:2324:97c7:112c]) by smtp.gmail.com with ESMTPSA id d5-20020adfef85000000b0032fb46812c2sm573718wro.12.2023.11.16.15.10.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Nov 2023 15:10:32 -0800 (PST) Message-ID: <8287fb3a-11e7-44fa-b0d9-72ab5eee1fd9@redhat.com> Date: Fri, 17 Nov 2023 00:10:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm/pagemap: Fix wr-protect even if PM_SCAN_WP_MATCHING not set To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Muhammad Usama Anjum , Andrew Morton , Andrei Vagin , syzbot+7ca4b2719dc742b8d0a4@syzkaller.appspotmail.com References: <20231116201547.536857-1-peterx@redhat.com> <20231116201547.536857-3-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231116201547.536857-3-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C1C8D4001D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: m7cafk5an1ww4745c94pxkmhtb7cj9oa X-HE-Tag: 1700176236-722586 X-HE-Meta: U2FsdGVkX199zjFYvcqJr+vMLn0QjEvgpvvPXkfsd++1tHMQVAqC/jga1VEIDsV5DZH3E1GnH3m7dOE5er8CoBgEHlCOq7/06B///E9ScM1Tckn16YPaoJM+KclnQ4gMVig9sMQp4cj9IqQimzoCCwIX0Apk3UlfZ3Y5UCxSt1TiGoMzhbrYP5I7lA8H4v9cDC/UT931y5OEygMJESWp0jxz+8NTjSlCOHOUYZLzGY/s+4o8Vr7Q3dCglrpT8HkahBmjLdd8+yhdvbC0Wjw8cf0xmCkHmorYOByWBaLH8GUThrO2GqlMle+BX9kOmn2pHd+DYIcSh7Vp8eeSAgVcnl8v8hr8KQwpH6r6Nu5Vo086BLA3aMs2PM4YBCJstmB0CDPMqicGwtik21SIktMZLtFIx/SMowvK6KYWTAbeIudeoRyxj75GKvElbZQ/4W+fKETdOQAoUV5vaQpNr15c2sllC2VS3gz1aGUNELMFP6Ae0b/hc6VjLFr1LB+ZL/K3pOTydM9LWUkdoD7Yiw76/8LHDCUxiKKg8EiIwjmTaVOdh28YjjzAVg4mo+4RP6MgwQx6qMn0J9UQl30yMhgoMMLHEebZFhWDDqkMdKZAkIUGZJfjUWhko4elIa2BmR0TQvNDStrQCBoXhCCj4NAnUStdiUg4MH4AqbcD7VI/lTM1x+tWO87AQqEPxYI9V6rGUJr9OwgV7+wtFkzPXXXQHcBsdq60Vigzwbhj0Z13NRteeM+RLmj7yEO+L82OP+0uoD3IToW5vnmBI3gzg9eZkxMHbXJHGSt5ZNdfffj8BwQQca8jSm2oi+s7DJJn57fGOBggRbACDN0dOzTnAmhCK/2GTpeps71yRO8fRKupOMszYKIzmbgO8Tyq9V1lwxc8Dqad9BXFg1DxjbA/bzlCS0gN393Z2y2H0LXktn+J+Lv5NP0MXCBETwym0BXq143NBEqP5jOIuQhuYiGTDxW GXmCFVQ4 PUUEiZRCmzrajFBY3XjoIjPv4X/p6Tmub4ClyE/Q58Va+uZSyH3pvIHm4ykmKt18gGcAE5sErbNfrFPi/Ts3g9A3zoWaNpfcILOm9Jo1AhayxUuCd0hMXPspu6xLda7LD3go53XIzmkS1jgz92sXV0KzoxZ4FX4TswjTKnVBLkATlZVhI04kyXOtWtAzz84TVxkWVxYbnesUcvc61Pu1HRoQrO2/kkYDG9X0jbcco+381AWcUiFwoyZQDCcNo4C854OqtWGS0lPKZgixfUruK0QJfbix8T2TBhuwX8jSK1IVCcROnYmt/9U4ncCqzdpGhk9WxMZ+J8m70QSFhxGmyHNTHJZQBQ0xg9ChrpKSDMVKzrCaY84Ac7HwKa+eaPageQjb/1d4AvM2P9ZadG6b2MfMGl8ADTiNvV1ThkA1yTcrWcfrMfQlw3ybJIugLXzP0kGOjhB74nna4xdxPNyYmO8hEiJtU4a0MRfPbm/UgXri8fI76hNIb+pKpGB2Olfcech/9RoYUaEXEfmRrikzcMF3z2KwOjEGOWI0LMGwDRQRFhbc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.11.23 21:15, Peter Xu wrote: > The new pagemap ioctl contains a fast path for wr-protections without > looking into category masks. It forgets to check PM_SCAN_WP_MATCHING > before applying the wr-protections. It can cause, e.g., pte markers > installed on archs that do not even support uffd wr-protect. > > WARNING: CPU: 0 PID: 5059 at mm/memory.c:1520 zap_pte_range mm/memory.c:1520 [inline] > > Fixes: 12f6b01a0bcb ("fs/proc/task_mmu: add fast paths to get/clear PAGE_IS_WRITTEN flag") > Reported-by: syzbot+7ca4b2719dc742b8d0a4@syzkaller.appspotmail.com > Signed-off-by: Peter Xu > --- > fs/proc/task_mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index e91085d79926..d19924bf0a39 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -2171,7 +2171,7 @@ static int pagemap_scan_pmd_entry(pmd_t *pmd, unsigned long start, > return 0; > } > > - if (!p->vec_out) { > + if ((p->arg.flags & PM_SCAN_WP_MATCHING) && !p->vec_out) { > /* Fast path for performing exclusive WP */ > for (addr = start; addr != end; pte++, addr += PAGE_SIZE) { > if (pte_uffd_wp(ptep_get(pte))) Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb