From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4796BEE57C6 for ; Wed, 11 Sep 2024 16:58:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB70F940073; Wed, 11 Sep 2024 12:58:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3E52940066; Wed, 11 Sep 2024 12:58:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DF0B940073; Wed, 11 Sep 2024 12:58:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 43F94940066 for ; Wed, 11 Sep 2024 12:58:10 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F240D8121E for ; Wed, 11 Sep 2024 16:58:09 +0000 (UTC) X-FDA: 82553065098.20.83FFEAA Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by imf28.hostedemail.com (Postfix) with ESMTP id 7DA29C0005 for ; Wed, 11 Sep 2024 16:58:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=lunn.ch header.s=20171124 header.b="aF9/SEtZ"; dmarc=pass (policy=none) header.from=lunn.ch; spf=pass (imf28.hostedemail.com: domain of andrew@lunn.ch designates 156.67.10.101 as permitted sender) smtp.mailfrom=andrew@lunn.ch ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726073860; a=rsa-sha256; cv=none; b=3nQEJ0SqjmEf3dMbgpWRokbQeFCgMy9X7P8mnKBakHYkJL0noo8uoFpE7pl3NzFiNhN80U UER1YqYNw88yZHhwqvf0H1OjrwT78/fhwuOok+LeAoeNENQpNsvsUXRKPb7iZgwA7Cj/ki eebBe55cmtxSdKRxUXJMgXHRLBxrNzw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=lunn.ch header.s=20171124 header.b="aF9/SEtZ"; dmarc=pass (policy=none) header.from=lunn.ch; spf=pass (imf28.hostedemail.com: domain of andrew@lunn.ch designates 156.67.10.101 as permitted sender) smtp.mailfrom=andrew@lunn.ch ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726073860; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W+/LEUKP/xtU0+T0eqY7BQH8KV8T8pZ4KeigsgrDIe0=; b=67FheFHgod2rMyx6+zr+YeEEnYWZE4SZ/ltgnCimvS/NAQTkrffenaI0CaQ7aRNq/srIVJ is0HUdQ+WLsFKMAW34AM7ll2r9/6UDyuBO8I5a0NMjerxVmEBZqhb4m3sitIpLKBVmyC7/ gTZyGDraNwG03mRN5ylhcQukkS6Bf/g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=W+/LEUKP/xtU0+T0eqY7BQH8KV8T8pZ4KeigsgrDIe0=; b=aF9/SEtZbC2PG/Or6pQLM1bOVU GLwMtrQa/QuDn8ca5V1YXoWiAo3XyGh+DYx2EPquErO/VGpRNIDARLGc7UECApwVz6+or8zu7VPzW NafaE5bU00njOZDHbm4TSDs6ZTjyAl1D7smaxafG85rMw043wmGjc6YFWvbHNB8K4BkE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1soQf5-007Eag-UR; Wed, 11 Sep 2024 18:57:47 +0200 Date: Wed, 11 Sep 2024 18:57:47 +0200 From: Andrew Lunn To: Lorenzo Stoakes Cc: Hans de Goede , Andrew Morton , Richard Narron , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Marcin Wojtas , Russell King , "David S . Miller" , Arnd Bergmann , Linus Torvalds , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH hotfix 6.11] minmax: reduce egregious min/max macro expansion Message-ID: <827b2d90-d23f-41c8-8e72-ecd5ca9ee534@lunn.ch> References: <20240911153457.1005227-1-lorenzo.stoakes@oracle.com> <181dec64-5906-4cdd-bb29-40bc7c02d63e@redhat.com> <3f622e05-9843-4763-9191-c980feb831d2@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f622e05-9843-4763-9191-c980feb831d2@lucifer.local> X-Rspam-User: X-Rspamd-Queue-Id: 7DA29C0005 X-Rspamd-Server: rspam01 X-Stat-Signature: ddtros81n57a5jmz141oku6f5ejxuggf X-HE-Tag: 1726073887-24534 X-HE-Meta: U2FsdGVkX1/vFiNt5ipHFJF1LwEx/gjDr7MEuTvt3R7fs4rRSXIe6YdBGnMknOUTcv/bzXohH3q/DaZPI0+9MtctCnVG6hg9Eh08lektdzu+2zNG9f9SMuxOgwYct79Ot0GQz/3/heuPPfi4qLi5MAPrlh8TvNs0AyvOsUfWPzMpf2EeI1DykFz1osXAwFecIVc+JGkKZLk1Mxn9eD5z9yhaLVbIqXbQs4gBvazRAeuqPPR90/twWz8P2ea6T4ub4VLL/KEVxVU4jw7rhg+Br2mK3p/ssaVONo1Qr0XsuEWC09thbna97EKa/jHY1ZmY0xSeWdwbq+JnG7WSkvW4/o9zMjSUfmyBqoBSfBMukJbEeUOASOKtlYVyJWgSKXA9LpiE+/J6/wQ9CnMOiampJznhybaDCdcUjyTxhvbWJxBjmmFUFkkJYTvXAn0aEv9s8D4gJEXJ/iPXLNDAwKDHmzCY7cVDpHbYOyM3Cxv1Z9pWs7Idl7yRKNGQ5YFycjZB2TZxZT58jltOsTOF6GwoBEbDNPdKKWqtxuc2IHJEvPXnf5k1J2A2mJijbSvRZtU06cIn7kIc0R99/IncX9oQFaxkRxOt9k0TojgYSDvafjKhzz7z2dmZ7iRHODx7Tm7h054Nq4wj2J4vJhGZS3VsVsWgfNWFYr1DWokw4OQJQcRN9YfTohEGjd0Po6bJgm4coMen1DGWJp8BDetdoHFhyLzTnQkH6qi5/I2W/LPbnJLmsZRx6ytbl1C/3ek3QbYMkcMkIJd5Sfmz+IYMiJJPMzXGSfWkbonW5dPjNmzaUwCx7DaTCsMW15Qy4Ua4oWyM9LsmO+Yly2MGLaumLIeW2vVPKdOZEf0l7+q7JfoXE95nZWL2pf6kWzucogsggD+cw1PPrgFEaIHmu26ApgZA/2/5RA0j4uSIuGzpz/Yj9IFIx7SgC1y0SAGGZnb9dxwL/gi7oj0mfBUCcXTo8Zv n6KRtUeA MSAQkP7JlIFOKuHZZFEbJTpsYIwbbTaV/e5DwmC27G2oR3uu2CxT49D1rfYIHQKfrjEFi1BG8z3cZZ5yIq1c4BuoSEQVPineLhuOAQ1oAtKbykVvA1OC5WuD3LoR97O6Dduco4x/oiAu+rZkxcoONcdfW18k/u8tnlX+DfCUMxjt5WT8vNWdfRckFcX0LYZupL1FtOMVo7/1UNBnvkbxRMHMIVXNaEhoFOuvLlYodxtVUXox8MDsZneYEJXoDsvByRhIqDEqfvS3ctWI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > I think that you can then also replace clamp_t() with clamp() > > The use of clamp_t() is to avoid egregious macro expansion in > clamp(). After the series improving min/max the clamp() is probably > equivalent. But in 5.15 it will likely not be. So this is, in line with the > purpose of this change, I believe necesasry. Maybe that should be in the commit message? Andrew