From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B41D2C54ED1 for ; Tue, 27 May 2025 16:41:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D1EB6B00DD; Tue, 27 May 2025 12:41:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A9B26B00DE; Tue, 27 May 2025 12:41:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E6FE6B00DF; Tue, 27 May 2025 12:41:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0F42F6B00DD for ; Tue, 27 May 2025 12:41:55 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A26B9BEB79 for ; Tue, 27 May 2025 16:41:54 +0000 (UTC) X-FDA: 83489254548.06.44B46C1 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf23.hostedemail.com (Postfix) with ESMTP id 66874140010 for ; Tue, 27 May 2025 16:41:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748364112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jf8YXMErvV5jByPzvQK2/iALYTms3500tpH7+I9n2jg=; b=oOC8ZGpB9T+Yqx/WOS+CwIZsLMToG2o6TT7X12oXmCjuMrFaFLQjVuYkllohMN4uR30Bmf TuHMxbF1nWTf9LRdnvXZn0a0pP4zAenVEOIJsYYX7C28FSn89kFg/KQ3kTDuWVxFhgXYb2 laN7HLB6Xobk9sW4SYns37LNo1eHU/I= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of pulehui@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=pulehui@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748364112; a=rsa-sha256; cv=none; b=GD1E2iTPhl29oaASs0b6ksUI8As7txep0AxSx3VMkYYFDqziCc66chDbF4+EszYANRFP8E +5iRydWZ2WxEz+j557OUn6zNjj4NBmeLDQhLW4oaW1V1z35jjJm4IQAP/izEM9AN7XOyJM 0PdQMHfadprPve6OSCquCUQYspsibhE= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4b6JL45zgJz4f3kvp for ; Wed, 28 May 2025 00:41:16 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 99A5F1A018D for ; Wed, 28 May 2025 00:41:43 +0800 (CST) Received: from [10.67.109.184] (unknown [10.67.109.184]) by APP2 (Coremail) with SMTP id Syh0CgDXk2ZG6zVo+FlUNg--.42217S2; Wed, 28 May 2025 00:41:43 +0800 (CST) Message-ID: <82692c51-a599-49ee-8830-f5c7afbd6b14@huaweicloud.com> Date: Wed, 28 May 2025 00:41:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/2] mm/mremap: Fix uprobe anon page be overwritten when expanding vma during mremap Content-Language: en-US To: Lorenzo Stoakes , Oleg Nesterov Cc: mhiramat@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <20250527132351.2050820-1-pulehui@huaweicloud.com> <20250527132351.2050820-2-pulehui@huaweicloud.com> <20250527153007.GD8333@redhat.com> From: Pu Lehui In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID:Syh0CgDXk2ZG6zVo+FlUNg--.42217S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uryrCrWfArWDuFy5tFyfXrb_yoW8Jw1kpF Wqya15KFs5trWUJwn2y34Ut3Wrt393Jr43XF90q34UAFZ0qFnagFW8JFWY9F1q9rs7K3WY va98Gr93XFy2vaDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9Sb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6x kF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE 5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r1j6r4UMcvjeV CFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwACI402YVCY1x02628vn2kIc2xKxwCY1x02 62kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7 km07C267AKxVWUXVWUAwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r10 6r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxV WUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG 6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UYxBIdaVFxhVjvjDU0xZFpf9x07UG-eOUUUUU= X-CM-SenderInfo: psxovxtxl6x35dzhxuhorxvhhfrp/ X-Rspam-User: X-Stat-Signature: mesd9syrd19ci59nwgfchhy47gtky8c5 X-Rspamd-Queue-Id: 66874140010 X-Rspamd-Server: rspam11 X-HE-Tag: 1748364109-991873 X-HE-Meta: U2FsdGVkX18yFUhjbua65YxBeQPnA40s8vkt5L/C44v72R1TS4QrkTrBWaWs87CDWEzhVXLoMtuQxhqtF21HIt49/JoN+GHvYliQ+LVNA5sJ/oegT2R+FoFRkSE+qidc2n3YIsjQGjS27R9zn5l45oROUrlhqvVToE+2aRJFey0H5ON3ghla+VCkMDkYsbJPaRoVXBfHc7lrUQoN+9ZAZ3fz69hia5e6fDKaFuCZZoyYJjoMyV5xSlJyaoxMTpOzq8c+Z/TofqPJCJdK43q+ANgHnQdQVs6wFJyQllROaag5l1KDjugHe9enXLu4GBlvGsBRkKouTdY6cLTFzTK0aGg6G5e6yzncZ4JNPxnWnfPATbWLcq4ZPKKzWkdzL7ANuS3l8Gf5sbbDhBl6IVdZJYrc6WtPUcG/xlqmieXD8c5TpEVTDotzOzkXHP5NXLntSTT50jDU9unlJ4bmBdaxLbb6+0rAHQpsV6GiIYZPuX2w1bz8facxZ4aYNsJTYjNKnNLhjZEfr5FltY8QY0H6DcBc+/XcPxcoKfzPU7hPQokfARZd7RAlyYHbtrN6wltG4kxga3v7ymg0kDJNyaOBkD5cpf5mdIxi7Fnb6yDK1tKXQ3kqH8OP2nO8lE7UEZvEbjqRAEknsMUc2hmGTCXitMNtyzosRxQ4iAnp5QEZr0oopF548V4nDSk07Tjw1Sb24/eJLTZswdlioyQ2czrDpmboduyYvGpMD6ZsEIMuQ3kkeAqTKF3K7mZ3Ww2bDgjAdePmhuYHChroXBuu9dDJAHQLlwMx4zhBPvqsiRZbO3V00AMKzMVwRLOyqdtEcqIxFWCnQZGoT6zG2o+HmUjOdXFPnKnLOOn4lOgiw8sO86TogSmdTKn6rYGxVlZXutPVWZq7QAYrRqI94YlUIqq7Y4TLi01SSQkJ+A/spF97CvVhyRSUUjSWczNfmYLbfI3/YyEEyX6291X1M15e473 +0915zrO hZDhFFAZVc1eHdBVOzYqR1LCkmTJWmLkXoapH3+wfcnUeVNDaYRh17MBlh5IyHC9w9Q9uOUn9YPW3wUC2e96m4MTUhS0eg1iwaxwqg6qQX+qnHAQL/f4E0RSZFKGIuixDfXVGfbH8tMkIN4ze8o6/Qbxc9TUJJmmnBsfq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/27 23:33, Lorenzo Stoakes wrote: > On Tue, May 27, 2025 at 05:30:08PM +0200, Oleg Nesterov wrote: >> Not that this is really important, but the test-case looks broken, >> >> On 05/27, Pu Lehui wrote: >>> >>> #define _GNU_SOURCE >>> #include >>> #include >>> #include >>> #include >>> #include >>> >>> int main(int argc, char *argv[]) >>> { >>> int fd = open(FNAME, O_RDWR|O_CREAT, 0600); >> >> FNAME is not defined >> >>> struct perf_event_attr attr = { >>> .type = 9, >> >> Cough ;) Yes I too used perf_event_attr.type == 9 when I wrote another >> test-case. Because I am lazy and this is what I see in >> /sys/bus/event_source/devices/uprobe/type on my machine. >> >> But me should not assume that perf_pmu_register(&perf_uprobe) -> idr_alloc() >> will return 9. >> >>> write(fd, "x", 1); >> >> looks unnecessary. >> >> Oleg. >> > > While I agree we should probably try to do this nicely, in defence of Pu I think > this is adapted from the syzkaller horror show :P and that code does tend to > just insert random integers etc. > > It would be good to refine this into something more robust if possible and > ideally add as a self-test, however! Yeah, just trying to make the commit message more compact, but miss a lot. Will do better next.