From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7EF6C64ED9 for ; Mon, 13 Feb 2023 06:26:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DAE546B0073; Mon, 13 Feb 2023 01:26:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5E396B0074; Mon, 13 Feb 2023 01:26:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFEDF6B0075; Mon, 13 Feb 2023 01:26:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B0CDE6B0073 for ; Mon, 13 Feb 2023 01:26:01 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 791CF160133 for ; Mon, 13 Feb 2023 06:26:01 +0000 (UTC) X-FDA: 80461283322.04.5E0527A Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by imf06.hostedemail.com (Postfix) with ESMTP id 4EA82180012 for ; Mon, 13 Feb 2023 06:25:59 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oDTaHYE7; spf=pass (imf06.hostedemail.com: domain of groeck7@gmail.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676269559; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WBfrO2gGyOvBRZ1A5wp4UK8YioFxtCNN29YZ0C6yJUM=; b=c9SJ5/8FqThYX5wgSWnxftLr9nkyIxS3iLQ6CtJf+BqHBOvolkwOGlW3XoGQVsWa7z4CWQ Ul7AvD+LVXRpmnfvhIArd8tp9/ow+Uh4/z8SE3GKCrMjBTh/YhKdX47i1FhrwAsguZUcY9 dB2EnnMBIshS9fmBzj6an37KJpwELf4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oDTaHYE7; spf=pass (imf06.hostedemail.com: domain of groeck7@gmail.com designates 209.85.167.178 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676269559; a=rsa-sha256; cv=none; b=mCw5tJJPx5vlCHL2ih+N0F5PaWfw1FLyYACPgZUi3ybjK4xfUbCsQLm7Ugnf0jCuS3iEl6 lhG3AKashu7NZOCspi/zYtmjYRAt9ZJ+7dV/CjzUrmMAQEKf0daUAmEo7k9npek+vbV2JZ mYNmH9pzbRcu6za7PaR5jm7seApJfNE= Received: by mail-oi1-f178.google.com with SMTP id t5so9370874oiw.1 for ; Sun, 12 Feb 2023 22:25:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=WBfrO2gGyOvBRZ1A5wp4UK8YioFxtCNN29YZ0C6yJUM=; b=oDTaHYE7Ifi7cTfoJaBKOA+euRlCFlo+ykP9tRkGsweDWCjfPlRLBkVyxOHGFcmNqc PSZTRHnsx3UreCHv1p9ynDEvrC5nGpdC4VXbwWYrd2yYwCkykGDPLP2SNyHtKIRZ0Fzf m5Q5HPiFjmx/8JH/hVxhNaJo4GLuifz/a00mQ5ccFU5DlCskiDprH6pwoBt/q7h6DDjY XLGT8w6vJ24mYBL9QM1YV+CRlakf167YfDtx3KOo8lkNAunfJWM4pqGoRQPXTLOlgYkl nosLoRl5OZPv9+Xx589w5Zoaba/auqZwvIrVa4S9ZAslff1MJvy24KQ2HNmX2D2e/q/v LF/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WBfrO2gGyOvBRZ1A5wp4UK8YioFxtCNN29YZ0C6yJUM=; b=vKVOhk1C7zfRkxTfMgXtm79o6WbMM9vebM9kRUNV3DDRjV+CH+R8eP6im+JBIvUhh5 XcPoMw6ycOEpT8ugHnWcgtEWtCbpbkCp55Anjg2xzFjgyGzpEEmVS0RUt8X75I2/sgOY DRwovGl38UXm7f7Zf00BpIkEYe8egf/tCTWh5YiT+G4v8dmNqp+FV/nKY2CVS+TCSG6R gMbjIgNP+V3PFvruOZkvuUu088EVd36+HSIQ5/wZhD7PG4ufx+FP/dq+9n9mi8X6B32z Ihq5FfC+sOhIczpFfy8mGrhhdKXxXNHdtRJTdY1CVB5PiFnF6SuQV7W8C7HayYg9DKJE kxCA== X-Gm-Message-State: AO0yUKV0soWl7zf+amAcf9hA3pvi8M7xKadUCcffr/l2/dn6sc/aPJKJ Qj4+L3HtCvfp6/nn641IE8Q= X-Google-Smtp-Source: AK7set/+6jsdhTf2sJtfJcDHaoQnUg14v4tlGoQakT99S8J8gTSqtG1+VHr+8pC/SE0SaaNJlMokqg== X-Received: by 2002:a05:6808:d2:b0:363:b918:643b with SMTP id t18-20020a05680800d200b00363b918643bmr10584927oic.31.1676269558366; Sun, 12 Feb 2023 22:25:58 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id dq3-20020a056808428300b0037d8148cf04sm1851027oib.46.2023.02.12.22.25.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Feb 2023 22:25:57 -0800 (PST) Message-ID: <8267dc7e-329f-73cf-b50e-9bf2606b8751@roeck-us.net> Date: Sun, 12 Feb 2023 22:25:52 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU Content-Language: en-US To: Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , Brian Cain , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Greg Ungerer , Guo Ren , Helge Deller , Huacai Chen , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Rich Felker , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Vineet Gupta , WANG Xuerui , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-3-rppt@kernel.org> <20230212173513.GA4052259@roeck-us.net> From: Guenter Roeck In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4EA82180012 X-Stat-Signature: c7scif8hfxyw5q75m9ccbx75xdkdp9g5 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676269559-850703 X-HE-Meta: U2FsdGVkX1+dL8AXwjfaXWaR3ZenhDzjU/mVFQrFlNCeP8uSkJNajhkeMjSriwHaG8o9ERIi+dcrvlA9G6nC28+oYfrtr1uOebtghxe2kiSAkbn3imqSJFXnR5hcuadY/pPmFv3hD2rVHqiRU7BKUDxIRCar24AlJUFcSs34rw8tJ87BgkV23HFIpNadlATSHT5VNMQy4Kr8k6sqcjX6vI8sGzqPBlOhfhSPzJQMfZSX8S8rn3W5G1ffVS9t15aIAn0nDQ/7+j0Lz5ZTLNAaI8xZvL9vMMxGAOeqCuR3xFWmC7a9hnTy/lEdke2QJ6pmwzq3xLyCSQc2X6hpnmQ8+FsdHAVfNHVL7U3J8E1CABisqoQss5ajbSrs3dpbLG6NXvw+Dn8SZ3Z5EVDHqi/x8ZvHCQZx6EwxslYSXXtVpDpVOnov+7uy8HaBloSk/Lm2aqjYl5B89aKisU3sG+hnvPq+PXKfR6TyV/FrGMaFlnnQ8DCj+GNPgJHoZGzoOPrhlqtXxlAnpS9Df8SZUZe+MJSowChvm+am5LvLHdZRlSHoiBhRIIKj5DWenXNhkW2+Lo8APRS8nT+6igUxYvaD3BL7H2ABo6S2UOI1pIKuHI6BeoYoDYtpQDi0zcoiLbnNdiszTpeXse2t9M07rGbj3/w8D3ekA10GSf6/hYIyB/SH7ZBLQD7QShJuHDE7xGW6PVfnBDwqVbSXnUL86Tm1Js5iFa3FFcIrR7iERjK7TxW/tPyAJPhjsCKgaP1BXxQqdI3vQEFrLCyx3KTc4k1aa3+pbTjnZFyhGgjy+BoqVXXiVB7cdfB4q920CCp7Q6e0QmeVoFOkkdM8AZeq7NB1JXrsxo0lG2p68zGN/k2Alar6aLeUr+r5d0EKlI8h3Bm1l/YYatyTtCTLmIXEMfNha46NRBNfXrbFTbHwJA9oP/TRHpGpIMoHY5d853vyGYLFUC1YSyUyUSRFItkYQ1w 3ZKoNWaS qz8r8kASt3ec8HkcBpxZ4LXWpRED3eVLCYMlFUo+gg/kY8IP4TNbzjM0qsoFkn+Z1Z4In5Bjz8HLMMQQspg9sd4Tjti5vhxXMwCVs45kgrOJgKkwXpjnNWrRKUqHGjcY6DU+m81MsOO8NaxE8R9fZ7q33+3dodGk2HztTZQ+LjZHd1b7cUXsx+80wAgw0ALnvSJVkUhkF1I5sBQYLP1KhBTQnMzC0bkFEphIZugr3hQU5hRVF5mM8gFaojae4OKCA9MpuwKLl5uTCWL9w2Ac10VJnlGNpUDqz2zH7K+Ml+GKTu+4PYv9wtoAvky3XZsLR1MNPfYJdQqSHLd6M4SbmdvFFdoGNZk7z8Wc6tZC3AiYjQHsrzVjufsHIWnRx98NZqhhnu31z3OQOM9n3y4wmpN4kU30Zl66IjXJ7lU1wC37pxLKU0C9BErOtEkL5Rk/sIgTqMpL4XKuIeS0+y8EfPBxgqK+l6EeblZkzdBebwHoIOhGW0gP0wcI/HNAUukLXZgUARcSaZPDDBRv0583q2J5jJy9HkQVEX6rLF7cRjCRXXZWvgsg4q/dDaXTx0tc7agQB3ApGTgzq65nNrlDYmDVXaOkbSsGbz/MFtNYe6o8sq2z0pBFPU7p+VVEamnoq+Vhz2oq2U03wQl/uRv3HJQ39z35DhqE/EKXPrgbdBA8u1gsfi3IxyAT/dLixdu0BPIxGR6gZlPguGOaB17t+0S9IE2ME2ZpXgERDbFpwI5WFUaQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/12/23 17:15, Mike Rapoport wrote: > Hi, > > On Sun, Feb 12, 2023 at 09:35:13AM -0800, Guenter Roeck wrote: >> Hi, >> >> On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: >>> From: "Mike Rapoport (IBM)" >>> >>> The MMU variant uses generic definitions of page_to_pfn() and >>> pfn_to_page(), but !MMU defines them in include/asm/page_no.h for no >>> good reason. >>> >>> Include asm-generic/memory_model.h in the common include/asm/page.h and >>> drop redundant definitions. >>> >>> Signed-off-by: Mike Rapoport (IBM) >>> Reviewed-by: Geert Uytterhoeven >>> Acked-by: Geert Uytterhoeven >> >> This patch results in a boot failure when trying to boot the mcf5208evb qemu >> emulation. Reverting it together with "mm, arch: add generic implementation >> of pfn_valid() for FLATMEM" fixes the problem. There is no error log - the >> emulation hangs silently until aborted. > > With the patch below I was able to get to the mount of the root file system, > but I don't have one, so I couldn't test the boot properly. > > diff --git a/arch/m68k/include/asm/page_no.h b/arch/m68k/include/asm/page_no.h > index 43ff6b109ebb..060e4c0e7605 100644 > --- a/arch/m68k/include/asm/page_no.h > +++ b/arch/m68k/include/asm/page_no.h > @@ -28,6 +28,8 @@ extern unsigned long memory_end; > #define virt_addr_valid(kaddr) (((unsigned long)(kaddr) >= PAGE_OFFSET) && \ > ((unsigned long)(kaddr) < memory_end)) > > +#define ARCH_PFN_OFFSET PHYS_PFN(PAGE_OFFSET_RAW) > + > #endif /* __ASSEMBLY__ */ > > #endif /* _M68K_PAGE_NO_H */ > Yes, that works. Thanks, Guenter >> Guenter >> >> --- >> bisect log: >> >> # bad: [6ba8a227fd19d19779005fb66ad7562608e1df83] Add linux-next specific files for 20230210 >> # good: [4ec5183ec48656cec489c49f989c508b68b518e3] Linux 6.2-rc7 >> git bisect start 'HEAD' 'v6.2-rc7' >> # good: [94613f0efc69ed41f9229ef5c294db3ec37145da] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git >> git bisect good 94613f0efc69ed41f9229ef5c294db3ec37145da >> # good: [19e62c715fe70dae4582c2874ed3e66715d09af6] Merge branch 'rcu/next' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git >> git bisect good 19e62c715fe70dae4582c2874ed3e66715d09af6 >> # good: [5d8b7ecef7f4a681b6e5538db59ff26c389c0ab6] Merge branch 'for-next' of https://gitlab.com/peda-linux/mux.git >> git bisect good 5d8b7ecef7f4a681b6e5538db59ff26c389c0ab6 >> # good: [c349bf6ec83903b20fe570c5609b9a864a64e09c] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/krisman/unicode.git >> git bisect good c349bf6ec83903b20fe570c5609b9a864a64e09c >> # good: [5a06a9f17454df38f35672be522ff5eb9b4277d2] selftest: add testing unsharing and counting ksm zero page >> git bisect good 5a06a9f17454df38f35672be522ff5eb9b4277d2 >> # bad: [f5d115a7b06e5661ed5218ffa9a2644c4ff1c135] Merge branch 'mm-nonmm-unstable' into mm-everything >> git bisect bad f5d115a7b06e5661ed5218ffa9a2644c4ff1c135 >> # bad: [acb018d6ea0c055381fba7dddaef386ee28f8075] mm/vmalloc.c: allow vread() to read out vm_map_ram areas >> git bisect bad acb018d6ea0c055381fba7dddaef386ee28f8075 >> # good: [1a5d9782ac969dc6e61c6786500b5160603188ea] mm/mmap: remove __vma_adjust() >> git bisect good 1a5d9782ac969dc6e61c6786500b5160603188ea >> # good: [4b32363697de957dcc890b6245bec3f58903639a] arm: include asm-generic/memory_model.h from page.h rather than memory.h >> git bisect good 4b32363697de957dcc890b6245bec3f58903639a >> # bad: [328cf3fa6682ce6a4de6f8bb8009c833dc33f3c8] mm/migrate: convert isolate_movable_page() to use folios >> git bisect bad 328cf3fa6682ce6a4de6f8bb8009c833dc33f3c8 >> # bad: [b704c765b08cabe82adf76a4d1a74f3688eee410] mm/mempolicy: convert queue_pages_pmd() to queue_folios_pmd() >> git bisect bad b704c765b08cabe82adf76a4d1a74f3688eee410 >> # bad: [e5734c8b0edfd2a053a5c256189586a3b1e9f63d] mm, arch: add generic implementation of pfn_valid() for FLATMEM >> git bisect bad e5734c8b0edfd2a053a5c256189586a3b1e9f63d >> # bad: [ad8aecea034c591b9754bc5908da9719853aa7fa] mips: drop definition of pfn_valid() for DISCONTIGMEM >> git bisect bad ad8aecea034c591b9754bc5908da9719853aa7fa >> # bad: [1f6271a0dfdf952c2e3981f424784d48f243a2be] m68k: use asm-generic/memory_model.h for both MMU and !MMU >> git bisect bad 1f6271a0dfdf952c2e3981f424784d48f243a2be >> # first bad commit: [1f6271a0dfdf952c2e3981f424784d48f243a2be] m68k: use asm-generic/memory_model.h for both MMU and !MMU >