From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F10EC3DA4A for ; Tue, 20 Aug 2024 03:02:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22B7E6B0083; Mon, 19 Aug 2024 23:02:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DB336B0085; Mon, 19 Aug 2024 23:02:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A31A6B0088; Mon, 19 Aug 2024 23:02:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DB5156B0083 for ; Mon, 19 Aug 2024 23:02:17 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 518CF41743 for ; Tue, 20 Aug 2024 03:02:17 +0000 (UTC) X-FDA: 82471125114.03.FA4D1FC Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf01.hostedemail.com (Postfix) with ESMTP id B9ABA4000E for ; Tue, 20 Aug 2024 03:02:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724122871; a=rsa-sha256; cv=none; b=JIXXNnf4hhjp6HT1xW3zb2QH1TWKK1oApWfsROQ7u82tO/b7N5YY3vuo+i7fjg6OMx+9/M OE2Y6fAQEv3Z+X4qCdTGGRk4JxMTDqNiwbE5jNUrolq/1ARatmLEh8NnwEeg68Gz4cZk9O pQjeBbyJLqcm8dkMBUj8TwN9dY8rHiE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724122871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HMkvpXVh3VJ0odf/pNWk62xd4y/S1nkaUXDWSHs3djg=; b=79DEutdcsceqIxL/P1ClIOzKimhjRWXo6YNPNbSZDc0jCAhWDujSQ9D+t5GnSoULBTlYbI h1i4ZpstVSYyAN/fXAuDtHohToJ56dqDp6RF1u6OxQ80mIxj4Puzhr63jFj8uz2gkTmvGP NMRKCPVWpOPCb/l30oVHLcGhHIG+aJQ= Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WnvMr41ryzfbXX; Tue, 20 Aug 2024 11:00:08 +0800 (CST) Received: from kwepemm600017.china.huawei.com (unknown [7.193.23.234]) by mail.maildlp.com (Postfix) with ESMTPS id 77715140138; Tue, 20 Aug 2024 11:02:08 +0800 (CST) Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 20 Aug 2024 11:02:06 +0800 Message-ID: <8257d76b-c700-89a6-0e29-f194d2e1cd61@huawei.com> Date: Tue, 20 Aug 2024 11:02:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v12 4/6] arm64: support copy_mc_[user]_highpage() To: Jonathan Cameron CC: Mark Rutland , Catalin Marinas , Will Deacon , Andrew Morton , James Morse , Robin Murphy , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Michael Ellerman , Nicholas Piggin , Andrey Ryabinin , Alexander Potapenko , Christophe Leroy , Aneesh Kumar K.V , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , , , , , , Guohanjun References: <20240528085915.1955987-1-tongtiangen@huawei.com> <20240528085915.1955987-5-tongtiangen@huawei.com> <20240819125601.0000687b@Huawei.com> From: Tong Tiangen In-Reply-To: <20240819125601.0000687b@Huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600017.china.huawei.com (7.193.23.234) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B9ABA4000E X-Stat-Signature: prbxdafwjht3eis1uo9x7miu4b44oued X-Rspam-User: X-HE-Tag: 1724122933-960571 X-HE-Meta: U2FsdGVkX18K8czdXxU88Lk7gl9xVy/0JV4w+vHhvQsmj6Wr95sDYEN5g5bRid49yEooj+1eEIs/t/UzmmIgDrTj40gVkH9tsFoxFhJg8JSbu5Rc1Oy7/jVhmY2DrsRJfDVd4+IN3i0m0L4BAQfDlVLmj8n4J479pCxAk9cTjCEooibbx3yLru5+fG9tS/AJ1bBmmdfE+1sfvmcr500SDw6k6Nq87PyWsrRrdu7pmuckQ+v2aDrnbAs7FeiUU4l1cfEgierOuoKVB0CWBkCbhCL6jTPHgE9JahDGNsuFrIQ//DvCdD7rGybLVkW7Fbbffu3HX+HOlkk2vmyhobkrqsir4e7TWchJ7RiFVrHuJBqhK/UNJ0vr0tD+gndSV2jhblO7+B7UPnGCygqNaJmobI2l4BjZT+Gi/g0E/NYQetNbjbFzMVbEM12g+KVuE9Yd3Exg21LQmqoqrh357jGHFvZZ613c5MnkEWyZkeicYNXSQlZ3Kvj4/TxyuSNWmQesUbQ6Kt/1GoW3fKsQf8d1SbpzCJ2q5Psyyl3zCPVePGosnMwz87STN7Sg3G3Wofc8JWzSLTdV2OdhYPDHld6l1sqqJBVCpatQ6LJt4GG6LfIovdsAWKjd0v8yCCYAcqLJ1auyDETfDmw1aAAEeGv4Xse+QxaaNW+m1EVYh9FZ1JuTxMo30qDZ/BRNMJzEcyHbrRUZmzdVaPDPatLlwft01yc6MwocrmD35oIidJyY3ElrzJXJjbemxWBJo/AwF55e8whgD3MPfuzr2q+GKHWSUxqGwoDxMhdc35YqOyUialdyHzwSlRX6YZvkZ0nMbPM45Y0WthsF8vWq0IM88I1HiixplLhVLlDVAeTcTdzcj1NMZxH3434PST2K77vIo5SgdtBPJswC2UA/DCIY1x1ZXMYIIzySeZrDzS1YvaZ7ndk6u5oMw+/qfEepCPIzo0k/0wKJb1hz6+B8r9uRbr3 AX70p2S2 EHfP/Dga1q40sCGV81h7DIDmX1rubB2oOcuZg1URcytIuQMGQ2U/OKhbitFQqN0Y12eB2/56G4hNvFqa2GEILHCMQzrCpwftkESOjcbB07ROdKPz19eBlQxQReElCcNqKr3T4wmVsr19znKVRy0Q4D0IYB9D8cVmGSiiYvN8ybXmXCCxFabpgGunwRF0hGLa4VEj0dhB3UH04OSiBxFTczH5OsX3KyoLmmOgMW6IOoBcL2tW8NdTCJnBK3dxx6uMYFPIu7Qn0qUCCUrlK5hZygpKzWMsoU39npsJopu0h9uHt0lI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/8/19 19:56, Jonathan Cameron 写道: > On Tue, 28 May 2024 16:59:13 +0800 > Tong Tiangen wrote: > >> Currently, many scenarios that can tolerate memory errors when copying page >> have been supported in the kernel[1~5], all of which are implemented by >> copy_mc_[user]_highpage(). arm64 should also support this mechanism. >> >> Due to mte, arm64 needs to have its own copy_mc_[user]_highpage() >> architecture implementation, macros __HAVE_ARCH_COPY_MC_HIGHPAGE and >> __HAVE_ARCH_COPY_MC_USER_HIGHPAGE have been added to control it. >> >> Add new helper copy_mc_page() which provide a page copy implementation with >> hardware memory error safe. The code logic of copy_mc_page() is the same as >> copy_page(), the main difference is that the ldp insn of copy_mc_page() >> contains the fixup type EX_TYPE_KACCESS_ERR_ZERO_ME_SAFE, therefore, the >> main logic is extracted to copy_page_template.S. >> >> [1] commit d302c2398ba2 ("mm, hwpoison: when copy-on-write hits poison, take page offline") >> [2] commit 1cb9dc4b475c ("mm: hwpoison: support recovery from HugePage copy-on-write faults") >> [3] commit 6b970599e807 ("mm: hwpoison: support recovery from ksm_might_need_to_copy()") >> [4] commit 98c76c9f1ef7 ("mm/khugepaged: recover from poisoned anonymous memory") >> [5] commit 12904d953364 ("mm/khugepaged: recover from poisoned file-backed memory") >> >> Signed-off-by: Tong Tiangen > Trivial stuff inline. > > Jonathan I'm sorry, I may not have understood what you meant. Where is the better place to do inline? :) Thanks, Tong. > > >> diff --git a/arch/arm64/lib/mte.S b/arch/arm64/lib/mte.S >> index 5018ac03b6bf..50ef24318281 100644 >> --- a/arch/arm64/lib/mte.S >> +++ b/arch/arm64/lib/mte.S >> @@ -80,6 +80,35 @@ SYM_FUNC_START(mte_copy_page_tags) >> ret >> SYM_FUNC_END(mte_copy_page_tags) >> >> +#ifdef CONFIG_ARCH_HAS_COPY_MC >> +/* >> + * Copy the tags from the source page to the destination one wiht machine check safe > Spell check. > with > > Also, maybe reword given machine check doesn't make sense on arm64. OK. > > >> + * x0 - address of the destination page >> + * x1 - address of the source page >> + * Returns: >> + * x0 - Return 0 if copy success, or >> + * -EFAULT if anything goes wrong while copying. >> + */ >> +SYM_FUNC_START(mte_copy_mc_page_tags) >> + mov x2, x0 >> + mov x3, x1 >> + multitag_transfer_size x5, x6 >> +1: >> +KERNEL_ME_SAFE(2f, ldgm x4, [x3]) >> + stgm x4, [x2] >> + add x2, x2, x5 >> + add x3, x3, x5 >> + tst x2, #(PAGE_SIZE - 1) >> + b.ne 1b >> + >> + mov x0, #0 >> + ret >> + >> +2: mov x0, #-EFAULT >> + ret >> +SYM_FUNC_END(mte_copy_mc_page_tags) >> +#endif >> + >> /* >> * Read tags from a user buffer (one tag per byte) and set the corresponding >> * tags at the given kernel address. Used by PTRACE_POKEMTETAGS. >> diff --git a/arch/arm64/mm/copypage.c b/arch/arm64/mm/copypage.c >> index a7bb20055ce0..ff0d9ceea2a4 100644 >> --- a/arch/arm64/mm/copypage.c >> +++ b/arch/arm64/mm/copypage.c >> @@ -40,3 +40,48 @@ void copy_user_highpage(struct page *to, struct page *from, > >> + >> +int copy_mc_user_highpage(struct page *to, struct page *from, >> + unsigned long vaddr, struct vm_area_struct *vma) >> +{ >> + int ret; >> + >> + ret = copy_mc_highpage(to, from); >> + if (!ret) >> + flush_dcache_page(to); > Personally I'd always keep the error out of line as it tends to be > more readable when reviewing a lot of code. > if (ret) > return ret; > > flush_dcache_page(to); > > return 0; This is more reasonable, and it is more readable to eliminate errors in time. Thanks, Tong. >> + >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(copy_mc_user_highpage); >> +#endif > > .