From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E368BC19F2D for ; Thu, 11 Aug 2022 07:27:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77A638E0002; Thu, 11 Aug 2022 03:27:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72A618E0001; Thu, 11 Aug 2022 03:27:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57D708E0002; Thu, 11 Aug 2022 03:27:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 448548E0001 for ; Thu, 11 Aug 2022 03:27:27 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1A7F81A033C for ; Thu, 11 Aug 2022 07:27:27 +0000 (UTC) X-FDA: 79786481334.31.80E77DC Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf07.hostedemail.com (Postfix) with ESMTP id 75D8140040 for ; Thu, 11 Aug 2022 07:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660202845; x=1691738845; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=pePLudKV82sJaY4x+onbl8CFOg9Pp25YUYlRVGHVzVM=; b=movZMOp0Jc3hc0mPWbKxvgD3afVALAQvEz2adFLaAao4y1z1xnH7jqK/ qsjr0FxpbaFzLG/L1idruPuBueV3GisuAZF5rUqkDYdlZVrZm8srohfcw AeIqptfkWgt29qTEVVtu+JDDb3aHJklTnrE9ArT+2dJD0UtXBxZ+L29Uu 2/8QVPfY+GNm7pz37zqcdl+KIa53RjXyNpEFMkhVHgYK6NQgxYHNMbHNO tpI9+ZBTfSMkoqVmZD4Zz/OMXBEmUykYeJSAV1Axb000fJVpd5BMF6ckH fRKmpcsZd9jJ3fHdhT22IK4iBE3D3L6mqFrK5Q2l5W1sqiL5eVWCLQYSy A==; X-IronPort-AV: E=McAfee;i="6400,9594,10435"; a="271666742" X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="271666742" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2022 00:27:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,228,1654585200"; d="scan'208";a="608835871" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 11 Aug 2022 00:27:23 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 00:27:22 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 11 Aug 2022 00:27:22 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 11 Aug 2022 00:27:22 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Thu, 11 Aug 2022 00:27:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kJZlU/tO7CRAZmvMgU6W8rVcfbPRNKJ6luAx4DA7H/4DZCQSaGFNQd2+hzHO4b8psHLCWnD7PLqTDhgbweUlU0y7N+Lb1RuHIvu2kvnzkOYrQl7O3EYDZdEIG0xItbjfIzZS7Sc9dCXf9MAqPDdJTDS5L/Bv8FeXwsKgdXxqpHPDeseH+aHVWIZmDqC/kJZr/hsFHUME1VvyKwskq9VntGA5iOJTF/zhjIIXZ1kKGpYPGY9Quyd+I7rlRknX5FmBopbown0f0Z8WgVL5OJv/6lSk3PJi9Hb+EKyIbK67fzan88zlcilNTlaECZ6AD0jdQRm9VwTtqaZStlaoXuISJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PXedN3lOlDIDqkCApdij241xN2Du/SiFGhrPYOygmPc=; b=e5Z2j3Xn5k5sjoDmIPPmos32IHzhaXF3BXtxB5W3u6Q0O4fvhxksaDyfdQWshTYD/T3VPM26yqMIw5Hxj9vbti/HSWv9tEkSBX2g5X8t3OYDH4OpZe3Q3esxpjvnEYHDkXsNPVNn6yZuGzun26+3PGbz4d8OSMxQ+qmlA7kjMWjnAPFjBM4xpZWLBzKtSYG2TmZ/3dQ64KOnOTYf7g2Q8o0wpYHDn8rW0gJ9RrNW5wYCOtPqB8XOYdIZZrjiV45m9ZAkF7wYMGF4TlkK3HZPn2NgcoPLucZFhFYePs8eGQ0hjuMkbqZThETbeOodzoVI6PhXZ0cLVnCIPZVOf7eJfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SJ0PR11MB5616.namprd11.prod.outlook.com (2603:10b6:a03:3aa::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Thu, 11 Aug 2022 07:27:15 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::fcda:4c77:5786:209c]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::fcda:4c77:5786:209c%4]) with mapi id 15.20.5525.011; Thu, 11 Aug 2022 07:27:15 +0000 Message-ID: <8250c10f-e786-7f8e-bb32-d417fcac3ca8@intel.com> Date: Thu, 11 Aug 2022 15:26:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] mm: release private data before split THP Content-Language: en-US To: Yang Shi , Yin Fengwei CC: , , , , , , References: <20220810064907.582899-1-fengwei.yin@intel.com> From: Yin Fengwei In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0027.apcprd02.prod.outlook.com (2603:1096:3:18::15) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc5df7ab-e87a-4efa-6134-08da7b6ae9f0 X-MS-TrafficTypeDiagnostic: SJ0PR11MB5616:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uwUbyACUuTmSZpYsw7nVOkEH2n5qb6myuekUjc/n7t9xHCXIbO2QL3ae9bTaTvJsGpQqIbGP4vHm3WQsSmmkul2zHSiUCz6mY8HIIqI4jt8q+3MnjotbN9e/CFa6YCswJLO4zG+Cxob0a8kiWWayzQrvj7RIU6JD/xWbh1kg9rJG78K8vKwRNf6JpscDSSrVY4dV3QB7Lpuj899Mwjaj3gjHpLMdvW3QUvKm8gc/E75UWg/9gYhFAZft321lUVoEE7YbwWmLg0bxTkvE24g9Bxer4XfGlIS7/zgiBzYH0csk8WsIyA3PdF6+eguR/RZtou0E3tvQqLS2cjszxmxv47jHpfHC2P1qTUnbFL/oErhNB0PFrIjt5jxUQ6qC4Oh1p2WiLTY/GsYs05cPqQE984Ow+StegsSPxNw58LjYoTm6xa3QEMKsM9YbDX6vrBbAEjeUPy13oHISy3xDUY4tXi/l9AJZRDpXK/J2Ws4xSBPVEWs3yF6J5WEFMNF34MwgX0JTmeLk47Nd8GRmFPDXdioBXuLGCze2ef8InAEWTWG0tOEDmBSx/O7QjnUlyuNoGstO9oOzrSpidm82hvF2nb0W/LqMcbL84o7chtO5d36TwJaVl0cv99De6dXEAnNSxZk/2bRcRn/Dx7nFwKONFrXLhuTTtYpWwlaFOJrUUPQb1UFraaDXowxNgmHU9gYS4pBtzgYeCgwtMWAPzEkx+50jwRh1Wq8+VyVFo1HK3Hq5LXPlTdKnKgTUHJhqF76SGgfJ5Bi4TjL847dC0AhhH2nBqnJTHBW/q9b50q22DrZeaGi/kG+drj/t0mfUxj6QodUhFZROop1DnF4YCWVnwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(346002)(366004)(136003)(39860400002)(478600001)(6486002)(31686004)(26005)(82960400001)(2906002)(31696002)(66946007)(4326008)(66556008)(41300700001)(8936002)(107886003)(5660300002)(86362001)(8676002)(66476007)(316002)(38100700002)(110136005)(6506007)(2616005)(6666004)(186003)(53546011)(83380400001)(6512007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3YvTDlSTk1RcTVnTVJHMHRQMFVqNi91blliZUt4cTQ3RE9yWnFrS0IxWnlq?= =?utf-8?B?UDVjcGRjNzNjUEVvdU9rUGNpd0NQZEVGbzErbi80MGFkZWx1NHZ4aTVDZlln?= =?utf-8?B?cHo2aUpocjI1UktlNFhvY0MremtUU3ZKRTcycmFyZHlEZytieEpLUUFvQldD?= =?utf-8?B?dkNhd3AyQ2lMaUFMajNBTWJMeU4wcGNWKzR0WGRWNUJSY3pNK0JQZEFKcnZx?= =?utf-8?B?aXhET0VESGovbVVJWHhMSnhoaDBUZ25PQU5GTWU4ZjAzR04wdmsvS1RzYXR6?= =?utf-8?B?VkdhOXAzMG56V2dZUFlWU0VORWtac09nODU2RlM4ejRGQSsrTGg3R3kwd2NX?= =?utf-8?B?WDkxcityRDBESG5YMFJ6ZGRMNEJzVU5LYzVoMFN0WjFSZElrUnhqYmt4aE1L?= =?utf-8?B?SHZ5SXdHRUdFUTNrQXZtbXRyQm1hNmhjMEE4Sld4R2k3ejhDa1RFVTcrVjYx?= =?utf-8?B?QzkxQkoybmsrK2V4RmxwZGFZdGwrNDUrZVo5dzBBS3VtcUc5N25oK1VQQWIw?= =?utf-8?B?Uk9zenJyZ0dDRUNkbVVxWk5rekc3cy9xdE1xK1hBaFdVUU0zU2xNWXluY3NR?= =?utf-8?B?YmQ1Mm5MM1c3VFdUNkNrZ3dzdzRKV002K3Z5U2lLbWwvL3h6TzUxaEdEMmxM?= =?utf-8?B?QlpiU2VUYVVZYklPQk9GM1ZTdmhPVFlrcTBNeWhOZHRhVXFpZmttdnowODVS?= =?utf-8?B?V2w2NFBGOFhaM2ZWVG9FS05meXBKUG5xcUlXUkYrbnp5Y2RjeXpGWG9lNUxR?= =?utf-8?B?NXZSenBhL2ZqSFBnN01BYUs3WUFudVVKSER4YlE2Q3dla1dWS0k4M1lkNlZL?= =?utf-8?B?d0h6OW1WSStXL201RjE2Q3lyYmQvSUlSTzVFRHM4S3FZMG1vNmhtTE1oNmhZ?= =?utf-8?B?T2ZrVTVZbVg0UFhiMnJUcEY0eWNDMHpVenIxTVhuL1k2Vmxjcko3dU5POEFT?= =?utf-8?B?VDVoR0hrZXpYY0tTNTZjckJmSnlUMHNWZVlPMUt5VW1ieW16TnNXUVpjWTFl?= =?utf-8?B?eFNZWWkxb3ZmN3kzc0YreFVtZHpraWtyQWlwYjJIWVlOdmk2S08wV0p1Z2FQ?= =?utf-8?B?b3dHYUlsZTUrTjFHaDhIbWlYZk1XMUtaeDJRWkwzOUdwQWhmUzk1OFA5TXdK?= =?utf-8?B?VEQ0aERaZVZ4cThJcEUxUEVybFF1eWVTenBPS3BjelMrTW9jWkd2ZUlUNjlP?= =?utf-8?B?NjZIWDJKcXo0Y2s0UU5lT2dCbHdkOGZ3OTZDUWZFQUNSb2E4N1hBd2NmRHdn?= =?utf-8?B?K0w4YVJJRXJWbHJQd1ZSZ3AyY2pwaEpCOTNMRm9DY1ZvZTN4dzRHL2xNSVVC?= =?utf-8?B?QlRMN1lVUHkxSnIzbnVybjNLb1JraXRIcXRVOG50UWdrU1ZlZ1dqVFowdlAy?= =?utf-8?B?SWVoaVoxMXdpb3pFTFNXa0xVaVZTVGwzNkFrR0IwTXFKNm52dGZJMDFCaFNu?= =?utf-8?B?L1pEWDlhSURBclZtM3ZkOWdYMVNUWmlCUzU3ZFp3eG5jQWVFQjl3Zkd3Qndv?= =?utf-8?B?ZzdqQTdpNHNBckZvUzZQZEwxSmc0eEZobmFqN3lGV0FTQUI5a2k1K0lOM01y?= =?utf-8?B?OWNQMjNIdVVaTUNVa0hEQ0ZZZnRGdG4rdGFhTS9uL0V6Q3BXWG44QlRKKzNF?= =?utf-8?B?RGJnL1ZYVkQ4aTZ4Q3pPYmthZDdQMXJhWk03d2czT0tYUjZTanhyVk8zOHR2?= =?utf-8?B?RDh6OUpNSmRQaEEvMjBiZGV4K1RQdGcyYkFSVElNMWI0K2xiSVY5bTJsZjZU?= =?utf-8?B?Rzg4eVZXK1krRzZCZjNoSE55UE1wOVcwYm1OOENCamVDRE9xc0gwb0hoR0lQ?= =?utf-8?B?SnlhZTIyYklmQjhzQUJmZ3EyV1IwNVdEdTR6V0Fla1hJN1BPVzVJM0hkelJG?= =?utf-8?B?OXdaYXo4eStsdjh4V1RwcXNtWi9jVGRSUXlhVUJRK0UwbTdPeXpLd29udGZZ?= =?utf-8?B?NXN5d2lpV1VPM056ZVR6WDA3M0xIQnZyMk1qbkJzN0lDaDBVZS85QzVvRFpO?= =?utf-8?B?Y3dqSzlQV1JOc3dMUXMxSFZCdzFsaWlCc0dKS2g0UzlDNktTYzRwMm9QTGxp?= =?utf-8?B?QldMYXhlcVIrL09jS0xMTzZzVHlMTnMyUUlKSFJzUmwyK1FIZk1xK2FYVnpu?= =?utf-8?Q?+MI9WixwAbbC78cPKU/x4xO4b?= X-MS-Exchange-CrossTenant-Network-Message-Id: fc5df7ab-e87a-4efa-6134-08da7b6ae9f0 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 07:27:15.0925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: awysYbsNhZXa9gmp6c6pEwY+p7KQOiBeTFYioIiY3AGdOMaMUmfxYILLI/15w8YwKxSGa/xoxjHcTXZTx5XXyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5616 X-OriginatorOrg: intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660202846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PXedN3lOlDIDqkCApdij241xN2Du/SiFGhrPYOygmPc=; b=mTx7FO04RiTFFAKUGMBDdEav1OjW9+1M3QmwOe2NGAUZdoLfveQMg9sNVc508Uq04vtwo6 kFnAk2MfNqaFefUTKlJDvhhsxQNu1FvXA6tRYtL/DsIYnF+LJqLLdJTxtqlPY6UtUgfcS9 EmF6XEjVC/hLbWxVT0QECKcDuxMP2QU= ARC-Authentication-Results: i=2; imf07.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=movZMOp0; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf07.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1660202846; a=rsa-sha256; cv=fail; b=oMH3TN9GKWyk+QmLftUWt6Krgzxij8p1I2zfPtYRoOTpnpe+kilwMMvqZ7gDqcMZr7SpTR xqPTVNFNF947lH8AVnXcsuP1Bhsexm5Gwa18RBbayPibodQPhIrZ+Hu42HXQ3D+Lf0I9Cx FZtqahdimhtnHy97ruHk18rcMpAAXUY= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 75D8140040 X-Rspam-User: X-Stat-Signature: p5bi3d7uf8nyzj4bsdyks5or1y91fwq5 Authentication-Results: imf07.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=movZMOp0; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf07.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") X-HE-Tag: 1660202845-606969 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/11 01:09, Yang Shi wrote: > On Tue, Aug 9, 2022 at 11:50 PM Yin Fengwei wrote: >> >> If there is private data attached to THP, the refcount of >> THP will be increased and block the THP split. Release >> private data attached to THP before split it to increase >> the chance of splitting THP successfully. >> >> There was a memory failure issue hit during HW error >> injection testing with 5.18 kernel + xfs as rootfs. Test >> got killed and system reboot was required to re-run the >> test. >> >> The issue was tracked down to THP split failure caused the >> memory failure not being handled. The page dump showed: >> >> [ 1785.433075] page:0000000025f9530b refcount:18 mapcount:0 mapping:000000008162eea7 index:0xa10 pfn:0x2f0200 >> [ 1785.443954] head:0000000025f9530b order:4 compound_mapcount:0 compound_pincount:0 >> [ 1785.452408] memcg:ff4247f2d28e9000 >> [ 1785.456304] aops:xfs_address_space_operations ino:8555182 dentry name:"baseos-filenames.solvx" >> [ 1785.466612] flags: 0x1000000000012036(referenced|uptodate|lru|active|private|head|node=0|zone=2) >> [ 1785.476514] raw: 1000000000012036 ffb9460f8bc07c08 ffb9460f8bc08408 ff4247f22e6299f8 >> [ 1785.485268] raw: 0000000000000a10 ff4247f194ade900 00000012ffffffff ff4247f2d28e9000 >> >> It was like the error was injected to a large folio for xfs >> with private data attached. >> >> With private data released before split THP, the test case >> could be run successfully many times without reboot system. >> >> Co-developed-by: Qiuxu Zhuo >> Signed-off-by: Qiuxu Zhuo >> Signed-off-by: Yin Fengwei >> Suggested-by: Matthew Wilcox >> --- >> Changelog from v2: >> - Use safe gfp flags for different callsite of split_huge_page_to_list >> per Yang's comment. >> - Remove reviewed-by tag from Aaron which was only valid for RFC patch >> but keep it by mistake. > > Reviewed-by: Yang Shi Thanks for your reviewing. Regards Yin, Fengwei > >> >> Changelog from v1: >> - Move private release to split_huge_page_to_list >> to cover wider path per Yang's comment. >> - Update to commit message. >> >> Changelog from RFC: >> - Use new folio API per Mathhew Wilcox's suggestion. >> - Add one line comment before re-get folio of page per >> Miaohe's comment. >> - Remove RFC tag >> - Add Co-developed-by of Qiuxu who did a lot of debugging >> work to locate where the real issue is. >> mm/huge_memory.c | 14 ++++++++++++-- >> 1 file changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 8a7c1b344abe..ae8c4e209e58 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -2627,6 +2627,8 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) >> mapping = NULL; >> anon_vma_lock_write(anon_vma); >> } else { >> + gfp_t gfp; >> + >> mapping = head->mapping; >> >> /* Truncated ? */ >> @@ -2635,8 +2637,16 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) >> goto out; >> } >> >> - xas_split_alloc(&xas, head, compound_order(head), >> - mapping_gfp_mask(mapping) & GFP_RECLAIM_MASK); >> + gfp = current_gfp_context(mapping_gfp_mask(mapping) & >> + GFP_RECLAIM_MASK); >> + >> + if (folio_test_private(folio) && >> + !filemap_release_folio(folio, gfp)) { >> + ret = -EBUSY; >> + goto out; >> + } >> + >> + xas_split_alloc(&xas, head, compound_order(head), gfp); >> if (xas_error(&xas)) { >> ret = xas_error(&xas); >> goto out; >> >> base-commit: d4252071b97d2027d246f6a82cbee4d52f618b47 >> -- >> 2.25.1 >> >