From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
John Hubbard <jhubbard@nvidia.com>,
Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/4] iov_iter: Add a function to extract a page list from an iterator
Date: Tue, 22 Nov 2022 13:36:57 +0000 [thread overview]
Message-ID: <824669.1669124217@warthog.procyon.org.uk> (raw)
In-Reply-To: <Y3zFzdWnWlEJ8X8/@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
> > +EXPORT_SYMBOL(iov_iter_extract_pages);
>
> get_user_pages_fast, pin_user_pages_fast are very intentionally
> EXPORT_SYMBOL_GPL, which should not be bypassed by an iov_* wrapper.
Ah, but I'm intending to replace:
EXPORT_SYMBOL(iov_iter_get_pages2);
EXPORT_SYMBOL(iov_iter_get_pages_alloc2);
which *aren't* marked _GPL, so you need to argue that one with Al.
David
prev parent reply other threads:[~2022-11-22 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 14:54 [RFC PATCH 0/4] iov_iter: Add extraction helpers David Howells
2022-11-17 14:54 ` [RFC PATCH 1/4] mm: Move FOLL_* defs to mm_types.h David Howells
2022-11-17 23:15 ` John Hubbard
2022-11-22 12:46 ` Christoph Hellwig
2022-11-17 14:54 ` [RFC PATCH 2/4] iov_iter: Add a function to extract a page list from an iterator David Howells
2022-11-22 12:51 ` Christoph Hellwig
2022-11-22 13:36 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=824669.1669124217@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox