From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B989C77B78 for ; Tue, 2 May 2023 19:05:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC8316B0072; Tue, 2 May 2023 15:05:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E787E6B0075; Tue, 2 May 2023 15:05:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3FC36B0081; Tue, 2 May 2023 15:05:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by kanga.kvack.org (Postfix) with ESMTP id B50BF6B0072 for ; Tue, 2 May 2023 15:05:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683054331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0S2yc+ZTNRgoAH3fjxIMA+gbVtscqyIDdigzY2/OjVg=; b=H/guvCKTa2jBVSoEMYQDGHzh+3kbmMudX0pl0/Z7AnqBbaxNVAvuLB9vh1lTLs5I4AzDxS xH2cvBKBMxcsFXbwu1NN4AkirkFQasEZ1NoeOqGF9qrkXMVAsjhCMkT+WVzKkSOmMwuZh6 ON2ELAmG8GqkFYh4hSNwSEnuPdO4am8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-IKvZ6PsxPA6Y30hXnwFayA-1; Tue, 02 May 2023 15:05:30 -0400 X-MC-Unique: IKvZ6PsxPA6Y30hXnwFayA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f1749c63c9so12814935e9.3 for ; Tue, 02 May 2023 12:05:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683054329; x=1685646329; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0S2yc+ZTNRgoAH3fjxIMA+gbVtscqyIDdigzY2/OjVg=; b=OS7om7hCtU9LbmfgLA54Jtg9v9P7pFZ2lsWem2BdxoXPb2QpWSQHtXSGGxoT/ODkAn rNthqCIc7+Hj1NT7XCKs2UZUn+cpufohat1M8uRaC8BR6HpFwoDkS5PIUny+doJOf+TM G9/98i4ofCMOJU4dsho7nifvpMTiuc4GuC0yAk7UwyiNJEa4cQJvz9d+IPRx6XTxXBIU dbC8J/sayBwVwFdrTR1B0QbDHstftR4Im7JAXxKur+WY8TpHyRcumHAoKcXTXUkHdSGG LexVjqPnKXOHqzB0XkgZKT4p1D8XO0LcI8OJcgFiFiXsJoZdWIhBvuN0flilQeM8Md9y 5fEw== X-Gm-Message-State: AC+VfDymQHiw+5/ajVAGn7Smx84ESeUFilb02YhUuG/U4LI4+QSVwsuZ ITsbFZnjXglyKQJrxKz1wn7RIkeGD3IXxJI3716VfMhIQ8unapCmiRiU8+PzbfKVymHB57CD5y9 iHsX8VUZiVfA= X-Received: by 2002:a7b:c015:0:b0:3f1:662a:93d0 with SMTP id c21-20020a7bc015000000b003f1662a93d0mr13369993wmb.15.1683054328795; Tue, 02 May 2023 12:05:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5V+NnBCdmD2ICFY88fyR5/MuVWTN0W2FYrYm/F35B55dmr3mxlkomvx8ayNTAEFJ/KlNPdKQ== X-Received: by 2002:a7b:c015:0:b0:3f1:662a:93d0 with SMTP id c21-20020a7bc015000000b003f1662a93d0mr13369974wmb.15.1683054328421; Tue, 02 May 2023 12:05:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:2400:6b79:2aa:9602:7016? (p200300cbc70024006b7902aa96027016.dip0.t-ipconnect.de. [2003:cb:c700:2400:6b79:2aa:9602:7016]) by smtp.gmail.com with ESMTPSA id m9-20020a7bce09000000b003f049a42689sm36193382wmc.25.2023.05.02.12.05.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 12:05:27 -0700 (PDT) Message-ID: <82368bae-b2cc-5d55-6de6-e3283cef063b@redhat.com> Date: Tue, 2 May 2023 21:05:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v7 3/3] mm/gup: disallow FOLL_LONGTERM GUP-fast writing to file-backed mappings To: Peter Zijlstra Cc: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jason Gunthorpe , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , Jason Gunthorpe , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , Dave Chinner , Theodore Ts'o , Peter Xu , Matthew Rosato , "Paul E . McKenney" , Christian Borntraeger , Mike Rapoport References: <1691115d-dba4-636b-d736-6a20359a67c3@redhat.com> <20230502172231.GH1597538@hirez.programming.kicks-ass.net> <406fd43a-a051-5fbe-6f66-a43f5e7e7573@redhat.com> <20230502185926.GE4253@hirez.programming.kicks-ass.net> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230502185926.GE4253@hirez.programming.kicks-ass.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.05.23 20:59, Peter Zijlstra wrote: > On Tue, May 02, 2023 at 07:34:06PM +0200, David Hildenbrand wrote: >> Now, if we read folio->mapping after checking if the page we pinned is still >> mapped (PTE unchanged), at least the page we pinned cannot be reused in the >> meantime. I suspect that we can still read "NULL" on the second read. But >> whatever we dereference from the first read should still be valid, even if >> the second read would have returned NULL ("rcu freeing"). > > Right, but given it's the compiler adding loads we're not sure what if > anything it uses and it gets very hard to reason about the code. > > This is where READ_ONCE() helps, we instruct the compiler to only do a > single load and we can still reason about the code. I completely agree, and I think we should fix that in page_is_secretmem() as well. -- Thanks, David / dhildenb