From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74110CD68E3 for ; Tue, 10 Oct 2023 02:26:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C53868003B; Mon, 9 Oct 2023 22:26:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDCD780027; Mon, 9 Oct 2023 22:26:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7CFA8003B; Mon, 9 Oct 2023 22:26:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 91C7680027 for ; Mon, 9 Oct 2023 22:26:49 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5E4421A04B1 for ; Tue, 10 Oct 2023 02:26:49 +0000 (UTC) X-FDA: 81327963738.21.8BD7E03 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by imf21.hostedemail.com (Postfix) with ESMTP id 8AEDD1C0011 for ; Tue, 10 Oct 2023 02:26:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Cj3+SQpp; spf=pass (imf21.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696904807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k6bZ4QRaLewauuynMhGijeUR1ZbN0za+0iHRlPIpluA=; b=Z5WVCufRGxvv1SZ1tqYyrJrGO3+2qbEJ4JSwa74STtNMuJXi93n9hfaMFk+BSBQKqor26g Bqf1YLVFOYyy+ZuNH/ppmlL6AZC4LrjVAlGcxrPmG7CoY2tVqpkZ476syZY/c8o/8NoQFB gjLBvRKapStfAgs+luEBDmeIvpGLrzE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696904807; a=rsa-sha256; cv=none; b=CNyfVJSxNiDnYkV+KMoDT2Gc6AxNwXqJsELSDqojVwUCZ25bFV4KSEtLeutg2jfGfwvqhu kPUOlNPwGOHt5SMzuFCWWydP7t4pkEl31VJ5wi61c0m6+IwoHAYNRZ1niRXrZ7+D2ajQe0 BmJtdDjniSBHxqWEQHeYyKA4PLysKSY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Cj3+SQpp; spf=pass (imf21.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1dd6128352cso683112fac.0 for ; Mon, 09 Oct 2023 19:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1696904805; x=1697509605; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k6bZ4QRaLewauuynMhGijeUR1ZbN0za+0iHRlPIpluA=; b=Cj3+SQppNuQWJdl/XAj4UGFFVPEddYF5NBzeNjXM3QMbdwbi9Bzz3l+HejETxU10bG vEszrU6GSCd0Sqmh4fqaF6EaLNQjt1W2xSqBwNvxiBeqzuV9K++UwRJhPxSfTiANzq5E yO1JAeQbPJHZ25tYFjjXtdaV1MS4mnzWA3SPNbuEIGgJ5MYB4zbqj+J6kt81pgO/HyJc 7HXBX+pH2FvdAGjFxjoW2ywkxghawY9ldgl4JKob/ZiiW0OkQEGmN+0d3BqQeXK0dZ4H 9M+LKuFaTZ6hpjlfGB3Pg7DroRqTtx2IKstg/8eRUC+TJskeU/407r47/5fIhmWHIAY3 1KlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696904805; x=1697509605; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k6bZ4QRaLewauuynMhGijeUR1ZbN0za+0iHRlPIpluA=; b=BMsJsqIMVH/psfC9qo8Gl64hRWmB3+CginH5Q+LDGqgGe5Sx9kanxQFDJ+fxooymaJ QumstEF9D1piT8CgByaAFo1OaTMdbVEkUYKMQhJZXh+czLklYlT7FZj4wOxFHwzHp+h5 zTFsjevVCd7tGDQ+fnSN62vcASVARwCaw8LaJa2Ffvfs1GSfs2fxYEs9NHhXAa6YUrAF qfyCk+F/BR/L/J9xT8w28+kFOCKFYPtFPV35hVqyrysuf8afOptVpDBEMR+B075zis+m SZH+CZycXhrACVT4WWrVaPlE1L9ZIlZphzI6ozAnBRZiC+OJ4oTMczrf4l0VojdIrHzA fN5g== X-Gm-Message-State: AOJu0Yw693YQKw94ucrZIXqgu87qpvWHCOdu1j2RA9VJBCjvenSKftRr YnHNaueEh6pWof96r1TQJsfqCg== X-Google-Smtp-Source: AGHT+IFNMfNUnQAw7Ukgw85jFGTqS0jfqdmMiuCZUaFcEa86nIOtKLHkoMXr8LRVeXlaGvzRXU8H/A== X-Received: by 2002:a05:6870:561e:b0:1d5:53c0:c1fe with SMTP id m30-20020a056870561e00b001d553c0c1femr17976060oao.3.1696904805328; Mon, 09 Oct 2023 19:26:45 -0700 (PDT) Received: from [10.84.155.153] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id fe1-20020a056a002f0100b00690c52267easm7041036pfb.40.2023.10.09.19.26.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Oct 2023 19:26:44 -0700 (PDT) Message-ID: <822387b7-4895-4e64-5806-0f56b5d6c447@bytedance.com> Date: Tue, 10 Oct 2023 10:26:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] mm: add printf attribute to shrinker_debugfs_name_alloc Content-Language: en-US To: Andrew Morton , Lucy Mielke Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20231009175006.326e61e6c0e46e6ce78699ff@linux-foundation.org> From: Qi Zheng In-Reply-To: <20231009175006.326e61e6c0e46e6ce78699ff@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 6m8hbekmbz6jc8qaaqipgcgn3hy7e9cc X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8AEDD1C0011 X-Rspam-User: X-HE-Tag: 1696904806-978915 X-HE-Meta: U2FsdGVkX1+9ZcJ/5bO+jL6b/P6H9lhhBeozYfQAFg2zuRQqrl5AJk4ZJnzvnMmjFvIIweWb3pbtqT+YugcwwdEOfsMN97nmo6/7RRGBBpmlrcPIgcEDSK4pVYwHcQ4ATykUwLjfB+VxtVEOoQ45CkbYwNeq5Y9AJRyBh9rp831iywUdNs1JHksliLiRKijmoO55R3RxCCZYU7yoxf4x/GNg16J1Q/S/0n1rUMjdRY1CwR5hsAhqwacqCrYUxlaEtuIR+NEKyuRigp0QQSAlcIU4bqIL4DJjRyJhU9GqK5BW1AWLWL+UTEB8lQWq2eFlq714021aplpckqc2bh8z6AHziBOFQIPt7CrC13RIpnn7PRzBJrPB4s9Ap1cO5ZuDBTmM12yLNzmnZzcYxaif1W0bzFKzzikl4q1FvpCnG5z9V+0zxbZQbeZACL3+101EfVP7DNdyiCw2bfLA0ZNWUXhCU3+cLzT8pXQ0q9ZTNrb4hEJ3sv+ZaFJxjN2t9tqZBHHSbNpCgjQ8rRYpbRIU0JESnvLLe0x0YBnT0CVgcG3Cmn/HRxKyFE8W/RO+iUE0rdo93T2DPvIyqgEky2i4qEWpLUbgJ7vtT4ngF4gUOUuysQyzlEUeX8WQkVtlNZmD3NorLUP/ktaq79Ukqk0r+vh97NkhTstFh8zc8SxBTuq29LGqpIQ/VCuj+lcy7c8+zAirawVlcNgMstxvTyIOMiXCpBk0OMq+Lr04tLPQ0LPKmWqy6CXQYz2hE+d9wVMuSL/tj68kQr8eQIWkRWkDpB6H/yq17CZQo7GKLcVOlt0ZDSpVu9ZYPoVM9H8zaCQ6NzpCzkaYMI29u5vCCyt/4t76nJeGVHPiDrZZAcyuOBYzLCxQ6GwV0I+JO/4W8U2DbMMRPZY3fSC+Y0Ifh+mxXy3l1LRrsX/iX1PY4kg6o474HBLECUPFbfrzcxdwOd+1IYnK3qtY9Wlmw3UmFMq 1G80x6Yk sCwxnKq7Zse6sA/XcwE/gPVREVTYG3JjOlHp6fxSofy5E08Bd3+ff1VDNEb47+dSz4QieK0pRYsMgXtaPeqBVfhrVhIs6rf/XblZe4txKBN8weZge/0v8wEIhiswGeOx3ImudGn+pCShrdh/oHmmMBA1sIvEefZ7iuxU7buvEakXcJ6jnoohVVfHIaaHsKinPJxzTOFNfNxSO8j+0u92nec6piB0JBAxWZj4MsQ5e3fNlHw6D8FLVmh+GkxnWJpPPQMmr6p7NOdtLB5RZv5r03iS6mQbPTeoL/G2O2YA/TQRAsHLFOMWn4VoHRp6tKLLZf3cXXdFNfFdW6KIpm27oalwi0iia/DeX455Ws84DtTEs0sRhoxly9ENDuSBc0kMRNi91Kp5izoqRM39em/UQBSJa9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On 2023/10/10 08:50, Andrew Morton wrote: > On Fri, 6 Oct 2023 22:30:51 +0200 Lucy Mielke wrote: > >> This fixes a compiler warning when compiling an allyesconfig with W=1: >> >> mm/internal.h:1235:9: error: function might be a candidate for ‘gnu_printf’ >> format attribute [-Werror=suggest-attribute=format] > > Thanks. I added > > Fixes: c42d50aefd17 ("mm: shrinker: add infrastructure for dynamically allocating shrinker") > > to this. Thanks. > >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -1229,8 +1229,8 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, >> int priority); >> >> #ifdef CONFIG_SHRINKER_DEBUG >> -static inline int shrinker_debugfs_name_alloc(struct shrinker *shrinker, >> - const char *fmt, va_list ap) >> +static inline __printf(2, 0) int shrinker_debugfs_name_alloc( >> + struct shrinker *shrinker, const char *fmt, va_list ap) >> { >> shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); And there is also a warning introduced by c42d50aefd17: mm/shrinker.c: In function 'shrinker_alloc': mm/shrinker.c:688:2: error: function 'shrinker_alloc' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format] 688 | err = shrinker_debugfs_name_alloc(shrinker, fmt, ap); | ^~~ This also needs to be fixed: diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index e4f93120e0ab..1a00be90d93a 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h @@ -131,6 +131,7 @@ struct shrinker { */ #define SHRINKER_NONSLAB BIT(4) +__printf(2, 3) struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...); void shrinker_register(struct shrinker *shrinker); void shrinker_free(struct shrinker *shrinker); Other than that, LGTM. Reviewed-by: Qi Zheng Thanks, Qi >> >> -- >> 2.42.0