From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB379C5320E for ; Tue, 20 Aug 2024 08:41:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41F626B0088; Tue, 20 Aug 2024 04:41:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CF826B0089; Tue, 20 Aug 2024 04:41:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2971A6B008A; Tue, 20 Aug 2024 04:41:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0B2AC6B0088 for ; Tue, 20 Aug 2024 04:41:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 834B1A9A55 for ; Tue, 20 Aug 2024 08:41:33 +0000 (UTC) X-FDA: 82471980066.01.314AEFC Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf22.hostedemail.com (Postfix) with ESMTP id E25DAC0017 for ; Tue, 20 Aug 2024 08:41:30 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724143213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u5Juq2nBrJtbxj0EFgLYse7XoGc4Z+yAgI5qvtCV5po=; b=BOTlvg5ikyriTLd4f4c2OZ2rvNVRqATVp+uxfsozFbZO+dE2qnOdnd4dgP60DZICQI5FvO hKEEdEvgrKqUSGHptOd4JXsD1BAmlutG6Qa9ZyRA9NKFIS1RtSQN6OdjUYYfaM0PSnlU2n lPD0liWba7K7nkJiSJJvcXdiUH6gdLQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724143213; a=rsa-sha256; cv=none; b=Nfppoh4IdS69QsjEpvze3trzn2adW8jOYi8F7TLLzSlBu0XAWbjHJ7iWZaynEafJ/eTurz VDtuMmNGlU7Kn7l+L5RdbcFyiImnc+3RyjldyufTsShYLVsjw8IIPJ8be/utkyiqIa9D8V TM+rEUlMVxu2fspHMyxqrcPQZFvThOQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Wp2qv03hzz1j6n7; Tue, 20 Aug 2024 16:36:27 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id 6DB801400FD; Tue, 20 Aug 2024 16:41:26 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 20 Aug 2024 16:41:26 +0800 Message-ID: <82225d4c-2a6e-4ae5-ba7e-3b92f1d3b0be@huawei.com> Date: Tue, 20 Aug 2024 16:41:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] mm: finish three more folio conversion Content-Language: en-US To: Matthew Wilcox CC: David Hildenbrand , Andrew Morton , Alexander Viro , Sidhartha Kumar , References: <20240817095122.2460977-1-wangkefeng.wang@huawei.com> <4ee78f2b-05e0-4f6a-99fd-73e6571e91d7@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemf100008.china.huawei.com (7.185.36.138) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E25DAC0017 X-Stat-Signature: a3uzf4fm18cbncea53fw1bysy8kww7q4 X-HE-Tag: 1724143290-528169 X-HE-Meta: U2FsdGVkX18gtdE9ll3rqRytJKKq3XmGdKVFPpJ/7xFuXzjGob18j9aZyzcrowkHRL5Dh7yx4K6pApwU9tVCyIZyNdauqaZNLZt5leEI9EMLObrMiplbCBRUJ/OvsDd5FGEndW0DGR2CmB59/+/sZo2jFMU7HVdyVGRezRM8M42PsimT6zlGAqlVyieakHggKJvKQ6hkEbtzgg5nQxNUuAzMz7aMEjeK/zlXHSLjSq6vGQvEGqxAAw9m0QrzlCsKQPrqS+8uQxCpIKsmVLLSiRS3WoVEuc6o9x2x5pR2UuqmiqxD20A8Lfx5KHN62rTQozpeqcVhRs+d0arxOxqGfRMsyVz1n+bmfb1LrgG08vBgoL9uf//JvX/5nsqCMQtuy2q+M7VcAwovVxXmz50lggvbTR/D+JgMcqVU/NHqIgFdcPXmVXdW4BQrPdt3y2TinXgLyM9vYVY5SoTRXRhPqAe2/4n7HoHJYKYyDt9R+ocimY0xduOmdcz9q0Vhuo10oFMRsqfPKq2HK5onzjc9pn4t/83ztH7Kmgn1ttgPAW9WjVpB6A4iLaR8HthMaQ5t5M2JhE1IPbjoSChPnxDobGTB+MCfi2EQl2nuF57kH8RZzZ8dbd5MdN2G5ztBxgRzFGyG2Mbhz1nUhUk4OYCiCdTmVFhpjAWetriVUtx5EO6pi7epEdcHLsEFE2kr0/AvzJeoRwLcqfzTiJqsyrMRcXCiAd3uJnao/UtT0OXU1TE7BRWNDBOdaRuG5avPHW5IPRnZGUAOazIPu3wAYiEG+L+0Q8UFh7rDc8KeVTdKfiB291Wo9wFRrKa3yw0w97DXHusdgs5rawp8+KgH2wDy9ylboasM0nNA2iRW0EfZU5IxJaYliQfNCXWSKprKPkmfcPWcLpPTbSIXt8wBKmAJyrNSfW17gd3+GLUfV+gXdZGL/nOLuPwmO1ezR5voRXpnB+zJER5GKcpYtyJNztX jYli4kO6 XxewDxqdR1j/gNUga+Te3RPOzt4jJeIj3VLruBPCz7r0B91bD0JVS8QFvULas5f8ROSGWbldwSSll6JcdwRVD07Atpet/TQxKI+G+Zl9Nl704+9kwBbHCbPpaa7avcmMGuIGZxJezYKl/xqvbdO5Pvob3x87UZkuZBkucHyHzwxG/oKyHGsvXhb0quQU6ewDX/EWQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/19 21:20, Matthew Wilcox wrote: > On Mon, Aug 19, 2024 at 07:13:18PM +0800, Kefeng Wang wrote: >> On 2024/8/19 17:59, David Hildenbrand wrote: >>> On 18.08.24 22:33, Matthew Wilcox wrote: >>>> On Sat, Aug 17, 2024 at 05:51:17PM +0800, Kefeng Wang wrote: >>>>> Convert to use folios then remove find_subpage(), thp_nr_pages() >>>>> and PageTransHuge(). >>>> >>>> This patch series is premature.  None of these APIs are particularly >>>> advantageous to remove (they're inline functions, so cost nothing unless >>>> used). >>> I do enjoy seeing the removal of thp_nr_pages(), though :) >>> >> >> The thp_nr_pages() and PageTransHuge() removing are found when improve >> memory hotplug[1], also find_subpage() has issue[2], this is where patches >> come from, since there are only few callers, I think we can >> cleanup it earlier? > > No, leave them alone until we get rid of readahead_batch() and friends. > It is beyond my scope about changing fuse/squashfs to remove readahead_batch, will separate find_subpage/set_huge_pmd changes, thanks for you suggestion.