Re: [PATCH 0/5] mm: finish three more folio conversion

[Kefeng Wang <wangkefeng.wang@huawei.com>]

On 2024/8/19 21:20, Matthew Wilcox wrote:
> On Mon, Aug 19, 2024 at 07:13:18PM +0800, Kefeng Wang wrote:
>> On 2024/8/19 17:59, David Hildenbrand wrote:
>>> On 18.08.24 22:33, Matthew Wilcox wrote:
>>>> On Sat, Aug 17, 2024 at 05:51:17PM +0800, Kefeng Wang wrote:
>>>>> Convert to use folios then remove find_subpage(), thp_nr_pages()
>>>>> and PageTransHuge().
>>>>
>>>> This patch series is premature.  None of these APIs are particularly
>>>> advantageous to remove (they're inline functions, so cost nothing unless
>>>> used).
>>> I do enjoy seeing the removal of thp_nr_pages(), though :)
>>>
>>
>> The thp_nr_pages() and PageTransHuge() removing are found when improve
>> memory hotplug[1], also find_subpage() has issue[2], this is where patches
>> come from, since there are only few callers, I think we can
>> cleanup it earlier?
> 
> No, leave them alone until we get rid of readahead_batch() and friends.
> 

It is beyond my scope about changing fuse/squashfs to remove
readahead_batch, will separate find_subpage/set_huge_pmd changes,
thanks for you suggestion.