From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 751FDC369CB for ; Wed, 23 Apr 2025 06:56:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E6B46B0005; Wed, 23 Apr 2025 02:56:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76C166B0007; Wed, 23 Apr 2025 02:56:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6335C6B0008; Wed, 23 Apr 2025 02:56:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 41B986B0005 for ; Wed, 23 Apr 2025 02:56:01 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0A952C1090 for ; Wed, 23 Apr 2025 06:56:02 +0000 (UTC) X-FDA: 83364398964.24.7FDCEC4 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf18.hostedemail.com (Postfix) with ESMTP id 0FB4B1C0006 for ; Wed, 23 Apr 2025 06:55:58 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=H6zEQMxC; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745391360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H1skONK6cs8UBil9X8sWmmdRUJr3xZeKqf2Y3Px4r6c=; b=vGkPRdf/PY/SMCkqk/8Ce10ROl3KdPp7ka5NSk0bnmfQB/JXBvJciuJuKdgFyHrdsRRSUD 6Zc5BoBDKf5kooS5dVGT8sDqg5D+oIiVQ25JWsBRda9MMDJgvJn7JH4QuXiObURadZ8g7O pgfdUCq8tvlcklr14Id+Mf5PnnxUNHk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745391360; a=rsa-sha256; cv=none; b=T50G0FXygZd0eFji0VnNBpGbx5FKEPmRMLdXvHvv24H7QQDveaVrk00ZkWd/ZGHgmdM5LH qCocVKQeHFkBzVANvErhOXjhGTGdGAJgSGVHVuD7U2/e+f1PMNUY/f0xZvHS4c8R9J2LcH fjp+fW2r930IPvlr+rJpFS7KDT1U0yQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=H6zEQMxC; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1745391355; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=H1skONK6cs8UBil9X8sWmmdRUJr3xZeKqf2Y3Px4r6c=; b=H6zEQMxCehdrixOQQK7BLU+jBWiVoYsnD7x9AouXhJW8gZ6W1e8TUQj23Imt3Uvzx71MYcZgwAk0roMSwSKGwFMq2gECipz+zbYrkpnQbhcagWsJDr3sEjIaNbvguZAOAH1oZ5venpAE444hBuUwD/X63Qru7zsC8ElxosHyT88= Received: from 30.74.144.121(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WXtS1Fp_1745391352 cluster:ay36) by smtp.aliyun-inc.com; Wed, 23 Apr 2025 14:55:53 +0800 Message-ID: <821dc0ef-faf9-460e-8396-2c0fdf3f6e94@linux.alibaba.com> Date: Wed, 23 Apr 2025 14:55:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/12] khugepaged: generalize hugepage_vma_revalidate for mTHP support To: Nico Pache , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, corbet@lwn.net, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, david@redhat.com, baohua@kernel.org, ryan.roberts@arm.com, willy@infradead.org, peterx@redhat.com, ziy@nvidia.com, wangkefeng.wang@huawei.com, usamaarif642@gmail.com, sunnanyong@huawei.com, vishal.moola@gmail.com, thomas.hellstrom@linux.intel.com, yang@os.amperecomputing.com, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, tiwai@suse.de, will@kernel.org, dave.hansen@linux.intel.com, jack@suse.cz, cl@gentwo.org, jglisse@google.com, surenb@google.com, zokeefe@google.com, hannes@cmpxchg.org, rientjes@google.com, mhocko@suse.com, rdunlap@infradead.org References: <20250417000238.74567-1-npache@redhat.com> <20250417000238.74567-4-npache@redhat.com> From: Baolin Wang In-Reply-To: <20250417000238.74567-4-npache@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0FB4B1C0006 X-Rspam-User: X-Stat-Signature: h3exae39qcyky33b97usgkr81pxx7i97 X-HE-Tag: 1745391358-369034 X-HE-Meta: U2FsdGVkX19lUz++Oa9e4kg2+h+YqwrxPwZK0X2/EkgPtsI/g6EBj9Wt1fLzHSgaDqFw1DewTfKZpB1xYGn4VKbBRoBKsOx3RKFetlEFQXoReJTfbyjPw2X51mHK2iNIscSMK1JT1xtETyHoQz3ceNOJ5RhC55ETjODvSJdIPaipqA/xTSCofSwCrOOZN+LwDBA7nRU1UuVFVFEb4YLUaJQMpqFu8NFK6ZWrQrJueAEOgnFaJWuR749EjKVGoF2KF0beRxguL8/NRFTrv6HYZqx7Yns7tM2Uipt90trNZmaRfR2Yz8JlocAwsNMd/Ubn/LyHprvEiex/iK2rolh3QFc6x+iqvByYi8x4sd8GxQFKFlG/nrRbfJVjE4otccEKsNNiuPcwpDGhzxAPGByc2nrFA8e5vIl9VXtX84ibn/avKs9egl1xCQ0mASKqboDAwRmYdkB6iYhFcCJ7gQ4ouoa8RgBZmvsoVel7f/S0UFl7hgdz215AV4Uh8emEllenKLLzmt1CHLQiexYarlnf/PQymsh906TdB0CYDoe9AsPH3dIwEJ1k+etsxqZOFUeyEyEBBCss8QeRGHj7w++obL37FoXXOd9nOpiiElk8FmxbP4QCMj8N5/fiyxGr1HVL7Dd3ouzd/pKxEb2wn1qO30WJBCVx6vHGOsga6MnOCCjXX5sAKLShVSsgeiE8pLtXwPZvbGtcp+yidLy+daFnq2R/SJgl7vqvBoH4v98M3Xq0A8n1R3b9BUF22Z5Pd0Nayt4p0q8jDu1MGGRgf9hgmx7Q7s2QsJ+sL+hhrwgFJ3EEYe3ElJ0lrK+QpyVzeW+1HKgwYOTt0m/4H9z4Iz9ki5ojVl4RoxaiCTYunt5qRP2ygUAv971nYOsAy6syGSCXCVLSpIuTSn/MQSP3NmBy1sAEorsLTZ8EYVGwtscaWNc4or954t4CQ/UkeQKJZlFzuvC/1Zt/CEVZM/hB5E3 0ePTZ9bZ fkkaGEWKm31WGjKRPHQenH50ro1M0Jcp5QwSeg6dfMPGUfAXUGpf7hLASZdQUcBRmqVHA0ytFpBzXE3n9TY96L76VIdHQQucmBZdTXR0q5i73wqL5AIpb3W+/THwY17jb+tds/blpvYoToi6AcvODESVHO5rDu4LNcr/GZSHLaVmWIrJLGM18K3T1qsQX4PKVzxrl+tyRZ5sU8q8dbOPJW2q3eF9twPKXM8c6ozcH5cfdBK0BkuUJmiQ9J7PtsqUgd2ODQAMGFmeEPjt1AyYtywSV870pTAEOI/W9/hQM2LdD8MCAA/l+eiCR+E+TE0b814ZtFgH5SFqHm2yNkllusY3kXTnRwTwYG1Qmu9BggPnvTGtBtT79M4xdv6TWmq85aA6Vi6jwmVYhDllGHnmf6RnchGdKc/niCJpe8u5vvW14nyzwISZWFe4qY6pZbMVlk7/sFH59ijOv31hFxsaRxAuRq7Fn5qTSZBNd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/4/17 08:02, Nico Pache wrote: > For khugepaged to support different mTHP orders, we must generalize this > function for arbitrary orders. > > No functional change in this patch. > > Co-developed-by: Dev Jain > Signed-off-by: Dev Jain > Signed-off-by: Nico Pache LGTM. Reviewed-by: Baolin Wang > --- > mm/khugepaged.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index b6281c04f1e5..54d7f43da69c 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -920,7 +920,7 @@ static int khugepaged_find_target_node(struct collapse_control *cc) > static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, > bool expect_anon, > struct vm_area_struct **vmap, > - struct collapse_control *cc) > + struct collapse_control *cc, int order) > { > struct vm_area_struct *vma; > unsigned long tva_flags = cc->is_khugepaged ? TVA_ENFORCE_SYSFS : 0; > @@ -932,9 +932,9 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, > if (!vma) > return SCAN_VMA_NULL; > > - if (!thp_vma_suitable_order(vma, address, PMD_ORDER)) > + if (!thp_vma_suitable_order(vma, address, order)) > return SCAN_ADDRESS_RANGE; > - if (!thp_vma_allowable_order(vma, vma->vm_flags, tva_flags, PMD_ORDER)) > + if (!thp_vma_allowable_order(vma, vma->vm_flags, tva_flags, order)) > return SCAN_VMA_CHECK; > /* > * Anon VMA expected, the address may be unmapped then > @@ -1130,7 +1130,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, > goto out_nolock; > > mmap_read_lock(mm); > - result = hugepage_vma_revalidate(mm, address, true, &vma, cc); > + result = hugepage_vma_revalidate(mm, address, true, &vma, cc, HPAGE_PMD_ORDER); > if (result != SCAN_SUCCEED) { > mmap_read_unlock(mm); > goto out_nolock; > @@ -1164,7 +1164,7 @@ static int collapse_huge_page(struct mm_struct *mm, unsigned long address, > * mmap_lock. > */ > mmap_write_lock(mm); > - result = hugepage_vma_revalidate(mm, address, true, &vma, cc); > + result = hugepage_vma_revalidate(mm, address, true, &vma, cc, HPAGE_PMD_ORDER); > if (result != SCAN_SUCCEED) > goto out_up_write; > /* check if the pmd is still valid */ > @@ -2790,7 +2790,7 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, > mmap_read_lock(mm); > mmap_locked = true; > result = hugepage_vma_revalidate(mm, addr, false, &vma, > - cc); > + cc, HPAGE_PMD_ORDER); > if (result != SCAN_SUCCEED) { > last_fail = result; > goto out_nolock;