From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C5FAD1BDD9 for ; Mon, 4 Nov 2024 18:16:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CA2A6B00A1; Mon, 4 Nov 2024 13:16:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 451EC6B00A3; Mon, 4 Nov 2024 13:16:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27C636B00A4; Mon, 4 Nov 2024 13:16:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0CC766B00A1 for ; Mon, 4 Nov 2024 13:16:25 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BC694140865 for ; Mon, 4 Nov 2024 18:16:24 +0000 (UTC) X-FDA: 82749216270.06.6C010EA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf09.hostedemail.com (Postfix) with ESMTP id F3A82140008 for ; Mon, 4 Nov 2024 18:15:59 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2GzPcuRX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vVREFjhx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2GzPcuRX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vVREFjhx; dmarc=none; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730744124; a=rsa-sha256; cv=none; b=6MQUr7Xhm4LUWMgz7yKUbhLUIEFOOa1P9kCc5h+WrHzvRKqk5rtTliKyo/Nsoce5qS8el/ 2B9P/hry7nSAWlw9RNvMIY5VGtH/rGTdwd9qw6MEOqQcSqIPK8NJi7xbab+SVPJS7QPrAk SMgoKq1WcTU1xnqCZm1UgEWtvvHJpws= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2GzPcuRX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vVREFjhx; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2GzPcuRX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=vVREFjhx; dmarc=none; spf=pass (imf09.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730744124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k5V18LyJV3CUrSq+qWIFH8rlajtGqEPc28Enl0HF0qw=; b=EwYEfmpR/jStqLzkaI0YDzq4oeWTKv8AhEWuLj5qa4Xneqlw2PFFbEKeyFbjjnBunHVgTb 5Zc4F6cLvdV6z4KVSyuow3bopUGuu13h0Uvf5pSCknjkPEWUQHJm/PsY3R0Yi3CJ9m9GWC fvvdv0TZPA5sXBK8d2a5n5UD53Utspo= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B18811FDE9; Mon, 4 Nov 2024 18:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730744180; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k5V18LyJV3CUrSq+qWIFH8rlajtGqEPc28Enl0HF0qw=; b=2GzPcuRXRfn4xDmfuj7a/0olwmk0CkW1Muw6yeVhN5jZaarbGLkl+4lDLZbYc4KGDfbJH4 aTYWGlpQJaGKqpElYy+Njc8O4O37TRYzXvYOn1zXKOddA/982/0y/awqz4H4IvXX/REVtA oj3LO/QGd27ZirpZG5xRetqnB9wcooU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730744180; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k5V18LyJV3CUrSq+qWIFH8rlajtGqEPc28Enl0HF0qw=; b=vVREFjhxhSisyxxWmkeZonCegyFITtrLbheAV12CA8dWoLHTJymRsTWTgf2ODzbMAx9eHt Kw3b+E5FCRaaR/CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1730744180; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k5V18LyJV3CUrSq+qWIFH8rlajtGqEPc28Enl0HF0qw=; b=2GzPcuRXRfn4xDmfuj7a/0olwmk0CkW1Muw6yeVhN5jZaarbGLkl+4lDLZbYc4KGDfbJH4 aTYWGlpQJaGKqpElYy+Njc8O4O37TRYzXvYOn1zXKOddA/982/0y/awqz4H4IvXX/REVtA oj3LO/QGd27ZirpZG5xRetqnB9wcooU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1730744180; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k5V18LyJV3CUrSq+qWIFH8rlajtGqEPc28Enl0HF0qw=; b=vVREFjhxhSisyxxWmkeZonCegyFITtrLbheAV12CA8dWoLHTJymRsTWTgf2ODzbMAx9eHt Kw3b+E5FCRaaR/CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8447113503; Mon, 4 Nov 2024 18:16:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id e5vKH3QPKWepSwAAD6G6ig (envelope-from ); Mon, 04 Nov 2024 18:16:20 +0000 Message-ID: <8202821f-05bc-41f8-9de3-bf78899a7c7b@suse.cz> Date: Mon, 4 Nov 2024 19:16:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slab: fix warning caused by duplicate kmem_cache creation in kmem_buckets_create To: Matthew Wilcox , Koichiro Den , Peter Collingbourne , Catalin Marinas Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, kees@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20241104150837.2756047-1-koichiro.den@gmail.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: F3A82140008 X-Rspamd-Server: rspam11 X-Stat-Signature: exge3o3t3fpygpsk86azr6yixq3xcar6 X-HE-Tag: 1730744159-161004 X-HE-Meta: U2FsdGVkX1/VgA08wq0FU3JlBwX6dLyH+vfgp/HTSIcWph9d02ap63Irf3K9lvFwz1yIxjMsglCz4hrhQxSGsYUnaW+OwirHXIl/5AHIjqKtO83Fa1Y8Ska/gWdjwYUp9vU8Zp6NjspBU2t1hw6eKCO7AovVb/kGbIPsJM1bfsBBzKHUAdompGdQt2MeM6VV/4WzMSLsui+ua437uA72olewguCUqDYR7duyQQ6d68mrAFP3580Oa1bxiLj9N2SFQwVgsJDjddGeubVq2ZuFbZiUYmq8wPNrwrGqUUwgEvj3BCulMEny1XxPLWypHSqHbqpz7yI9IuuftBDmJUwssBX9Wl+C5GEaCmTGJKnkMmZn+Jxuul6fgmKP5hIYBq/s6wlK06iI3Dr5655B0e72TSKQneZyH3lNUD34v9Lh4f/JeGSlhh7uAhT6QC+va4Iv6j858l2CbUu/tDh+ampSo9rGnf+3OgvtjaDf3fluD33gn8pewP/TrtsR3p6Q8zqHiOdVKC5nMktCCoHKwMzsCV5Gc8kHA28e67USV8xbsUKxdpQcWdiyPDxVeeHTDg8YkYa5KhIMfArXe4dSQ+IlQyLknNWLuzjHXbp0MyVoBFl2FEZ4uK9UMTkSccA+FI9ztWaOfOeHLoeZGsb+8v/+/3F6aEEknGvucqoX4eTQ8SMMwzk5s8QE2sSpqamiIBiLhXl3A3chm66vRBDxjAiXW7Bp5tbb0Cmw1xiG10aGCgOBPGgc0cyEMx9Bc3/7BPUIysnbWrNN0j2CGcSEap9aTu5RXCm5zlDklTrXZcpTnrZSO8qU1f2BwNA6/AVwA2VOe8EbKDNIsqG459pP4A4FMUXS8BAg58LP5qot+oEjjXpgh2QK7/Mh58EDFXLXGfA7YF0NPS7CAqiqP6uubfFFmkjGMmGbRHD9LD7C9b032YlX6EMWPPVhgxEvtRsea1bHUNzncadc4n7SvTVXzDO kXOOJEfs eEaMM1L+dc0BtuBtaHyPpWeuMUmyzj186vMwm1FAcp+eS/6uDZKjftsmnDpJaXs+oGZHEMArrQjo8Ny7+akqdG52jI7fsnu5WSlHB8oK50VlLq8pJaI1TXeTqXBsacjz98aVXtp58MMQrrBHQHNYU/5uzZHMqHlqua9VCp1SwJX6l2D6Lk9ou/5vw175b4EcT6p0VwcDdGlX870UqQ/U1oUxNW7JT7otc0xXZpkwtUZT6UkjhJbUg36OX3h7QXsfMD2L+a0Rdefo6jxiUcA0p7XzDeLH8Ao+lNxRKqQkfc2cLAbRaqrzqa4k6v1Y795uL4ykVK42t613Miv03B60qbKAT87zHXGR0jLixyWiag5iT1xD3zyv5hT2r3dbilFL31yUG+0nEJ5JbArxl/TyvjvhRjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/4/24 19:00, Matthew Wilcox wrote: > On Tue, Nov 05, 2024 at 12:08:37AM +0900, Koichiro Den wrote: >> Commit b035f5a6d852 ("mm: slab: reduce the kmalloc() minimum alignment >> if DMA bouncing possible") reduced ARCH_KMALLOC_MINALIGN to 8 on arm64. >> However, with KASAN_HW_TAGS enabled, arch_slab_minalign() becomes 16. >> This causes kmalloc_caches[*][8] to be aliased to kmalloc_caches[*][16], >> resulting in kmem_buckets_create() attempting to create a kmem_cache for >> size 16 twice. This duplication triggers warnings on boot: > > Wouldn't this be easier? They wanted it to depend on actual HW capability / kernel parameter, see d949a8155d13 ("mm: make minimum slab alignment a runtime property") Also Catalin's commit referenced above was part of the series that made the alignment more dynamic for other cases IIRC. So I doubt we can simply reduce it back to a build-time constant. > +++ b/arch/arm64/include/asm/cache.h > @@ -33,7 +33,11 @@ > * the CPU. > */ > #define ARCH_DMA_MINALIGN (128) > +#ifdef CONFIG_KASAN_HW_TAGS > +#define ARCH_KMALLOC_MINALIGN (16) > +#else > #define ARCH_KMALLOC_MINALIGN (8) > +#endif > > #ifndef __ASSEMBLY__ > >