From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B317C433FE for ; Fri, 4 Feb 2022 23:39:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39BB56B0071; Fri, 4 Feb 2022 18:39:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34B956B0073; Fri, 4 Feb 2022 18:39:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EC256B0074; Fri, 4 Feb 2022 18:39:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 0F2236B0071 for ; Fri, 4 Feb 2022 18:39:42 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B4F87824C42D for ; Fri, 4 Feb 2022 23:39:41 +0000 (UTC) X-FDA: 79106716962.21.27C1D7F Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by imf11.hostedemail.com (Postfix) with ESMTP id 4EF2F40003 for ; Fri, 4 Feb 2022 23:39:41 +0000 (UTC) Received: by mail-io1-f50.google.com with SMTP id 9so9387965iou.2 for ; Fri, 04 Feb 2022 15:39:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=chay6cI5krPMdvmjI0OgtPSx/juylZb2Zp77TTGYBDU=; b=ghF9s5MbclL4SAtvIK2qGV+BljWVspJXqofubIdxJEF14Xz9ytHpkkFxpswuY/BsgI jyktOsJw7HiIBplyOMdLypyl5fEAN123X3pm30RrXatGH7VJLU0G2sGL6oulw1BlK47Q zlEtzHahkHzgXbyjsAtGOBVSuOZtqDlBcOdjI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=chay6cI5krPMdvmjI0OgtPSx/juylZb2Zp77TTGYBDU=; b=JC7BYXv0IdewCdmYW881jVmLr0fuuQiiDrSTEg+MAYp8rxFm+OJAKSlnIdXv0SlQRl gagQ6IPCgdsI0xaQeAR90ql1zjF1q4lfZcXalx6+nswjpSzmCTTwcqEurICfE2Nfxy3k mTyjovypF/WKbqE6vkO30Uv1Br7L7x8WGfdig4D2lViW5tgXTk0IyzYvJBO8Ov4pJi7u SyNPfX4DEV8WFd1hw4Xg1iqZ3fgdZszfXgWJn3WaDGxAdQ1Umw4Ue9Tzve0Wv+RJsU1i xFjN49B4Iay0mdfYwA12ij0UtTSlsfoM66PLy4G3rljLZcW9cHohhYs5Vto7VXSLdXdB OI/A== X-Gm-Message-State: AOAM5303LGTHwjjdTzSJ2R65NBuEWNv8vGtiCuvjGZsXcqkXLQwsw5Fl hk691BrQTbwjLnUPKw5dSkBUig== X-Google-Smtp-Source: ABdhPJxwry8B1iySH3HNGgjwyySt2sl1IYQJ9sPBEZsfj1ARJPiZ4Cfn77PbNSIkbwQAa0+fQ9Qv2g== X-Received: by 2002:a05:6638:2493:: with SMTP id x19mr681599jat.219.1644017980601; Fri, 04 Feb 2022 15:39:40 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id e17sm1654076ilm.67.2022.02.04.15.39.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Feb 2022 15:39:40 -0800 (PST) Subject: Re: [PATCH 0/3] selftests: Remove duplicate CPUID wrappers To: Reinette Chatre , shuah@kernel.org, linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Dave Hansen , Ram Pai , Sandipan Das , Florian Weimer , "Desnes A. Nunes do Rosario" , Ingo Molnar , Thiago Jung Bauermann , Michael Ellerman , Michal Suchanek , linux-mm@kvack.org, "Chang S . Bae" , Borislav Petkov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Andy Lutomirski , Shuah Khan References: From: Shuah Khan Message-ID: <81df8c0e-fde6-f3b8-f988-b539f193635b@linuxfoundation.org> Date: Fri, 4 Feb 2022 16:39:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4EF2F40003 X-Stat-Signature: dzryquaye1atq69ofji9u51bshthg7sx Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=ghF9s5Mb; spf=pass (imf11.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.50 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1644017981-465634 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/4/22 12:17 PM, Reinette Chatre wrote: > A few tests that require running CPUID do so with a private > implementation of a wrapper for CPUID. This duplication of > the CPUID wrapper should be avoided but having one is also > unnecessary because of the existence of a macro that can > be used instead. > > This series replaces private CPUID wrappers with calls > to the __cpuid_count() macro from cpuid.h as made available > by gcc and clang/llvm. > > Cc: Dave Hansen > Cc: Ram Pai > Cc: Sandipan Das > Cc: Florian Weimer > Cc: "Desnes A. Nunes do Rosario" > Cc: Ingo Molnar > Cc: Thiago Jung Bauermann > Cc: Michael Ellerman > Cc: Michal Suchanek > Cc: linux-mm@kvack.org > Cc: Chang S. Bae > Cc: Borislav Petkov > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: x86@kernel.org > Cc: Andy Lutomirski > > Reinette Chatre (3): > selftests/vm/pkeys: Use existing __cpuid_count() macro > selftests/x86/amx: Use existing __cpuid_count() macro > selftests/x86/corrupt_xstate_header: Use existing __cpuid_count() > macro > > tools/testing/selftests/vm/pkey-x86.h | 22 +++--------------- > tools/testing/selftests/x86/amx.c | 23 +++++-------------- > .../selftests/x86/corrupt_xstate_header.c | 17 ++------------ > 3 files changed, 11 insertions(+), 51 deletions(-) > I am all for this cleanup. However, I am not finding __cpuid_count() marco on my system with gcc: gcc --version gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0 My concern is regression on older gcc versions. thanks, -- Shuah