From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30470C27C53 for ; Wed, 12 Jun 2024 10:06:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86B4B6B008A; Wed, 12 Jun 2024 06:06:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81B126B0092; Wed, 12 Jun 2024 06:06:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BBA16B0093; Wed, 12 Jun 2024 06:06:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4E1FA6B008A for ; Wed, 12 Jun 2024 06:06:11 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E3962C1722 for ; Wed, 12 Jun 2024 10:06:10 +0000 (UTC) X-FDA: 82221806100.26.7883817 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf02.hostedemail.com (Postfix) with ESMTP id E7F6F8000D for ; Wed, 12 Jun 2024 10:06:08 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ECY38bhA; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.47 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718186769; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j7GQT4sb8fOqdwN7qErmxIxCia5GY2ESmxbkweiG4mk=; b=Ij0t6iTWJNBs5diSBNDE4Hmd4kLoHhzRBNAwwutkSaCi/nC+AJL/zm7NkKor2KtCGWdan8 6b9XqA388swIq54uOPqsQ7fZzraBbX21B9hwFg5sQ1aSQD12xoHnifqDnMliNK2PpSKWUq gmuuQ4CpSHPe9OkAJ3fXQx3M2EEG8hQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ECY38bhA; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.47 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718186769; a=rsa-sha256; cv=none; b=mftv77xBrgPK2/OlZYK9KZcZB4Qy1w07H0W4CtsUynUMi13h8RDGCHgt1fWzb4vjjXzzMV WFuwIKv44PyZfqFq7V1AqSydG7cfvtzvH05lv1r0lLT230N+yBFVfnzhazlUeDgGhL0siv Zkei+eMde9l5jlkT7PeFtWzLN0oqUL0= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-421757d217aso46715915e9.3 for ; Wed, 12 Jun 2024 03:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718186767; x=1718791567; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j7GQT4sb8fOqdwN7qErmxIxCia5GY2ESmxbkweiG4mk=; b=ECY38bhAGHjt2Ws+epZqr7a5d5qAR0V1j5xwJSFGQcd34bTIWMJAVINmhUjY3/lHKs YyQdAQc4IK4wIYwCZelAvalL3X5ycECyNmwCuCqtOezARmwVM5BDNKNiRL8lKD8GaSUi wXLhsAAwc/AsvJp1V7BesH527S6qMaMHmxcgBCz3ri7jV6ZJisTICZZ/aJo4m7ycynhY ZL95W2NpWti7wBLDoniF+qUGhnRIVvxCfurhy3uD/z57tCyiaen8Wpo77xXRTR7TDryB Y5VKiL/Mh6E4XFMFZZCnmGSJO59yAu/kolc5ds10zVs/V8GS1qe5iRoFaNKlc9Cwjp45 X9WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718186767; x=1718791567; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j7GQT4sb8fOqdwN7qErmxIxCia5GY2ESmxbkweiG4mk=; b=tDyiqdRmkvx2pDzzBFRGeIg6QdUsUfnhY4brBh/S5ZI/0pzq9ZhRHY9HubpxWi9ZuE gKePv9uryx27b1LBLPKhjVjaRNpL9fmAM49Q6+XtUJb+dDZ6Uxjew2A2GBumg+657lbB AfsYLIqAcI7fCnNA5DCCqoagRyjms8OMu7du4g5hIuTewCoa5arWNnUWIcrdRNLv3h+p d3ZAhG7HxY6IA5c/u/KSSx8NJbTauoE3kmSZRCV84YkuXaOSbKF3bj2GK0lL3kZEhfJ+ w+VB0H0ub0+jWN2WeW0FtjKWeAhNE8/0/64Bz0LSBwErJKD7kv6lEBCZM0nBXSZM+RVp RopQ== X-Forwarded-Encrypted: i=1; AJvYcCXTM2qy3uWTtV0zN6N3dCjUdtgEd/Oww6oxuW87L+2Y1ppMWVmf4MaLGVT9Ok0VFpKiPTMmg6FgFkdEXyOEd4KSw1k= X-Gm-Message-State: AOJu0YxWWAKtsEGiksbmJ4oZZSCe2m6NED6UDcBE2yc2UD1fuba7/V8G 4WqiKUGeokcrZlr+ajr3YfzBhDfUBSBGvgigfli8x3/pTTWlW5VFi8rDei2ywzA= X-Google-Smtp-Source: AGHT+IEc+w6vERYyx26ozDlBXedCJnqiKgmj86kpCTQ5mYYcm1u2cnMPFRH40yWhGkpp8pMqt5gJLg== X-Received: by 2002:a05:600c:4f4a:b0:421:f43d:dadd with SMTP id 5b1f17b1804b1-422867bf628mr16526785e9.33.1718186766848; Wed, 12 Jun 2024 03:06:06 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422874e73c7sm19643925e9.42.2024.06.12.03.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 03:06:05 -0700 (PDT) Date: Wed, 12 Jun 2024 13:06:01 +0300 From: Dan Carpenter To: Kefeng Wang Cc: oe-kbuild@lists.linux.dev, Andrew Morton , lkp@intel.com, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , ying.huang@intel.com, Baolin Wang , David Hildenbrand , John Hubbard , Mel Gorman , Ryan Roberts , liushixin2@huawei.com Subject: Re: [PATCH] mm: fix possible OOB in numa_rebuild_large_mapping() Message-ID: <81da44d7-e07d-4757-9a67-87c35b62512c@moroto.mountain> References: <100add53-aa58-44ce-a15d-8438001fb2b9@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: E7F6F8000D X-Rspamd-Server: rspam01 X-Stat-Signature: abb8oad3t5t64uxa4pgjaxeebmwhwyi5 X-HE-Tag: 1718186768-90819 X-HE-Meta: U2FsdGVkX1/ARFePqKhPKHeycWB+G54tUJpz7xT6n+utGavAagOQmI+nlAPbdxXG0DA5DJHPnCpUf7pPgZorWLu9uhAXJ7oF+og+uhymoJw/AqeMVEEw607RiRQokVVNYLYoHyw9N1J3zQ163M51PXvBHZFXr9aYZ5/ZW+UC3XMg80cHSGvykrJ5SwJyxPYTnCX9ehv+fJhHOmVApoL+iDFfg/ZS053RDMNc3Ym09oOFFfJl9IuMzToJcwjBLs2iCSHqniOQybPF8uWxXle9e3fl/dG+RHgNoqdptjhTxNg3G4Kjbm1gCiRERsvotEyf26VHUbFg30v4Epa+zG+MIAvjYg5Gn/PJuodFf/oIKBvDerlHyV/4/2IBtzeU15GRpZaE0AnkIjNdSIZPgf+Om/CE9cnn18oPvC5huSJe2Y0ukVspkPtRX+If/fFSgeisfczB43seshz2l+jeotOo4FSg221zcW2n05tjXC8DM4PYLuTf/4J8rsjBxqFseNvIV38Jrqs4x9aLcidUQPZbLm/8EMOQ8nbJotAut1+aE5dbLnEs+/KsNfu8USLU5WpBTYCR6VW/rHHTmduTKxDHheXk3yOUvoLJRpH/QsNPlEiaEtC1aWkhGm3eetYoQTqf9oubObW0oSQ8WxDY5qu1X4k6zP0Hz35S/w3P/pxLRoxwDDtOlvSY+YE0+4sdUo7GImou0BJe87vpTFP7e4MD33V1En7s8CCHnXKIK7nbrYKj5NwVh9glLFD0kk4bZEJ3Idwq13w3a8HMi3e2Sz6c4HzEHe2hKLGFH7H0p8MMnnYfloXE+7ylyd2uHSK2pUSIN3X+vn+kNV4jMKVN03t6sBh79R9LjPEJicA8tD97rTHAXSpiP8doe3SaX2/41g6sQZJ0wDJbmK9CR1izd934FecyA9ZGYj9saQ9UiFMcUSBFcYASEfshRPZpj2TYXxuHIDEdZ6qri07IptE7Hbd EOmDP9Q1 /xYk3CeX2mqlHs+WihsJoyk5mMNtyRFYe3MvzRQqFH779NQ2xvF6a6L26QYeM6MhqB67G9YCKemHjmATXOjvLsblwvvczMtwrDzRoxo7gUQZ0HkCh0M6FVQV8ZhRqTmlJRlYWSM8voTpW59w+7VShzz4RHbrzW4B5mmXsmAYblplYf8s5PCrgf5GZM4DDgQnrfbD8QDAnU6CgksR+Vwp6RCFBWR/IYv1wsyi9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 12, 2024 at 10:50:02AM +0800, Kefeng Wang wrote: > > b99a342d4f11a5 Huang Ying 2021-04-29 5364 out_map: > > b99a342d4f11a5 Huang Ying 2021-04-29 5365 /* > > b99a342d4f11a5 Huang Ying 2021-04-29 5366 * Make it present again, depending on how arch implements > > b99a342d4f11a5 Huang Ying 2021-04-29 5367 * non-accessible ptes, some can allow access by kernel mode. > > b99a342d4f11a5 Huang Ying 2021-04-29 5368 */ > > d2136d749d76af Baolin Wang 2024-03-29 5369 if (folio && folio_test_large(folio)) > > > > Are folio_test_large() and folio_is_zone_device() mutually exclusive? > > If so then this is a false positive. Just ignore the warning in that > > case. > > > > The folio in ZONE_DEVICE is not a large folio, so there is no issue for now, > but will fix. > If it's not an issue, then don't feel obligated to do anything. These are a one time email and then I treat it as addressed. These warnings are intended to be useful, not a burden. regards, dan carpenter