From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4156C2BD09 for ; Mon, 1 Jul 2024 08:51:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 687686B00B5; Mon, 1 Jul 2024 04:51:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 637786B00B6; Mon, 1 Jul 2024 04:51:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B1306B00B7; Mon, 1 Jul 2024 04:51:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 28C106B00B5 for ; Mon, 1 Jul 2024 04:51:17 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9561E1A0B93 for ; Mon, 1 Jul 2024 08:51:16 +0000 (UTC) X-FDA: 82290564552.02.3EA6B20 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 469EB1C0013 for ; Mon, 1 Jul 2024 08:51:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iV+oupgl; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719823864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Dwuh31FWXKFETeVE1bIi4aG9bVbhfrl9UVZK40+cBU=; b=Fxjjvf4e1vmX3tzGzk1+JV0ZQGiip79wTKPUt4V3uJO14RwCbJAtBGbDp0ekBJkp7wi3qC pt8ygbkjZswZUurbUCx+pj9wtMNLYcAi0lBmnO2/o5ddIJrxSvh/y6oGVQeP9WZBelF5Eb ynEq0bT6P7qcLkx6uMKZEEgCiOOcfbg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iV+oupgl; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719823864; a=rsa-sha256; cv=none; b=GrSR3/kF1cJJelbPpe1ERq9B0Udc59im5aGXiVveyNFTXce02uEiXdIk5dvODx/TXGPiVh OhTwmwB6clUasOXNOv4+W/c8zmyeQZv1xpfOtkppecDwflDLREByqaqbviuHuV38Sj0ky7 ItGskQEpiPCz2dNJL2P6N8/QCo4JiRs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719823873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+Dwuh31FWXKFETeVE1bIi4aG9bVbhfrl9UVZK40+cBU=; b=iV+oupglgO3ZYAvGqkIhzaT9CFUPLUAWk49l4WhamnAyq0fO5oYET4Ll4aN/FAnVhBomlM XbvFXGrjKJjWNahqIXKn/XEs055ueIhB2dFYbSDTS9QcWO4p2QgdsAKDiKPQQhkeeAzKjY UhRc53HIjeSv8Qlg+nJOgVLiEoNcKdo= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-zIa5gCi4Ml-Un4cgXWUArA-1; Mon, 01 Jul 2024 04:51:12 -0400 X-MC-Unique: zIa5gCi4Ml-Un4cgXWUArA-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a6fe837c066so339927666b.1 for ; Mon, 01 Jul 2024 01:51:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719823871; x=1720428671; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Dwuh31FWXKFETeVE1bIi4aG9bVbhfrl9UVZK40+cBU=; b=vXddvSoGpe+rc/mMg1pLqDH8ndn5Z6u3+HhyUxUvXa+xv5YfcYP85i/krdjZFZ1TaT Ogvq0aLIFu0/kuUt+iaF68/EZnM4qyd1QJN6BoY3ScQ306pmnuOpiMjFI5FKEPCLKjoi elU4dhgqKY5APBwpahARVO6354XEncqOFu4pYaDvIEuX3Y79N3D2cc3qfzoYhSV0M9e0 9tAu5nkgsczQ+QHiRhbRtoDCqhqESSjL8fKmQ9LFt3G8gTl4vttHyxPHzYUzUtMWHXDV EvlynMB33nbNTjH0BNzqQxB9tkMX7aWVS/GRdbUbHv07SSi+no6W42GyFkdGYJy6B7A9 roUQ== X-Forwarded-Encrypted: i=1; AJvYcCWEkhFJqAgQCDOx0A+rMyVmtgVLZ5WI7Ggh8h0wq3TEeHiEsPX8NZIOD790AHuhn6TPKSucEApVyiDBtkdssV5JQsc= X-Gm-Message-State: AOJu0Yx5Rnl2ia+8mvGNyRxptdh64p1B02OWxOYJzgRPTJFyBCQiB81k NnERKm/hH4lBpgGfw4j3LmgKuVf7Ie782rnZjG0TbirIzh614AraCeSqLH7P45vzsK3X1CpghSc UXCcumtRYPredhNGgsegSKh7X1BgkPnicOaVlwNNRcqjprxHc X-Received: by 2002:a17:907:3f29:b0:a6f:6df5:a264 with SMTP id a640c23a62f3a-a751386ec5fmr488694666b.1.1719823871268; Mon, 01 Jul 2024 01:51:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYvD40tgD05VnEwmXz0XcpYx3ec+54nXSBpU3yVu8tlzKFZdfjFxO8yOk+ow1/wiXC0tObSg== X-Received: by 2002:a17:907:3f29:b0:a6f:6df5:a264 with SMTP id a640c23a62f3a-a751386ec5fmr488690666b.1.1719823870372; Mon, 01 Jul 2024 01:51:10 -0700 (PDT) Received: from [100.81.188.195] ([178.24.249.76]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf1846esm312641266b.38.2024.07.01.01.51.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jul 2024 01:51:09 -0700 (PDT) Message-ID: <81d768d4-6d37-4d73-a1a4-39950a663105@redhat.com> Date: Mon, 1 Jul 2024 10:51:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmscan: drop checking if _deferred_list is empty before using TTU_SYNC To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , Ryan Roberts References: <20240629234155.53524-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240629234155.53524-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 469EB1C0013 X-Stat-Signature: wtcj33443u31d5do41ep8tgpmr9gpga9 X-HE-Tag: 1719823874-916155 X-HE-Meta: U2FsdGVkX19STkxI8aD26WY1PrtgRjcuI/rIgV/ctpvo7JES8RLWOR1Do+HBOOYuuWVIMT//t1CLt6BBOaeuJbsNIW5iJslsjZS+jwQvSar5WpZChGIp43KpnJNve3nHepXVLq2JrienPOzxkJ0l/GfbpjWyCvlWheV2LCDq3Nz8PQjLzTUVfI/z/4JU5R4pGT5HWvVLdxpObPRH58aCjMfXhcA/u6zhwwzi5Tgu0qNwfHUvyr6HlIlvUtwTYHj2GVtbJRRzJASekxHaL7+wz5C8wwFpwiHSB4cbI7u+3r9/F8WrtxY+OSAr36bqZjXPS/LGsVuvcd5y90jArH1+C4Tq3aVnul9YH9GNlwQj5L/+Q+2aPz4Miig1i640OwxfhJl/iiPNjvc/JeCY4J+oDVrnhW9KS5TlFWXztdVJqBeg9dzs1FOi4x2p6QK+8J745N5oQEt5Vfr4djTu6gc9YiTbr1nfUwhF6IuMgxihqizZAvkdLE1BvpjkxFu46vmrvNdwVrbvBhlfOzGy8k7Wpj1946Jimp9v0cKcivFhzfxEYLH0icc86o5PeMPS0q+YydkfRyZ2DfaaAaWEqT948whzGTI2ODo6S8I9Vh3wZ3WXzp8gQ1WrzyEcLoz3tcaQ4P1RGA+I4tUloI/nVmY3QSeaTIWnQg80C/Cxb4h6l+CGjx8A0hyChF9bt/FiMSDHpTVejLAaueht49unIM6CQ56cGDr34TDi0g23GQ2dHdjm9BalxuI4oL6Br7C3diQ1g5WvCQH7CoBx8+Zxd9fGPefQAKN72f/ul2eY1Mh50UDyTdGA5A2hcsE2efi1trnezQfy+rUAnoE6iPbaUfq00rA517yyfPHbJrvDwvsVsXIuS2YDkr0tayGiVEkg9RCzmTKe2yBFXH2hqNCkYb7RV68nkALNO/0M3vCJRBBJntKAI3Ru+5KyMmqpNhjL51LsMbwKdKeJIbkQCI03Mt0 jcfcLsZc VMgeaXByFKF06/XWgxpT5guVBLkycsCbsIam5YKa9QZwuSDCVslHnybtaUfO2uwjoPFWyE9nGwSJ9JGAUJPltnPdpPloJFU7hQtrm+h/zGcL+mo/7xX6cBnkyPU15fM/TEZuzhVcQ/5QW21xZDyB/dCOuFupT1Asm0DTy3xL0EfHYtM/lW8CyzfRGC5MBANqLoO+dk3ZTJc89QCeddNxkzBL+5IoNkOg6VK9ajnO150s3TKVsVu4uooPwk5yInDF/lmlozsImhcv7Qx+xPc7J9yroUg0k801Of7qP4dytGYolLl2t+JBvtqBUqtJvEwYd6IDjoIBx7gRNFzSx7cmqroW2LeAlQo0TeRFrNW6jKwD+wf2PJT3hFRj73Xt3pgg9tTukIKGOeMwUy4t8sGU0apjsh4ox5+Bp8x+KbJXWppNLy2BNblRqxWZXTWSFIWQmxO+QNhgglmeA+nC2zdBlQ20pdD2+GzGDQhECCgJsZAlXR4Tjob8QA0Tgcyi+66npNdM48DtPbJU+2MRxtfVOqGe++X6gip+X2x+UPfT5LwUWICho/sFpARu7OPabYEb87M1v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.06.24 01:41, Barry Song wrote: > From: Barry Song > > The optimization of list_empty(&folio->_deferred_list) aimed to prevent > increasing the PTL duration when a large folio is partially unmapped, > for example, from subpage 0 to subpage (nr - 2). > > But Ryan's commit 5ed890ce5147 ("mm: vmscan: avoid split during > shrink_folio_list()") actually splits this kind of large folios. This > makes the "optimization" useless. > > Signed-off-by: Barry Song > Cc: David Hildenbrand > Cc: Ryan Roberts > --- > -v1 > * I remember David and Ryan once suggested that this check could be dropped > while the patch was being pulled into mm-unstable. However, for some reason, > I forgot to request squashing this change. > > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 3d4c681c6d40..0761f91b407f 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1291,7 +1291,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > * try_to_unmap acquire PTL from the first PTE, > * eliminating the influence of temporary PTE values. > */ > - if (folio_test_large(folio) && list_empty(&folio->_deferred_list)) > + if (folio_test_large(folio)) > flags |= TTU_SYNC; > > try_to_unmap(folio, flags); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb