Re: [PATCH v2 2/2] mm: support multi-size THP numa balancing

[Baolin Wang <baolin.wang@linux.alibaba.com>]

On 2024/4/1 10:50, Huang, Ying wrote:
> Baolin Wang <baolin.wang@linux.alibaba.com> writes:
> 
>> Now the anonymous page allocation already supports multi-size THP (mTHP),
>> but the numa balancing still prohibits mTHP migration even though it is an
>> exclusive mapping, which is unreasonable.
>>
>> Allow scanning mTHP:
>> Commit 859d4adc3415 ("mm: numa: do not trap faults on shared data section
>> pages") skips shared CoW pages' NUMA page migration to avoid shared data
>> segment migration. In addition, commit 80d47f5de5e3 ("mm: don't try to
>> NUMA-migrate COW pages that have other uses") change to use page_count()
>> to avoid GUP pages migration, that will also skip the mTHP numa scaning.
>> Theoretically, we can use folio_maybe_dma_pinned() to detect the GUP
>> issue, although there is still a GUP race, the issue seems to have been
>> resolved by commit 80d47f5de5e3. Meanwhile, use the folio_likely_mapped_shared()
>> to skip shared CoW pages though this is not a precise sharers count. To
>> check if the folio is shared, ideally we want to make sure every page is
>> mapped to the same process, but doing that seems expensive and using
>> the estimated mapcount seems can work when running autonuma benchmark.
>>
>> Allow migrating mTHP:
>> As mentioned in the previous thread[1], large folios (including THP) are
>> more susceptible to false sharing issues among threads than 4K base page,
>> leading to pages ping-pong back and forth during numa balancing, which is
>> currently not easy to resolve. Therefore, as a start to support mTHP numa
>> balancing, we can follow the PMD mapped THP's strategy, that means we can
>> reuse the 2-stage filter in should_numa_migrate_memory() to check if the
>> mTHP is being heavily contended among threads (through checking the CPU id
>> and pid of the last access) to avoid false sharing at some degree. Thus,
>> we can restore all PTE maps upon the first hint page fault of a large folio
>> to follow the PMD mapped THP's strategy. In the future, we can continue to
>> optimize the NUMA balancing algorithm to avoid the false sharing issue with
>> large folios as much as possible.
>>
>> Performance data:
>> Machine environment: 2 nodes, 128 cores Intel(R) Xeon(R) Platinum
>> Base: 2024-03-25 mm-unstable branch
>> Enable mTHP to run autonuma-benchmark
>>
>> mTHP:16K
>> Base				Patched
>> numa01				numa01
>> 224.70				143.48
>> numa01_THREAD_ALLOC		numa01_THREAD_ALLOC
>> 118.05				47.43
>> numa02				numa02
>> 13.45				9.29
>> numa02_SMT			numa02_SMT
>> 14.80				7.50
>>
>> mTHP:64K
>> Base				Patched
>> numa01				numa01
>> 216.15				114.40
>> numa01_THREAD_ALLOC		numa01_THREAD_ALLOC
>> 115.35				47.41
>> numa02				numa02
>> 13.24				9.25
>> numa02_SMT			numa02_SMT
>> 14.67				7.34
>>
>> mTHP:128K
>> Base				Patched
>> numa01				numa01
>> 205.13				144.45
>> numa01_THREAD_ALLOC		numa01_THREAD_ALLOC
>> 112.93				41.88
>> numa02				numa02
>> 13.16				9.18
>> numa02_SMT			numa02_SMT
>> 14.81				7.49
>>
>> [1] https://lore.kernel.org/all/20231117100745.fnpijbk4xgmals3k@techsingularity.net/
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>> ---
>>   mm/memory.c   | 57 +++++++++++++++++++++++++++++++++++++++++++--------
>>   mm/mprotect.c |  3 ++-
>>   2 files changed, 51 insertions(+), 9 deletions(-)
>>
>> diff --git a/mm/memory.c b/mm/memory.c
>> index c30fb4b95e15..2aca19e4fbd8 100644
>> --- a/mm/memory.c
>> +++ b/mm/memory.c
>> @@ -5068,16 +5068,56 @@ static void numa_rebuild_single_mapping(struct vm_fault *vmf, struct vm_area_str
>>   	update_mmu_cache_range(vmf, vma, vmf->address, vmf->pte, 1);
>>   }
>>   
>> +static void numa_rebuild_large_mapping(struct vm_fault *vmf, struct vm_area_struct *vma,
>> +				       struct folio *folio, pte_t fault_pte, bool ignore_writable)
>> +{
>> +	int nr = pte_pfn(fault_pte) - folio_pfn(folio);
>> +	unsigned long start = max(vmf->address - nr * PAGE_SIZE, vma->vm_start);
>> +	unsigned long end = min(vmf->address + (folio_nr_pages(folio) - nr) * PAGE_SIZE, vma->vm_end);
>> +	pte_t *start_ptep = vmf->pte - (vmf->address - start) / PAGE_SIZE;
>> +	bool pte_write_upgrade = vma_wants_manual_pte_write_upgrade(vma);
> 
> We call vma_wants_manual_pte_write_upgrade() in do_numa_page() already.
> It seems that we can make "ignore_writable = true" if
> "vma_wants_manual_pte_write_upgrade() == false" in do_numa_page() to
> remove one call.

 From the original logics, we should also call pte_mkwrite() for the new 
mapping if the pte_write() is true while 
vma_wants_manual_pte_write_upgrade() is false.

But I can add a new boolean parameter for numa_rebuild_large_mapping() 
to remove the same function call.

> Otherwise, the patchset LGTM, feel free to add
> 
> Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
> 
> in the future versions.

Thanks for your valuable input!