From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47EAFE77199 for ; Thu, 9 Jan 2025 02:25:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B23496B0088; Wed, 8 Jan 2025 21:25:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD2726B0089; Wed, 8 Jan 2025 21:25:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 973026B008A; Wed, 8 Jan 2025 21:25:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7A3976B0088 for ; Wed, 8 Jan 2025 21:25:20 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0B2D0A1649 for ; Thu, 9 Jan 2025 02:25:20 +0000 (UTC) X-FDA: 82986321600.01.D98D41F Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf03.hostedemail.com (Postfix) with ESMTP id D3EBD20005 for ; Thu, 9 Jan 2025 02:25:17 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=citrix.com header.s=google header.b=sKL1C9KY; dmarc=pass (policy=reject) header.from=citrix.com; spf=pass (imf03.hostedemail.com: domain of andrew.cooper@cloud.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=andrew.cooper@cloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736389518; a=rsa-sha256; cv=none; b=dn+6HwpcjpST3PgqYZXa/STxAWVM+fMyhU0Y/XMPyhVjbwmQqiJCzeCo8LrB2OC2P/yP6C W/tuYHE7r4vv9Xf5Z06Dze9LYcCPdfvsLzilli/tgxFJnzUkVFxF3jOtyMt6s7InrtDmft SngKJecfJZ2j21I/mkhkF75j2QMeyf4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=citrix.com header.s=google header.b=sKL1C9KY; dmarc=pass (policy=reject) header.from=citrix.com; spf=pass (imf03.hostedemail.com: domain of andrew.cooper@cloud.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=andrew.cooper@cloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736389518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wea2a8dCwmi+NPCnneen+G70itew2atVlu361VPW/1w=; b=QFtgMwzTXHecem+RMy02UdP0wCjFHQHZ92jCjSPRvRk2N/hX9yBj9BTpGUHQHs+1l0vsX4 gKkv+b+60g+bRSI8e9qT0i5PJlI7gp9BOcSVmix5Ia+wTneicHrpnTLScW6eMWL+dZSohB Re5MlOTbAx8V5pA6KsbL1t+xxcVQOeY= Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-3862d161947so198694f8f.3 for ; Wed, 08 Jan 2025 18:25:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1736389516; x=1736994316; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:subject:references:cc:to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Wea2a8dCwmi+NPCnneen+G70itew2atVlu361VPW/1w=; b=sKL1C9KYQ7oMX/QXCi5SPx+c2p0OUFtO2f697mbXOqWGaigrtkCr6NzBtti/QD2/v9 kJQX+xjD+hCQSRL4kWjxHcxZeBL0zgMUFvs7HM+lLlKG2xUbfPzubNuT8+YhRE8U/Ahq ah9sj6LEuov6KGKyjsWXrdOGgbzissXnf+F7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736389516; x=1736994316; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:subject:references:cc:to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Wea2a8dCwmi+NPCnneen+G70itew2atVlu361VPW/1w=; b=onKH1X1SCYIPT7EEKGATTJsrXy6CxzEwCBIEgP6bZ6tqHXZAt3nUZ4fBZ1NPQHRqdP ceO+GsomImVOmrgrCUVIEPAJb+SCaTDDykbFwqZDmL91ncTzImgm5LvMiVkXXxvBDaAv 0exWuURyqoqJyYGi8dNz+S8ObbL3kIJTw07fQNLwatANyZhZB+IfyFtvoSf5mXdTX0bq EWzwg8na5mq85j1YOV5uglaDlKgdidXDUBMUkKCybw9RzAbQ3gUGpvwpIRzmWzabTzE3 YC/X9JhbABcj81KwgcSQM8rRBG7E0/pBMmVy9ZNW/nO+BzBACMVvbahPvaEZAni9ZDmZ tVYQ== X-Forwarded-Encrypted: i=1; AJvYcCX0y05agObTSnr+ao+PWAiJiusmG3CpljIdxzTky86nZItO+isXROsW80w8yGhmwNzIyCOQebiv8w==@kvack.org X-Gm-Message-State: AOJu0YwGmhUbbI8W/vFrhymTzq5NO5pYY7Wb0uWVpSg3Qvh0VngFgeos Wju/rJZNQgh00Swdvxmdu13kDErxi2Th3kmWRJfKT/KG4kAwe5skMtVC4RixZQA= X-Gm-Gg: ASbGncvH3LqFabFPOvplZ8HWzRQIalT7PCJre8kLhokG4dVpRfg3zSFjW4/6jSPMqkS KbjCER0Yq7IVNVf4G7LYLiCYzgWyheIAGlvp9SiJ8SAMWr9jI3BPunWvTBFjPLbjpxlUg5SQCX+ Tq9+M5iH6GI2deIOFYnFzDKpRVgD1MIBjGkSotudVmtNSxxCLvuSY3bRkb/BgIYPIF67At4UTg8 G/iHmI13CcS+nHqqRu58v2wH7HFl7F+Or7rcv2z1wx0RuAnpla2fF9wd5sh8f8oCeU= X-Google-Smtp-Source: AGHT+IEObqlRf+g43lWkX6Wry4OmXNdC8/HReG2/uaVy4g7eqKaZ28cGgk+iKfqAhuaHH3LjMgl1yw== X-Received: by 2002:a05:6000:1567:b0:386:3cfa:62ad with SMTP id ffacd0b85a97d-38a872f6970mr4302076f8f.1.1736389516185; Wed, 08 Jan 2025 18:25:16 -0800 (PST) Received: from [192.168.86.29] ([83.105.36.37]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9dc8802sm4509535e9.10.2025.01.08.18.25.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 18:25:15 -0800 (PST) Message-ID: <81c63009-efc2-4f82-a6f8-b6378cb11a6b@citrix.com> Date: Thu, 9 Jan 2025 02:25:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: yosryahmed@google.com Cc: akpm@linux-foundation.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, jackmanb@google.com, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mingo@redhat.com, nadav.amit@gmail.com, peterz@infradead.org, reijiw@google.com, riel@surriel.com, tglx@linutronix.de, x86@kernel.org, zhengqi.arch@bytedance.com References: Subject: Re: [PATCH v3 00/12] AMD broadcast TLB invalidation Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D3EBD20005 X-Stat-Signature: bnfykq75akqtos5uugsfrc1sddwtpb5t X-HE-Tag: 1736389517-891671 X-HE-Meta: U2FsdGVkX1+4gt/w417fWc9WD4D6gE+IFLRxr4SLtAcI5KNknj5KLxcWMAcEHiCFne2hjoi2/UtR+eI9UuTJXBFjQdFasGb4ZfEmgoodgBkPAU6VbI0tqjt4Ss9nQ+gVl2wKnswXE0NXDQEmoyechkZIe1n1eJfiIjqcy+HJWfrx8epggIC7/ScgTXfZl/yyZSjBHMn40lBbEkzzczQIAv3XPo3gpxaDvL9/OSRfklYt7dC0y38BldCCzlHFRec2bDlYHJGm14TC9aRA+xkRZ8K2FMuihDlULY5Py3h5fbsOgEmRoz7197EpcttXLJMxGUNwdYnH8ybylWmm7UTep7iIRSyXn3a0gedxqs+c6NVw1AJClyXgDsJkbtxnGB/LNlifxEG2FQ4YYqx6gjOSkJ1tQsjDvIdZx46JBIlyHJnaOrg0oOpcVhht0jUolBJuyfAaIJ3I4Gh1FCznqRY02QljsJdsmP7vcMz8odGdKNTSEZ0v2aCfLh51FVkD+zW0kGFxNVGK38PODzE92Bd+l/+/KZifMGBqnkBQ6hi/NiyRvKlbSM4FsSdHXvWnitorazV9Gy/A/k/GNbUPcdfkOtYrF4RE/O8KsGNKor6KR3Z5tUM29HJpEDKCKErMRHUOjTk6rRAN9DXXQ7d3hp+w7uNVr7HCOB6lb3l8M7s6LR/RodpaEqWDITLZ2UfSzUNgH9+M9QMVUXduivVy7/UHxUBkPMSghdvVMYiidOKjDFrB1p0+7OqBkAJzNGaThXKIrybVaL7ETZIhpQCcu5hU+P8h15plD5D6z3AtQ4niLPO2sYewMAbDVrTwQ5peKurrCVukRZpVG9LYVDvrpwyTjueTOCcPG/nswm7PJ/UFpC8BvttEmhCfIXkM8TnIWVj1sCNnUbYUAB7RVHD1zlzZ++/6Lj+ydDuXWhvwjMjn2kK2xD4fxfrJGYc6V/0FpufYcsNLVaz3lY0jsqrYjxW P37XuEs1 TglVM32rL07MyItuNQnsDPdYKiceIJy7hcbh9owC8BRZyJWpMEKHtL6nul2VTb8dKOcANvMclRfp1L1AutAG9KMcAlO5USXHM9lKmYYmz4Yg7CT8nxD1o0ipUGef6PZu4vTJ3bC50m5b/vdTbbMpjaHD6pfDt7JLFPnGHadWQsmyMbAy17Ls1jqOJ2Ppafb+NriHniFHthBSUZSeqzaRFGos15uwwmyBClJUGHE239aFOp9l0SrrO8mtxdMeYqbUy0KbNMTbJNEHYWIfcqRUi+mkDMOrX1t/SBJqFlg2Vnxv220tN3JnXSkIy5Jb6wWQjMloRIMYtQO3FcsrOyIov/6zNq35Y9vuhW/qyQyK2YAaz82//qCzjA4euzR0za43E0xNsfCI2kiNF+DxkGy/a2CS8hZ/fTwdANJwCeIEqMsHDHyUf2fPot24la3jiqNpWYHjiVXFOssBjdOBgcZTXHWAKTM7trATD1FoOqe8MVDQgJ74spf2gPtyQZCG/jNhLPoai5/HedYJDD3M3vFDPPAMOKC7mqyhu2s68IwvkTf6gFF1ZccVxK67TDNCj8Khw+F7Dzb8aHVkxwyEVDeumfuSz/q+dlvmasMQ8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> I suspect AMD wouldn't tell us exactly ;) > > Well, ideally they would just tell us the conditions under which CPUs > respond to the broadcast TLB flush or the expectations around latency. Disclaimer.  I'm not at AMD; I don't know how they implement it; I'm just a random person on the internet.  But, here are a few things that might be relevant to know. AMD's SEV-SNP whitepaper [1] states that RMP permissions "are cached in the CPU TLB and related structures" and also "When required, hardware automatically performs TLB invalidations to ensure that all processors in the system see the updated RMP entry information." That sentence doesn't use "broadcast" or "remote", but "all processors" is a pretty clear clue.  Broadcast TLB invalidations are a building block of all the RMP-manipulation instructions. Furthermore, to be useful in this context, they need to be ordered with memory.  Specifically, a new pagewalk mustn't start after an invalidation, yet observe the stale RMP entry. x86 CPUs do have reasonable forward-progress guarantees, but in order to achieve forward progress, they need to e.g. guarantee that one memory access doesn't displace the TLB entry backing a different memory access from the same instruction, or you could livelock while trying to complete a single instruction. A consequence is that you can't safely invalidate a TLB entry of an in-progress instruction (although this means only the oldest instruction in the pipeline, because everything else is speculative and potentially transient). INVLPGB invalidations are interrupt-like from the point of view of the remote core, but can be processed ~Andrew [1] https://www.amd.com/content/dam/amd/en/documents/epyc-business-docs/white-papers/SEV-SNP-strengthening-vm-isolation-with-integrity-protection-and-more.pdf