From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E97CC4828D for ; Thu, 1 Feb 2024 13:16:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A2C26B0082; Thu, 1 Feb 2024 08:16:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9530A6B0087; Thu, 1 Feb 2024 08:16:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CC856B0088; Thu, 1 Feb 2024 08:16:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 654E66B0082 for ; Thu, 1 Feb 2024 08:16:49 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 35837A0E5B for ; Thu, 1 Feb 2024 13:16:49 +0000 (UTC) X-FDA: 81743284938.09.0FD6A84 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id E20E31A0021 for ; Thu, 1 Feb 2024 13:16:46 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KN5Og+G3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of pabeni@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706793407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0kyJ1DUM3o5azfN5Jkt+7DvlWs1v9oq/r1ygnOyP95M=; b=edXIz3apMihQNBSWBrsjCHrY/IYfrnXxvfC3W6vsY3/G5yHKvqJ2+wWvmfkF/DaOohoOtP pzs4nBAPfd7sk/Bb/Onv+K0XJGpfHsXsHr150R9ZjY+5MZ1tZq18WPArT38jOBVEcwQRjr d8x0cFEh65cfKpQUKCZTAuoxY/vUcC8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KN5Og+G3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of pabeni@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706793407; a=rsa-sha256; cv=none; b=hh3EuxQq55yIn8x+myEnGDn5YkcfnwLhjgBrohJc1hVe6Ou02+MbRyYstkO+8qjh6tucOA XKmYIr6x62B5z/Ehh+ioQhdZSZJsp3ewOEMFcOYi0oHny89h7w4vQNUdXXX3dAXd1rA34V k85QSjWR6F+KbrKfi6i5CADu6A5ZBzM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706793405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0kyJ1DUM3o5azfN5Jkt+7DvlWs1v9oq/r1ygnOyP95M=; b=KN5Og+G3m6Q0l5yvUMiv8avOb/Uo8PoVujxx0CjqcNdeUhJ00aUm53QvXMNsXC3MG/Bmcl 1pKlKQF68Rbo43uAnUoRbGFEhWsQhXln0lRWyPfk0/jIoeN0i/5SsEDmxNVk3wdYZk5Vye GCFrSJ7tsPYHKVO2wOuS2Or1Qgl9+9w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-lv0FBhBiMaylGjTGY3dv1Q-1; Thu, 01 Feb 2024 08:16:44 -0500 X-MC-Unique: lv0FBhBiMaylGjTGY3dv1Q-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40ef6441d1aso1019265e9.0 for ; Thu, 01 Feb 2024 05:16:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706793403; x=1707398203; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jMyGzesJ/z8ohl7KVzA66xKH8S456nUXduHOJbN1y64=; b=kgVxMt8GGm9eHfgXK/8w0O1wW0OuFk8ZJ2P23FO04Pyb+1FTwpjtO/Jv2Dnaa1vWtx cBnqMgPk9hQH14ZZugqFfRkPNDfJ3fFrQfOvwN3HSE3GG3BO4p9gM2mhHPqO+9wJEbLI 8zdPSU3KebF93yN8NmjnAchQgICMR0xw/31X21ir6knWrOZt5AMkeWkz42e//AoKNQ/v XYF5X/2TFoWx2g5C9+DxwCvh/LDpkRRf7UydZayThxS9DYFJ1oF0RLqC73ol50LsP+Sk rQLSi9sDpjRIDGTfWNTvOWdDxsKSFNdY44tofodqmcANn3Ss2hne9Y3QNwfm6YOxbO0B p6xA== X-Forwarded-Encrypted: i=0; AJvYcCVrwyR24V4EuagUsD4oMA8jf01K1QuwEsbwdHutVgYwIzTbnqEdwdjgThOOe7GNv6NCp5f8Q+RUtaVW+JGXCjtgvi0= X-Gm-Message-State: AOJu0Ywb/l/sZHuXo+t8QwCWPXsgwnFkER+krygUsTVkoF1E6Nl7NWcR E1pYKNUhCA/DJUoDPNQFoe5dXfaFIO1iyF1E0Z2UXXwRRz6Aq+blwHDc0e2ZKV01wyeV96t8D8Z xZ8Bx9EVSXTu2W4uyojduoC9VRCm/KnIU8xoHaN8AH9A2pgI4 X-Received: by 2002:a05:600c:1da7:b0:40f:c34a:a3d with SMTP id p39-20020a05600c1da700b0040fc34a0a3dmr33683wms.0.1706793403505; Thu, 01 Feb 2024 05:16:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRAP06jOZUsEI+yRVHfvK8CImFGDMYPJywrkavL8JrVIwIzD/C3rG4c8k0WemoaSiruOb2tg== X-Received: by 2002:a05:600c:1da7:b0:40f:c34a:a3d with SMTP id p39-20020a05600c1da700b0040fc34a0a3dmr33661wms.0.1706793403155; Thu, 01 Feb 2024 05:16:43 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW/Q05nEw2lfWAkFO9uaW6nkg2bEEKXGAGM3SkT1AB0V3ltWfKX+AQvuT92xi2K4H3IlB6XREOOyleaRRrBpWkMvXCZ2LCBcOusk9kkhqxMcW/dZ8A082SMtU317vKxKxKlKs7sya+Codh5edzTsSNxZGpdRy6AC4Pzd691XyLICnyHCnCVs8q6KQraV6zI7b/r19+ZJcBxvdU9GymrJcJ9k3ZyMspsSPczxlkHemKHdoMrUmVz2FqbMh8d4vxqKSqcxgju6pBq7stFbNqSqpY/qciPFj7cbL5JACROuZhl9qk30kFF65F6GYBUychSyhlK4qEcHTPo5w1ALC4NVIFp93k3hhEUABZrC484zD51ubqJKadjEu8GgAgrysmc9G2DLTtSeJKxmj/a4v2lwIL4e9m4tagTmVRM2L444rjF8GJa Received: from gerbillo.redhat.com (146-241-238-90.dyn.eolo.it. [146.241.238.90]) by smtp.gmail.com with ESMTPSA id g15-20020a05600c310f00b0040fb0193565sm4437876wmo.29.2024.02.01.05.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 05:16:42 -0800 (PST) Message-ID: <81c37127dda0f2f69a019d67d4420f62c995ee7f.camel@redhat.com> Subject: Re: [PATCH net-next v4 2/5] page_frag: unify gfp bits for order 3 page allocation From: Paolo Abeni To: Yunsheng Lin , davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Duyck , Alexander Duyck , "Michael S. Tsirkin" , Jason Wang , Andrew Morton , Eric Dumazet , kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org Date: Thu, 01 Feb 2024 14:16:41 +0100 In-Reply-To: <20240130113710.34511-3-linyunsheng@huawei.com> References: <20240130113710.34511-1-linyunsheng@huawei.com> <20240130113710.34511-3-linyunsheng@huawei.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqAL zgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQ nM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUx fvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E20E31A0021 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: f7yem6g6myji8dic9qshnrjjamtuhjzf X-HE-Tag: 1706793406-921792 X-HE-Meta: U2FsdGVkX18xBuy2APKod1aaEDH3JTl6hEillLTGC7bxC43Iu/gHr9lOpVI8/Z872Ee7s7Ignnb50StgkUCOBFJfB8j/SJ1irOlksmukPSJnACzB6YUt0f79dXTIil/yJGI3Y6hEl2QstmNT7FmYeZRGGufpY//cvLKsL3F2Kl/xgD/TGuwVEKT+ABAGn6WR3YYuLQj4ijSMRtpbH+9ve1GmeTCGosIO4vRhxvZwOKFtn1GE9Pdz3Fc3qaRvAq5A7Lq5tJh3u1dQ3h8P82bdwvWW3nTuTCt7W4ZAGcnxlw6aWHVGjO9KoyB8vmPUcO5SraTrbRR7MgF9kmBu9TqyiFbMF55HOPkIP2ImqdGJFsTksZxz3XGbOrcCNP1ZkrTS0vatBTIYTrS0Voz9gyntzZmroorYYg2/cOaIBS4R66oGkBJ+al01AwdZHeW7SzZMd4hTuhnOnhiDIEWvcTSvbI5Zi2Xq0kMM3ULrSWJxiyaXEkaWA5rlUqRqCtgysmCP5r55VcqAZLS1GEzq49VHIWqB2ZZOeUG7drJy/7IiMp/iiGF/LMWrFjQcQisvyCtcYuBk8zaWBetu5e1/ySAJfr7zcmYb+qv7eX2avIh/h6rQ7nlWCmC+OXiCQBaMpO5AfdjwilWcW0K5KT2tKW4xtGgrT2D+Pv8XXwmitqVwkdMCqcgY3pJBEMtS5VnQqczgf8BB8fQCQnLp4SxIrFJj+o3KE/Td2XgGecaFJIJGG6qisiUyPtR897ntx0VMXVOAlPxsljxscxAFkETi3FTf5zauFNA8pDij72fBLd91MmEOWb2G7RbMnyp9XtJs4PeDtGpQXW6eVaE9sUgxWjYGzpU8UJLs6cielWI9okJuHM9nGeSdMV7YYOx//xuIrDF/OmfdQYRMTD7Nt/5x//gPwIQtyoG/Lbp1w/r9U3gep03a60Yt9VBOsQbrIX01rDzWGGypMVhMMmQ6qL4OFIK /bc5FNFm jTJSeldQqloWyQIj1x4+gwKpN8OdS4/+f/D7AsPFbbTwFrxEn+o+LPfYRZ/vSAc1laSv4Vduzl2Tj69AVxr2xiwYeGlAZEeG3zAomfTKcsjl2gHnO24J1iMkdneg52JZjPgZT8pIq0B4TzAnZ/AlJ5eS5uwNk6txKLCbtFvFj0mkLs/Zc30y/zpGFvrz3EpDopXnb3oWsf8ibb+mu7urunUQqyG9DANHSUV7t8uW452EYKwVPzqor4Nk/pu5RtOmdd/LGRnUWXNAfuAIZPBQ5frVmr49zq9kRvweHRVVSXICGF+Uw4/Y1buBBdvA74EcJ1gh2JxsdOqzuPeeaKiK04iT8Jf2ZUiccGCaAOy3nBajDIt8lDKGym7Rst75fZtcavmdD6nC4BH2OeudKNhIIoAVOzn8iIUK2QGOj/dsrHgpdNTzFEJ4v5bWAROhWK539P0p0UFW33i7LbKUEKY1tTKC9yels/vX6R03hDSK9FTHBhVphjlYoteCxnfrPexXDWOAeQCnF0OYIFtjES+TrEsWTP1/J5jRmakEWMbEJVQgwHssnSJzHGElLR+4yaAKQwM3M+3pozC7/l1o6ZqWFw+LYgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2024-01-30 at 19:37 +0800, Yunsheng Lin wrote: > Currently there seems to be three page frag implementions > which all try to allocate order 3 page, if that fails, it > then fail back to allocate order 0 page, and each of them > all allow order 3 page allocation to fail under certain > condition by using specific gfp bits. >=20 > The gfp bits for order 3 page allocation are different > between different implementation, __GFP_NOMEMALLOC is > or'd to forbid access to emergency reserves memory for > __page_frag_cache_refill(), but it is not or'd in other > implementions, __GFP_DIRECT_RECLAIM is masked off to avoid > direct reclaim in skb_page_frag_refill(), but it is not > masked off in __page_frag_cache_refill(). >=20 > This patch unifies the gfp bits used between different > implementions by or'ing __GFP_NOMEMALLOC and masking off > __GFP_DIRECT_RECLAIM for order 3 page allocation to avoid > possible pressure for mm. >=20 > Signed-off-by: Yunsheng Lin > Reviewed-by: Alexander Duyck > CC: Alexander Duyck > --- > drivers/vhost/net.c | 2 +- > mm/page_alloc.c | 4 ++-- > net/core/sock.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index f2ed7167c848..e574e21cc0ca 100644 > --- a/drivers/vhost/net.c > +++ b/drivers/vhost/net.c > @@ -670,7 +670,7 @@ static bool vhost_net_page_frag_refill(struct vhost_n= et *net, unsigned int sz, > =09=09/* Avoid direct reclaim but allow kswapd to wake */ > =09=09pfrag->page =3D alloc_pages((gfp & ~__GFP_DIRECT_RECLAIM) | > =09=09=09=09=09 __GFP_COMP | __GFP_NOWARN | > -=09=09=09=09=09 __GFP_NORETRY, > +=09=09=09=09=09 __GFP_NORETRY | __GFP_NOMEMALLOC, > =09=09=09=09=09 SKB_FRAG_PAGE_ORDER); > =09=09if (likely(pfrag->page)) { > =09=09=09pfrag->size =3D PAGE_SIZE << SKB_FRAG_PAGE_ORDER; > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index c0f7e67c4250..636145c29f70 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -4685,8 +4685,8 @@ static struct page *__page_frag_cache_refill(struct= page_frag_cache *nc, > =09gfp_t gfp =3D gfp_mask; > =20 > #if (PAGE_SIZE < PAGE_FRAG_CACHE_MAX_SIZE) > -=09gfp_mask |=3D __GFP_COMP | __GFP_NOWARN | __GFP_NORETRY | > -=09=09 __GFP_NOMEMALLOC; > +=09gfp_mask =3D (gfp_mask & ~__GFP_DIRECT_RECLAIM) | __GFP_COMP | > +=09=09 __GFP_NOWARN | __GFP_NORETRY | __GFP_NOMEMALLOC; > =09page =3D alloc_pages_node(NUMA_NO_NODE, gfp_mask, > =09=09=09=09PAGE_FRAG_CACHE_MAX_ORDER); > =09nc->size =3D page ? PAGE_FRAG_CACHE_MAX_SIZE : PAGE_SIZE; > diff --git a/net/core/sock.c b/net/core/sock.c > index 88bf810394a5..8289a3d8c375 100644 > --- a/net/core/sock.c > +++ b/net/core/sock.c > @@ -2919,7 +2919,7 @@ bool skb_page_frag_refill(unsigned int sz, struct p= age_frag *pfrag, gfp_t gfp) > =09=09/* Avoid direct reclaim but allow kswapd to wake */ > =09=09pfrag->page =3D alloc_pages((gfp & ~__GFP_DIRECT_RECLAIM) | > =09=09=09=09=09 __GFP_COMP | __GFP_NOWARN | > -=09=09=09=09=09 __GFP_NORETRY, > +=09=09=09=09=09 __GFP_NORETRY | __GFP_NOMEMALLOC, > =09=09=09=09=09 SKB_FRAG_PAGE_ORDER); This will prevent memory reserve usage when allocating order 3 pages, but not when allocating a single page as a fallback. Still different from the __page_frag_cache_refill() allocator - which never accesses the memory reserves. I'm unsure we want to propagate the __page_frag_cache_refill behavior here, the current behavior could be required by some systems. It looks like this series still leave the skb_page_frag_refill() allocator alone, what about dropping this chunk, too?=20 Thanks! Paolo