From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D34DDC5321E for ; Mon, 26 Aug 2024 14:55:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55AE96B0088; Mon, 26 Aug 2024 10:55:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E3806B0089; Mon, 26 Aug 2024 10:55:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35EE96B008A; Mon, 26 Aug 2024 10:55:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0EBB56B0088 for ; Mon, 26 Aug 2024 10:55:33 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CA546A0FC1 for ; Mon, 26 Aug 2024 14:55:32 +0000 (UTC) X-FDA: 82494695304.27.CE29A80 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 9980F180003 for ; Mon, 26 Aug 2024 14:55:29 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h7fBPTHv; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724684110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n5SB2WkOSNNQeOpnKZtlhsRdNuwcT+sxkvCztu2t5ME=; b=8m7l6pm02zlD3lbJWCpA8PCqgYSRZVj8OI5koS1iihfCinfIqDr2g7g1auEl/dsCxXhGq+ 6JbTutMPjVSVvhp/jvRVUpYyFhcVRAuYqHz0s2U1KDagqeD8aewTjiBvnrMAT7X85hTTSc 5eIfmrMqMZiXWwIBRkL9qOiuEhkOWco= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h7fBPTHv; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724684110; a=rsa-sha256; cv=none; b=XBcWzIi0XGAPXazFbeoS80pVXOem1JdRLuJnzx4WZhOWbfQFDixUSasUbxjnmFqTuNYXqK XrlMtCPwKiDuGAQsn2D/RbZDM+7SQRPAIH50I70AzeVjwgge/fnB4YSC8NJEwdKqMnggdV 5YiH83CwfGdf/6RWmAndoOJBdgZUGUE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724684128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=n5SB2WkOSNNQeOpnKZtlhsRdNuwcT+sxkvCztu2t5ME=; b=h7fBPTHvAtNfx5aaOZrts4Mi5CV94xWq26327w9vMs45U4E49Aph88GRaXWqUJupjGybK9 h4t78irJDxEopvtnAmJaS72ZWjvrniPBULZd74K7vqlRSLMMAaLzRYkq7PSe5BLAHAUJAW HUcSaRaR99XXk3hEet+egI/LMiWnp84= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-7JBSw2nvMyKiAjx1Fwwvvw-1; Mon, 26 Aug 2024 10:55:27 -0400 X-MC-Unique: 7JBSw2nvMyKiAjx1Fwwvvw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-371914b5caaso2783373f8f.0 for ; Mon, 26 Aug 2024 07:55:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724684126; x=1725288926; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=n5SB2WkOSNNQeOpnKZtlhsRdNuwcT+sxkvCztu2t5ME=; b=GVstLaAU+8qcw9oxnA3I3S2B9FKFK+7yWcor28tQ8oYHHefwLYVgb1PDLtg+NWe1L7 tCp7O7QwP8b+0iRSpZvPpL61h2Cr9p0yj6eazXbIL7VsCoubk7D1D7EVFeZgqZSZloKX 4aTQU/seX1zSeB+IJsohgYLC9lmUwYuSFPKQDq+gDQWuCNVHT3bxL/CAeQpiRkyvM51R o9mgE4oLattuvcb5A9GMVbgMJw1xWyaRizmoDOWxEZlUnEl5UI30p3RdL8r1GY+0/g9k myN2NVzwQ9HMhCBhCq02mGjmw7dFcdkPAnTRriQ5WmkNSrmD0X8Q8nOhg2eA18LsTXCa a7FA== X-Forwarded-Encrypted: i=1; AJvYcCV8yqmTkH5rUc/cZzqG38mPf2P6chNt9rFvmilAHNN7o//eL1tJb9nSIny0wY6rdYHwfcZwoNriug==@kvack.org X-Gm-Message-State: AOJu0YyzQTz6lrY4qlrsmoHgt0CfyWxJQxV7JEu6Rj+M7D5T0ZvzhDWQ BDWMBEZjV3HhmKJsehKZeNlbjn96eyXyyDmLixvaBaozYaJPJt4CA6z4bWb+gu8vmJeOiP6qORT DqnkrHTOcLR5V4hhA60/L3k07rjzYx9mdHyH3W9XdeM58/RdL X-Received: by 2002:a5d:6b03:0:b0:368:12ef:92cf with SMTP id ffacd0b85a97d-373118e3735mr6962578f8f.48.1724684126203; Mon, 26 Aug 2024 07:55:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG18VYTWm1F2inP/cfryxlleccdwTkZ9Hr/eBwnRdsa1XJs7VDiXetnkPuA0fCLWkzgDaADqQ== X-Received: by 2002:a5d:6b03:0:b0:368:12ef:92cf with SMTP id ffacd0b85a97d-373118e3735mr6962557f8f.48.1724684125285; Mon, 26 Aug 2024 07:55:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1900:16b0:8dc:77e:31af? (p200300cbc737190016b008dc077e31af.dip0.t-ipconnect.de. [2003:cb:c737:1900:16b0:8dc:77e:31af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42b8a351d3asm97357545e9.13.2024.08.26.07.55.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 07:55:24 -0700 (PDT) Message-ID: <81c2219f-5dcd-4838-8c8d-767b7ff9f714@redhat.com> Date: Mon, 26 Aug 2024 16:55:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] mm: memory_hotplug: unify Huge/LRU/non-LRU movable folio isolation To: Kefeng Wang , Andrew Morton Cc: Oscar Salvador , Miaohe Lin , Naoya Horiguchi , linux-mm@kvack.org References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-6-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240817084941.2375713-6-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: qijtcyzebyibo4p7ax6aa1zqj75144y9 X-Rspamd-Queue-Id: 9980F180003 X-Rspamd-Server: rspam11 X-HE-Tag: 1724684129-583578 X-HE-Meta: U2FsdGVkX1/ID2jeaGppTV5fRYH3HIoFrCGWVQbh3Sc/HXgqq2gCXd/SORThavbxtHy2Qeks7QMbMBCMZRauxAVJoYdWA4a1ls7VD9Oj7XgkFKsjDr/IWQEF/se14ZGlGIoVcNm20vKkhAiRNwAvDG4vPrxmJHAR88LnQW7s98Sq879YKBkKPTInvOkkC8swlnRNjVSqTJ0B7kSWLHi5BZHKjxxJa4i/GAJ5hfaXOAdWQ5Bc7CNh6VB0LqR1UQLsmaoRkENMn1/KfHUV8DBkDrek31PLfc3wgJgG9h/mTQBhNZFgSkpx2m0oZqegyj2irRGJ1J87Yj6yb+cthiWi+HJtackH9uOu2isdo85Lufw4/PEGUJAVFZRX+mEfCsftS48t4L+FxJJJwEZrmlb7qnMCdFVgM9LHbkVsUcG7xootGHUrneXfUshZ+SlKEdAOjKNhhZmgU73ZzWmTZQ6HeL8ZC5VGuexs4rDifi5JuZdpOkYjfS+0BI7UINWuYZ+vdi8L7m2rV/3kaNBNGMGHYk97z43eA0GFTT39afR52na68Zg+7mBy6cEq0ywjJAhEjXhZWCbJeDID5z5/BzUJ0k5+MkqsjYYsjekJ1OlKvNmSs4Of/JZLaGEjQIaZfTQ4ZmmMizeRC+NhT54Zp5QIkzzQyR1tSJSWiZ7Jt/n+9z9zEysRzwCF1TRVl2v2aa6VFs/YhieromTQ1WfAJeFiarBrd7kNHnCFsDz3VCLjZT/XYRmTk2zRyRp2hfesSfUGzCpwnWGsEr8THvLCtILnjtJvGl6JkqjogE4g/TsrwatDyZ4cCvZyDjsVSaEfPkb+IGEM/BYYNlGb//sBw0asELRNmH6cDDHV79WtHrRlpCO9SQPkwUJRZvMRGzUnnYtt1EPY90UKgXIyxhGzVmF6TFSPcWqgw+/JjGE3pcORJJ04kWEQEiLxCEN+fHHDUG/Z34cDRBDS6Y4jGO4+Un/ YkipLrve EbisCEtiGZ+JyFjDhHT8/NKJra8u5XmcP/3VAR1oDIWS7oSAFTUq6hct3WjO1NLsCWgi3tw3GerphnYp5uqfp3BHtbzymfQkqKTEy26gBIOrU8ms+1d7KksoZjccJCQXlAE1lEok9TFGOGX1sVKNi18/O9tXetIOqJEr6jx+Urt4LNG3q9ZdV8bDBqAFtL2K4z5vCjmsbx/cDa9HpWvTCFD0HY0Vip0aFiVaedCcQtlEbNL9ILmv/wvfr8meZHUzknjpp26mJMAddwlpGvZOV2sRlLeja/6hb2mgoTl9kQkCO/fc8L2+02iLspazZzBlXoOFfypIb8yEL7uC9OWAn7XX2NcdtQn509t1GRmBRQExixRayyGsYlNL4T2Zeb4fH+MGmygmckcfaA/5eP/ZLMzc8Sd3Gy/WuYP6qlhVupuCj8xOmgMNK8aJ0VHueqMPaM6deKpjjn2W6ZDtcpHY5PJsAu5lDDPXqHl7e3MpKr4+5pK0oqcPEUfNKtBz8wSFucAnC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.08.24 10:49, Kefeng Wang wrote: > Use the isolate_folio_to_list() to unify hugetlb/LRU/non-LRU > folio isolation, which cleanup code a bit and save a few calls > to compound_head(). > > Signed-off-by: Kefeng Wang > --- > mm/memory_hotplug.c | 45 +++++++++++++++++---------------------------- > 1 file changed, 17 insertions(+), 28 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 02a0d4fbc3fe..cc9c16db2f8c 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1773,14 +1773,14 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > { > unsigned long pfn; > - struct page *page; > LIST_HEAD(source); > + struct folio *folio; > static DEFINE_RATELIMIT_STATE(migrate_rs, DEFAULT_RATELIMIT_INTERVAL, > DEFAULT_RATELIMIT_BURST); > > for (pfn = start_pfn; pfn < end_pfn; pfn++) { > - struct folio *folio; > - bool isolated; > + struct page *page; > + bool huge; Please use "hugetlb" if you mean hugetlb :) > > if (!pfn_valid(pfn)) > continue; > @@ -1812,34 +1812,22 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > continue; > } > > - if (folio_test_hugetlb(folio)) { > - isolate_hugetlb(folio, &source); > - continue; > + huge = folio_test_hugetlb(folio); > + if (!huge) { > + folio = folio_get_nontail_page(page); > + if (!folio) > + continue; > } Hm, remind me why we are changing the hugetlb code to not take a reference here? It does look odd. utback_movable_pages(&source); -- Cheers, David / dhildenb