From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFC6CD11C2 for ; Wed, 10 Apr 2024 08:34:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D99306B007B; Wed, 10 Apr 2024 04:34:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D49116B0083; Wed, 10 Apr 2024 04:34:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE9B76B0085; Wed, 10 Apr 2024 04:34:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A189E6B007B for ; Wed, 10 Apr 2024 04:34:15 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6593A16071A for ; Wed, 10 Apr 2024 08:34:15 +0000 (UTC) X-FDA: 81992960070.12.BC5B32C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 2155CC0014 for ; Wed, 10 Apr 2024 08:34:11 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IBmN48LX; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712738052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BWLZ/q1gyu4D0XmEKgmR0P7MI9xWaMnbKOLpO15YcPM=; b=tPUslVknWbybmRs2jN7uyI7Z39Z1pyx5khKzUrpVfx6jULparZ+1NsMo2LWK8MTc7/57oY 715aODvge7qyR4fETb1326v1ujzLaE/g+SoMfN6COTsxeg5S6RDoa7nbWob1qcJ5ElnDpj MOLrlr3lcoX09N4WywGePheRBr5G+x8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IBmN48LX; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712738052; a=rsa-sha256; cv=none; b=0ShffgJQqJIxavi5ujZb+/R5HACF4BmK4kXIixHxqPm84BhTcm5Qlj/TRqDpcJnFhpXW8/ P9O/vWLlWGNOZs8B8OA+h3rxIMuSfy4dX4Ia/ICvQl2XXjVh9NKOsAydpKcj0jpDFUSamD 9trolRvSXr5IdXtshUgNfSZD82YZIZo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712738051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BWLZ/q1gyu4D0XmEKgmR0P7MI9xWaMnbKOLpO15YcPM=; b=IBmN48LXj3QwCdSPmXt/VOXj+YiGC/KgBLWeEfOTVqdSVP1KKo4PPycRquIAuiOHEloK5S IX1PILzGWRj/b9h45mTP5YfNOOHGKl+7iaoDM9eCz5HAfpF0U3GTA77neFinodcdSabm9G vohHsSohFxjysNCgKMGKvedEsOYqVvM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-mBJzYUFPNuC72Ne2G38_hQ-1; Wed, 10 Apr 2024 04:34:09 -0400 X-MC-Unique: mBJzYUFPNuC72Ne2G38_hQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-34619c30076so777761f8f.1 for ; Wed, 10 Apr 2024 01:34:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712738049; x=1713342849; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BWLZ/q1gyu4D0XmEKgmR0P7MI9xWaMnbKOLpO15YcPM=; b=uhf3SyEiRR1kQr6Jek/jvB53e1r04mlg//Q2UwPf+SRPJqnvhFDnUHvpwjRFDTzcQ+ W5HqEXvUuUFgKcBNs3u8EdnPn6NTe6/vW5fIU6tS0msBmqcxNyK5sqZtlrf2G1mvqV6Q BlRljkNa1TDbZJN3NzXs4M4ara3cZNRi1ybbkOQNIKkSpUtS9Nggx6fYqKqrESVmoHO2 pyW4b4eBFwI2i1fjW04pLul0R7RzeddsfTFz8bdZqR9Xo9Z6tUyyNsHWw5O72t2JJDm5 nrl8D8Iaacsrsl+bCiGWcDQZCHRGZ5pty2Y8guc8G81pv1NDvboC6wVvtgnhIEx2vRY/ bYVg== X-Forwarded-Encrypted: i=1; AJvYcCXYpW0oKf+5UkMxEuRljAjf0b+C7yWs4jELdPPC17ELVvcQz0I/92RMZRYrs08CRHh/nM/cp4hKxA5cYF2N1vwtiQU= X-Gm-Message-State: AOJu0YwsiCenKqbwjiqjPp/uoFl6yS+w+jDZa1jbBKmvzguFv6IacB/E tcgKN5Wo/ATt8YICma4pc3JFmoLCAn3l7sjF3GfQWNlDpaUvSSIJawx9rvD1rjB7dJnc3OpM5Yv 1xCQjOJmC2PPi9sDcFblv4bUUkBliuLZsxvfVzSkpE/ZRnJtQ X-Received: by 2002:a5d:4a10:0:b0:343:7ed6:765b with SMTP id m16-20020a5d4a10000000b003437ed6765bmr1267301wrq.39.1712738048790; Wed, 10 Apr 2024 01:34:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPENjs5SpD+lKW7lAXT8GOzgCf+z5bH6hDs/X6I8uA8MRFhnmCFPcQbKBr+NmAukETNiO7hg== X-Received: by 2002:a5d:4a10:0:b0:343:7ed6:765b with SMTP id m16-20020a5d4a10000000b003437ed6765bmr1267287wrq.39.1712738048415; Wed, 10 Apr 2024 01:34:08 -0700 (PDT) Received: from ?IPV6:2003:cb:c712:fa00:38eb:93ad:be38:d469? (p200300cbc712fa0038eb93adbe38d469.dip0.t-ipconnect.de. [2003:cb:c712:fa00:38eb:93ad:be38:d469]) by smtp.gmail.com with ESMTPSA id i11-20020adfe48b000000b0034330c9eccasm13363017wrm.79.2024.04.10.01.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 01:34:07 -0700 (PDT) Message-ID: <81c1de48-1e31-449d-8f5a-9342634cea27@redhat.com> Date: Wed, 10 Apr 2024 10:34:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] mm/ksm: add ksm_get_folio To: alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Izik Eidus , Matthew Wilcox , Andrea Arcangeli , Hugh Dickins , Chris Wright References: <20240409092826.1733637-1-alexs@kernel.org> <20240409092826.1733637-2-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240409092826.1733637-2-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2155CC0014 X-Rspam-User: X-Stat-Signature: 41uyhr7uz8macrm7yre64cd4rch6hhfp X-Rspamd-Server: rspam01 X-HE-Tag: 1712738051-361198 X-HE-Meta: U2FsdGVkX19IM1MIv3XtnurMiwSOI/cD1ST5gcGiMR8H1tcr2FxZg9+Jh6zbzMFfDEVXx4mxSrs4wGqPGVxMfMznr5LDm78TB6DfB2pOBZNsci6u8hNjlDa7XZGU5f/xNBTkkFBeERCkerb5EdWJBiI4RZ99iYTKugAuQBDt5dm8KCFvm0iJiXoIok+RQhK0RwIDdKCB/9v2ft5atr7BSVu34rZEvr4Yx/HcbObYA6xLzVlDwvPRYX8NziYLqJ8H6pUq6AC7DWN4jTqx3+KziVxp0nLYi8opJ2u8624w/DnrXep7vMoxTXwxtfi8ysKY8dGmQj6ookMsXZ9C6lcJb8i2avhWS7OApoB0QSzbcpt3NZwj/TnaUdpGe0IHKBtiqhZeHmBOiAaNwTctKeE9Y1/fcu5vhU0NVlO5OtwZQAL1bK7R/M0A9Ba2UuGzY3yyNoDdC1mLtgcwmI6fxmKHrd2vwrj5yzRgeyYXur9EcOAKtVxHBzLZOSiqSgRz0R6bRbc5LzaiFrYXfP72/hlDMOtvrayRqKA9bZnN8F4LdxIP9L3VjEQd4lhfdzevdHfgox4PNZlOecKD50WPOu1CcWGm+/bOPoNQ7QlZnkEwtCDfW7ghoBNdw9D94rgk5xLTvP6hpEC46ip++PVsI9DPe9tw4Nikiv5ljpPRF2OFcz++6CScZmQ+d+NoWlYWbOG0AnptMArZ0zC0RJQFCuG2dwl5yDQ/npDSjZZcF0LSn7yy+/jQGaqj4mczIK1piuYemmwVD9FtoQhLLzIs9SE1ZZFLREzKML54u93oNplK36UbGGhBnGJlZrG6eTQIPWn9cVdyY5U17/LpOMhjFW2vr9GDAI44DqvVCyUqZ8Ax1iyLIejY8c63qI++/GSOYAsDkW3Io+qIpZl3RY7aPm5h/ZliPVWUKAdhfftjYRfFj7LRhd4TdNZzFdMLmaY3Fslo+Lg/TLWNZG23w6vwRrd KmmesklO Ad61C1iDVbwAHhMngIzYBHCBThlQTrD1z42PfnL7EDSFbnneAOBcgEPKEiC9zWzRuRQlCOKWLMs0pt0p43dYfuBHqZtyfWfcJPpRF7WooX8gISpcMnYHfv7LsAa4mi+Iops1+T3RrqaML+tZyO/KG28r1LUWDDPCLQTM8IbfSvMKi4PWS9LEPV8MuDn0ta1K1rN3suwGVMPsCPgDSZMTzyw0vfy0G2byGtxm/tG46fm+IR7l8fxRpLlnnE161xVnBUwUfFagKnbrOZHDYU904Izd0G7/cmObJCCeZfG7grUXX4SUeGbRGp0VdVY6hBT3q0B36b+j9SGHTFngewA6m7zyhXlsscKmV3bpezuGL86/429XoHp/9XbGf/7jbatC5Y6S2+LffJTn94MxowMNcVTpvZHCa9UGIE7sa7CN6rgA68OeA+pGhBI7Y+HPRQQeAazGMUvWK+R5bnovZX/3ok5UM1htdXggvZZL+IJL7BKCwEQwj5vna+yCNZPpLJcc2rjbdWUIzmYszN5BeOVQD+9nVGPcr3mScnDcKYsZvkkSDVZj4xFbQSL31F4ehcA6A+cXAarkDSp1MYQaFWWa2V1cWbBIQBpiuPOYObKtqpFIff1Z8VXnrwSKaEOM+qgf8GZcy0ST2Fenw48BwkhxqXsQOtH+2zBDbi058wMgjtd9wSXj32Bqk2/+Zw9RTI86ss5cZJW4/iEJJrd+NDSpAADFNH1DUXDoJhWiUEXN0uyZeHnMafRWZa5nmFR9l6onjtHan8WMDf5KM57KicYfF0PbTblIZ24hafkxY6ysz3O3MI8DiJrRnzegjjw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.04.24 11:28, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > The ksm only contains single pages, so we could add a new func > ksm_get_folio for get_ksm_page to use folio instead of pages to save a > couple of compound_head calls. > > After all caller replaced, get_ksm_page will be removed. > > Signed-off-by: Alex Shi (tencent) > To: Andrew Morton > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > Reviewed-by: David Hildenbrand > --- > mm/ksm.c | 40 ++++++++++++++++++++++++---------------- > 1 file changed, 24 insertions(+), 16 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 8c001819cf10..ac080235b002 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -915,10 +915,10 @@ enum get_ksm_page_flags { > * a page to put something that might look like our key in page->mapping. > * is on its way to being freed; but it is an anomaly to bear in mind. > */ > -static struct page *get_ksm_page(struct ksm_stable_node *stable_node, > +static struct folio *ksm_get_folio(struct ksm_stable_node *stable_node, Just realized that you should adjust the function name in the comment above this function in this patch. -- Cheers, David / dhildenb